[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title James Dumay commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Oh nice one Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY closed an issue as Fixed Actually this was fixed back in Jan in v1.12 of the plugin. Not sure why it was not closed. Jenkins / JENKINS-41063 SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Change By: Tom FENNELLY Status: Open Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title James Dumay commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields We don't have this on the plan to fix before 1.0 however there is some work going on at the moment to make SSE work across sessions and it may fix this incidentally - Vivek Pandey have you run into this with your current project? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Oleg Nenashev commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields James Dumay Tom FENNELLY IIRC you were going to fix it before the public Blue Ocean release. Were there any changes in the plan? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-41063 SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Change By: James Dumay Priority: Critical Major Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields I don't plan on doing anything more on this until after we have more details of how this might be used in a clustering env. I'm not going to remove the Serializable interface marker because that will result in some Servlet containers barfing on it completely. Also, making some of the fields serializable is just a waste of time too imo, because there's a lot more to making it actually work in a clustered env - the backend event bus subscriptions need to be re-established too etc, or the client will just stop receiving events. If the sessions are not sticky and browsers are constantly being assigned to a replicated session on a different node, then I'd bet that will cause a litany of other ugly issues. TL;DR ... we need to figure out how clustering might work before doing a "real" fix for this. Anything else is just sweeping crap under the carpet. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-41063 SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Change By: Tom FENNELLY Sprint: tethys Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-41063 SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Change By: Tom FENNELLY Sprint: tethys Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields I did a 1.12 release of the SSE Gateway Plugin that makes the EventDispatcher serializable so as not to raise errors in the session manager. Yes, it would not be deserializable but that doesn't matter for now. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title James Dumay commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Can you send the ux team at CloudBees an email? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Oleg Nenashev commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields James Dumay Previously I have provided links to my fixes to Tom, but something still needs to be applied to the plugin's upstream. Just making fields transient will formally work, but after that deserialized event dispatcher will not work at all. Hence I had a more complex fix (sorry, cannot provide it here since it's not OSS) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title James Dumay commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Oleg Nenashev did you get a resolution here? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields I'm fine with just making the relevant fields transient. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Oleg Nenashev commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields I have a private patch for serializable EventDispatcher. Can share it with you though the code is not open-source. As a temporary fix I would be fine if you just remove the "implements Serializable" definition. It won't impact the default session manager. OTOH, it's not binary compatible. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Tom FENNELLY commented on JENKINS-41063 Re: SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields The SSE Gateway really only uses the servlet session as a way of "scoping" dispatchers to the browser sessions with which the are associated i.e. not as a means of "persisting" anything across sessions. So from a non clustered point of view, the easy fix here is to just make all the fields transient. That should at least stop the servlet container session manager from barfing. If it's a case that we ever want to make this clusterable, I think we'd need to first have a clear idea about the overall clustering architecture that it needs to work in. Then we'd have to figure out what changes would need to be made. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41063) SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields
Title: Message Title Oleg Nenashev created an issue Jenkins / JENKINS-41063 SSE GW Plugin: Serializable EventDispatcher contains non-serializable fields Issue Type: Bug Assignee: Tom FENNELLY Components: sse-gateway-plugin Created: 2017/Jan/13 12:41 PM Priority: Critical Reporter: Oleg Nenashev I was prototyping some code around Session management in Jenkins with standard Jetty's HashSessionManager. This session manager tries to serialize sessions and their attributes to the disk. In Jetty all session attributes are supposed to be serializable, especially if they declare the Serializable interface. In SSE Plugin EventDispather instances cannot be really serialized, because classes like PubSubBus and Authentication instances are not serializable in Jenkins core it causes failures in Session management. Add Comment
