[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: Tom FENNELLY Priority: Critical Minor Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: Tom FENNELLY Sprint: 1. 0 1 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY stopped work on JENKINS-42137 Change By: Tom FENNELLY Status: In Progress Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY commented on JENKINS-42137 Re: Don't fetch run data on an event if it not already in the store This is a bit of a rat-hole. Talked with Michael Neale and we decided to punt on trying to perform this optimisation for now. PR 867 "seemed" to do the trick, but the ATH uncovered a scenario where the fetch should still take place. If the RunDetails page is cold loaded for a run instance (e.g. directly from a link), the page loads the pipeline instance, steps data and a load of other stuff, but doesn't use the ActivityService or create a Pager instance. If it's a failed run and the user clicks on the Re-Run button a build will be triggered, causing SSE events, which in turn cause the DefaultSSEHandler to attempt to get the Pager instance from the PagerService etc etc. I spent some time studying all this and kinda got it working, but ran into other issues then with other components. Bottom line ... I think this is something we should come back to post 1.0 because it seems like some other things need to be straightened out in order to make it work and I don't think it's worth taking the risk of breaking things at this point. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY commented on JENKINS-42137 Re: Don't fetch run data on an event if it not already in the store https://github.com/jenkinsci/blueocean-plugin/pull/867 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY updated JENKINS-42137 Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: Tom FENNELLY Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY started work on JENKINS-42137 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: James Dumay Priority: Critical Major Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Michael Neale commented on JENKINS-42137 Re: Don't fetch run data on an event if it not already in the store We had a discussion on this, and agreed ideally it would check the store first to see if there is any interest in the event, as it is likely dropping the data on the floor anyway, so this should be able to be eliminated. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY started work on JENKINS-42137 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Tom FENNELLY stopped work on JENKINS-42137 Change By: Tom FENNELLY Status: In Progress Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title
Michael Neale updated an issue
Jenkins / JENKINS-42137
Don't fetch run data on an event if it not already in the store
Change By:
Michael Neale
+This ticket started life as a bug, after observing what was thought to be a regression.+The BlueOcean main pipeline screen (https://ci.blueocean.io/blue/pipelines) appears to be receiving events for running pipelines that are not visible, and then fetching data, creating more than expected traffic.On a regular basis this sends event from the backend to the frontend detailing things that are running.h4. To reproduce* Open /blue/pipelines/ in one tab* Run a job like bwalding-alwaysBlue from a classic screen in another tab : https://ci.blueocean.io/job/scratch/job/bwalding-alwaysBlue/configure* Note that /blue/pipelines/ receives events for this job and does requests. Expected behavior: * Should not fetch the run data if the job isn't even in the store. h4. Some detailsEvent socket:https://ci.blueocean.io/sse-gateway/listen/jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9Event data:{noformat}open {"dispatcherId":"jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9","dispatcherInst":1238701885} 16:15:00.445job {"jenkins_object_type":"org.jenkinsci.plugins.workflow.job.WorkflowRun","jenkins_event_uuid":"6c1358f1-f887-41bb-beb9-3228dda99df8","sse_subs_dispatcher_inst":"1238701885","job_run_status":"SUCCESS","job_name":"scratch/bwalding-alwaysBlue","jenkins_org":"jenkins","job_run_queueId":"5246","jenkins_object_name":"#2","blueocean_job_rest_url":"/blue/rest/organizations/jenkins/pipelines/scratch/pipelines/bwalding-alwaysBlue/","jenkins_object_id":"2","jenkins_event":"job_run_ended","sse_subs_dispatcher":"jenkins-blueocean-core-js-1487311928759-80shtgg3w8q5hpelba9k9","blueocean_job_pipeline_name":"scratch/bwalding-alwaysBlue","jenkins_object_url":"job/scratch/job/bwalding-alwaysBlue/2/","jenkins_channel":"job"} {noformat}Once the frontend receives those events, the frontend then makes a call to retrieve details about the run.https://ci.blueocean.io/blue/rest/organizations/jenkins/pipelines/scratch/pipelines/bwalding-alwaysBlue/runs/2/However the important thing to note is that the bwalding-alwaysBlue job is not visible on the front screen - so the frontend is querying the backend for details on jobs that will not change the state of the front end (afaik)In a large instance that is running a lot of jobs all the time, this could be problematic.
[JIRA] (JENKINS-42137) Don't fetch run data on an event if it not already in the store
Title: Message Title Michael Neale updated an issue Jenkins / JENKINS-42137 Don't fetch run data on an event if it not already in the store Change By: Michael Neale Summary: Keep an eye Don't fetch run data on SSE events and resulting REST API calls - Investigate an event if it not already in the store Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
