[JIRA] (JENKINS-42218) Refactor branch filtering control to share logic with JDL controls

2017-03-21 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42218  
 
 
  Refactor branch filtering control to share logic with JDL controls   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Priority: 
 Minor Major  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42218) Refactor branch filtering control to share logic with JDL controls

2017-03-21 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42218  
 
 
  Refactor branch filtering control to share logic with JDL controls   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 Blue Ocean 1.1  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42218) Refactor branch filtering control to share logic with JDL controls

2017-02-21 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42218  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Refactor branch filtering control to share logic with JDL controls   
 

  
 
 
 
 

 
 The start of this refactor is here: https://github.com/jenkinsci/jenkins-design-language/commit/46c4577093ae34f846e96881d80ef31bee353449 master needs to be merged, and there have been non-trivial changes to Dropdown in the intervening time... so I might be the best person to take a stab at this one if/when we prioritize it.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42218) Refactor branch filtering control to share logic with JDL controls

2017-02-21 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42218  
 
 
  Refactor branch filtering control to share logic with JDL controls   
 

  
 
 
 
 

 
Issue Type: 
  Task  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 blueocean-plugin  
 
 
Created: 
 2017/Feb/21 3:11 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Cliff Meyers  
 

  
 
 
 
 

 
 The branch filtering feature (JENKINS-35768) has been implemented using a 3rd party "typeahead" control. The design spec for the "branch filtering" control is similar to the JDL Dropdown and ideally would share much of the same logic. A work-in-progress branch exists to refactor out the Dropdown's menu into a "FlyoutMenu" control that could be reused in different components. The end state of the code might look something like this: 
 
Dropdown 
 
button (as today) 
FlyoutMenu 
  
Typeahead (this might be the name for the control that branch filtering uses) 
 
TextInput 
FlyoutMenu