[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-22 Thread kzan...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Keith Zantow updated  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42784  
 
 
  Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
Change By: 
 Keith Zantow  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-21 Thread kzan...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Keith Zantow updated  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42784  
 
 
  Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
Change By: 
 Keith Zantow  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-21 Thread kzan...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Keith Zantow commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Isa Vilacides this isn't the right issue for text changes, please comment on this issue: JENKINS-42135  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-21 Thread m.vilaci...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Isa Vilacides commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 To add to that: 
 
The copy seems confusing since it says "It says that it's recommended if you do not have a jenkinsfile" and you can actually use it with a jenkinsfile. 
If you import a huge organisation, the user is not advised that it might take a lng time if there are many repos. They just see pipelines popping up but there is no sense of progress and this causes customers to retry to import it because they think that it just didn't work (it happened to 3 our of 4 team members in my team). I believe we should have a disclaimer letting the customer know that it might take long and that they can check progress in the classic view on the scan job or something like that. 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-20 Thread kzan...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Keith Zantow started work on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Keith Zantow  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-20 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Adding details of an issue discovered by Isa Vilacides during exploratory testing. I am confident the underlying issue here is the same but want to preserve it for traceability: Problem: The copy of "Just one repository" github pipeline creation is confusing. It says that it's recommended if you do not have a jenkinsfile, but if you do not have a jenkinsfile, then no pipeline is created and it says that the pipeline is pending to be created when it will never be Steps to reproduce 
 
Click on create a pipeline and chose "Github"→ some organization → Just one repository 
Chose any repo with no jenkinsfile and click on "Create pipeline" 
 Current result 
 
It spins creating pipeline until it times out 
The pipeline is not created but the message is "Saving was successful and pipeline creation is in progress. Go to the dashboard..." so my expectation is that there is a background process that will keep trying or so on. The message should be: there is no jenkinsfile and no pipeline has been created 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   

[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-20 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers assigned an issue to Keith Zantow  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Assigning to Keith as it sounds like there are some significant changes coming in backend. I'm happy to implement the frontend changes once those are in place - just reassign the ticket when ready and CC me on the PR. Thanks!  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-42784  
 
 
  Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
Change By: 
 Cliff Meyers  
 
 
Assignee: 
 Cliff Meyers Keith Zantow  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-20 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers stopped work on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Cliff Meyers  
 
 
Status: 
 In Progress Open  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-20 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Sounds as though all of these PR's will be abandoned in favor of some changes that Keith Zantow is going to implement, per discussion in Gitter room. Possible changes include: 
 
possible improvement to API to support "add repo" use case. Rather than requiring a PUT request that includes the full repo list each time, allow a simpler request to that adds a single repo to anything existing. 
ensure single repo optimization happens for "update" calls in addition to create 
Change impl not to use regex (unclear to me what this would entail) 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-17 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 New PR from Vivek with backend changes: https://github.com/jenkinsci/blueocean-plugin/pull/911 Will implement UI changes in same branch.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Here's a PR with my suggested change in action: https://github.com/jenkinsci/blueocean-plugin/pull/908 It seems to do what we want, but I have to defer to the others as to whether this is really an appropriate code change. See my detailed comments on the PR.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Vivek Pandey it's true that it will place more load on the server and slow down the org folder scanning slightly, but shouldn't the scan of the single repo still complete much faster than the org folder scan on its own (at least when the number of repos is large)?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers edited a comment on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 [~vivek] it's true that  it  #2  will place more load on the server and slow down the org folder scanning slightly, but shouldn't the scan of the single repo still complete much faster than the org folder scan on its own (at least when the number of repos is large)?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 #2 doesn't make sense, in case of jenkisnfile present, you are scanning it twice and it nullifies, in fact makes perf worse that without optimization.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey edited a comment on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 In case of empty repo, backend calls SCMSourceEvent.fireNow() - no org scan is triggered. If there was a jenkins file you would receive mbp start and finish event but without that there is no event.[~cliffmeyers] [~kzantow] One possible solution is for UI (in creation flow) to call API to [check existence of Jenkinsfile in that org folder|https://github.com/jenkinsci/blueocean-plugin/tree/master/blueocean-rest#get-github-file-content-from-org-folder]. If its 404, launch editor, otherwise keep waiting.  Edit: Above is not sure shot in current form. Flagging repo as empty is one extra API call. If this is acceptable, then repos API Cliff uses can include emptyRepo: true|false in the response. Idea is that If its empty repo then Cliff can trigger create API to create org (that is wait for create response to get back with 201) and then don't wait for scan, simply launch editor?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 2 and 3 in theory sound good. If we know it was a repo that had 0 branches (is that cheap?) then we can jump straight to this case. Does this also affect the case when it has branches but none have jenkinsfiles?   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread kzan...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Keith Zantow commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Vivek Pandey right, but i'm trying to avoid a bunch of API calls that we just made presumably to determine that X branches have no Jenkinsfile  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 In case of empty repo, backend calls SCMSourceEvent.fireNow() - no org scan is triggered. If there was a jenkins file you would receive mbp start and finish event but without that there is no event. Cliff Meyers Keith Zantow One possible solution is for UI (in creation flow) to call API to check existence of Jenkinsfile in that org folder. If its 404, launch editor, otherwise keep waiting.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Keith Zantow I'll let the others speak to it... if it requires a change in the OSS libraries, it's likely not workable in our timeframe.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread kzan...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Keith Zantow commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Cliff Meyers but it's already doing that... we just need to listen until it's finished and issue an indexing complete for the containing org folder  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Keith Zantow unfortunately "checking for Jenkinsfile" is not a cheap operation, since it requires N Github API calls where N = number of branches in repo.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread kzan...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Keith Zantow commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Cliff Meyers Vivek Panday how about we check to see if the repo has a Jenkinsfile, and if not, issue a scan complete event explicitly server-side for consistency?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Vivek Pandey specifically maybe you can speak to whether firing both the optimized single-repo scan and the org folder scan would cause an errors or undue load on the server.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers edited a comment on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 To clarify: any time you pick "single repo", the UI will respond to either the "org folder indexing complete" event or the "multi branch indexing complete" event, provided it's for the pipeline that corresponds to the selected repo. (Obviously we want to ignore the events from other pipelines that might have already been created).The first time through, if you pick a repo w/ no jenkinsfile, you'll get neither event - and therefore the timeout - because of this logic here:https://github.com/jenkinsci/blueocean-plugin/commit/5470506f1048c97a40ee8f16e21fe4b80f234dd3#diff-5e7377cad1cf9f0aa33fcc1e0cf62af9R120There's no org indexing done at all, and the event for the multi-branch indexing never fires, because it never will if there's no jenkinsfile.Now, *if you previously selected a repo and it contained a jenkinsfile*, then selecting other repos will result in 'missing jenkinsfile" screen because the org indexing event does in fact fire at some point. Well, it probably will, at least hopefully within the  first  60s timeout window.So I see a few ways to address this: # UI only: if the user picked "single repo" and the 60s timeout is hit, show the "missing jenkinsfile" state anyways. If something flaky happened on the backend, it's possible that the Editor will open in an error state. [~kzantow] maybe you can provide some input there. It might actually work fine.#  Backend only: change the logic linked above so that the single repo case performs both the optimized "SCMSourceEvent.fireNow" call, and the "organizationFolder.scheduleBuild" as well. For repos w/ JF, that should preserve faster performance. For repos w/o JF, we should still get the "org folder indexing complete" event within the 60s window, which means the UI code isn't making the fuzzy "no event means no JF" assumption.# Make both changes. This would give us extra insurance that if the user picked "single repo" that doesn't have a JF, AND the org indexing takes longer than 60s, that we still show the state where they can launch the editor. cc [~vivek] and [~michaelneale] for input.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 To clarify: any time you pick "single repo", the UI will respond to either the "org folder indexing complete" event or the "multi branch indexing complete" event, provided it's for the pipeline that corresponds to the selected repo. (Obviously we want to ignore the events from other pipelines that might have already been created). The first time through, if you pick a repo w/ no jenkinsfile, you'll get neither event - and therefore the timeout - because of this logic here: https://github.com/jenkinsci/blueocean-plugin/commit/5470506f1048c97a40ee8f16e21fe4b80f234dd3#diff-5e7377cad1cf9f0aa33fcc1e0cf62af9R120 There's no org indexing done at all, and the event for the multi-branch indexing never fires, because it never will if there's no jenkinsfile. Now, if you previously selected a repo and it contained a jenkinsfile, then selecting other repos will result in 'missing jenkinsfile" screen because the org indexing event does in fact fire at some point. Well, it probably will, at least hopefully within the first 60s timeout window. So I see a few ways to address this:  
 
UI only: if the user picked "single repo" and the 60s timeout is hit, show the "missing jenkinsfile" state anyways. If something flaky happened on the backend, it's possible that the Editor will open in an error state. Keith Zantow maybe you can provide some input there. It might actually work fine. 
Backend only: change the logic linked above so that the single repo case performs both the optimized "SCMSourceEvent.fireNow" call, and the "organizationFolder.scheduleBuild" as well. For repos w/ JF, that should preserve faster performance. For repos w/o JF, we should still get the "org folder indexing complete" event within the 60s window, which means the UI code isn't making the fuzzy "no event means no JF" assumption. 
Make both changes. This would give us extra insurance that if the user picked "single repo" that doesn't have a JF, AND the org indexing takes longer than 60s, that we still show the state where they can launch the editor. 
 cc Vivek Pandey and Michael Neale for input.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
   

[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers started work on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Cliff Meyers  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers assigned an issue to Cliff Meyers  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42784  
 
 
  Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
Change By: 
 Cliff Meyers  
 
 
Assignee: 
 Keith Zantow Cliff Meyers  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 Yep creation - take it if you need to  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-15 Thread cmey...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Cliff Meyers commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 James Dumay is this an editor bug, or creation? If the latter, I'll certainly take it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-14 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 When we are in the "pick one" flow we shouldn't end with this "timeout" error state. I think this is only suitable for when you pick "discover all" - WDYT Cliff Meyers?
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-14 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42784  
 
 
  Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Attachment: 
 timeout.png  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-14 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-42784  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
 I ran into this also - heres a screencast https://www.dropbox.com/s/zegnbnbriioufjv/create-pipeline-timeout.mov?dl=0   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42784) Unable to create new pipeline for empty repo in brand new github org

2017-03-14 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42784  
 
 
  Unable to create new pipeline for empty repo in brand new github org   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Keith Zantow  
 
 
Components: 
 blueocean-pipeline-editor-plugin, blueocean-plugin  
 
 
Created: 
 2017/Mar/15 1:27 AM  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Michael Neale  
 

  
 
 
 
 

 
 Found a new "edge case" - basically if an org folder is being created and then an empty repo added, it wont offer to create a Jenkinsfile in github. if the org folder already exists, then everything works as expected.  To reproduce:  
 
Create an empty github repo - no commits 
Ensure your jenkins has no github org folder for what you are about to add 
Add a new github pipeline via blue ocean - and pick your empty repo 
   Note that it will "time out" and not offer to create a pipeline, only an empty org folder will exist.  If you then repeat the above, it should result in an offer to create a Jenkinsfile (ie the second time, it seems to work). Somehow the creation of the org folder the first time prevents somethign from happening that prompts the editor.    I am not sure if this is in the creation flow code or the editor though... hard to tell. It is probably not an uncommon case to come across.