[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale updated JENKINS-47286 Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Michael Neale Status: Reopened Open Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale closed an issue as Postponed Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Michael Neale Status: Open Closed Resolution: Postponed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale assigned an issue to Michael Neale Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Michael Neale Assignee: Paul Horvath Michael Neale Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view can't seem to unassign it. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale assigned an issue to Paul Horvath Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Michael Neale Assignee: Michael Neale Paul Horvath Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Reinhold Füreder edited a comment on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Assigning this back to you [~michaelneale] with the update/summary comment above ... Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Reinhold Füreder assigned an issue to Michael Neale Assigning this back to you with update/summary comment... Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Reinhold Füreder Assignee: Reinhold Füreder Michael Neale Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Reinhold Füreder commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Michael Neale I am a bit surprised by being the new assignee of this issue, as I am not sure what you are expecting from me. Considering the admittedly rather long history of this issue and its distractions/deviations I think I can only try to do a little update: the issue's title/goal is still completely the same and correct and IMHO the "only" (or main) thing certainly missing is a stable/public API for org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME) (as this is annotated with @Restricted(NoExternalUse.class)) In the course of doing that other questions from https://issues.jenkins-ci.org/browse/JENKINS-47286?focusedCommentId=334032=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-334032 might be answered as well... (I think item #2 "mouse hover" was actually fixed; see https://issues.jenkins-ci.org/browse/JENKINS-47286?focusedCommentId=360479=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-360479) Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view (can't leave this unassigned for some reason). Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale assigned an issue to Paul Horvath Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Michael Neale Assignee: James Dumay Paul Horvath Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Michael Neale assigned an issue to Reinhold Füreder Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Michael Neale Assignee: Paul Horvath Reinhold Füreder Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title
Reinhold Füreder commented on JENKINS-47286
Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
While I am not sure if this is the correct/perfect/recommended place for this question, it admittedly fits to this issue and I can actually give you a little hint My approach for this is to have a skipableStage step in my shared Jenkins pipeline library that wraps the default/standard stage step, so the usage is almost like normally:
...
acmeSharedLibrary.skipableStage("stage name") {
... // normal stage implementation
}
...
... and the steps implementation in pseudo code is:
stage(stageName) {
if (currentBuild.result) {
echo "Skipping stage '${stageName}' due to build result '${currentBuild.result}'..."
Result result = Result.fromString(currentBuild.result)
markStageSkippedForResult(stageName, result) // via the aformentioned workaround
} else {
body() // which is the closure block of this "skippableStage"
}
}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title
Mihai Dinu edited a comment on JENKINS-47286
Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
There's a nice post here: **[https://comquent.de/en/skipped-stages-in-jenkins-scripted-pipeline/] that describes how to use the [https://github.com/comquent/imperative-when] workaround. I have a related question though: is it possible to show the stages that follow a failed stage as skipped (or failed)? My use case is something like this{code:java}node {try {stage('Will fail') {sh 'exit 1'}stage('Some operations') {echo 'This stage should run when previous stage is successful'echo 'Should be skipped or failed when previous stage fails'}} catch (err) {echo "Print the error from the first stage $err"}finally {stage('Post build') {echo 'Always do some cleanup ops'}}}{code} The problem that I'm facing is that any stage from my pipeline can fail and I want all my downstream stages to be skipped, except the post build one. When a stage fails, it is caught in the `catch` *_catch_* block and so all downstream stages are ignored, ruining the pipeline stage view from the job UI. Any possible solutions for this?
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title
Mihai Dinu commented on JENKINS-47286
Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
There's a nice post here: **https://comquent.de/en/skipped-stages-in-jenkins-scripted-pipeline/ that describes how to use the https://github.com/comquent/imperative-when workaround. I have a related question though: is it possible to show the stages that follow a failed stage as skipped (or failed)? My use case is something like this
node {
try {
stage('Will fail') {
sh 'exit 1'
}
stage('Some operations') {
echo 'This stage should run when previous stage is successful'
echo 'Should be skipped or failed when previous stage fails'
}
}
catch (err) {
echo "Print the error from the first stage $err"
}
finally {
stage('Post build') {
echo 'Always do some cleanup ops'
}
}
}
The problem that I'm facing is that any stage from my pipeline can fail and I want all my downstream stages to be skipped, except the post build one. When a stage fails, it is caught in the `catch` block and so all downstream stages are ignored, ruining the pipeline stage view from the job UI. Any possible solutions for this?
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Cameron Taggart commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Adding it as a Global Shared Library is documented here. https://jenkins.io/doc/book/pipeline/shared-libraries/#global-shared-libraries It is working for me. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Cameron Taggart edited a comment on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view How do we use the workaround at [https://github.com/comquent/imperative-when |https://github.com/comquent/imperative-when: ] ? It does not appear to be a plugin that we can load. I'm a bit confused on how to use it. Any tips are appreciated. It would be great if this came out of the box. I'm migrating a declarative Jenkinsfile and got stuck on this. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Cameron Taggart commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view How do we use the workaround at https://github.com/comquent/imperative-when ? It does not appear to be a plugin that we can load. I'm a bit confused on how to use it. Any tips are appreciated. It would be great if this came out of the box. I'm migrating a declarative Jenkinsfile and got stuck on this. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Reinhold Füreder commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view This morning I was positively surprised that according to BlueOcean change log (https://plugins.jenkins.io/blueocean) this issue was solved: Change log 1.11.0 (Feb 13, 2019) ... JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view ... ... "only" to find out that it is still in status reopened, i.e. unresolved and that "only" one aspect was solved: namely the missing translation (https://github.com/jenkinsci/blueocean-plugin/commit/b0bf45c64afbf511971c7e79ff2dd317f1bddfc8) – of course I am happy/grateful about that too. However, this is a bit misleading Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Chris Maes reopened an issue This issue is not solved. The skipping of stages in blue ocean view is well supported in Pipeline syntax, but not in scripted pipelines. The workaround proposed in https://github.com/comquent/imperative-when works correctly, but since I am using https://github.com/jenkinsci/JenkinsPipelineUnit it seems quite impossible for me to get my unit-tests working. Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Chris Maes Resolution: Postponed Status: Resolved Reopened Assignee: James Dumay Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title
Reinhold Füreder edited a comment on JENKINS-47286
Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
[~benkeil83] Great + thanks!Some questions and comments WRT [https://github.com/comquent/imperative-when:] # [~jamesdumay] {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} is annotated with {{@Restricted(NoExternalUse.class)}} => I assume one therefore should not and cannot rely on this method being available forever. However, since this approach seems to work very well or would be at least an acceptable workaround for scripted pipelines, how are the chances that this will be get part of the official API (via removing this annotation?) or might even get used/wrapped by a new official API? ** When trying out the other similarly named methods in {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils}} (i.e. {{markStageFailedAndContinued}}, {{markStageSkippedForFailure}}, {{markStageSkippedForUnstable}}, {{markStageSkippedForConditional}}) the behaviour is rather surprising and "proofs" the aforementioned annotation ;) => so let's just stay with {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} # [~jamesdumay] The mouse over hovering text in blue ocean shows "common.state.skipped": Since I also get this in a little declarative pipeline prototype I guess this is a minor bug (missing translation, or – maybe even better/preferable – missing to state the reason for the skipping) {color:#707070}and not a side effect of (ab-)using this method in the wrong context{color}? # @ All: I am wondering why the {{body}} closure evaluation is coded with delegation based on {{config}} map in this example!? # @ All: The {{STAGE_NAME}} is an unknown property in class section of shared library (that is not in "vars" section) but works in "Jenkinsfile" – I guess that is due to some transformation magic applied on "vars" section? # -@ All: Is that unfortunately leading to such SEVERE log lines:-{noformat}2018-04-06 11:04:03 SEVERE [io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor ] Could not find execution for run ACME-Pipeline#2347{noformat} # ** * Update:* No that is another Jenkins pipeline or Blue Ocean bug, because it also happens for builds that do NOT use this method/approach; or that even do not skip any stages...
Add Comment
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title
Reinhold Füreder edited a comment on JENKINS-47286
Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
[~benkeil83] Great + thanks!Some questions and comments WRT [https://github.com/comquent/imperative-when:] # [~jamesdumay] {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} is annotated with {{@Restricted(NoExternalUse.class)}} => I assume one therefore should not and cannot rely on this method being available forever. However, since this approach seems to work very well or would be at least an acceptable workaround for scripted pipelines, how are the chances that this will be get part of the official API (via removing this annotation?) or might even get used/wrapped by a new official API? ** When trying out the other similarly named methods in {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils}} (i.e. {{markStageFailedAndContinued}}, {{markStageSkippedForFailure}}, {{markStageSkippedForUnstable}}, {{markStageSkippedForConditional}}) the behaviour is rather surprising and "proofs" the aforementioned annotation ;) => so let's just stay with {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} # [~jamesdumay] The mouse over hovering text in blue ocean shows "common.state.skipped": Since I also get this in a little declarative pipeline prototype I guess this is a minor bug (missing translation, or – maybe even better/preferable – missing to state the reason for the skipping) {color:#707070}and not a side effect of (ab-)using this method in the wrong context{color}? # @ All: I am wondering why the {{body}} closure evaluation is coded with delegation based on {{config}} map in this example!? # @ All: The {{STAGE_NAME}} is an unknown property in class section of shared library (that is not in "vars" section) but works in "Jenkinsfile" – I guess that is due to some transformation magic applied on "vars" section? # - @ All: Is that unfortunately leading to such SEVERE log lines: - {noformat}2018-04-06 11:04:03 SEVERE [io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor ] Could not find execution for run ACME-Pipeline#2347{noformat} ** *Update:* No that is another Jenkins pipeline or Blue Ocean bug, because it also happens for builds that do NOT use this method/approach; or that even do not skip any stages...
Add Comment
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title
Reinhold Füreder edited a comment on JENKINS-47286
Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
[~benkeil83] Great + thanks!Some questions and comments WRT [https://github.com/comquent/imperative-when:] # [~jamesdumay] {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} is annotated with {{@Restricted(NoExternalUse.class)}} => I assume one therefore should not and cannot rely on this method being available forever. However, since this approach seems to work very well or would be at least an acceptable workaround for scripted pipelines, how are the chances that this will be get part of the official API (via removing this annotation?) or might even get used/wrapped by a new official API? ** When trying out the other similarly named methods in {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils}} (i.e. {{markStageFailedAndContinued}}, {{markStageSkippedForFailure}}, {{markStageSkippedForUnstable}}, {{markStageSkippedForConditional}}) the behaviour is rather surprising and "proofs" the aforementioned annotation ;) => so let's just stay with {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} # [~jamesdumay] The mouse over hovering text in blue ocean shows "common.state.skipped": Since I also get this in a little declarative pipeline prototype I guess this is a minor bug (missing translation, or – maybe even better/preferable – missing to state the reason for the skipping) {color:#707070}and not a side effect of (ab-)using this method in the wrong context{color}? # @ All: I am wondering why the {{body}} closure evaluation is coded with delegation based on {{config}} map in this example!? # @ All: The {{STAGE_NAME}} is an unknown property in class section of shared library (that is not in "vars" section) but works in "Jenkinsfile" – I guess that is due to some transformation magic applied on "vars" section? # @ All: Is that unfortunately leading to such SEVERE log lines:{noformat}2018-04-06 11:04:03 SEVERE [io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor ] Could not find execution for run ACME-Pipeline#2347{noformat}
Add Comment
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title
Reinhold Füreder edited a comment on JENKINS-47286
Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
[~benkeil83] Great + thanks!Some questions and comments WRT [ https://github.com/comquent/imperative-when: ] # [~jamesdumay] {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} is annotated with {{@Restricted(NoExternalUse.class)}} => I assume one therefore should not and cannot rely on this method being available forever. However, since this approach seems to work very well or would be at least an acceptable workaround for scripted pipelines, how are the chances that this will be get part of the official API (via removing this annotation?) or might even get used/wrapped by a new official API? ** When trying out the other similarly named methods in {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils}} (i.e. {{markStageFailedAndContinued}}, {{markStageSkippedForFailure}}, {{markStageSkippedForUnstable}}, {{markStageSkippedForConditional}}) the behaviour is rather surprising and "proofs" the aforementioned annotation ;) => so let's just stay with {{org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME)}} # [~jamesdumay] The mouse over hovering text in blue ocean shows "common.state.skipped": Since I also get this in a little declarative pipeline prototype I guess this is a minor bug (missing translation, or -- – maybe even better/preferable -- – missing to state the reason for the skipping) {color:#707070}and not a side effect of (ab-)using this method in the wrong context{color}?# @ All: I am wondering why the {{body}} closure evaluation is coded with delegation based on {{config}} map in this example!?# @ All: The {{STAGE_NAME}} is an unknown property in class section of shared library (that is not in "vars" section) but works in "Jenkinsfile" -- – I guess that is due to some transformation magic applied on "vars" section?
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Reinhold Füreder commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Ben Keil Great + thanks! Some questions and comments WRT https://github.com/comquent/imperative-when: James Dumay org.jenkinsci.plugins.pipeline.modeldefinition.Utils.markStageSkippedForConditional(STAGE_NAME) is annotated with @Restricted(NoExternalUse.class) => I assume one therefore should not and cannot rely on this method being available forever. However, since this approach seems to work very well or would be at least an acceptable workaround for scripted pipelines, how are the chances that this will be get part of the official API (via removing this annotation?) or might even get used/wrapped by a new official API? James Dumay The mouse over hovering text in blue ocean shows "common.state.skipped": Since I also get this in a little declarative pipeline prototype I guess this is a minor bug (missing translation, or – maybe even better/preferable – missing to state the reason for the skipping) and not a side effect of (ab-)using this method in the wrong context? @ All: I am wondering why the body closure evaluation is coded with delegation based on config map in this example!? @ All: The STAGE_NAME is an unknown property in class section of shared library (that is not in "vars" section) but works in "Jenkinsfile" – I guess that is due to some transformation magic applied on "vars" section? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Ben Keil updated an issue Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Ben Keil Comment: But I would be nice if all functions from the declarative pipeline also be available in the scripted pipeline. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Ben Keil commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view But I would be nice if all functions from the declarative pipeline also be available in the scripted pipeline. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Grzegorz Kotarski commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view I can confirm too, it works very nice, good work! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Aron Smyk edited a comment on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Works like a charm! Great find [~benkeil83], thanks!Since the solution was a 15 -liner lines of Shared Library I hope it will be implemented. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Aron Smyk commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Works like a charm! Great find Ben Keil, thanks! Since the solution was a 15-liner Shared Library I hope it will be implemented. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Ben Keil commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Take a look at https://github.com/comquent/imperative-when Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Leandro Lucarella commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view +1 Even when the issue proper here concerns me, I find it very worrying that there are features that are planned to be only available in declarative when I thought declarative was just a convenient simplification of scripted pipelines for people only needing very simple pipelines. Is obvious that when it comes to complex pipelines, or even sharing code (reuse possibilities are very crippled in declarative, as one can't put stages or stuff like agent or triggers in a library), there is no other option but scripted pipelines. It seems crazy (and backwards) to make scripted pipelines a second-class citizen. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Grzegorz Kotarski commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Why is the issue marked as resolved? The declarative pipeline is a subset of scripted pipeline (if I understand correctly), so there should be also possible to skip the stage. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Simon Wydooghe commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view I think people with scripted pipelines could benefit greatly from this. Scripted pipeline users run more advanced pipelines I'm guessing, so it feels weird to not support this feature there as it seems they will be the first ones to implement this functionality in their pipelines. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Patrice Matignon commented on JENKINS-47286 Re: Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view I find unfortunate that the ticket be rejected wholesale. I think it had 2 things potentially in its scope that could be considered independently, and both of them are pretty common sense IMHO. The first part is adding support for skipped stages (i.e. add an _expression_ to the stage to determine whether to skip or not), which was shutdown, sadly. The second part is concerned solely on rendering a skipped stage in a pipeline visualization (classic or blue ocean). This applies to declarative pipelines right now, and I can't think there would be anyone arguing against it. IF skipped stages are one day available on scripted pipelines, the same rendering would apply as well. Would there be support for splitting this ticket maybe ? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47286) Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view
Title: Message Title Patrice Matignon updated an issue Jenkins / JENKINS-47286 Support skipping stages in scripted pipelines for nice visualization in blue ocean and classic UI stage view Change By: Patrice Matignon Created as response to comments of https://issues.jenkins-ci.org/browse/JENKINS-37781 as the visualization of skipped stages is very, very nice for declarative pipelines in Blue Ocean. # Allow to skip stages in scripted pipelines leading to equally nice visualization in Blue Ocean: The current approaches mentioned by [~mkobit] in https://issues.jenkins-ci.org/browse/JENKINS-37781?focusedCommentId=294965=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-294965 and [~jamesdumay] in https://issues.jenkins-ci.org/browse/JENKINS-37781?focusedCommentId=294966=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-294966 lead to either misleading or just less obvious visualization... # Improve visualization of stage view: instead of showing skipped stages (declarative pipelines) as always being green and allegedly executed, make them e.g. gray. ** Stage "skipped" is actually skipped, but stage view shows: !classic-ui-stage-view-1.png|thumbnail! ** This is IMHO also an IMHO a major enhancement and valid fix for the other problem reported by [~mkobit] in https://issues.jenkins-ci.org/browse/JENKINS-37781?focusedCommentId=294965=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-294965: "[The Pipeline Stage View Plugin] has some weird display issues if new pipelines have different stage executions than previous ones." Add Comment
