[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title SCM/JIRA link daemon commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubNotificationContext.java http://jenkins-ci.org/commit/github-branch-source-plugin/23480ace348f5515e227e507d5aeeda46fc93c89 Log: Merge pull request #175 from steven-foster/JENKINS-47366 JENKINS-47366 Avoid reporting premature build status Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/c088f0b60bf9...23480ace348f *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Steven Foster commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit I have an open PR at https://github.com/jenkinsci/github-branch-source-plugin/pull/175 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Tim Jacomb commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit Steven Foster Did you get anywhere with this? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Andrew Bayer updated an issue Jenkins / JENKINS-47366 Checkout in second stage sets SUCCESS on Github commit Change By: Andrew Bayer Component/s: core Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title
Frank Grimes updated an issue
Jenkins / JENKINS-47366
Checkout in second stage sets SUCCESS on Github commit
Change By:
Frank Grimes
In tIn a multi-agent pipeline, 'checkout' step sets SUCCESS status to Github commit. This happens if any previous stage already published successful build result.So commit is marked as SUCCESS for some time. If later tests fail, commit status is changed for FAILURE. *This enables bad code merge from a PR and bad code deployment*.This is seen in several complex pipelines with the both pipeline default checkout and with {{checkout scm}}. Here is a minimal example, where {{junit}} or any other publishing step replaced with {{currentBuild.result = 'SUCCESS'}}:{code:java}pipeline {agent nonestages {stage('Set SUCCESS') {agent anysteps {script {currentBuild.result = 'SUCCESS'}}}stage('Checkout, test, fail') {agent anysteps {sh """sleep 60 exit 1"""}}}}{code}Here are selected lines rom a build log. Note two 'GitHub has been notified' messages:{code:java}Branch indexing06:33:50 Connecting to https://api.github.com using Obtained Jenkinsfile from 2c5c8ce94a1ba597eab4c959a4f43f505c38a77c[Pipeline] stage[Pipeline] { (Set SUCCESS)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout...[Pipeline] withEnv[Pipeline] {[Pipeline] script[Pipeline] {[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Checkout, test, fail)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout > /usr/bin/git rev-parse --is-inside-work-tree # timeout=60Fetching changes from the remote Git repository... > /usr/bin/git config core.sparsecheckout # timeout=60 > /usr/bin/git checkout -f 7ce1f7ba4b355294f3fc475b9d84528eba3669cbCommit message: "Update Jenkinsfile"GitHub has been notified of this commit’s build result[Pipeline] withEnv[Pipeline] {[Pipeline] sh[a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA] Running shell script+ sleep 60+ exit 1[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] End of PipelineGitHub has been notified of this commit’s build resultERROR: script returned exit code 1Finished: FAILURE{code}
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title
Frank Grimes updated an issue
Jenkins / JENKINS-47366
Checkout in second stage sets SUCCESS on Github commit
Change By:
Frank Grimes
tIn In a multi-agent pipeline, 'checkout' step sets SUCCESS status to Github commit. This happens if any previous stage already published successful build result.So commit is marked as SUCCESS for some time. If later tests fail, commit status is changed for FAILURE. *This enables bad code merge from a PR and bad code deployment*.This is seen in several complex pipelines with the both pipeline default checkout and with {{checkout scm}}. Here is a minimal example, where {{junit}} or any other publishing step replaced with {{currentBuild.result = 'SUCCESS'}}:{code:java}pipeline {agent nonestages {stage('Set SUCCESS') {agent anysteps {script {currentBuild.result = 'SUCCESS'}}}stage('Checkout, test, fail') {agent anysteps {sh """sleep 60 exit 1"""}}}}{code}Here are selected lines rom a build log. Note two 'GitHub has been notified' messages:{code:java}Branch indexing06:33:50 Connecting to https://api.github.com using Obtained Jenkinsfile from 2c5c8ce94a1ba597eab4c959a4f43f505c38a77c[Pipeline] stage[Pipeline] { (Set SUCCESS)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout...[Pipeline] withEnv[Pipeline] {[Pipeline] script[Pipeline] {[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Checkout, test, fail)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout > /usr/bin/git rev-parse --is-inside-work-tree # timeout=60Fetching changes from the remote Git repository... > /usr/bin/git config core.sparsecheckout # timeout=60 > /usr/bin/git checkout -f 7ce1f7ba4b355294f3fc475b9d84528eba3669cbCommit message: "Update Jenkinsfile"GitHub has been notified of this commit’s build result[Pipeline] withEnv[Pipeline] {[Pipeline] sh[a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA] Running shell script+ sleep 60+ exit 1[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] End of PipelineGitHub has been notified of this commit’s build resultERROR: script returned exit code 1Finished: FAILURE{code}
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Alexander Vorobiev commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit Awesome! Looking forward to be able to split our monolith stages. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Steven Foster commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit Actually, I see the bug now. My mistake. I'll try to fix it Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Steven Foster commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit From what I understand, the Multibranch (github-branch-source) pipeline only updates the Github Commit Status at 3 places: When the job is queued (pending) When the repo is checked out (in progress) and When the job finishes (result) I'm not sure where it would update the commit status in the middle of the build, that's why I asked about another plugin. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Alexander Vorobiev commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit Steven Foster, no, this plugin is not installed in the system. Thank you for looking at it. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Steven Foster commented on JENKINS-47366 Re: Checkout in second stage sets SUCCESS on Github commit do you have https://plugins.jenkins.io/github-autostatus plugin installed? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title Alexander Vorobiev updated an issue Jenkins / JENKINS-47366 Checkout in second stage sets SUCCESS on Github commit Change By: Alexander Vorobiev Component/s: core Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
