[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Felipe Santos edited a comment on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned I suppose think https://issues.jenkins-ci.org/browse/ JENKINS-61469 is caused due to this. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.188533.1518867464000.56.1585171321033%40Atlassian.JIRA.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Felipe Santos commented on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned I suppose https://issues.jenkins-ci.org/browse/JENKINS-61469 is caused due to this. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.188533.1518867464000.51.1585171320961%40Atlassian.JIRA.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Andrew Bayer updated an issue Jenkins / JENKINS-49610 The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned Change By: Andrew Bayer Priority: Critical Major Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Michael Neale edited a comment on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned [~abayer] Now blue ocean is being fixed - the main thing for this is *probably* to have an obnoxious SEVERE error that an id isn't set (aimed at jobDSL users). I'll confirm with other users that this was the issue (mostly they seem to be jobDSL users) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Michael Neale commented on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned Now blue ocean is being fixed - the main thing for this is probably to have an obnoxious SEVERE error that an id isn't set (aimed at jobDSL users). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Michael Neale commented on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned On talking with stephen - the short term more urgent thing is to fix up blue ocean https://issues.jenkins-ci.org/browse/JENKINS-48571 first - get that out. Then can look at this to warn/error out for jobdsl/future users. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Michael Neale commented on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned Right, this is tricky. Can I ask if this has been around, with jobDSL, and only recently being noted? A warning/error may be ok for jobDSL, but for blue ocean would want it to not suddenly blow up. If a work around for blue users is to open and save the config in classic - I think that is ok, if that is the main impact (assuming it is fixed so NEW jobs get a reasonable non null id). Assuming I understood this. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Stephen Connolly commented on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned Ok, after seeing how many users of JobDSL are being caught by this, I am inclined to thing we critically need to throw an exception in setOwner if id==null even if this risks breaking existing job-dsl scripts as anything else will risk rebuild storms after job-dsl overwrites the configuration which IMHO would help users fix the bug in their job-dsl scripts rather than mask it further down in the weeds. We cannot make this change cleanly, however, as this change will cause BlueOcean to blow up. I think a hack-fix may be required until BlueOcean is fixed... namely we create the ISE and walk the stack to see if BlueOcean is in the stack-trace... if we see BlueOcean (by String classname) then we Log the exception at SEVERE and set the id to blueocean otherwise we throw. That would be my suggestion, but we should assess any alternatives as the stack walking is certainly a bad code smell... even if a non-performance critical code path... and we need to assess what would happen if job-dsl blows up... does it delete the job or leave it alone? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Stephen Connolly updated an issue Jenkins / JENKINS-49610 The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned Change By: Stephen Connolly Issue Type: Bug Improvement Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Stephen Connolly commented on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned There may also be other potential solutions. e.g. your original PR could be a potential solution if you want to put that in the assessment. Feel free to just take my two proposed candidate solutions or to investigate and come up with additional proposed solutions... you need to assess at least two solutions though, and I'd like the "throwing IllegalStateException" to be included in the assessment Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title
Stephen Connolly commented on JENKINS-49610
Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Assessment criteria for selection of a proposed solution
I'm not looking for anything complex or a heavyweight process... could be as simple as "I'm going to setup a test system with a broken job-dsl script that doesn't assign {{id}}s and see which causes rebuilds" or could be as complex as 10 pages of various metrics (I would hope you err on the side of simple though) Just let's get the criteria agreed, documented and record the results and decision.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
Title: Message Title Stephen Connolly commented on JENKINS-49610 Re: The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned FTR my initial gut feeling is that throwing IllegalStateException is the better way to go as the UI code paths should always be pre-assigning an ID and this would catch users of e.g. JobDSL and present them with a meaningful exception that guides them to their solution. That would have the side-effect of breaking existing (IMHO already broken) systems... but the other approach would give those systems build storms which would be a much more subtle problem to notice Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49610) The SCMSource.setOwner(owner) contract needs updating to include ensuring that an ID has been assigned
<<< text/html; charset="UTF-8": Unrecognized >>>
