[JIRA] (JENKINS-49709) Proxy Config broken in Bitbucket Branch Source Plugin
Title: Message Title Antonio Muñiz closed an issue as Fixed Fixed in https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/112 Jenkins / JENKINS-49709 Proxy Config broken in Bitbucket Branch Source Plugin Change By: Antonio Muñiz Status: Open Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options,
[JIRA] (JENKINS-49709) Proxy Config broken in Bitbucket Branch Source Plugin
Title: Message Title Thomas Kalmár commented on JENKINS-49709 Re: Proxy Config broken in Bitbucket Branch Source Plugin Hi Jaco, URI.create(...) does not throw an MalformedURLException. The JavaDoc of the getHttpClient Mehtod states: @param host must be of format: scheme://host:port. e.g. http://localhost:7990 which should be validated on the Configuration page. If you have an invalid host your whole setup is broken. BTW. poor mans solution is entering the scheme://host:port in the proxy exception list :/. If your solution should work you also have to strip the port from the URL. (Pattern ^.?://([^:]) ) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49709) Proxy Config broken in Bitbucket Branch Source Plugin
Title: Message Title Jaco Greyling commented on JENKINS-49709 Re: Proxy Config broken in Bitbucket Branch Source Plugin Hi Thomas, I see you've closed my issue, before I could comment, so let me do it here. Whilst your solution certainly looks elegant on face value I do have a problem with it. You're trying to cast to a new class (URL) and if it fails it throws a MalformedURLException. The problem I have with this is the fact that when you through the Exception you don't know where it comes from (unless you investigate the stack trace). With my solution I merely strip the scheme:// and leave the validation to HttpGet. This means that if there is indeed a problem with the original URL it will be thrown by the HTTP client (in this case Apache HTTP Client) which in my opinion is a better place for it. It makes errors handling easier to interpret in a runtime situation. Perhaps that is just my view, but happy to see what the maintainers decide to do with it Thanks for your input, though! Jaco Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49709) Proxy Config broken in Bitbucket Branch Source Plugin
Title: Message Title Thomas Kalmár updated an issue Jenkins / JENKINS-49709 Proxy Config broken in Bitbucket Branch Source Plugin Change By: Thomas Kalmár When getting the proxy config (for an Bitbucket server) the protocoll and port should be ignored.As a workaround i have to put the full host URL of the Server in the Proxy Exclusion list Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49709) Proxy Config broken in Bitbucket Branch Source Plugin
Title: Message Title Thomas Kalmár commented on JENKINS-49709 Re: Proxy Config broken in Bitbucket Branch Source Plugin https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/112 should fix this Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49709) Proxy Config broken in Bitbucket Branch Source Plugin
Title: Message Title Thomas Kalmár created an issue Jenkins / JENKINS-49709 Proxy Config broken in Bitbucket Branch Source Plugin Issue Type: Bug Assignee: Unassigned Components: bitbucket-branch-source-plugin Created: 2018-02-23 08:45 Priority: Minor Reporter: Thomas Kalmár When getting the proxy config the protocoll and port should be ignored. As a workaround i have to put the full host URL of the Server in the Proxy Exclusion list Add Comment This message was sent by Atlassian JIRA
