[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Rafael Pestano updated JENKINS-50116 Jenkins / JENKINS-50116 Last changes history becomes empty after Jenkins restart Change By: Rafael Pestano Status: Fixed but Unreleased Closed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Rafael Pestano updated JENKINS-50116 Fixed for v2.6.3 Jenkins / JENKINS-50116 Last changes history becomes empty after Jenkins restart Change By: Rafael Pestano Status: Open Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Daniel Beck commented on JENKINS-50116 Re: Last changes history becomes empty after Jenkins restart Make the transient action factory the only source for project actions – not any job property or whatever else you did. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Rafael Pestano commented on JENKINS-50116 Re: Last changes history becomes empty after Jenkins restart Hi again Daniel Beck, I got some progress here and now it is working (I can get LastChanges history after jenkins restart) but I still need to traverse all builds (now on the transient factory) so I think it can be improved, see changes here. Also when I add the transient factory I get duplicated last changes icon on the left panel (see attached image) . Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Rafael Pestano updated an issue Jenkins / JENKINS-50116 Last changes history becomes empty after Jenkins restart Change By: Rafael Pestano Attachment: last-changes-icons.png Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Daniel Beck commented on JENKINS-50116 Re: Last changes history becomes empty after Jenkins restart There's no need to store the project-level action. It can be transient, hence the name. https://jenkins.io/doc/developer/extensions/jenkins-core/#transientactionfactory might help. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Rafael Pestano commented on JENKINS-50116 Re: Last changes history becomes empty after Jenkins restart Hi Daniel Beck, thank you very much for the hint. Do you have any docs or sample project using TransientActionFactory? As an example I've found github plugin link action and they use the concept of job property, see here. Do I need it? When/how the action is stored on the factory? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Daniel Beck commented on JENKINS-50116 Re: Last changes history becomes empty after Jenkins restart The project action looks like it should be created in a https://javadoc.jenkins.io/jenkins/model/TransientActionFactory.html for the appropriate job type (AbstractProject) rather than stored with the job. It could be attached to any project, and getIcon overloaded to only show when one of the newest N builds has an Action attached. This would be more efficient than always traversing all builds. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title
Rafael Pestano updated an issue
Jenkins / JENKINS-50116
Last changes history becomes empty after Jenkins restart
Change By:
Rafael Pestano
After a restart the [Last changes history|https://wiki.jenkins.io/display/JENKINS/Last+Changes+Plugin#LastChangesPlugin-Buildchangeshistory] becomes empty. This is explained by following comment on JENKINS-49368:{quote}[https://github.com/jenkinsci/last-changes-plugin/commit/0cb6083a31b207099c5400e4f4a93bee8510f3a5] will not work correctly after the Jenkins restart. The class has no readResolve() resolution, so the value will be null when you save new jobs and reload them from the disk. It will cause NPEs in methods like getLastChangesBuilds().{quote} [getLastChangesBuilds()|https://github.com/jenkinsci/last-changes-plugin/blob/2e0f1c1c58d7a1ccda8118f98d874951a4dab7f6/src/main/resources/com/github/jenkins/lastchanges/LastChangesProjectAction/index.jelly#L15] is what we use to create the history page. Note that after a job run the history is restored.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title
Rafael Pestano updated an issue
Jenkins / JENKINS-50116
Last changes history becomes empty after Jenkins restart
Change By:
Rafael Pestano
After a restart the [Last changes history|https://wiki.jenkins.io/display/JENKINS/Last+Changes+Plugin#LastChangesPlugin-Buildchangeshistory] becomes empty. This is explained by following comment on JENKINS-49368:{quote} [https://github.com/jenkinsci/last-changes-plugin/commit/0cb6083a31b207099c5400e4f4a93bee8510f3a5] will not work correctly after the Jenkins restart. The class has no readResolve() resolution, so the value will be null when you save new jobs and reload them from the disk. It will cause NPEs in methods like getLastChangesBuilds().{quote} [ getLastChangesBuilds() |https://github.com/jenkinsci/last-changes-plugin/blob/2e0f1c1c58d7a1ccda8118f98d874951a4dab7f6/src/main/resources/com/github/jenkins/lastchanges/LastChangesProjectAction/index.jelly#L15] is what we use to create the history page.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title
Rafael Pestano updated an issue
Jenkins / JENKINS-50116
Last changes history becomes empty after Jenkins restart
Change By:
Rafael Pestano
As comented After a restart the [Last changes history|https://wiki.jenkins.io/display/JENKINS/Last+Changes+Plugin#LastChangesPlugin-Buildchangeshistory] becomes empty. This is explained by following comment on JENKINS-49368: {quote} [ https://github.com/jenkinsci/last-changes-plugin/commit/0cb6083a31b207099c5400e4f4a93bee8510f3a5 ] will not work correctly after the Jenkins restart. The class has no readResolve() resolution, so the value will be null when you save new jobs and reload them from the disk. It will cause NPEs in methods like getLastChangesBuilds(). {quote} getLastChangesBuilds() is what we use to create the history page.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop rec
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Rafael Pestano updated an issue Jenkins / JENKINS-50116 Last changes history becomes empty after Jenkins restart Change By: Rafael Pestano As comented on JENKINS- 45892 49368 :https://github.com/jenkinsci/last-changes-plugin/commit/0cb6083a31b207099c5400e4f4a93bee8510f3a5 will not work correctly after the Jenkins restart. The class has no readResolve() resolution, so the value will be null when you save new jobs and reload them from the disk. It will cause NPEs in methods like getLastChangesBuilds(). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50116) Last changes history becomes empty after Jenkins restart
Title: Message Title Rafael Pestano created an issue Jenkins / JENKINS-50116 Last changes history becomes empty after Jenkins restart Issue Type: Bug Assignee: Rafael Pestano Components: last-changes-plugin Created: 2018-03-12 11:49 Priority: Minor Reporter: Rafael Pestano As comented on JENKINS-45892: https://github.com/jenkinsci/last-changes-plugin/commit/0cb6083a31b207099c5400e4f4a93bee8510f3a5 will not work correctly after the Jenkins restart. The class has no readResolve() resolution, so the value will be null when you save new jobs and reload them from the disk. It will cause NPEs in methods like getLastChangesBuilds(). Add Comment
