[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Paul Allen closed an issue as Fixed Released in 1.8.8 Jenkins / JENKINS-50393 P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable Change By: Paul Allen Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Paul Allen resolved as Fixed Ready for release. Jenkins / JENKINS-50393 P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable Change By: Paul Allen Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Paul Allen commented on JENKINS-50393 Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable If anyone wants to test the fix the latest build for the HPI file is here: https://ci.jenkins.io/job/Plugins/job/p4-plugin/job/master/188/ Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50393 Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/workspace/ManualWorkspaceImpl.java src/test/java/org/jenkinsci/plugins/p4/client/WorkspaceTest.java http://jenkins-ci.org/commit/p4-plugin/befa99fd217ab61ca72ae0d0e925b2015c32da6a Log: Look for the expanded original name when updating the view. Added test case for Job names with a '/' restricted character. JENKINS-50393 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Paul Allen started work on JENKINS-50393 Change By: Paul Allen Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Paul Allen updated an issue Jenkins / JENKINS-50393 P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable Change By: Paul Allen Labels: P4_VERIFY P4_A Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Paul Allen assigned an issue to Paul Allen Jenkins / JENKINS-50393 P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable Change By: Paul Allen Assignee: Paul Allen Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title
Michael Rose commented on JENKINS-50393
Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
In my case, I switched from ${JOB_NAME} to ${JOB_BASE_NAME} as a short-term fix.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Michael Rose edited a comment on JENKINS-50393 Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable I just ran into this problem as well. Should have looked before creating an a similar issue that occurs with pipeline jobs . Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Michael Rose commented on JENKINS-50393 Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable I just ran into this problem as well. Should have looked before creating an issue. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title
Karl Wirth edited a comment on JENKINS-50393
Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Confirm reproduction steps(1) Create a Folder(2) Create Freestyle johb under folder(3) Use recomended workspace naming convention 'jenkins-$\{NODE_NAME}-$\{JOB_NAME}-$\{EXECUTOR_NUMBER}' when setting up Perforce connection.(4) 'Build Now'Error as mentioned above is because the folder is part of the JOB_NAME but in the name it '/' is replaced with '-' but not in the view:{code:java}ERROR: P4: Unable to setup workspace: com.perforce.p4java.exception.RequestException: Error in client specification.Mapping '//jenkins-master-Folder2/FreestyleUnderFolder-1/...' is not under '//jenkins-master-Folder2-FreestyleUnderFolder-1/...'.{code}
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title
Karl Wirth commented on JENKINS-50393
Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Confirm reproduction steps (1) Create a Folder (2) Create Freestyle johb under folder (3) Use recomended workspace naming convention 'jenkins-${NODE_NAME}${JOB_NAME}${EXECUTOR_NUMBER}' when setting up Perforce connection. (4) 'Build Now' Error as mentioned above is because the folder is part of the JOB_NAME but in the name it is replaced with '-' but not in the view:
ERROR: P4: Unable to setup workspace: com.perforce.p4java.exception.RequestException: Error in client specification.
Mapping '//jenkins-master-Folder2/FreestyleUnderFolder-1/...' is not under '//jenkins-master-Folder2-FreestyleUnderFolder-1/...'.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Karl Wirth updated an issue Jenkins / JENKINS-50393 P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable Change By: Karl Wirth Labels: P4_VERIFY Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Paul Allen commented on JENKINS-50393 Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable The only significant change introduced in 1.8.7 was from pull request https://github.com/jenkinsci/p4-plugin/pull/70 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title Maxfield Stewart commented on JENKINS-50393 Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable Confirmed this happens for us as well with 1.8.7 and we had to downgrade to 1.8.6. It would appear that folder paths, in particular, are not escaped properly in the workspace name (but still escape properly in the client spec). Workspace names are not properly converting the job_name of a folder, which will have a path style syntax with "/" for folder breaks, into "-" hyphen's which was the traditional behavior. It still works for the clientspec however. This effectively breaks anyone using jobs in folders. For us this occurred trying to load global libraries for a pipeline in the folder global library config, but we can repro it at the job level as well. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title W Basu commented on JENKINS-50393 Re: P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable David Hows, thanks for raising this issue. Are you paying perforce customer? If yes, would you raise this through the support channel as well please? This would ensure a better traction. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title
David Hows updated an issue
Jenkins / JENKINS-50393
P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Change By:
David Hows
Upgraded to 1.8.7 and this has broken all jobs on our instance which use the JOB_NAME variable for workspace name/mapping.Looking at the failed jobs, I can see that the $\{JOB_NAME} variable used for both the Workspace name and list of mappings is being treated differently.Consider the output below.{code:java}p4 client -o syd_jenkins_NightlyTesting-BUILD_COMPILER-clang-3.5.0... p4 client -i +P4: Unable to setup workspace: com.perforce.p4java.exception.RequestException: Error in client specification.Mapping '//syd_jenkins_NightlyTesting/BUILD_COMPILER=clang-3.5.0/...' is not under '//syd_jenkins_NightlyTesting-BUILD_COMPILER-clang-3.5.0/...'.{code}The job configuration contains a workspace name of \ { \ {syd_jenkins_$\ \ {JOB_NAME \ } }}and there are a list of mappings for this workspace that take the form of:{code:java}//Depot/core/dummy/... //syd_jenkins_${JOB_NAME}/...{code} From the output above, I believe the expansion of the JOB_NAME variable is treated differently within the two fields, rendering the 1.8.7 release of the P4 plugin unusable for anyone running in this manner.I have downgraded to 1.8.6 in the interim and this has resolved the issue.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title
David Hows updated an issue
Jenkins / JENKINS-50393
P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Change By:
David Hows
Upgraded to 1.8.7 and this has broken all jobs on our instance which use the JOB_NAME variable for workspace name/mapping.Looking at the failed jobs, I can see that the $\{JOB_NAME} variable used for both the Workspace name and list of mappings is being treated differently.Consider the output below.{code:java}p4 client -o syd_jenkins_NightlyTesting-BUILD_COMPILER-clang-3.5.0... p4 client -i +P4: Unable to setup workspace: com.perforce.p4java.exception.RequestException: Error in client specification.Mapping '//syd_jenkins_NightlyTesting/BUILD_COMPILER=clang-3.5.0/...' is not under '//syd_jenkins_NightlyTesting-BUILD_COMPILER-clang-3.5.0/...'.{code}The job configuration contains a workspace name of \{\{syd_jenkins_ \ $\\{JOB_NAME\} }}and there are a list of mappings for this workspace that take the form of:{code:java}//Depot/core/dummy/... //syd_jenkins_${JOB_NAME}/...{code} From the output above, I believe the expansion of the JOB_NAME variable is treated differently within the two fields, rendering the 1.8.7 release of the P4 plugin unusable for anyone running in this manner.I have downgraded to 1.8.6 in the interim and this has resolved the issue.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-50393) P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Title: Message Title
David Hows created an issue
Jenkins / JENKINS-50393
P4 Plugin update 1.8.7 breaks against workspaces using the $JOB_NAME variable
Issue Type:
Bug
Assignee:
Unassigned
Components:
p4-plugin
Created:
2018-03-25 23:32
Priority:
Blocker
Reporter:
David Hows
Upgraded to 1.8.7 and this has broken all jobs on our instance which use the JOB_NAME variable for workspace name/mapping. Looking at the failed jobs, I can see that the ${JOB_NAME} variable used for both the Workspace name and list of mappings is being treated differently. Consider the output below.
p4 client -o syd_jenkins_NightlyTesting-BUILD_COMPILER-clang-3.5.0
... p4 client -i +
P4: Unable to setup workspace: com.perforce.p4java.exception.RequestException: Error in client specification.
Mapping '//syd_jenkins_NightlyTesting/BUILD_COMPILER=clang-3.5.0/...' is not under '//syd_jenkins_NightlyTesting-BUILD_COMPILER-clang-3.5.0/...'.
The job configuration contains a workspace name of {{syd_jenkins_${JOB_NAME} }}and there are a list of mappings for this workspace that take the form of:
//Depot/core/dummy/... //syd_jenkins_${JOB_NAME}/...
From the output above, I believe the expansion of the JOB_NAME variable is treated differently within the two fields, rendering the 1.8.7 release of the P4 plugin unusable for anyone running in this manner. I have downgraded to 1.8.6 in the interim and this has
