[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Prem Gangana assigned an issue to Antonio Muñiz Hi Antonio, Could you check this issue ? -Prem Jenkins / JENKINS-50744 locks in parallel phases are incorrectly handled Change By: Prem Gangana Assignee: Antonio Muñiz Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189843.1523464883000.20367.1559622120193%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title
Prem Gangana updated an issue
Jenkins / JENKINS-50744
locks in parallel phases are incorrectly handled
Change By:
Prem Gangana
Hi,I would like to know if there is something wrong with below pipeline script.Step 1 : Trigger a pipeline build with the {{error error}} commented outStep 2 : Immediately trigger another pipeline build with {{error error}} un-commentedStep 3 : You will see that the build 1 gets superseded and aborted as soon as the build 2 errors out.I would expect build 1 to not get superseded and finish, since build 2 {color:#ff}*failed*{color}, not *passed*.I have removed the milestone steps from the script and then repeated Steps 1 & 2. This time, build 1 does not get superseded and do not get aborted.I wonder if the usage of milestones is flawed here ? If so, how can i change the script to achieve expected behaviorSample Pipeline Script: {code:java}node { timestamps{milestone()lock(resource: "my_bld_lock", inversePrecedence: true) { milestone() stage("Bld") {sleep 10 }}milestone()lock(resource: "my_pkg_lock", inversePrecedence: true) { milestone() stage("Pkg") {sleep 15 }}milestone()parallel(["Testing" : { lock(resource: "my_test_lock", inversePrecedence: true) {stage("Test") { sleep 6} }},"Second Level Testing": { lock(resource: "my_second_test_lock", inversePrecedence: true) {stage("Second Level Test") { sleep 4} }},"Create & Deploy" : { lock(resource: "my_create_lock", inversePrecedence: true) {stage("Create") { sleep 5 // error "error" sleep 30} } lock(resource: "my_deploy_lock", inversePrecedence: true) {stage("Deploy") { sleep 70} }},])milestone() }}{code}
Add Comment
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title
Prem Gangana updated an issue
Jenkins / JENKINS-50744
locks in parallel phases are incorrectly handled
Change By:
Prem Gangana
Hi, We have noticed, I would like to know if there is something wrong with below pipeline script.Step 1 : Trigger a pipeline build with the {{error error}} commented out Step 2 : Immediately trigger another pipeline build with {{error error}} un-commented Step 3 : You will see that the locks were build 1 gets superseded and aborted as soon as the build 2 errors out.I would expect build 1 to not handled / cleaned up properly during parallel phase executions get superseded and finish, since build 2 {color:#FF}*failed*{color}, not *passed* . I have removed the milestone steps from the script and then repeated Steps 1 & 2. This time, build 1 does not get superseded and aborted.I wonder if the usage of milestones is flawed here ? If so, how can i change the script to achieve expected behavior Sample Pipeline Script: {code:java}node { timestamps{ milestone() lock(resource: "my_bld_lock", inversePrecedence: true) {milestone()stage("Bld") { sleep 5 10 } } milestone() lock(resource: "my_pkg_lock", inversePrecedence: true) { milestone() stage("Pkg") {sleep 15 }}milestone() parallel([ "Testing" : {lock(resource: "my_test_lock", inversePrecedence: true) { stage("Test") { // error "error" sleep 10 6 }} }, "Second Level Testing": {lock(resource: "my_second_test_lock", inversePrecedence: true) { stage("Second Level Test") {sleep 10 4 }} }, " Deployment Create & Deploy " : {lock(resource: " my_deploy_lock my_create_lock ", inversePrecedence: true) { stage(" Deploy Create ") {sleep 90 5 } // error "error" sleep 30 } } , failFast lock(resource : "my_deploy_lock", inversePrecedence: true ) { ] stage("Deploy" ) { sleep 70 } {code } Scenario : }, ]) Trigger a pipeline build with with above pipeline script first and then trigger a second one with the line _error "error"_ un-commented. You will see that, the first pipeline build gets killed milestone ( ABORTED or NOT_BUILT ) as soon as the second pipeline build errors out. The first pipeline build console shows that it is Superseded by the second build, which obviously should not be the case, the second build was waiting for the lock "my_deploy_lock" and it should not have killed the build that possessed the lock. } Note: failFast is required in this case, the problem is that the errored build is killing another build }{code}
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title
Prem Gangana updated an issue
Jenkins / JENKINS-50744
locks in parallel phases are incorrectly handled
Change By:
Prem Gangana
Hi,I would like to know if there is something wrong with below pipeline script.Step 1 : Trigger a pipeline build with the {{error error}} commented out Step 2 : Immediately trigger another pipeline build with {{error error}} un-commented Step 3 : You will see that the build 1 gets superseded and aborted as soon as the build 2 errors out.I would expect build 1 to not get superseded and finish, since build 2 {color:# FF ff }*failed*{color}, not *passed*.I have removed the milestone steps from the script and then repeated Steps 1 & 2. This time, build 1 does not get superseded and aborted.I wonder if the usage of milestones is flawed here ? If so, how can i change the script to achieve expected behaviorSample Pipeline Script: {code:java}node { timestamps{milestone()lock(resource: "my_bld_lock", inversePrecedence: true) { milestone() stage("Bld") {sleep 10 }}milestone()lock(resource: "my_pkg_lock", inversePrecedence: true) { milestone() stage("Pkg") {sleep 15 }}milestone()parallel(["Testing" : { lock(resource: "my_test_lock", inversePrecedence: true) {stage("Test") { sleep 6} }},"Second Level Testing": { lock(resource: "my_second_test_lock", inversePrecedence: true) {stage("Second Level Test") { sleep 4} }},"Create & Deploy" : { lock(resource: "my_create_lock", inversePrecedence: true) {stage("Create") { sleep 5 // error "error" sleep 30} } lock(resource: "my_deploy_lock", inversePrecedence: true) {stage("Deploy") { sleep 70} }},])milestone() }}{code}
Add Comment
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Prem Gangana updated an issue Jenkins / JENKINS-50744 locks in parallel phases are incorrectly handled Change By: Prem Gangana Labels: lockable milestone parallel pipeline Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189843.1523464883000.20350.1559621820286%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Prem Gangana commented on JENKINS-50744 Re: locks in parallel phases are incorrectly handled After few experiments, noticed that the milestone steps are the culprits, without the milestone steps, the earlier builds does not get superseded and aborted if the current one fails Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189843.1523464883000.20349.1559621820274%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Prem Gangana updated an issue Jenkins / JENKINS-50744 locks in parallel phases are incorrectly handled Change By: Prem Gangana Component/s: pipeline-milestone-step-plugin Component/s: lockable-resources-plugin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189843.1523464883000.20342.1559621640697%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Prem Gangana updated an issue Jenkins / JENKINS-50744 locks in parallel phases are incorrectly handled Change By: Prem Gangana Labels: lockable milestone parallel pipeline Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189843.1523464883000.20341.1559621640569%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Prem Gangana commented on JENKINS-50744 Re: locks in parallel phases are incorrectly handled Could some one look into this ? This has major side effects even with out failFast:true. the Errored builds kill earlier builds making them think they were superseeded by the errored build. I believe this is happening because the errored build is releasing all the locks even the ones that are not yet acquired by it and then the earlier builds were getting superseeded due to this and are getting into ABORTED / NOT_BUILT state. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189843.1523464883000.10637.1558643460171%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Andrew Bayer updated an issue Jenkins / JENKINS-50744 locks in parallel phases are incorrectly handled Change By: Andrew Bayer Component/s: pipeline Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title Prem Gangana updated an issue Jenkins / JENKINS-50744 locks in parallel phases are incorrectly handled Change By: Prem Gangana Component/s: pipeline Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title
Prem Gangana updated an issue
Jenkins / JENKINS-50744
locks in parallel phases are incorrectly handled
Change By:
Prem Gangana
Hi,We have noticed, that the locks were not handled / cleaned up properly during parallel phase executions. Sample Pipeline Script: {code:java}node {milestone()lock(resource: "my_bld_lock", inversePrecedence: true) {milestone()stage("Bld") {sleep 5}}milestone()parallel(["Testing": {lock(resource: "my_test_lock", inversePrecedence: true) {stage("Test") {// error "error"sleep 10}}},"Second Level Testing": {lock(resource: "my_second_test_lock", inversePrecedence: true) {stage("Second Level Test") {sleep 10}}},"Deployment": {lock(resource: "my_deploy_lock", inversePrecedence: true) {stage("Deploy") {sleep 90}}},failFast: true])}{code}Scenario :Trigger a pipeline build with with above pipeline script first and then trigger a second one with the line _error "error"_ un-commented. You will see that, the first pipeline build gets killed (ABORTED or NOT_BUILT) as soon as the second pipeline build errors out. The first pipeline build console shows that it is Superseded by the second build, which obviously should not be the case, the second build was waiting for the lock "my_deploy_lock" and it should not have killed the build that possessed the lock.Note: failFast is required in this case, the problem is that the errored build is killing another build
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-50744) locks in parallel phases are incorrectly handled
Title: Message Title
Prem Gangana created an issue
Jenkins / JENKINS-50744
locks in parallel phases are incorrectly handled
Issue Type:
Bug
Assignee:
Unassigned
Components:
lockable-resources-plugin
Created:
2018-04-11 16:41
Environment:
Jenkins : 2.89.4 Lockable Resource Plugin : 2.1
Labels:
lockable pipeline parallel
Priority:
Major
Reporter:
Prem Gangana
Hi, We have noticed, that the locks were not handled / cleaned up properly during parallel phase executions. Sample Pipeline Script:
node {
milestone()
lock(resource: "my_bld_lock", inversePrecedence: true) {
milestone()
stage("Bld") {
sleep 5
}
}
milestone()
parallel([
"Testing": {
lock(resource: "my_test_lock", inversePrecedence: true) {
stage("Test") {
// error "error"
sleep 10
}
}
},
"Second Level Testing": {
lock(resource: "my_second_test_lock", inversePrecedence: true) {
stage("Second Level Test") {
sleep 10
}
}
},
"Deployment": {
lock(resource: "my_deploy_lock", inversePrecedence: true) {
stage("Deploy") {
sleep 90
}
}
},
failFast: true
])
}
Scenario : Trigger a pipeline build with with above pipeline script first and then trigger a second one with the line error "error" un-commented. You will see that, the first pipeline build gets killed (ABORTED or NOT_BUILT) as soon as the second pipeline
