[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title Oliver Gondža updated an issue Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Change By: Oliver Gondža Labels: diagnostics lts-candidate Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.190230.1524671418000.9745.1558596720304%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Change By: Oleg Nenashev Labels: diagnostics lts-candidate Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Change By: Oleg Nenashev Released As: Remoting 3.30 , Jenkins 2.176 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title Jeff Thompson resolved as Fixed Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Change By: Jeff Thompson Status: In Progress Resolved Resolution: Fixed Released As: Remoting 3.30 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title pjdarton commented on JENKINS-51004 Re: slave.jar -loggingConfig argument not working as documented Thanks for investigating and getting to the bottom of this Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title William Brode started work on JENKINS-51004 Change By: William Brode Status: Reopened In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title William Brode commented on JENKINS-51004 Re: slave.jar -loggingConfig argument not working as documented I've submitted a PR for the fix: https://github.com/jenkinsci/remoting/pull/317 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title
pjdarton commented on JENKINS-51004
Re: slave.jar -loggingConfig argument not working as documented
FYI, since I originally logged this bug, I uploaded the script that I use to run slave.jar onto the Jenkins wiki (as an example JNLP launcher script for use with the vSphere plugin, as folks kept getting stuck on this bit). This script shows how I was invoking slave.jar, which should help with reproducing the bug (if the bug is still present in the current version of the code). You can find it by going to the vSphere Cloud Plugin wiki page and looking for JenkinsSlaveStartup.cmd. That has a line (485) saying
@SET _cmdLine=%JAVA_HOME%bin\java -Djava.util.logging.config.file=jenkins-slave.logging.properties %SLAVE_JVM_ARGS% -jar slave.jar -jnlpUrl %SLAVE_JNLP_URL% %SLAVE_PARAMS%
where SLAVE_JVM_ARGS are typically "-Xms256M -Xmx4096M -Dhudson.remoting.RemoteClassLoader.force=com.sun.jna.Native", the SLAVE_JNLP_URL is what you'd expect and SLAVE_PARAMS typically contains "{{-secret }}" and little else. ...and the next but-one line runs %_cmdLine% to invoke .../bin/java ... -jar slave.jar ...
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title Jeff Thompson commented on JENKINS-51004 Re: slave.jar -loggingConfig argument not working as documented I tested it with a Jenkins instance running on Mac and an agent on Windows. I tried to follow the documentation and the defect report, though I don't recall the details now. Things seemed to work the way I expected. If you could file a PR that would be great. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title William Brode commented on JENKINS-51004 Re: slave.jar -loggingConfig argument not working as documented Jeff Thompson, how did you test this? I just cloned the repo and tried to debug and found that -loggingConfig just doesn't work at all. The tests work because they bypass the Launcher (wherein the problem resides). So I'm wondering if you were just trying to reproduce using the maven tests? In any case I'll fork the repo and do a pull request with what I think is the fix. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title William Brode reopened an issue Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Change By: William Brode Resolution: Cannot Reproduce Status: Closed Reopened Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title William Brode assigned an issue to William Brode Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Change By: William Brode Assignee: Jeff Thompson William Brode Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title Jeff Thompson closed an issue as Cannot Reproduce Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Change By: Jeff Thompson Status: Open Closed Resolution: Cannot Reproduce Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title Jeff Thompson commented on JENKINS-51004 Re: slave.jar -loggingConfig argument not working as documented Thanks for the clear issue report. However, I haven't been able to reproduce the issue. I have Remoting 3.23 in this instance and it seems to work fine with the "-loggingConfig" parameter. My agent is also on Windows. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title
pjdarton updated an issue
Jenkins / JENKINS-51004
slave.jar -loggingConfig argument not working as documented
Change By:
pjdarton
TL;DR: -loggingConfig doesn't work; Workaround is to use -Djava.util.logging.config.file.Long version: While trying to track down mysterious slave disconnects, I needed more logging than slave.jar provided by default so, after discovering [the documentation|https://github.com/jenkinsci/remoting/blob/remoting-3.14/docs/logging.md] I created a file "[ {{ ^ jenkins-slave.logging.properties }}|https://issues.jenkins-ci.org/secure/attachment/42314/jenkins-slave.logging.properties ]" containing all the java.util.logging properties that I wanted set (logging more finely, and to both the console and logfiles).I then invoked the slave.jar with the argument {{-loggingConfig jenkins-slave.logging.properties}}.However, the console output from slave.jar was unaffected.What I expected was that the logging would be configured according to my properties file, (but it wasn't).I investigated and discovered that if, instead, I provide a JVM argument of {{-Djava.util.logging.config.file=jenkins-slave.logging.properties}} then that worked perfectly.I also found that, if I did *both* then {{org.jenkinsci.remoting.engine.WorkDirManager}}'s [setupLogging method|https://github.com/jenkinsci/remoting/blob/remoting-3.14/src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java#L275] logged a {{FINE}} message of "{{Reading Logging configuration from file: jenkins-slave.logging.properties}}", implying that the {{-loggingConfig}} argument is being passed through correctly.i.e. the CLI argument parsing is working, and the configuration is getting as far as {{WorkDirManager}}, but whatever is being done with it doesn't have the desired/expected effect.What I would expect is that passing in a {{-loggingConfig}} argument would be (nearly) functionally identical to using {{-Djava.util.logging.config.file}}. While I would expect that anything logged before "{{Reading Logging configuration from file: jenkins-slave.logging.properties}}" would be logged with the default logging configuration (as mentioned in the docs), I would expect all subsequent logging to use the specified configuration not the default, and that's what doesn't seem to be happening.
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title
pjdarton updated an issue
Jenkins / JENKINS-51004
slave.jar -loggingConfig argument not working as documented
Change By:
pjdarton
While trying to track down mysterious slave disconnects, I needed more logging than slave.jar provided by default so, after discovering [the documentation|https://github.com/jenkinsci/remoting/blob/remoting-3.14/docs/logging.md] I created a file " [ {{jenkins-slave.logging.properties}} |https://issues.jenkins-ci.org/secure/attachment/42314/jenkins-slave.logging.properties] " containing all the java.util.logging properties that I wanted set (logging more finely, and to both the console and logfiles).I then invoked the slave.jar with the argument {{-loggingConfig jenkins-slave.logging.properties}}.However, the console output from slave.jar was unaffected.What I expected was that the logging would be configured according to my properties file, (but it wasn't).I investigated and discovered that if, instead, I provide a JVM argument of {{-Djava.util.logging.config.file=jenkins-slave.logging.properties}} then that worked perfectly.I also found that, if I did *both* then {{org.jenkinsci.remoting.engine.WorkDirManager}}'s [setupLogging method|https://github.com/jenkinsci/remoting/blob/remoting-3.14/src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java#L275] logged a {{FINE}} message of "{{Reading Logging configuration from file: jenkins-slave.logging.properties}}", implying that the {{-loggingConfig}} argument is being passed through correctly.i.e. the CLI argument parsing is working, and the configuration is getting as far as {{WorkDirManager}}, but whatever is being done with it doesn't have the desired/expected effect.What I would expect is that passing in a {{-loggingConfig}} argument would be (nearly) functionally identical to using {{-Djava.util.logging.config.file}}. While I would expect that anything logged before "{{Reading Logging configuration from file: jenkins-slave.logging.properties}}" would be logged with the default logging configuration (as mentioned in the docs), I would expect all subsequent logging to use the specified configuration not the default, and that's what doesn't seem to be happening.
Add Comment
[JIRA] (JENKINS-51004) slave.jar -loggingConfig argument not working as documented
Title: Message Title pjdarton created an issue Jenkins / JENKINS-51004 slave.jar -loggingConfig argument not working as documented Issue Type: Bug Assignee: Jeff Thompson Attachments: jenkins-slave.logging.properties Components: remoting Created: 2018-04-25 15:50 Environment: slave.jar version 3.14 Slaves connecting via JNLP, launched from a script. Custom logging.properties file provided. (also, my slaves were on Windows, but this might be platform-agnostic) Labels: diagnostics Priority: Minor Reporter: pjdarton While trying to track down mysterious slave disconnects, I needed more logging than slave.jar provided by default so, after discovering the documentation I created a file "jenkins-slave.logging.properties" containing all the java.util.logging properties that I wanted set (logging more finely, and to both the console and logfiles). I then invoked the slave.jar with the argument -loggingConfig jenkins-slave.logging.properties. However, the console output from slave.jar was unaffected. What I expected was that the logging would be configured according to my properties file, (but it wasn't). I investigated and discovered that if, instead, I provide a JVM argument of -Djava.util.logging.config.file=jenkins-slave.logging.properties then that worked perfectly. I also found that, if I did both then org.jenkinsci.remoting.engine.WorkDirManager's setupLoggi
