[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-11-06 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick commented on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 For the timestamper case, this warning is displayed only if you use the View as plain text link—which AFAIK never worked for Pipeline builds anyway. I checked whether it was straightforward to suppress this link in the patch for JENKINS-48344, but unfortunately it is not, due to the _javascript_ tricks involved. The call from WarningsPublisher.parseConsoleLog is unrelated.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-11-06 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 
 
That message was added to workflow-job-plugin 2 years ago  it seems to have first appeared in workflow-job-plugin 2.26, not in any of the preceding plugin releases.
 Mark Waite The message was added in this PR sometime in its 2-year lifespan, but only recently merged and released in workflow-job 2.26. The log-handling rewrite for JEP-210 has changed the nature of various log-related methods. Previously, `getLogFile` always returned a reference to a file that already existed on disk, but now with external logging, that call has to read the entire log (which may involve network calls) and write it to a temporary file which is then returned. The best alternative that I know of would be to call WorkflowRun#getLogText and then handle it directly, but depending on your use case, maybe WorkflowRun#getLogReader or WorkflowRun#getLog(int) would be useful as well.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-11-06 Thread lostinberlin2...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Steve Boardwell commented on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 I have also recently started seeing this and am also using the manager object to read the log file.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-19 Thread mark.earl.wa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Waite edited a comment on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 I'm seeing this as well in the Jenkins log.  It seems to be an [intentional message|https://github.com/jenkinsci/workflow-job-plugin/blob/0f39d7cd0b70ab2505191e0090c034a64f517d7a/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java#L1064] from workflow-job-plugin.Now I'll need to reconsider how I test specific bugs with Pipeline jobs.  I've used the groovy post build plugin to read the logfile from the manager object, but that is apparently no longer a preferred action.  Any hints of the preferred replacement for getLogFile()?  That message was [added to workflow-job-plugin 2 years ago|https://github.com/jenkinsci/workflow-job-plugin/commit/e6a58e8e2d30f7faa6941694ff58770cc14f50e7].  I'm a little ashamed I didn't detect the message sooner , though looking at the tags which include that commit, it seems to have first appeared in workflow-job-plugin 2 . 26, not in any of the preceding plugin releases .   Maybe I'm not as inattentive as I thought . ..  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-19 Thread mark.earl.wa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Waite edited a comment on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 I'm seeing this as well in the Jenkins log.  It seems to be an [intentional message|https://github.com/jenkinsci/workflow-job-plugin/blob/0f39d7cd0b70ab2505191e0090c034a64f517d7a/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java#L1064] from workflow-job-plugin.Now I'll need to reconsider how I test specific bugs with Pipeline jobs.  I've used the groovy post build plugin to read the logfile from the manager object, but that is apparently no longer a preferred action.      Any hints of the preferred replacement for getLogFile()?  That message was [added to workflow-job-plugin 2 years ago|https://github.com/jenkinsci/workflow-job-plugin/commit/e6a58e8e2d30f7faa6941694ff58770cc14f50e7].  I'm a little ashamed I didn't detect the message sooner...  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-19 Thread mark.earl.wa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Waite commented on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 I'm seeing this as well in the Jenkins log. It seems to be an intentional message from workflow-job-plugin. Now I'll need to reconsider how I test specific bugs with Pipeline jobs. I've used the groovy post build plugin to read the logfile from the manager object, but that is apparently no longer a preferred action. Any hints of the preferred replacement for getLogFile()? That message was added to workflow-job-plugin 2 years ago. I'm a little ashamed I didn't detect the message sooner...  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-19 Thread mark.earl.wa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Waite updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-54128  
 
 
  Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
Change By: 
 Mark Waite  
 
 
Component/s: 
 timestamper-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-18 Thread median...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nick Jones updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-54128  
 
 
  Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
Change By: 
 Nick Jones  
 
 
Component/s: 
 workflow-job-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-18 Thread median...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nick Jones commented on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 I'm getting this – or something very similar to it – myself, running a pre-release build of Timestamper 1.18.11 (from JENKINS-54081): 

 

Avoid calling getLogFile on  #31
java.lang.UnsupportedOperationException
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.getLogFile(WorkflowRun.java:1064)
	at hudson.plugins.warnings.WarningsPublisher.parseConsoleLog(WarningsPublisher.java:371)
	at hudson.plugins.warnings.WarningsPublisher.perform(WarningsPublisher.java:312)
	at hudson.plugins.analysis.core.HealthAwarePublisher.perform(HealthAwarePublisher.java:69)
	at hudson.plugins.analysis.core.HealthAwareRecorder.perform(HealthAwareRecorder.java:298)
	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:80)
	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:67)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)
	at hudson.security.ACL.impersonate(ACL.java:290)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
 

 I don't think it's actually Timestamper, but rather the changes in Pipeline Job 2.26.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-17 Thread tolsti...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alexander Tolstikov commented on  JENKINS-54128  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
 FYI, I can't reproduce it at the moment...  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-54128) Timestamper causes lots of WARNING messages in the log (getLogFile call)

2018-10-17 Thread tolsti...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alexander Tolstikov created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-54128  
 
 
  Timestamper causes lots of WARNING messages in the log (getLogFile call)   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Steven G Brown  
 
 
Components: 
 timestamper-plugin  
 
 
Created: 
 2018-10-17 11:55  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Alexander Tolstikov  
 

  
 
 
 
 

 
 Timestamper causes lots of WARNING messages in the log: 

 
Oct 17, 2018 8:19:32 AM org.jenkinsci.plugins.workflow.job.WorkflowRun getLogFile
WARNING: Avoid calling getLogFile on  #3
java.lang.UnsupportedOperationException
at org.jenkinsci.plugins.workflow.job.WorkflowRun.getLogFile(WorkflowRun.java:1064)
at hudson.plugins.timestamper.io.LogFileReader.nextLine(LogFileReader.java:157)
at hudson.plugins.timestamper.action.TimestampsActionOutput$1.readNextLine(TimestampsActionOutput.java:173)
at hudson.plugins.timestamper.action.TimestampsActionOutput$1.read(TimestampsActionOutput.java:132)
at java.io.BufferedReader.fill(BufferedReader.java:161)
at java.io.BufferedReader.readLine(BufferedReader.java:324)
at java.io.BufferedReader.readLine(BufferedReader.java:389)
at hudson.plugins.timestamper.action.TimestampsAction.doIndex(TimestampsAction.java:102)
at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)
at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:184)
at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:117)
at org.kohsuke.stapler.IndexDispatcher.dispatch(IndexDispatcher.java:27)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:739)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:870)
at org.kohsuke.stapler.MetaClass$10.dispatch(MetaClass.java:384)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:739)
at