[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick updated JENKINS-55017 Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Change By: Jesse Glick Status: Fixed but Unreleased Resolved Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.5779.1578592861418%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick updated JENKINS-55017 Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Change By: Jesse Glick Status: In Review Fixed but Unreleased Resolution: Fixed Released As: 1.8 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.5765.1578592320365%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick updated JENKINS-55017 Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.5403.1578535810416%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick updated JENKINS-55017 Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Change By: Jesse Glick Status: In Review Progress Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.5031.1578511740481%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick assigned an issue to Jesse Glick Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Change By: Jesse Glick Assignee: Chris Tapley Jesse Glick Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.5029.1578511740404%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick updated JENKINS-55017 Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.4141.1578424800934%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick started work on JENKINS-55017 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.4138.1578424800796%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick assigned an issue to Chris Tapley Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Change By: Jesse Glick Assignee: Chris Tapley Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.4135.1578424800704%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Chris Tapley commented on JENKINS-55017 Re: Allow advanced configuration for other s3 providers Hi Jesse Glick, I've submitted the PR. Please let me know what you think. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.703.1566914102013%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Chris Tapley commented on JENKINS-55017 Re: Allow advanced configuration for other s3 providers I have been adding tests as I go, but I will also look at Docker Fixtures or TestContainers for better test coverage. I have been testing with AWS and minio. Minio does indeed appear to support presigned URLs. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.9838.1566822840591%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Jesse Glick commented on JENKINS-55017 Re: Allow advanced configuration for other s3 providers Great! In general, the main things that help a PR get merged: clearly stated goal minimal diff (no lines not directly contributing to goal) code structure making it obvious that existing scenarios would not regress convincing test coverage Test coverage in this plugin is a hard problem, unfortunately. I run tests manually against S3 before release, and would run them against a tricky-looking PR before merge. (There used to be a private CI builder for this plugin with an AWS account, but that was shut down since it is not being actively developed: my employer is not currently prioritizing this over other things.) On the other hand, for this particular change there is an OSS provider which claims S3 compatibility—MinIO—so there may be a way to offer self-contained test coverage: use either Docker Fixtures or TestContainers to include a test suite with a Docker fixture for MinIO and delegate to ArtifactManagerTest.artifactStashAndDelete; see JCloudsArtifactManagerTest for the live AWS version. (I am assuming that S3BlobStore.toExternalURL actually works in MinIO. Various documentation suggests that it supports presigned URLs, but I have never tried it. See the plugin README for discussion of how presigned URLs are critical to the security model.) Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Chris Tapley commented on JENKINS-55017 Re: Allow advanced configuration for other s3 providers I believe I have a working implementation of this in a fork https://github.com/christapley/artifact-manager-s3-plugin. Jesse Glick, would you accept a pr for this? Are there any special requirements to get this accepted? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196055.1543946313000.9216.1566735120104%40Atlassian.JIRA.
[JIRA] (JENKINS-55017) Allow advanced configuration for other s3 providers
Title: Message Title Gennady Feldman created an issue Jenkins / JENKINS-55017 Allow advanced configuration for other s3 providers Issue Type: New Feature Assignee: Unassigned Components: artifact-manager-s3-plugin Created: 2018-12-04 17:58 Priority: Major Reporter: Gennady Feldman Currently the plugin hard codes the URL template here: https://github.com/jenkinsci/artifact-manager-s3-plugin/blob/master/src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStore.java#L164 I would love to be able to customize this via some sort of advanced config. There are a number of providers that provide S3 compatible API. Would love to be able to use them. Add Comment
