subject:"\[JIRA\] \(JENKINS\-56402\) Declarative Pipeline shows SUCCESS even though job FAILED"

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 @Philip{quote}The condition blocks are executed in the order shown below.{quote}Yea, I had a feeling it  would be  was  that way, but wasn't sure. Thanks for pointing it out!  :) @Devin - I like your idea for the new read-only variable.P.S. JIRA is giving me a "Communications Breakdown" error when I @ your usernames. Was getting it since yesterday afternoon, but just figured it out it is related to tagging people.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 @Philip {quote}The condition blocks are executed in the order shown below.{quote}Yea, I had a feeling it would be that way, but wasn't sure. Thanks for pointing it out! @Devin - I like your idea for the new read-only variable.P.S. JIRA is giving me a "Communications Breakdown" error when I @ your usernames.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 @Philip{quote}The condition blocks are executed in the order shown below.{quote}Yea, I had a feeling it would be that way, but wasn't sure. Thanks for pointing it out!@Devin - I like your idea for the new read-only variable.P.S. JIRA is giving me a "Communications Breakdown" error when I @ your usernames.Was getting it since yesterday afternoon, but just figured it out it is related to tagging people.
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 

The condition blocks are executed in the order shown below.
 Yea, I had a feeling it would be that way, but wasn't sure. Thanks for pointing it out!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56402  
 
 
  Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
Change By: 
 Lakshya Kapoor  
 
 
Comment: 
 Test.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 Test.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

2019-03-06 Thread dnusb...@cloudbees.com (JIRA)

Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 [~kapoorlakshya] Your workaround won't work as [~pzozobrado] pointed out because {{always}} runs first, however {{cleanup}} has the same semantics as {{always}} other than running last, so you can probably use it for your workaround as they demonstrated. [~pzozobrado] Fall-through happens for changed, fixed, and regression, (and always, unsuccessful, and cleanup, but those are probably less interesting). The reason is that in Jenkins these conditions are not a first-class result, so Declarative computes them based on the current build status in comparison to the previous build's result, so one of aborted, failure, success, unstable, or notBuilt will always be executed if one of changed, fixed, or regression is executed. More than one of aborted, failure, success, unstable, and notBuilt will not be executed in the same post block. I think that it would be possible to support the use cases you both have mentioned by creating a new read-only variable that would only be set inside of post conditions in Declarative that would represent the current logical build status versus {{currentBuild.result}} which is just the literal value of {{Run.result}}. That way you would be able to access the current build status without Declarative needing to modify {{Run.result}} which is problematic in some cases.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

2019-03-06 Thread dnusb...@cloudbees.com (JIRA)

Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 [~kapoorlakshya] Your workaround won't work as [~pzozobrado] pointed out because {{always}} runs first, however {{cleanup}} has the same semantics as {{always}} other than running last, so you  might be able to  can probably  use it for your workaround  as they demonstrated .I think that it would be possible to support the use cases you both have mentioned by creating a new read-only variable that would only be set inside of post conditions in Declarative that would represent the current logical build status versus {{currentBuild.result}} which is just the literal value of {{Run.result}}. That way you would be able to access the current build status without Declarative needing to modify {{Run.result}} which is problematic in some cases.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

2019-03-06 Thread dnusb...@cloudbees.com (JIRA)

Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 Lakshya Kapoor Your workaround won't work as Philip Zozobrado pointed out because always runs first, however cleanup has the same semantics as always other than running last, so you might be able to use it for your workaround. I think that it would be possible to support the use cases you both have mentioned by creating a new read-only variable that would only be set inside of post conditions in Declarative that would represent the current logical build status versus currentBuild.result which is just the literal value of Run.result. That way you would be able to access the current build status without Declarative needing to modify Run.result which is problematic in some cases.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 Hi [~dnusbaum], my use case is similar to [~pzozobrado]'s. I am sending an email notification in my post step ({{always}}) and I am using {{currentBuild.currentResult}} to determine the font color for the build status and the subject line in the email:{code:java}def statusColor = colorCodeByStatus(currentBuild.currentResult) // $BUILD_STATUS font color...// Returns HEX code based on given build statusdef colorCodeByStatus(status) {  if(status == 'SUCCESS') {'#28B463' // Green  } else if(status == 'FAILURE') {'#DF0101' // Red  } else { // Aborted or Unstable'#9E9E9E' // Gray  }}{code}I am not sure if this violates any sort of best practices, but this could be a workaround for such use cases:{code:java}post {  success {  currentBuild.currentResult = 'SUCCESS'  }  unstable {  currentBuild.currentResult = 'UNSTABLE'  }  failure {  currentBuild.currentResult = 'FAILURE'  }  always {dir(path: 'report') {  executePostSteps(JOB_NAME)}  }} // post{code}  I haven't had a chance to test it yet, so please feel free to critique it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 [~kapoorlakshya], unfortunately, {{always}} runs first. That won't work: * [https://jenkins.io/doc/book/pipeline/syntax/#post]{quote}The condition blocks are executed in the order shown below. always, changed, fixed, regression, aborted, failure, success, unstable, unsuccessful, and cleanup.{quote}There's also some  fall-through  waterfalling  not documented: {{fixed}} will _also_ run {{success}}, for example.I've updated my pipeline to:{code}post {cleanup {cleanWs()}failure {notifySlack([status  : 'FAILURE', pipeline: this] as JenkinsStatus)}fixed {notifySlack([status  : 'FIXED', pipeline: this] as JenkinsStatus)}unstable {notifySlack([status  : 'UNSTABLE', pipeline: this] as JenkinsStatus)}success {notifySlack([status  : 'SUCCESS', pipeline: this] as JenkinsStatus)}}{code}However, I'm still looking for a way to kill the {{fixed}}  fall-through  waterfall into {{success}} .  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 [~kapoorlakshya], unfortunately, {{always}} runs first. That won't work: * [https://jenkins.io/doc/book/pipeline/syntax/#post]{quote}The condition blocks are executed in the order shown below. always, changed, fixed, regression, aborted, failure, success, unstable, unsuccessful, and cleanup.{quote}There's also some fall-through not documented: {{fixed}} will _also_ run {{success}}, for example. I've updated my pipeline to:{code}post {cleanup {cleanWs()}failure {notifySlack([status  : 'FAILURE', pipeline: this] as JenkinsStatus)}fixed {notifySlack([status  : 'FIXED', pipeline: this] as JenkinsStatus)}unstable {notifySlack([status  : 'UNSTABLE', pipeline: this] as JenkinsStatus)}success {notifySlack([status  : 'SUCCESS', pipeline: this] as JenkinsStatus)}}{code}However, I'm still looking for a way to kill the {{fixed}} fall-through.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 [~kapoorlakshya], unfortunately, {{always}} runs first. That won't work: * [https://jenkins.io/doc/book/pipeline/syntax/#post]{quote}The condition blocks are executed in the order shown below. always, changed, fixed, regression, aborted, failure, success, unstable, unsuccessful, and cleanup.{quote} There's also some fall-through not documented: {{fixed}} will _also_ run {{success}}, for example.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 Lakshya Kapoor, unfortunately, always runs first. That won't work: 
 
https://jenkins.io/doc/book/pipeline/syntax/#post 
 

The condition blocks are executed in the order shown below. always, changed, fixed, regression, aborted, failure, success, unstable, unsuccessful, and cleanup.
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 Hi Devin Nusbaum, my use case is similar to Philip Zozobrado's. I am sending an email notification in my post step (always) and I am using currentBuild.currentResult to determine the font color for the build status and the subject line in the email: 

 

def statusColor = colorCodeByStatus(currentBuild.currentResult) // $BUILD_STATUS font color

...

// Returns HEX code based on given build status
def colorCodeByStatus(status) {
  if(status == 'SUCCESS') {
'#28B463' // Green

  } else if(status == 'FAILURE') {
'#DF0101' // Red

  } else { // Aborted or Unstable
'#9E9E9E' // Gray
  }
}
 

 I am not sure if this violates any sort of best practices, but this could be a workaround for such use cases: 

 

post {
  success {
  currentBuild.currentResult = 'SUCCESS'
  }
  unstable {
  currentBuild.currentResult = 'UNSTABLE'
  }
  failure {
  currentBuild.currentResult = 'FAILURE'
  }
  always {
dir(path: 'report') {
  executePostSteps(JOB_NAME)
}
  }
} // post
 

 I haven't had a chance to test it yet, so please feel free to critique it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 {quote}I asked about your exact use case because I am curious if there is a functionality gap we can address so that users would have no reason to use currentBuild given its confusing edge cases.{quote}I use currentBuild extensively to get the build's information, following some examples from here: https://www.christopherrung.com/2017/05/04/slack-build-notifications/It's a notification prettier to send Slack messages about the build's status at the point of success, failure, etc. While they don't directly use {{result}} in the code, we used POST   { { code} always { notifySlack(currentbuild.result) } {code } }as a catch-all for build statuses. {{currentBuild}} is, however, extensively used for grabbing test results and result details.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 {quote}I asked about your exact use case because I am curious if there is a functionality gap we can address so that users would have no reason to use currentBuild given its confusing edge cases.{quote}I use currentBuild extensively to get the build's information, following some examples from here: https://www.christopherrung.com/2017/05/04/slack-build-notifications/It's a notification prettier to send Slack messages about the build's status at the point of success, failure, etc. While they don't directly use {{result}} in the code, we used POST {{ always { notifySlack(currentbuild.result) } }} as a catch-all for build statuses. {{currentBuild}} is, however, extensively used for grabbing test results and result details.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 
 
I asked about your exact use case because I am curious if there is a functionality gap we can address so that users would have no reason to use currentBuild given its confusing edge cases.
 I use currentBuild extensively to get the build's information, following some examples from here: https://www.christopherrung.com/2017/05/04/slack-build-notifications/ It's a notification prettier to send Slack messages about the build's status at the point of success, failure, etc. While they don't directly use result in the code, we used POST {{ always  { notifySlack(currentbuild.result) }  }} as a catch-all for build statuses. currentBuild is, however, extensively used for grabbing test results and result details.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 

Does all what you said also apply to currentBuild.currentResult
 Yes, currentBuild.getCurrentResult() is identical to currentBuild.getResult() except for the fact that it defaults to SUCCESS instead of null if the build result has not yet been set, see the code here. 

How do we get a build status when inspecting `currentBuild` if `result` and `currentResult` are both incorrect on a build failure?
 As far as I am aware, there is no way in Declarative to get an accurate picture of the current build status using only currentBuild. In Scripted, I think you could use try/catch statements along with currentBuild to look at the current status and catch specific kinds of exceptions to handle status-conditional logic, essentially duplicating this logic in Declarative. In Declarative, you should be able to use post conditions to handle status-conditional logic without needing to use currentBuild directly. I asked about your exact use case because I am curious if there is a functionality gap we can address so that users would have no reason to use currentBuild given its confusing edge cases.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 [~dnusbaum] Does all what you said also apply to  `  {{ currentBuild.currentResult ` }}  ? It's also showing incorrectly on failed stages.{quote}Can you use POST conditions without actually inspecting the build result?{quote}I'd like to answer your question with another question: How do we get a build status when inspecting  `  {{ currentBuild ` }}  if  `  {{ result ` }}  and  `  {{ currentResult ` }}  are both incorrect on a build failure?Wouldn't this also make  `  {{ resultIsBetterOrEqualTo ` }}  and  `  {{ resultIsWorseOrEqualTo ` }}  now moot since we can no longer rely on any build status checks?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 [~dnusbaum] Does all what you said also apply to `currentBuild.currentResult` ? It's also showing incorrectly on failed stages.{quote}Can you use POST conditions without actually inspecting the build result?{quote}I'd like to answer your question with another question: How do we get a build status when inspecting `currentBuild` if `result` and `currentResult` are both incorrect on a build failure? Wouldn't this also make `resultIsBetterOrEqualTo` and `resultIsWorseOrEqualTo` now moot since we can no longer rely on any build status checks?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 Devin Nusbaum Does all what you said also apply to `currentBuild.currentResult` ? It's also showing incorrectly on failed stages. 
 
Can you use POST conditions without actually inspecting the build result?
 I'd like to answer your question with another question: How do we get a build status when inspecting `currentBuild` if `result` and `currentResult` are both incorrect on a build failure?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title

Devin Nusbaum edited a comment on JENKINS-56402

Re: Declarative Pipeline shows SUCCESS even though job FAILED

[~kapoorlakshya] Yes, this is caused by [PR 313|https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/313], which was the fix for JENKINS-55459. In general, you cannot use {{currentBuild.result}} to accurately determine the current state of the build, because {{currentBuild.result}} does not take into account any in-flight exceptions that are propagating throughout the execution and will cause it to result in failure at the top-level. Post conditions in Declarative _do_ account for these in-flight exceptions and should be triggered appropriately. Getting and/or setting the build result is somewhat messy in Scripted Pipeline as well and does not always do what you want because there is no step-level build result, only an overall build result. The changes made in PR 313 made Declarative match the behavior of Scripted.What is your actual use case? Can you use POST post conditions without actually inspecting the build result? Perhaps we could provide some other kind of API visible to scripts to expose the ephemeral result that will be used when deciding what POST steps to run, but if you are setting the build result intentionally to try and change the flow of execution then I am not sure what we could do to fix that use case. CC [~abayer]

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56402  
 
 
  Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Component/s: 
 pipeline-model-definition-plugin  
 
 
Component/s: 
 pipeline  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title

Devin Nusbaum commented on JENKINS-56402

Re: Declarative Pipeline shows SUCCESS even though job FAILED

Lakshya Kapoor Yes, this is caused by PR 313, which was the fix for JENKINS-55459. In general, you cannot use currentBuild.result to accurately determine the current state of the build, because currentBuild.result does not take into account any in-flight exceptions that are propagating throughout the execution and will cause it to result in failure at the top-level. Post conditions in Declarative do account for these in-flight exceptions and should be triggered appropriately. Getting and/or setting the build result is somewhat messy in Scripted Pipeline as well and does not always do what you want because there is no step-level build result, only an overall build result. The changes made in PR 313 made Declarative match the behavior of Scripted. What is your actual use case? Can you use POST conditions without actually inspecting the build result? Perhaps we could provide some other kind of API visible to scripts to expose the ephemeral result that will be used when deciding what POST steps to run, but if you are setting the build result intentionally to try and change the flow of execution then I am not sure what we could do to fix that use case. CC Andrew Bayer

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 ^^ I can confirm, symptoms arise upgrading to 1.3.5. I updated an older Jenkins to 1.3.5 and it resulted in the same symptoms. Downgrading back to 1.3.4.1 resolved it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 I investigated this issue and looks like it introduced by the Pipeline: Declarative plugin v1.3.5. The offending commit seems to be https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/39c7ed1e153bc3ae10a8aaf77ccc3bc7da2dc93a. Downgrading to v1.3.4.1 is the workaround for now.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 I'm experiencing the same. {{currentBuild.currentResult}} for all failed and aborted builds returns "SUCCESS". Same when using {{$BUILD_STATUS}} through the {{emailext}} plugin.Using Jenkins version 2.150.3 and Pipeline 2.6. All pipeline related plugins are at the latest version as well. *EDIT*: I investigated this issue and looks like it introduced by the {{Pipeline: Declarative}} plugin v1.3.5. The offending commit seems to be [https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/39c7ed1e153bc3ae10a8aaf77ccc3bc7da2dc93a|https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/39c7ed1e153bc3ae10a8aaf77ccc3bc7da2dc93a].{color:#00875a}*Downgrading to v1.3.4.1 is the workaround for now.*{color}   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 I'm experiencing the same. {{currentBuild.currentResult}} for all failed and aborted builds returns "SUCCESS". Same when using {{$BUILD_STATUS}} through the {{emailext}} plugin.Using Jenkins version 2.150.3 and Pipeline 2.6. All pipeline related plugins are at the latest version as well. *EDIT*: I investigated this issue and looks like it introduced by the   {{Pipeline: Declarative}} plugin v1.3.5. The offending commit seems to be [39c7ed1e153bc3ae10a8aaf77ccc3bc7da2dc93a|https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/39c7ed1e153bc3ae10a8aaf77ccc3bc7da2dc93a].{color:#00875a}*Downgrading to v1.3.4.1 is the workaround for now.*{color}   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor edited a comment on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 I'm experiencing the same. {{currentBuild.currentResult}} for all failed and aborted builds returns "SUCCESS". Same when using {{$BUILD_STATUS}} through the {{emailext}} plugin.Using Jenkins version 2.150.3 and Pipeline 2.6. All pipeline related plugins are at the latest version as well.*EDIT*: I investigated this issue and looks like it introduced by the {{Pipeline: Declarative}} plugin v1.3.5. The offending commit seems to be [ https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/ 39c7ed1e153bc3ae10a8aaf77ccc3bc7da2dc93a|https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/39c7ed1e153bc3ae10a8aaf77ccc3bc7da2dc93a].{color:#00875a}*Downgrading to v1.3.4.1 is the workaround for now.*{color}   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Zozobrado updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56402  
 
 
  Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
Change By: 
 Philip Zozobrado  
 
 
Environment: 
 Jenkins 2.150.3,  Pipeline 2.6,  using a slave build executioner  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED

Title: Message Title


 
 
 
 

 
 
 

 
   
 Lakshya Kapoor commented on  JENKINS-56402  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Declarative Pipeline shows SUCCESS even though job FAILED   
 

  
 
 
 
 

 
 I'm experiencing the same. currentBuild.currentResult for all failed and aborted builds returns "SUCCESS". Same when using $BUILD_STATUS through the emailext plugin. Using Jenkins version 2.150.3 and Pipeline 2.6. All pipeline related plugins are at the latest version as well.    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-56402) Declarative Pipeline shows SUCCESS even though job FAILED