[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Devin Nusbaum commented on JENKINS-56544 Re: failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage I'm not sure why you were not able to reproduce with my original testcase I probably didn't clean my plugin work directory or something and so was running code that didn't match 1.3.6, and then immediately started trying to simplify and got rid of the key piece that causes the issue. I think your reproduction should work fine, thanks for coming up with it! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Ray Kivisto commented on JENKINS-56544 Re: failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage I should also mention that your new reduced testcase also reproduces the issue with the build status as: Finished: ABORTED Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Ray Kivisto commented on JENKINS-56544 Re: failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage I'm not sure why you were not able to reproduce with my original testcase, I just tried again now, and started a brand new Jenkins LTS 2.164.1 instance (latest LTS as of today), and installed the "recommended plugins", then ran the attached Jenkinsfile without any changes or Jenkins configuration changes (meaning the `agent any` blocks ran on the master), and the end of the build log shows: Finished: ABORTED Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Ray Kivisto updated an issue Jenkins / JENKINS-56544 failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage Change By: Ray Kivisto Attachment: pipeline__Jenkins__and_Mozilla_Firefox.png Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title
Devin Nusbaum commented on JENKINS-56544
Re: failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Ok, I was able to reproduce the issue, here is the minimal reproduction case:
pipeline {
agent none
stages {
stage("foo") {
failFast true
parallel {
stage("first") {
steps {
error "First branch"
}
}
stage("second") {
agent any
steps {
sleep 10
echo "Second branch"
}
}
}
}
}
}
Note that this reproduction does not have any nested stages. I think the root of the issue is the agent any in the branch that gets terminated early because of the explicit build result setting in LabelScript as noted in my previous comment.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Devin Nusbaum started work on JENKINS-56544 Change By: Devin Nusbaum Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Devin Nusbaum assigned an issue to Devin Nusbaum Jenkins / JENKINS-56544 failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage Change By: Devin Nusbaum Assignee: Andrew Bayer Devin Nusbaum Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title
Devin Nusbaum commented on JENKINS-56544
Re: failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
I spent some time trying to reproduce this today but was not able to. Here is what I came up with as a base, but I experimented with various modifications to nesting, post stages, and swapping out error for a failing sh step but everything seemed to work fine. I do think there could be some issues with certain kinds of agents based on LabelScript.groovy, DockerPipelineFromDockerfileScript.groovy (1, 2, and 3), and DockerPipelineScript.groovy (1, and 2), but I don't think those places would matter for the Jenkinsfile you posted (Unless maybe LabelScript is being used to run the builds on your machine and that try/catch block is being triggered). One thing that is strange to me is that in your logs we see that the post conditions for failure and aborted both ran:
[Pipeline] { (Declarative: Post Actions)
[Pipeline] echo
Pipeline ALWAYS
[Pipeline] echo
Pipeline Aborted
[Pipeline] echo
Pipeline FAILURE
There is probably something wrong in Failure.meetsCondition, that is causing those two conditions to overlap in some cases. Maybe the new errorResult computation needs to be moved before this line so that line can check whether the errorResult matches Aborted specifically rather than just checking if error is null. Either way I think this is just a symptom of the build result being aborted in the first place, so it might not matter in practice once we figure out the other issue.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Ray Kivisto updated an issue Jenkins / JENKINS-56544 failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage Change By: Ray Kivisto Environment: Fresh Jenkins LTS 2.150.3 install'recommended' plugins, including [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition] version 1.3.6 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56544) failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage
Title: Message Title Ray Kivisto created an issue Jenkins / JENKINS-56544 failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage Issue Type: Improvement Assignee: Andrew Bayer Attachments: Jenkinsfile, log, test.png Components: pipeline-model-definition-plugin Created: 2019-03-13 13:37 Priority: Minor Reporter: Ray Kivisto Symptom With a Pipeline using parallel stages with failFast true enabled, when a nested stage fails, the final build result is showing as ABORTED instead of FAILURE A similar bug was recently fixed JENKINS-55459 which corrected the build status result when using non-nested parallel stages with failFast true enabled, but it seems it did not catch the case where a nested stage inside of one of the parallel stages fails. Evidence The fix for JENKINS-55459 was delivered under version 1.3.5 of the Pipeline: Declarative Plugin, I am testing version 1.3.6. I started up a brand new Jenkins LTS 2.150.3 instance, with the 'recommended' plugins, including Pipeline: Declarative Plugin version 1.3.6 I ran the testcase inside of JENKINS-55459 and the build status is correctly marked as failed, so the fix from JENKINS-55459 was correct. When I run the attached Jenkinsfile , the build still shows as ABORTED: ... ERROR: script returned exit code 1 Finished: ABORTED Here is the full log: log I expected the build status to be marked as FAILURE, not ABORTED. Hypothesis I believe the fix from JENKINS-55459
