[JIRA] (JENKINS-56860) Rebuild plugin records incorrect "Started by user"

2019-05-27 Thread mooncros...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Grigor Lechev commented on  JENKINS-56860  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Rebuild plugin records incorrect "Started by user"   
 

  
 
 
 
 

 
 This is fixed with https://github.com/jenkinsci/rebuild-plugin/pull/57, available in plugin version 1.31  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198522.1554260497000.12426.1558956420255%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56860) Rebuild plugin records incorrect "Started by user"

2019-05-08 Thread beyli...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ilya B edited a comment on  JENKINS-56860  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Rebuild plugin records incorrect "Started by user"   
 

  
 
 
 
 

 
 I am using Rebuilder version 1.29 and for me it includes comments for both builds, which is good, but they are mixed up and go in the wrong order:  |!https://jenkins.i.prover.com/static/94049128/images/48x48/notepad.png!|No changes.||!https://jenkins.i.prover.com/static/94049128/images/48x48/orange-square.png!|Started by upstream project xxx build number + 1023 456 + originally caused by:     * Triggered by +GitLab Merge Request #176+: abc/xxx/issue54 => master ||!https://jenkins.i.prover.com/static/94049128/images/48x48/orange-square.png!|Started by user +Xxx+||!https://jenkins.i.prover.com/static/94049128/images/48x48/orange-square.png!|Rebuilds build #+1,123+ |the comment "Started by upstream" refers to the original build 1123.  Since one can change parameters in the rebuild, the description may or may not be relevant, but it is important to point that it  it  describes another branch.So if someone is revisiting this plugin, please make sure that the inherited descriptions are marked with the original build number and, if possible, pushed to the end.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198522.1554260497000.20857.1557330360286%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56860) Rebuild plugin records incorrect "Started by user"

2019-05-08 Thread beyli...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ilya B commented on  JENKINS-56860  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Rebuild plugin records incorrect "Started by user"   
 

  
 
 
 
 

 
 I am using Rebuilder version 1.29 and for me it includes comments for both builds, which is good, but they are mixed up and go in the wrong order: 
 

 
 
 
No changes. 
 
 
 
Started by upstream project xxx build number 1023 originally caused by: * Triggered by GitLab Merge Request #176: abc/xxx/issue54 => master 
 

 
  | 
 

 
 
 
Started by user Xxx 
 
 
 
Rebuilds build #1,123  
 

 
 the comment "Started by upstream" refers to the original build 1123.  Since one can change parameters in the rebuild, the description may or may not be relevant, but it is important to point that it it describes another branch. So if someone is revisiting this plugin, please make sure that the inherited descriptions are marked with the original build number and, if possible, pushed to the end.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

 

[JIRA] (JENKINS-56860) Rebuild plugin records incorrect "Started by user"

2019-05-08 Thread beyli...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ilya B edited a comment on  JENKINS-56860  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Rebuild plugin records incorrect "Started by user"   
 

  
 
 
 
 

 
 I am using Rebuilder version 1.29 and for me it includes comments for both builds, which is good, but they are mixed up and go in the wrong order:|!https://jenkins.i.prover.com/static/94049128/images/48x48/notepad.png!|No changes.||!https://jenkins.i.prover.com/static/94049128/images/48x48/orange-square.png!|Started by upstream project xxx build number +1023+ originally caused by: * Triggered by +GitLab Merge Request #176+: abc/xxx/issue54 => master   ||!https://jenkins.i.prover.com/static/94049128/images/48x48/orange-square.png!|Started by user +Xxx+||!https://jenkins.i.prover.com/static/94049128/images/48x48/orange-square.png!|Rebuilds build #+1,123+ |the comment "Started by upstream" refers to the original build 1123.  Since one can change parameters in the rebuild, the description may or may not be relevant, but it is important to point that it it describes another branch.So if someone is revisiting this plugin, please make sure that the inherited descriptions are marked with the original build number and, if possible, pushed to the end.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198522.1554260497000.20838.1557329880448%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56860) Rebuild plugin records incorrect "Started by user"

2019-04-22 Thread lsbw...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 lsb want commented on  JENKINS-56860  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Rebuild plugin records incorrect "Started by user"   
 

  
 
 
 
 

 
 I got this problem too  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56860) Rebuild plugin records incorrect "Started by user"

2019-04-02 Thread jenkin...@codeassassin.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jason Stangroome updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56860  
 
 
  Rebuild plugin records incorrect "Started by user"   
 

  
 
 
 
 

 
Change By: 
 Jason Stangroome  
 

  
 
 
 
 

 
 When rebuilding, the new build has the "Started by user" populated with the value from the source build, not the details of the user who requested the rebuild.I.e.: # User Alice triggers Build 1  # Build 1 completes and states "Started by user Alice". # User Bob opens Build 1 and clicks "Rebuild", triggering Build 2. # Build 2 completes and states "Started by user Alice" but should have stated "Started by user Bob".This creates confusion for accountability and auditing. Reverting to Rebuilder plugin 1.29 fixes the issue. Two other users have also reported the issue here on the PR for the release which introduced the bug:[https://github.com/jenkinsci/rebuild-plugin/pull/56#issuecomment-478868354]   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56860) Rebuild plugin records incorrect "Started by user"

2019-04-02 Thread jenkin...@codeassassin.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jason Stangroome created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56860  
 
 
  Rebuild plugin records incorrect "Started by user"   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 ragesh_nair  
 
 
Components: 
 rebuild-plugin  
 
 
Created: 
 2019-04-03 03:01  
 
 
Environment: 
 Jenkins v2.164.1 LTS on Ubuntu 14.04 Trusty w/ Rebuilder plugin v1.30  
 
 
Labels: 
 regression security  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Jason Stangroome  
 

  
 
 
 
 

 
 When rebuilding, the new build has the "Started by user" populated with the value from the source build, not the details of the user who requested the rebuild. I.e.: 
 
User Alice triggers Build 1  
Build 1 completes and states "Started by user Alice". 
User Bob opens Build 1 and clicks "Rebuild", triggering Build 2. 
Build 2 completes and states "Started by user Alice" but should have stated "Started by user Bob". 
 This creates confusion for accountability and auditing. Two other users have also reported the issue here on the PR for the release which introduced the bug: https://github.com/jenkinsci/rebuild-plugin/pull/56#issuecomment-478868354