[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title
Liam Newman edited a comment on JENKINS-56996
Re: null permission lookup when pull-request's origin repo/branch is deleted on github
Wow. I did 't some digging on this and it is not particularly easy.I'd love to be able to simply catch and swallow some error locally, but if we do that it may result in jobs being deleted (or marked for deletion) simply because there was an error while reading them. I looked pretty carefully and I didn't see a way to address this safely in a small/local change.The core problem is that the code that controls how child items are created and maintained is spread across several other plugins, including folders, scm-api and branch-api.My thought is that we'll need to add a no-op {{preserve(String itemName)}} method to {{[SCMHeadObserver|https://github.com/jenkinsci/scm-api-plugin/blob/6a044fe60143278ed26f8d91b0ec1cee116617d6/src/main/java/jenkins/scm/api/SCMHeadObserver.java#L43]}}. Then we can wire through an implementation in {{[MultiBranchProject.SCMHeadObserverImpl|https://github.com/jenkinsci/branch-api-plugin/blob/ed229d8e1392645c99e5686b8bd652a14ec87f4a/src/main/java/jenkins/branch/MultiBranchProject.java#L1948]}}. Finally, we'd expose that in github-branch-source for the {{GitHubSCMSource}} to call when an error occurs.I suppose it would okay for PRs specifically to simply be deleted on {{FileNotFoundException}} specifically, but not great behavior.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198693.1555102536000.22815.1557453720179%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman commented on JENKINS-56996 Re: null permission lookup when pull-request's origin repo/branch is deleted on github Released as part of v2.5.2, waiting to close until we hear from reporter. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198693.1555102536000.21366.1557362220158%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman updated JENKINS-56996 I'm going to resolve this as fixed and move forward. Christian Höltje Please comment if this is not fixed for you. Jenkins / JENKINS-56996 null permission lookup when pull-request's origin repo/branch is deleted on github Change By: Liam Newman Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198693.1555102536000.20510.1557279300687%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman commented on JENKINS-56996 Re: null permission lookup when pull-request's origin repo/branch is deleted on github Christian Höltje Please try this version: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/github-branch-source/2.5.2-rc835.5125eb8241d3/ It should make you scan not fail due to issues with one PR. NOTE: PRs that experience errors will be marked "orphaned" (and possibly deleted depending on your orphan strategy). Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198693.1555102536000.20102.1557239760131%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman started work on JENKINS-56996 Change By: Liam Newman Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman updated JENKINS-56996 Jenkins / JENKINS-56996 null permission lookup when pull-request's origin repo/branch is deleted on github Change By: Liam Newman Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman assigned an issue to Liam Newman Jenkins / JENKINS-56996 null permission lookup when pull-request's origin repo/branch is deleted on github Change By: Liam Newman Assignee: Liam Newman Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title
Liam Newman edited a comment on JENKINS-56996
Re: null permission lookup when pull-request's origin repo/branch is deleted on github
Wow. I did't some digging on this and it is not particularly easy.I'd love to be able to simply catch and swallow some error locally, but if we do that it may result in jobs being deleted (or marked for deletion) simply because there was an error while reading them. I looked pretty carefully and I didn't see a way to address this safely in a small/local change.The core problem is that the code that controls how child items are created and maintained is spread across several other plugins, including folders, scm-api and branch-api.My thought is that we'll need to add a no-op {{preserve(String itemName)}} method to {{[SCMHeadObserver|https://github.com/jenkinsci/scm-api-plugin/blob/6a044fe60143278ed26f8d91b0ec1cee116617d6/src/main/java/jenkins/scm/api/SCMHeadObserver.java#L43]}}. Then we can wire through an implementation in {{[MultiBranchProject.SCMHeadObserverImpl|https://github.com/jenkinsci/branch-api-plugin/blob/ed229d8e1392645c99e5686b8bd652a14ec87f4a/src/main/java/jenkins/branch/MultiBranchProject.java#L1948]}}. Finally, we'd expose that in github-branch-source for the {{GitHubSCMSource}} to call when an error occurs. I suppose it would okay for PRs specifically to simply be deleted on {{FileNotFoundException}} specifically, but not great behavior.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman assigned an issue to Unassigned Jenkins / JENKINS-56996 null permission lookup when pull-request's origin repo/branch is deleted on github Change By: Liam Newman Assignee: Liam Newman Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title
Liam Newman edited a comment on JENKINS-56996
Re: null permission lookup when pull-request's origin repo/branch is deleted on github
Wow. I did't some digging on this and it is not particularly easy.I'd love to be able to simply catch and swallow some error locally, but if we do that it may result in jobs being deleted (or marked for deletion) simply because there was an error while reading them. I looked pretty carefully and I didn't see a way to address this safely in a small/local change.The core problem is that the code that controls how child items are created and maintained is spread across several other plugins, including folders, scm-api and branch-api. My thought is that we'll need to add a no-op { { preserve(String itemName)} } method to { { [SCMHeadObserver|https://github.com/jenkinsci/scm-api-plugin/blob/6a044fe60143278ed26f8d91b0ec1cee116617d6/src/main/java/jenkins/scm/api/SCMHeadObserver.java#L43]} } . Then we can wire through an implementation in {{ [MultiBranchProject.SCMHeadObserverImpl|https://github.com/jenkinsci/branch-api-plugin/blob/ed229d8e1392645c99e5686b8bd652a14ec87f4a/src/main/java/jenkins/branch/MultiBranchProject.java#L1948] }} . Finally, we'd expose that in github-branch-source for the { { GitHubSCMSource} } to call when an error occurs.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title
Liam Newman commented on JENKINS-56996
Re: null permission lookup when pull-request's origin repo/branch is deleted on github
Wow. I did't some digging on this and it is not particularly easy. I'd love to be able to simply catch and swallow some error locally, but if we do that it may result in jobs being deleted (or marked for deletion) simply because there was an error while reading them. I looked pretty carefully and I didn't see a way to address this safely in a small/local change. The core problem is that the code that controls how child items are created and maintained is spread across several other plugins, including folders, scm-api and branch-api. My thought is that we'll need to add a no-op {preserve(String itemName)} method to {[SCMHeadObserver|https://github.com/jenkinsci/scm-api-plugin/blob/6a044fe60143278ed26f8d91b0ec1cee116617d6/src/main/java/jenkins/scm/api/SCMHeadObserver.java#L43]} . Then we can wire through an implementation in MultiBranchProject.SCMHeadObserverImpl. Finally, we'd expose that in github-branch-source for the {GitHubSCMSource} to call when an error occurs.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman assigned an issue to Liam Newman Jenkins / JENKINS-56996 null permission lookup when pull-request's origin repo/branch is deleted on github Change By: Liam Newman Assignee: Liam Newman Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman commented on JENKINS-56996 Re: null permission lookup when pull-request's origin repo/branch is deleted on github Christian Höltje Right, that's what I thought you were saying. Thanks, I'm working on this. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Christian Höltje commented on JENKINS-56996 Re: null permission lookup when pull-request's origin repo/branch is deleted on github So, the issue is that the updating of all PRs stops, not that this one PR doesn't refresh (which is understandable). Is that correct? The scanning for the entire organization folder (and down) stops, nothing new gets added or removed. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Liam Newman commented on JENKINS-56996 Re: null permission lookup when pull-request's origin repo/branch is deleted on github Christian Höltje So, the issue is that the updating of all PRs stops, not that this one PR doesn't refresh (which is understandable). Is that correct? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56996) null permission lookup when pull-request's origin repo/branch is deleted on github
Title: Message Title Christian Höltje created an issue Jenkins / JENKINS-56996 null permission lookup when pull-request's origin repo/branch is deleted on github Issue Type: Bug Assignee: Unassigned Components: github-branch-source-plugin Created: 2019-04-12 20:55 Environment: Jenkins 2.164.1 git: 4.0.0-rc git-client: 3.0.0-rc git-server: 1.7 github: 1.29.4 github-api: 1.95 github-branch-source: 2.4.5 github-oauth: 0.31 github-pr-coverage-status: 2.0.0 pipeline-github: 2.5 pipeline-github-lib: 1.0 Priority: Major Reporter: Christian Höltje We use GitHub Organizations to manage our jobs. We found a bug where if a pull request has its source repository/branch deleted (e.g. it was a personal fork and that personal fork was deleted) then that repository stops updating from github. Here is the log from the "Scan Repository Log': Checking pull request #154 ERROR: [Fri Apr 12 16:39:29 EDT 2019] Could not fetch branches from source org.jenkinsci.plugins.github_branch_source.GitHubSCMNavigator::https://github.example.com/api/v3::robert-continuous-delivery::howard java.io.FileNotFoundException: https://github.example.com/api/v3/repos/robert-continuous-delivery/howard/collaborators/null/permission at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:243) at com.squareup.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210) at com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:25) at org.kohsuke.github.Requester.parse(Requester.java:625)
