[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman closed an issue as Fixed Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Status: Resolved Closed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.8555.1572896820487%40Atlassian.JIRA.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Released As: Jenkins 2.177 , LTS 2.176.1 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.11610.1558714740115%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Oliver Gondža updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Oliver Gondža Labels: lts 2.176.1 - candidate fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.9763.1558597140177%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Oleg Nenashev Released As: Jenkins 2.177 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.2851.1557982200353%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman edited a comment on JENKINS-57111 Re: Base class setChannel does not handle exceptions from onOnline call LTS Justification:This fixes long-standing agent disconnect issues for a number of plugins, probably more than just the ones linked. This change is very low risk. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.589.155785290%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman commented on JENKINS-57111 Re: Base class setChannel does not handle exceptions from onOnline call LTS Justification: This fixes long-standing agent disconnect issues for a number of plugins, probably more than just the ones linked. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.571.1557851760138%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Labels: lts-candidate Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.569.1557851640122%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman commented on JENKINS-57111 Re: Base class setChannel does not handle exceptions from onOnline call The next LTS will be out in June, but the base looks like it will be 2.176 - missed by one. I will see what I can do to get this pulled into that release. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.559.1557851400113%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman commented on JENKINS-57111 Re: Base class setChannel does not handle exceptions from onOnline call Published in v2.177. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.1562.1557758040197%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated JENKINS-57111 Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Status: Fixed but Unreleased Resolved Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.1560.1557757980293%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated JENKINS-57111 PR merged. Will be release in the next couple weeks to weekly build. Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Status: In Review Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.671.1557722760237%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated JENKINS-57111 Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.20506.1557278640196%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman started work on JENKINS-57111 Change By: Liam Newman Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.20297.1557250020261%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman assigned an issue to Liam Newman Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Assignee: Liam Newman Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198858.1555612432000.20296.1557250020248%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Throwing an exception in ComputerListener.onOnline should not take a node offline:[core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164|https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164]However, there a number of issues filed that show exceptions in onOnline not being handled, the latest being one in branch-api: [ jenkinsci/branch-api-plugin PR #142| https://github.com/jenkinsci/branch-api-plugin/pull/142] Here is the code used in on the Master node and the related test:[core/src/main/java/jenkins/model/Jenkins.java#L979-L993|https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/jenkins/model/Jenkins.java#L979-L993][test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487|https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487]Here is the code in SlaveComputer.setChannel() and the test file showing no test:[core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698|https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698][test/src/test/java/hudson/slaves/SlaveComputerTest.java|https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/hudson/slaves/SlaveComputerTest.java]NOTE: the Jenkins.java code is not correct either since it will swallow more than the contract specifies - including NullPointerException for example. Also, it should probably be a WARNING rather than SEVERE. Add Comment
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Throwing an exception in ComputerListener.onOnline should not take a node offline:[ https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/ core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164| https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/ core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164]However, there a number of issues filed that show exceptions in onOnline not being handled, the latest being one in branch-api: [ https://github.com/jenkinsci/branch-api-plugin/pull/142 ] Here is the code used in on the Master node and the related test: [core/src/main/java/jenkins/model/Jenkins.java#L979-L993| https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/jenkins/model/Jenkins.java#L979-L993 ] [test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487| https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487 ] Here is the code in hudson.slaves. SlaveComputer.setChannel () and the test file showing no test: [core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698| https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698 ] [test/src/test/java/hudson/slaves/SlaveComputerTest.java| https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/hudson/slaves/SlaveComputerTest.java #L45 ] NOTE: the Jenkins.java code is not correct either since it will swallow more than the contract specifies - including NullPointerException for example. Also, it should probably be a WARNING rather than SEVERE. Add Comment
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Throwing an exception in ComputerListener.onOnline should not take a node offline: [ https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164 |core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164] However, there a number of issues filed that show exceptions in onOnline not being handled, the latest being one in branch-api: https://github.com/jenkinsci/branch-api-plugin/pull/142 Here is the code used in on the Master node and the related test:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/jenkins/model/Jenkins.java#L979-L993https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487Here is the code in hudson.slaves.SlaveComputer.setChannel and the test file showing no test:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/hudson/slaves/SlaveComputerTest.java#L45NOTE: the Jenkins.java code is not correct either since it will swallow more than the contract specifies - including NullPointerException for example. Also, it should probably be a WARNING rather than SEVERE. Add Comment
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Throwing an exception in ComputerListener.onOnline should not take a node offline:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164However, there a number of issues filed that show exceptions in onOnline not being handled, the latest being one in branch-api: https://github.com/jenkinsci/branch-api-plugin/pull/142 Here is the code used in on the Master node and the related test:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/jenkins/model/Jenkins.java#L979-L993https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487Here is the code in hudson.slaves.SlaveComputer.setChannel and the test file showing no test:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/hudson/slaves/SlaveComputerTest.java#L45NOTE: the Jenkins.java code is not correct either since it will swallow more than the contract specifies - including NullPointerException for example. Also, it should probably be a WARNING rather than SEVERE. Add Comment This message wa
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Change By: Liam Newman Throwing an exception in ComputerListener.onOnline should not take a node offline:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164However, there a number of issues filed that show exceptions in onOnline not being handled, the latest being one in branch-api: https://github.com/jenkinsci/branch-api-plugin/pull/142 Here is the code used in on the Master node and the related test:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/jenkins/model/Jenkins.java#L979-L993https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487 Here is the code in hudson.slaves.SlaveComputer.setChannel and the test file showing no test:https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/hudson/slaves/SlaveComputerTest.java#L45 NOTE: the Jenkins.java code is not correct either since it will swallow more than the contract specifies - including NullPointerException for example. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman commented on JENKINS-57111 Re: Base class setChannel does not handle exceptions from onOnline call Linked issues are likely all due to this one. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57111) Base class setChannel does not handle exceptions from onOnline call
Title: Message Title Liam Newman created an issue Jenkins / JENKINS-57111 Base class setChannel does not handle exceptions from onOnline call Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-04-18 18:33 Priority: Major Reporter: Liam Newman Throwing an exception in ComputerListener.onOnline should not take a node offline: https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/ComputerListener.java#L135-L164 However, there a number of issues filed that show exceptions in onOnline not being handled, the latest being one in branch-api: https://github.com/jenkinsci/branch-api-plugin/pull/142 Here is the code used in on the Master node and the related test: https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/jenkins/model/Jenkins.java#L979-L993 https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/jenkins/model/JenkinsTest.java#L473-L487 Here is the code in hudson.slaves.SlaveComputer.setChannel and the test file showing no test: https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/core/src/main/java/hudson/slaves/SlaveComputer.java#L696-L698 https://github.com/jenkinsci/jenkins/blob/2767b00146ce2ff2738b7fd7c6db95a26b8f9f39/test/src/test/java/hudson/slaves/SlaveComputerTest.java#L45
