[JIRA] (JENKINS-58351) buildType is used incorrectly for windows builds

2019-07-05 Thread dennis.cappend...@siemens.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Dennis Cappendijk edited a comment on  JENKINS-58351  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: buildType is used incorrectly for windows builds   
 

  
 
 
 
 

 
 Would  this  it  be possible to add this as an improvement to the plugin? Ie, when a visual studio generator is set to the generator property use config instead of CMAKE_BUILD_TYPE or would this be too custom?    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200466.1562256626000.2204.1562315220271%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-58351) buildType is used incorrectly for windows builds

2019-07-05 Thread dennis.cappend...@siemens.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Dennis Cappendijk commented on  JENKINS-58351  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: buildType is used incorrectly for windows builds   
 

  
 
 
 
 

 
 Would this be possible to add this as an improvement to the plugin? Ie, when a visual studio generator is set to the generator property use config instead of CMAKE_BUILD_TYPE or would this be too custom?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200466.1562256626000.2202.1562315160204%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-58351) buildType is used incorrectly for windows builds

2019-07-04 Thread fifteenknots...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Weber commented on  JENKINS-58351  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: buildType is used incorrectly for windows builds   
 

  
 
 
 
 

 
 Cmake's evaluation of the CMAKE_BUILD_TYPE variable is not specific to the OS, it is specific to the buildscript generator. For the VS generator, apparently even the cmake guys could not find a way to generate build scripts for the VS build tool that pass the CMAKE_BUILD_TYPE-corresponding compiler/linker options to the compiler/linker. So users must take care to pass the 

 

'--config Debug' 

 to the VS build tool themselve. As a workaround, you might want to try the nmake or nmake-jom generators.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200466.1562256626000.2057.1562270820132%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-58351) buildType is used incorrectly for windows builds

2019-07-04 Thread dennis.cappend...@siemens.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Dennis Cappendijk created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58351  
 
 
  buildType is used incorrectly for windows builds   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Martin Weber  
 
 
Components: 
 cmakebuilder-plugin  
 
 
Created: 
 2019-07-04 16:10  
 
 
Environment: 
 Windows + visual studio 2015 / Linux + unix makefiles  Jenkins ver. 2.176.1  cmake builder plugin Version 2.6.2  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Dennis Cappendijk  
 

  
 
 
 
 

 
 I have created a Jenkins pipeline that covers both windows and linux. However it appears that cmakeBuild does not use buildType correctly for windows. For Linux is correctly adds -DCMAKE_BUILD_TYPE=Debug or Release in the configure step However for windows the CMAKE_BUILD_TYPE variable is ignored: 

 

17:47:24Manually-specified variables were not used by the project:
17:47:24  
17:47:24  CMAKE_BUILD_TYPE
 

 And subsequently in the --build step, the --config is unused. Resulting in a Debug-by-default build on windows. -config Debug or -config Release (depending on buildType should be added to the --build phase for windows (and CMAKE_BUILD_TYPE should not be used for windows)   The current workaround to this is adding --config Debug/Release explicitly in the steps: 

 

steps: [[args: '--config Debug', withCmake: true]]