[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-11-18 Thread vinc...@latombe.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vincent Latombe closed an issue as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58682  
 
 
  Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
Change By: 
 Vincent Latombe  
 
 
Status: 
 Open Closed  
 
 
Resolution: 
 Fixed  
 
 
Released As: 
 1.21.2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200965.1564154658000.2548.1574085000923%40Atlassian.JIRA.


[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-11-18 Thread vinc...@latombe.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vincent Latombe commented on  JENKINS-58682  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
 And it was added through https://github.com/jenkinsci/kubernetes-plugin/pull/638 (1.21.2 and later).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200965.1564154658000.2542.1574084940409%40Atlassian.JIRA.


[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-11-18 Thread vinc...@latombe.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vincent Latombe commented on  JENKINS-58682  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
 

however, changing the YAML merge strategy configuration at the cloud level seems to have no effect.
 Indeed, there is NO global flag to control YAML merge strategy. A pod template controls how it merged with its parent. What is missing here is support of this field for declarative.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200965.1564154658000.2533.1574084880331%40Atlassian.JIRA.


[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-11-18 Thread vinc...@latombe.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vincent Latombe commented on  JENKINS-58682  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
 Allan BURDAJEWICZ what you reproduced is expected, this is the current override behaviour. See https://github.com/jenkinsci/kubernetes-plugin/pull/623/  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200965.1564154658000.2528.1574083920654%40Atlassian.JIRA.


[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-09-19 Thread aburdajew...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Allan BURDAJEWICZ commented on  JENKINS-58682  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
 I believe that this is mainly a problem for declarative pipeline. That has a different behavior than scripted pipeline according to: 
 
https://github.com/jenkinsci/kubernetes-plugin/pull/480 
https://github.com/jenkinsci/kubernetes-plugin/blob/kubernetes-1.19.0/src/main/resources/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesDeclarativeAgentScript.groovy#L42-L44 
https://github.com/jenkinsci/kubernetes-plugin/blob/kubernetes-1.19.0/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java#L98-L102 
 I have attached examples of this difference of behavior. You can see that with scripted, the inherited template image jenkins/jnlp-slave:3.27-1-alpine correctly override the parent template image jenkins/slave:alpine. In declarative, it does not override it. Note: The merge strategy of the parent template is "Override". declarativeExample.groovy scriptedExample.groovy declarativeExample.log scriptedExample.log   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to 

[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-09-19 Thread aburdajew...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Allan BURDAJEWICZ updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58682  
 
 
  Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
Change By: 
 Allan BURDAJEWICZ  
 
 
Attachment: 
 declarativeExample.groovy  
 
 
Attachment: 
 scriptedExample.groovy  
 
 
Attachment: 
 declarativeExample.log  
 
 
Attachment: 
 scriptedExample.log  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion 

[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-07-29 Thread vinc...@latombe.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vincent Latombe assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58682  
 
 
  Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
Change By: 
 Vincent Latombe  
 
 
Assignee: 
 Carlos Sanchez  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200965.1564154658000.2830.1564402740183%40Atlassian.JIRA.


[JIRA] (JENKINS-58682) Global YAML Merge Strategy is not respected

2019-07-26 Thread dylanhell...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Dylan Hellems created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58682  
 
 
  Global YAML Merge Strategy is not respected   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Carlos Sanchez  
 
 
Components: 
 kubernetes-plugin  
 
 
Created: 
 2019-07-26 15:24  
 
 
Environment: 
 Jenkins 2.176.1 LTS running on Kubernetes managed by Amazon EKS kubernetes-plugin 1.17.1  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Dylan Hellems  
 

  
 
 
 
 

 
 Summary Our team recently attempted an upgrade from kubernetes-plugin version 1.16.1 to 1.17.1, and the update broke our pipelines. We are making use of pod templates at the cloud level for shared configuration of agents, and we are inheriting these templates and extending them in our pipelines. Before the update, our pod template YAML and our pipeline YAML were merged to generate the agent configuration. After the update, the pipeline YAML overrode our pod template completely.  I believe I've traced the issue back to this ticket: https://issues.jenkins-ci.org/browse/JENKINS-58405.  The default YAML merge strategy has been changed to 'override' and an option has been added to change this, however, changing the YAML merge strategy configuration at the cloud level seems to have no effect. This is doubly impactful, as there appears to be no way to configure the YAML merge strategy at the pipeline level with the DSL, which is our team's preferred way of defining pipeline.  

 

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 8: Invalid config option "yamlMergeStrategy" for agent type "kubernetes". Valid config options are [activeDeadlineSeconds, cloud, containerTemplate, containerTemplates,