[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title Chris Kilding updated JENKINS-60329 Jenkins / JENKINS-60329 Username/password credentials can not be used with git Change By: Chris Kilding Status: In Review Resolved Resolution: Fixed Released As: 0.2.0 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203338.1575027217000.4206.1579778580248%40Atlassian.JIRA.
[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title Chris Kilding commented on JENKINS-60329 Re: Username/password credentials can not be used with git A fix is ready to test (if you're willing to build the .hpi from source) in this pull request: https://github.com/jenkinsci/aws-secrets-manager-credentials-provider-plugin/pull/10 Note that you'll need to add the jenkins:credentials:type tag to your AWS secrets, per the README. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203338.1575027217000.1034.1579261620277%40Atlassian.JIRA.
[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title Chris Kilding updated JENKINS-60329 Jenkins / JENKINS-60329 Username/password credentials can not be used with git Change By: Chris Kilding Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203338.1575027217000.1032.1579261500197%40Atlassian.JIRA.
[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title Chris Kilding started work on JENKINS-60329 Change By: Chris Kilding Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203338.1575027217000.1030.1579261440208%40Atlassian.JIRA.
[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title Chris Kilding commented on JENKINS-60329 Re: Username/password credentials can not be used with git When I looked at option 3 - get creative with the credential snapshot taker - I found it has very strict type constraints, so I don’t think it is viable to change the returned credential type within the snapshot taker. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203338.1575027217000.9704.1576582200118%40Atlassian.JIRA.
[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title Chris Kilding commented on JENKINS-60329 Re: Username/password credentials can not be used with git The options for fixing this appear (to me at least) to be: Fix the naive credential type detection in the Git plugin. Push type detection up the chain in the credentials provider, so that by the time we instantiate the primary credential object, we already know the exact type. This eliminates the multi-type object. Decompose the multi-type object and return a single type object in the credential snapshot taker (this is a fragile solution: it would fix the Git plugin because it just so happens to snapshot credentials, but it doesn’t generalise to plugins that use credentials directly). Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203338.1575027217000.9696.1576582080431%40Atlassian.JIRA.
[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title Chris Kilding commented on JENKINS-60329 Re: Username/password credentials can not be used with git Hi Peter, I have added a failing test that reproduces the issue in a GitHub PR to get us started. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203338.1575027217000.2161.1575648600198%40Atlassian.JIRA.
[JIRA] (JENKINS-60329) Username/password credentials can not be used with git
Title: Message Title
Peter Fich created an issue
Jenkins / JENKINS-60329
Username/password credentials can not be used with git
Issue Type:
Bug
Assignee:
Chris Kilding
Components:
aws-secrets-manager-credentials-provider-plugin
Created:
2019-11-29 11:33
Priority:
Minor
Reporter:
Peter Fich
I'm trying to use username/password credentials with git in a pipeline like this:
pipeline {
agent any
stages {
stage('Example') {
steps {
git credentialsId: 'git-creds', url:'https://github.com/jenkinsci/aws-secrets-manager-credentials-provider-plugin.git'
}
}
}
}
The Git plugin will first test if the credentials are a ssh key, and then try to extract the key. Only if the credentials are not a ssh key will it test if it is a username/password. The issue is that 'AwsCredentials' are implementing both 'StandardUsernamePasswordCredentials' and 'SSHUserPrivateKey'. The solution would be (I think) to have different subclasses for each.
