[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Mark Waite commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Usually the best way for me to create tests is to open the source code in the Netbeans integrated development environment, select the class or classes that need tests, then select "Tools" and "Create / Update Tests". It will generate JUnit stubs to test the specific class. The IDE also provides a way to run individual tests and to run all the tests in a specific class. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.136429.1271845294000.1848.1575586680681%40Atlassian.JIRA.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Tim Black commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Thanks for your attention, Mark Waite. I am not a Java developer, but I've got the experience to make a positive contribution here, at least from the test and integration angle. I looked through the [Beginners Guide To Contributing|https://wiki.jenkins.io/display/JENKINS/Beginners+Guide+to+Contributing], but I'm having trouble finding information on best practices for authoring such tests and for what resources to use for running the tests. The best lead I could find there was mention of [the jenkins-infra project|https://github.com/jenkins-infra/jenkins-infra], which contains configuration management tools that I'm guessing is how tests are expected to be run. Am I on the right track? Can you point me to any better docs, or your personal suggestions? Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.136429.1271845294000.1807.1575584520708%40Atlassian.JIRA.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Mark Waite commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates The recent submodule additions were done with specific attention to test automation. I'm still deeply attached to test automation to allow the plugin to be safely released to the 250 000 installations of Jenkins. For me, a pull request to allow inclusion of submodule changes in the changeset would need to: Include tests that confirm the current behavior of not including submodule changes in the changeset (or confirm that there are already tests which verify that) Include tests that confirm the default behavior is to not include submodule changes in the changeset Include tests that enable inclusion of submodule changes in the changeset, including tests for: Repository with no submodules Repository with 1 submodule Repository with more than 1 submodule Repository with 1 submodule which includes another submodule (recursive) Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Tim Black edited a comment on JENKINS-6334 Re: Support for displaying changesets in submodule updates +Update+I have read [~markewaite]'s comment above and see that there are no PRs related to this issue. I'd be happy to contribute as this is a high value, low-hanging fruit in my opinion.However, I am not a java developer, and from Mark's comments this task is largely that of backfilling a void of automated tests covering submodules, to justify any _consideration_ of a PR that touches submodules. This is of course most unfortunate.I wonder if [~markewaite] still feels this way, however, since [several of the recent releases show submodule changes|[https://github.com/jenkinsci/git-plugin/releases] . | [ https://github.com/jenkinsci/git-plugin/releases] ] . +Original Comment+I have updated to [Jenkins ver. 2.190.3|https://jenkins.io/], am using Git plugin 4.0.0, Git Client Plugin 3.0.0, and have updated my multibranch pipeline job config to recursively update submodules. In the resulting build "changes" it prints the name of the changed submodule, but does not include the changelog for it. I would like to try [~eprstov]'s solution, but I do not see an "sbm" branch here: [https://github.com/jenkinsci/git-plugin/branches]. I'm guessing it's just gone as this is a year later, and my best bet is to use the 4.0.0 tag.Has anyone else made any progress to getting a PR submitted for [~eprstov] patch (wherever it is)? Thanks. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Tim Black edited a comment on JENKINS-6334 Re: Support for displaying changesets in submodule updates +Update+I have read [~markewaite]'s comment above and see that there are no PRs related to this issue. I'd be happy to contribute as this is a high value, low-hanging fruit in my opinion.However, I am not a java developer, and from Mark's comments this task is largely that of backfilling a void of automated tests covering submodules, to justify any _consideration_ of a PR that touches submodules. This is of course most unfortunate.I wonder if [~markewaite] still feels this way, however, since [several of the recent releases show submodule changes|[https://github.com/jenkinsci/git-plugin/releases] ] . |https://github.com/jenkinsci/git-plugin/releases] +Original Comment+I have updated to [Jenkins ver. 2.190.3|https://jenkins.io/], am using Git plugin 4.0.0, Git Client Plugin 3.0.0, and have updated my multibranch pipeline job config to recursively update submodules. In the resulting build "changes" it prints the name of the changed submodule, but does not include the changelog for it. I would like to try [~eprstov]'s solution, but I do not see an "sbm" branch here: [https://github.com/jenkinsci/git-plugin/branches]. I'm guessing it's just gone as this is a year later, and my best bet is to use the 4.0.0 tag.Has anyone else made any progress to getting a PR submitted for [~eprstov] patch (wherever it is)? Thanks. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Tim Black edited a comment on JENKINS-6334 Re: Support for displaying changesets in submodule updates +Update+ I have read [~markewaite]'s comment above and see that there are no PRs related to this issue. I'd be happy to contribute as this is a high value, low-hanging fruit in my opinion.However, I am not a java developer, and from Mark's comments this task is largely that of backfilling a void of automated tests covering submodules, to justify any _consideration_ of a PR that touches submodules. This is of course most unfortunate.I wonder if [~markewaite] still feels this way, however, since [several of the recent releases show submodule changes|[https://github.com/jenkinsci/git-plugin/releases]].+Original Comment+I have updated to [Jenkins ver. 2.190.3|https://jenkins.io/], am using Git plugin 4.0.0, Git Client Plugin 3.0.0, and have updated my multibranch pipeline job config to recursively update submodules. In the resulting build "changes" it prints the name of the changed submodule, but does not include the changelog for it. I would like to try Yakov [~eprstov] 's solution, but I do not see an "sbm" branch here: [https://github.com/jenkinsci/git-plugin/branches]. What reference do I need to fetch to build 'm guessing it's just gone as this ? is a year later, and my best bet is to use the 4.0.0 tag. Has anyone else made any progress to getting a PR submitted for [~eprstov] patch (wherever it is)? Thanks. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Tim Black commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates I have updated to Jenkins ver. 2.190.3, am using Git plugin 4.0.0, Git Client Plugin 3.0.0, and have updated my multibranch pipeline job config to recursively update submodules. In the resulting build "changes" it prints the name of the changed submodule, but does not include the changelog for it. I would like to try Yakov's solution, but I do not see an "sbm" branch here: https://github.com/jenkinsci/git-plugin/branches. What reference do I need to fetch to build this? Has anyone else made any progress to getting a PR submitted for Yakov's patch (wherever it is)? Thanks. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.136429.1271845294000.876.1575501302188%40Atlassian.JIRA.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Tim Black edited a comment on JENKINS-6334 Re: Support for displaying changesets in submodule updates I have updated to [Jenkins ver. 2.190.3|https://jenkins.io/], am using Git plugin 4.0.0, Git Client Plugin 3.0.0, and have updated my multibranch pipeline job config to recursively update submodules. In the resulting build "changes" it prints the name of the changed submodule, but does not include the changelog for it. I would like to try Yakov's solution, but I do not see an "sbm" branch here: [https://github.com/jenkinsci/git-plugin/branches]. What reference do I need to fetch to build this?Has anyone else made any progress to getting a PR submitted for Yakov's [~eprstov] patch (wherever it is)? Thanks. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.136429.1271845294000.878.1575501302324%40Atlassian.JIRA.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Carlos Garcia commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates As per older comments, I wouldn't hold my breath Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title liyatikal commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Will this change be released some time soon? Thank you! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title John Kuzniar commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Awesome, thanks. And thank you Yakov for the solution to this problem. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Carlos Garcia commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates This is I have currently installed, after building the sbm branch (yesterday). Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Carlos Garcia updated an issue Jenkins / JENKINS-6334 Support for displaying changesets in submodule updates Change By: Carlos Garcia Attachment: git-plugins.png Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title John Kuzniar commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Carlos, Have you tried his recent 4.0 beta build on the sbm branch? I was using the 3.6 version, but now need at least 3.9. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Carlos Garcia commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates John, I used Yakov's plugins building them from 'sbm' branch. They worked fine so far. I had minor issues during building, "findbugs" complained about a possible Null pointer dereference, and a test did not pass in git-client plugin. Despite that, for now, all is working normally, so unless a major problem arises, I will stick to Yakov's plugin. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title John Kuzniar commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Yakov, could you deliver your solution? I built your version (worked well, there were a few random java failures), but we need to update our git and git client plugins. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Yakov Karnygin commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates hello Carlos, you just need to enable it. open "Advanced sub-modules behaviours" and check the "Collect submodules changes" option: I forgot to mention it. sorry. note that the first build made after enabling the feature fails due to an issue in the implementation. subsequent builds go well. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Yakov Karnygin updated an issue Jenkins / JENKINS-6334 Support for displaying changesets in submodule updates Change By: Yakov Karnygin Attachment: image-2018-08-28-10-18-31-907.png Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Carlos Garcia commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Yakov Karnygin, I tried your solution, but your plugin seems to behave exactly the same as the official. Could you provide a compiled git-plugin with this change made, and any short instruction on how achieve this changeset for submodules? Of course, the definitive solution should come from official Jenkins plugin repository, but in the meanwhile I can work with your unofficial version. Thank you! Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Mark Waite edited a comment on JENKINS-6334 Re: Support for displaying changesets in submodule updates No one is paying attention to this as far as I can tell.There is no time frame for implementing a "critical 5 year old new feature request".If someone wants it evaluated, they should submit a pull request, following the contribution guidelines in the git plugin. They should include automated tests which verify the functionality. They should assure that the default behavior of the plugin remains consistent with previous default behavior (so that existing users don't complain when default behavior changes). They should assure that the pull request runs well interactively when the capability is enabled. They should enlist the help of other users to verify that the proposed change is working as expected by those other users. Those users should place their feedback on the pull request.The git plugin is sorely lacking in automated tests to verify its submodule functions. A significant regression in submodule functionality was introduced in git plugin 3.0 due to that lack of automated tests. I'm evaluating the pull request which proposes a fix by writing tests which compare submodule behaviors between git client plugin 2 1 . 6 21 with git client plugin 3 2 .0. I've spent most of my available development time in the last month creating automated tests of base submodule functionality.The other way to accelerate the evaluation of this type of proposal is to submit a wide array of submodule functionality verification tests for git client plugin 2 1 . 6 21 , along with a port of those changes to git client plugin 3 2 .0 branch. That accelerates evaluation by allowing me to review the proposed change against an existing suite of tests, instead of requiring that I create all those tests and then use them to evaluate the proposed change. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Mark Waite commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates No one is paying attention to this as far as I can tell. There is no time frame for implementing a "critical 5 year old new feature request". If someone wants it evaluated, they should submit a pull request, following the contribution guidelines in the git plugin. They should include automated tests which verify the functionality. They should assure that the default behavior of the plugin remains consistent with previous default behavior (so that existing users don't complain when default behavior changes). They should assure that the pull request runs well interactively when the capability is enabled. They should enlist the help of other users to verify that the proposed change is working as expected by those other users. Those users should place their feedback on the pull request. The git plugin is sorely lacking in automated tests to verify its submodule functions. A significant regression in submodule functionality was introduced in git plugin 3.0 due to that lack of automated tests. I'm evaluating the pull request which proposes a fix by writing tests which compare submodule behaviors between git plugin 2.6 with git plugin 3.0. I've spent most of my available development time in the last month creating automated tests of base submodule functionality. The other way to accelerate the evaluation of this type of proposal is to submit a wide array of submodule functionality verification tests for git plugin 2.6, along with a port of those changes to git plugin 3.0 branch. That accelerates evaluation by allowing me to review the proposed change against an existing suite of tests, instead of requiring that I create all those tests and then use them to evaluate the proposed change. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Orlin Jechev commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates What is the time frame of implementing a 'Critical' 5 years old new feature request? Is it expected bvakili to submit pull request or the issue should be assigned to somebody else? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Glen Stark commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates This is also a problem for us. Is anyone paying attention to this? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Luka Orelj commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates Yeah I am also interested in this feature. Any news? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Ravishanker C N edited a comment on JENKINS-6334 Re: Support for displaying changesets in submodule updates This is a really important feature. Is it working?Thanks,ravi Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Ravishanker C N assigned an issue to bvakili Jenkins / JENKINS-6334 Support for displaying changesets in submodule updates Change By: Ravishanker C N Assignee: bvakili Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Title: Message Title Ravishanker C N commented on JENKINS-6334 Re: Support for displaying changesets in submodule updates This is a really important feature. Is it working? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-6334) Support for displaying changesets in submodule updates
Martin Wagner commented on JENKINS-6334 Support for displaying changesets in submodule updates JENKINS-6258 has been solved meanwhile, has anyone had a look at bvakili's patch yet? Thanks! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
