[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2014-05-18 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 started work on  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build
















Change By:


Oleg Nenashev
(18/May/14 10:31 AM)




Status:


Open
InProgress



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2014-05-18 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 commented on  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build















The PR has not been merged yet...



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2014-05-18 Thread o.v.nenas...@gmail.com (JIRA)















































Oleg Nenashev
 assigned  JENKINS-18734 to Brendan Nolan



BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build
















Change By:


Oleg Nenashev
(18/May/14 10:32 AM)




Assignee:


BrendanNolan



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2013-07-20 Thread brendan.no...@gmail.com (JIRA)














































Brendan Nolan
 commented on  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build















Replied on pull request to comments. 

I think the StackOverflowError is preferable to the UnsupportedOperationException which is clearly wrong. But if you don't like the fix I'll resolve as won't fix.




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2013-07-14 Thread ku...@gmx.de (JIRA)














































kutzi
 commented on  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build















I see.

See pull request for additional remarks.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2013-07-13 Thread ku...@gmx.de (JIRA)














































kutzi
 commented on  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build















What's the real world (i.e. apart from unit testing) problem, you're trying to fix here?
AFAIK perform(Build?,? build, ...) is throwing UnsupportedOperationException for a good reason: because it shouldn't be usead anymore.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2013-07-13 Thread brendan.no...@gmail.com (JIRA)














































Brendan Nolan
 commented on  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build















Since the FreeStyleBuild and MatrixRun still subclass Build the perform(Build?,? build, ...) in BuildStepCompatabilityLayer will be if called if you using Reflection.

As I said I encountered the issue when trying to invoke the ArtifactArchiver using the groovy plugin which internally looks to use Reflection to invoke the call.

So we have a situation that it would work when called from a Maven build but not a FreeStyleBuild or MatrixRun build. Maybe the proper fix is to change the class hierarchy of FreeStyleBuild and MatrixRun.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2013-07-12 Thread brendan.no...@gmail.com (JIRA)














































Brendan Nolan
 updated  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build
















Change By:


Brendan Nolan
(12/Jul/13 9:53 PM)




Summary:


BuildStepCompatibilityLayer.perform
throw
throws
UnsupportedOperationwheninvokedusingclassesthatsubclassBuild





Description:



Thefollowingcodewillthrowanunsupportedoperation.{code}FreeStyleBuildmock=Mockito.mock(FreeStyleBuild.class,Mockito.CALLS_REAL_METHODS);		ArtifactArchiverartifactArchiver=newArtifactArchiver(,,true);artifactArchiver.perform(mock,null,null);{code}IcameacrosstheissuewhentryingtocalltheArtifactArchiverviathegroovypluginonaMatrixRunbuild.TheBuildStepCompatibilityLayershouldcheckiftheimplementingBuildStepprovidesanimplementationofthe{perform(AbstractBuild?,?build,Launcherlauncher,BuildListenerlistener)}



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2013-07-12 Thread brendan.no...@gmail.com (JIRA)














































Brendan Nolan
 updated  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build
















Change By:


Brendan Nolan
(12/Jul/13 10:13 PM)




Description:


Thefollowingcodewillthrowanunsupportedoperation.{code}FreeStyleBuildmock=Mockito.mock(FreeStyleBuild.class,Mockito.CALLS_REAL_METHODS);		ArtifactArchiverartifactArchiver=newArtifactArchiver(,,true);artifactArchiver.perform(mock,null,null);{code}IcameacrosstheissuewhentryingtocalltheArtifactArchiverviathegroovypluginonaMatrixRunbuild.TheBuildStepCompatibilityLayershouldcheckiftheimplementingBuildStepprovidesanimplementationofthe{
{
perform(AbstractBuild?,?build,Launcherlauncher,BuildListenerlistener)}
}



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [core] (JENKINS-18734) BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build

2013-07-12 Thread brendan.no...@gmail.com (JIRA)














































Brendan Nolan
 commented on  JENKINS-18734


BuildStepCompatibilityLayer.perform throws UnsupportedOperation when invoked using classes that subclass Build















Added pull request - https://github.com/jenkinsci/jenkins/pull/847



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.