[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-27 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24625


style.css should define background color for input fields















Code changed in jenkins
User: Michal Turek
Path:
 src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
 src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/index.jelly
 src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly
http://jenkins-ci.org/commit/cppcheck-plugin/cb9f0426890e0b938ca711d18698a0007a8e9fb5
Log:
  JENKINS-24834 CPP check report background colours not displaying for new or resolved issues since upgrade


	White background color was set to all TD elements in core's JENKINS-24625 which overwrote settings of outer TR.
	Missing mandatory "title" element added to l:layout.































This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-15 Thread tom.fenne...@gmail.com (JIRA)














































Tom FENNELLY
 commented on  JENKINS-24625


style.css should define background color for input fields















This change causes other small issues.  Please see JENKINS-24703.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-15 Thread tom.fenne...@gmail.com (JIRA)














































Tom FENNELLY
 commented on  JENKINS-24625


style.css should define background color for input fields















The description of this JIRA just says "Switch your theme to...".  Where exactly did you go to switch the theme?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-15 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 commented on  JENKINS-24625


style.css should define background color for input fields















Cannot reproduce on Windows 8.1 with any of the four high contrast themes in IE 11 or Firefox 32. How can this be reproduced?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-15 Thread jenkins-ci....@qtea.nl (JIRA)














































Ceesjan Luiten
 commented on  JENKINS-24625


style.css should define background color for input fields















I cannot reproduce it either on Windows 8.1 nor on Vista with Firefox/IE. Firefox 32 on Windows XP does have the problem:

http://ghost.qtea.nl/tmp/jenkins-colors-winxp-firefox32.png

Linux deals with this less well than Windows it seems, with both KDE and Gnome suffering from it.

Re JENKINS-24703: Instead of my previous solution (the merged pull request) the background color can also be set on the body element: I still get good readable inputs. 



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-13 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24625


style.css should define background color for input fields















Code changed in jenkins
User: quinox
Path:
 war/src/main/webapp/css/style.css
http://jenkins-ci.org/commit/jenkins/143581e67fbcf971bfdadf2ad42535a6912caf73
Log:
  FIXED JENKINS-24625 Set background color on input elements





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-13 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24625


style.css should define background color for input fields















Code changed in jenkins
User: Daniel Beck
Path:
 war/src/main/webapp/css/style.css
http://jenkins-ci.org/commit/jenkins/2753fac18d6ead74d8f446abcebda659eab29155
Log:
  Merge pull request #1394 from quinox/master

FIXED JENKINS-24625 Set background color on input elements


Compare: https://github.com/jenkinsci/jenkins/compare/8cbd2b57a8e2...2753fac18d6e




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-13 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-24625 as Fixed


style.css should define background color for input fields
















Change By:


SCM/JIRA link daemon
(13/Sep/14 4:27 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-13 Thread dogf...@java.net (JIRA)














































dogfood
 commented on  JENKINS-24625


style.css should define background color for input fields















Integrated in  jenkins_main_trunk #3678
 FIXED JENKINS-24625 Set background color on input elements (Revision 143581e67fbcf971bfdadf2ad42535a6912caf73)

 Result = SUCCESS
quinox : 143581e67fbcf971bfdadf2ad42535a6912caf73
Files : 

	war/src/main/webapp/css/style.css





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-11 Thread jenkins-ci....@qtea.nl (JIRA)














































Ceesjan Luiten
 commented on  JENKINS-24625


style.css should define background color for input fields















I can submit a pull request with the fixed CSS if that would help.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-11 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 commented on  JENKINS-24625


style.css should define background color for input fields















That would probably be a good idea (Tom, who's working on Jenkins UX, is currently on vacation). For advice related to that, see:
https://wiki.jenkins-ci.org/display/JENKINS/Governance+Document#GovernanceDocument-Usingpullrequests
https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-11 Thread jenkins-ci....@qtea.nl (JIRA)














































Ceesjan Luiten
 commented on  JENKINS-24625


style.css should define background color for input fields















Thanks for the help Daniel, made the pull request.

For those who want to reproduce the bug: After switching your theme you might need to restart your browser before the color scheme becomes fully active (the window decoration changes right away). Also, Chrome/Chromium isn't affected by it because they seem to ignore the user's theme completely.

There's no testcase; if these kinds of issues should be intercepted in the future Jenkins could incorporate some kind of CSS Lint in the validation process.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-08 Thread jenkins-ci....@qtea.nl (JIRA)














































Ceesjan Luiten
 created  JENKINS-24625


style.css should define background color for input fields















Issue Type:


Bug



Affects Versions:


current



Assignee:


Unassigned


Attachments:


2014-08-09_114643_7858.png



Components:


core



Created:


08/Sep/14 9:50 AM



Description:


Currently style.css sets the foreground color but doesn't set the background color; this renders all input fields unreadable for people with certain color schemes.

https://github.com/jenkinsci/jenkins/blob/7cdb85d09c0a709c59694de7b009cb2d0117578b/war/src/main/webapp/css/style.css#L115

To reproduce on Windows: Switch the Windows theme to High Contract and open a job configuration page.

To reproduce on Linux: Switch your theme to one where you have dark backgrounds and light text.

To solve this, add 'background-color: #fff' to the same definition.




Project:


Jenkins



Labels:


css




Priority:


Minor



Reporter:


Ceesjan Luiten

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24625) style.css should define background color for input fields

2014-09-08 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 updated  JENKINS-24625


style.css should define background color for input fields
















Change By:


Daniel Beck
(08/Sep/14 11:36 AM)




Labels:


css
user-experience





Affects Version/s:


current



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.