[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Lucie Votypkova commented on JENKINS-25276 Re: Job Disappears from ListView after rename Hi, I tested it manually and it work well. I created test for it https://github.com/jenkinsci/nested-view-plugin/pull/22. Thanks a lot! Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Lucie Votypkova commented on JENKINS-25276 Re: Job Disappears from ListView after rename Thank you, I am going to look at it and test it. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Jesse Glick commented on JENKINS-25276 Re: Job Disappears from ListView after rename Just don't push branches to jenkinsci. In this case I needed to, in order to offer it up for collaboration. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Jesse Glick reopened an issue Argh, link daemon… Jenkins / JENKINS-25276 Job Disappears from ListView after rename Change By: Jesse Glick Resolution: Fixed Status: Resolved Reopened Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Daniel Beck commented on JENKINS-25276 Re: Job Disappears from ListView after rename Just don't push branches to jenkinsci. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Jesse Glick assigned an issue to Jesse Glick Jenkins / JENKINS-25276 Job Disappears from ListView after rename Change By: Jesse Glick Assignee: JesseGlick Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Jesse Glick started work on JENKINS-25276 Change By: Jesse Glick Status: Open InProgress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Jesse Glick commented on JENKINS-25276 Re: Job Disappears from ListView after rename Jenkins.onRenamed still calls View.onJobRenamed for compatibility, so NestedView could still implement it. But this will only work for simple renames at top level. It would be better for the nested view to be included in the ListView listener (both for location change and delete). Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-25276 Job Disappears from ListView after rename Change By: SCM/JIRA link daemon Status: InProgress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title SCM/JIRA link daemon commented on JENKINS-25276 Re: Job Disappears from ListView after rename Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/ListView.java http://jenkins-ci.org/commit/jenkins/9300dab566131e002657bdba606c99ddb10a97c1 Log: [FIXED JENKINS-25276] NestedView extends View implements ViewGroup, so need to search recursively. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Lucie Votypkova commented on JENKINS-25276 Re: Job Disappears from ListView after rename Hi, I checked a code and the problem is that NestedView is not item but only ViewGroup (in comparing with Folder plugin which does the similar). Now renamed job procedure is delegated on ItemListener of ListView for all instances of ListView and method onJobRename is deprecated and do nothing. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/View.java#L588 https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/ListView.java#L434 https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/ListView.java#L449 So unfortunately the old one way stopped work due to empty onJobRename method and new one does not work because NestedView is not Item. I am not sure what I should change - the NestedView to meet requirements for working of new way, or the listener of ListView to included even GroupView which is not Item. Someone any suggestion? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-25276) Job Disappears from ListView after rename
Title: Message Title Lucie Votypkova commented on JENKINS-25276 Re: Job Disappears from ListView after rename This issue is caused by changes in core. Now onRenameJob method is not used. I am looking on this issue because it has big impact on our Jenkins instance, almost all our root views (views owned by Jenkins instance) are NestedView, so almost all our views are affected by this issue. I will comment when I am sure exactly where is the problem in code. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
