[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-19 Thread scm_issue_l...@java.net (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-33037 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/Fingerprint.java core/src/test/java/hudson/model/FingerprintTest.java http://jenkins-ci.org/commit/jenkins/8ba59197e4d4631c9cf2570749d49f25a724 Log: Merge pull request #2049 from pjanouse/

JENKINS-33037
 
[FIXED JENKINS-33037] Fixed malformed ranges in RangeSet.fromString() 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-19 Thread dogf...@java.net (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 dogfood commented on  JENKINS-33037 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 
 
Integrated in  jenkins_main_trunk #4509 

JENKINS-33037
 Fixed malformed ranges in RangeSet.fromString() (Revision c1621a2bd09533f874c4aff9d193c334ee97078d) 
 Result = SUCCESS pjanouse : c1621a2bd09533f874c4aff9d193c334ee97078d Files :  
 

core/src/main/java/hudson/model/Fingerprint.java
 

core/src/test/java/hudson/model/FingerprintTest.java
 
 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-19 Thread scm_issue_l...@java.net (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon resolved as Fixed 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33037 
 
 
 
  hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 

Change By:
 
 SCM/JIRA link daemon 
 
 
 

Status:
 
 Open Resolved 
 
 
 

Resolution:
 
 Fixed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-18 Thread scm_issue_l...@java.net (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-33037 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Ing. Pavel Janousek Path: core/src/main/java/hudson/model/Fingerprint.java core/src/test/java/hudson/model/FingerprintTest.java http://jenkins-ci.org/commit/jenkins/c1621a2bd09533f874c4aff9d193c334ee97078d Log: JENKINS-33037 Fixed malformed ranges in RangeSet.fromString() 
Fix for rejecting malformed ranges in hudson.model.Fingerprint.RangeSet.fromString(...) 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-10 Thread pjano...@redhat.com (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Pavel Janoušek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33037 
 
 
 
  hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 

Change By:
 
 Pavel Janoušek 
 
 
 
 
 
 
 
 
 
 {{hudson.model.Fingerprint.RangeSet.fromString(...)}} accepts a malformed form of string which doesn't represent any range like:* "1\-\-5" or "1\-\-\-\-\-\-5"* "1,,5" or "1,,,5"* "1\-5\-"* ",\-,"* "1-"* ",1,2"* "5-1" etc.Proposed fix:We should be very rigid and careful  in  of  input validation because this function is directly utilized from e.g.  {{  AbstractBuildRangeCommand }} class  where user input string is passed directly without any validation. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-10 Thread pjano...@redhat.com (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Pavel Janoušek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33037 
 
 
 
  hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 

Change By:
 
 Pavel Janoušek 
 
 
 
 
 
 
 
 
 
 {{hudson.model.Fingerprint.RangeSet.fromString(...)}} accepts a malformed form of string which doesn't represent any range like:* "1\-\-5" or "1\-\-\-\-\-\-5"* "1,,5" or "1,,,5"* "1\-5\-"* ",\-,"* "1-"* " ,1,2"* " 5-1" etc.Proposed fix:We should be very rigid and careful in input validation because this function is directly utilized from e.g. AbstractBuildRangeCommand where user input string is passed directly without any validation. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-10 Thread pjano...@redhat.com (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Pavel Janoušek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33037 
 
 
 
  hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 

Change By:
 
 Pavel Janoušek 
 
 
 
 
 
 
 
 
 
 {{hudson.model.Fingerprint.RangeSet.fromString(...)}} accepts a malformed form of string which doesn't represent any range like:* "1\-\-5" or "1\-\-\-\-\-\-5"* "1,,5" or "1,,,5"* "1\-5\-"* " ,\-,"* "1-"* " 5-1" etc.Proposed fix:We should be very rigid and careful in input validation because this function is directly utilized from e.g. AbstractBuildRangeCommand where user input string is passed directly without any validation. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-03-10 Thread pjano...@redhat.com (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Pavel Janoušek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33037 
 
 
 
  hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 

Change By:
 
 Pavel Janoušek 
 
 
 
 
 
 
 
 
 
 {{hudson.model.Fingerprint.RangeSet.fromString(...)}} accepts a  malformed form of  string  which doesn't represent any  range  specification  like  _ :* "1\-\- 3 5 " _, _  or "1 ,,15"_ etc. Hyphen and comma can be repeated more times (like _"1 \-\-\-\-\-\- 10 5 " _ * "1 ,  _ ,5 "  or " 1,,, 10 5 " _).  Proposed fix:We should reject any either _ * " 1 \- 5 \-" _ or _ * " ,, 5-1 " _  etc.Proposed fix:We should be very rigid and careful in input validation because this function is directly utilized  from  the  e.g. AbstractBuildRangeCommand where user  input  string is passed directly without any validation . 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-02-22 Thread pjano...@redhat.com (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Pavel Janoušek commented on  JENKINS-33037 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 
 
PR sent. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-02-19 Thread pjano...@redhat.com (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Pavel Janoušek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33037 
 
 
 
  hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 

Change By:
 
 Pavel Janoušek 
 
 
 
 
 
 
 
 
 
 {{ hudson.model.Fingerprint.RangeSet.fromString(...) }}  accepts a string range specification like _"1\-\-3"_, _"1,,15"_ etc. Hyphen and comma can be repeated more times (like _"1\-\-\-\-\-\-10"_, _"1,,,10"_).Proposed fix:We should reject any either _"\-\-"_ or _",,"_ from the input. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [core] (JENKINS-33037) hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges

2016-02-19 Thread pjano...@redhat.com (JIRA) 
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Pavel Janoušek created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33037 
 
 
 
  hudson.model.Fingerprint.RangeSet.fromString(...) accepts malformed ranges  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 
 Pavel Janoušek 
 
 
 

Components:
 

 core 
 
 
 

Created:
 

 19/Feb/16 2:30 PM 
 
 
 

Priority:
 
  Minor 
 
 
 

Reporter:
 
 Pavel Janoušek 
 
 
 
 
 
 
 
 
 
 
hudson.model.Fingerprint.RangeSet.fromString(...) accepts a string range specification like "1--3", "1,,15" etc. Hyphen and comma can be repeated more times (like "1--10", "1,,,10"). 
Proposed fix: We should reject any either "--" or ",," from the input. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment