[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-05 Thread grei...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 gus reiber resolved as Won't Fix 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33955 
 
 
 
  help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 

Change By:
 
 gus reiber 
 
 
 

Status:
 
 Open Resolved 
 
 
 

Resolution:
 
 Won't Fix 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-05 Thread grei...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 gus reiber commented on  JENKINS-33955 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 
 
k. So here is the deal... The help buttons must be vertically aligned top or tall controls look awful. But, the top padding of its parent cell is set such that the help will be middle aligned with a single line of text when the text is allowed to be its recommended height. This make the help button look right next to all the checkboxes and radio button lists in the config form as well as tall controls. 
For lines where there is a text input or button, the text line is taller than lines where there isn't a form element. In those cases, the button does not look vertically aligned middle and thus seems slightly off. 
I can set the minimum line height to match the height of the form input buttons, but that will make the long form longer, so I am reluctant to do it. But, if there are continued complaints, I will try that next. 
I just don't have enough data, short of doing a bunch of JS hacking, to know the exact right rule to apply to that button.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread grei...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 gus reiber commented on  JENKINS-33955 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 
 
Yeah, so my conclusion is that they have to be top aligned as they are now. Before when they were vertical middle, with tall controls, it was almost impossible to tell what the hell the icon even related to. With single line controls, align middle is better, but only slightly so. I thought I had tried to offset the top such that for single lines, even when the item was aligned top, it actually seemed centered. I will take another look, but the thing is that i don't have any metadata that tells me if this label or that icon is associated with a short or tall control. 
...thus I need some rules that work mostly well in the most cases. 
There are still some cases where the text vertical alignment is totally messed up. 
...anyway. I will take a look, but I am happy to say the alignment is much, much better now than it was. I don't think perfect is possible given the table hackery being used to render these guys. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33955 
 
 
 
  help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 
 
Perhaps I misread. I read this issue as: you'd like the icon moved down to be centered on the horizontal center-line of the textbox...moving up and down is vertical alignment/offset. If you meant that you want more/less space between the right-edge of textbox and the left-edge of the help icon, that would be horizontal alignment/offset. 
For comparison, I have attached the old alignments with my own notes about what was ugly nice about them. 
 
 
 
 
 
 
 
 
 

Change By:
 
 Spike Washburn 
 
 
 

Attachment:
 
 Screen Shot 2016-04-04 at 9.19.33 PM.png 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn edited a comment on  JENKINS-33955 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 
 Perhaps I misread.  I read this issue as: you'd like the icon moved down to be centered on the horizontal center-line of the textbox...moving up and down is vertical alignment/offset.  If you meant that you want more/less space between the right-edge of textbox and the left-edge of the help icon, that would be horizontal alignment/offset.For comparison, I have attached the old alignments with my own notes about what was ugly nice about them. !Screen Shot 2016-04-04 at 9.19.33 PM.png|thumbnail! 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread jn...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 James Nord commented on  JENKINS-33955 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 
 
I think I meant horizontally aligned - but you get what I mean  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn commented on  JENKINS-33955 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 
 
gus reiber perhaps you could make a ruling on how "broken" and "ugly" this is. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn commented on  JENKINS-33955 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 
 
Top-align looks better for large controls, but not as good for single-line controls. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn assigned an issue to gus reiber 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33955 
 
 
 
  help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 

Change By:
 
 Spike Washburn 
 
 
 

Assignee:
 
 gus reiber 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33955 
 
 
 
  help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 

Change By:
 
 Spike Washburn 
 
 
 

Labels:
 
 2.0 2.0-beta  community-bee  ui 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33955 
 
 
 
  help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 

Change By:
 
 Spike Washburn 
 
 
 
 
 
 
 
 
 
 The blue "Help" icons are no longer correctly aligned on the 2.0 newJob page.In previous releases for textboxes & dropdowns  they where  vertically  aligned in the center which looked visually appealing.  Now they are aligned at the top which looks ugly.The icon should be aligned with the first line of text - just as it is for checkboxes 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-33955) help icons vertically mis-aligned on 2.0 newJob page

2016-04-04 Thread swashb...@cloudbees.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Spike Washburn updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-33955 
 
 
 
  help icons vertically mis-aligned on 2.0 newJob page  
 
 
 
 
 
 
 
 
 

Change By:
 
 Spike Washburn 
 
 
 

Summary:
 
 help icons  vertically  mis -  aligned on 2.0 newJob page 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.