[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Oleg Nenashev resolved as Fixed Jenkins / JENKINS-35190 Improper PingThread handling Change By: Oleg Nenashev Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Oleg Nenashev commented on JENKINS-35190 Re: Improper PingThread handling Releases: remoting-2.60 and jenkins-2.9 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title SCM/JIRA link daemon commented on JENKINS-35190 Re: Improper PingThread handling Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/c718516adfddeb10cbf616ce37c619cc6bbafd53 Log: Update remoting to 2.60 (#2403) Changes summary: Fixed issues: JENKINS-22722(https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (https://github.com/jenkinsci/remoting/pull/80) JENKINS-32326 (https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (https://github.com/jenkinsci/remoting/pull/84) JENKINS-35190(https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (https://github.com/jenkinsci/remoting/pull/85) JENKINS-31256(https://issues.jenkins-ci.org/browse/JENKINS-31256) - hudson.Remoting.Engine#waitForServerToBack now uses credentials for connection. (https://github.com/jenkinsci/remoting/pull/87) JENKINS-35494(https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in hudson.remoting.Launcher (main executable class). (https://github.com/jenkinsci/remoting/pull/88) Enhancements: Ensure a message is logged if remoting fails to override the default ClassFilter. (https://github.com/jenkinsci/remoting/pull/80) Add Comment
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title SCM/JIRA link daemon commented on JENKINS-35190 Re: Improper PingThread handling Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/d9f12b0e614d9598221c571001aa43c018b21e25 Log: Update remoting to 2.60 Changes summary: Fixed issues: JENKINS-22722(https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (https://github.com/jenkinsci/remoting/pull/80) JENKINS-32326 (https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (https://github.com/jenkinsci/remoting/pull/84) JENKINS-35190(https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (https://github.com/jenkinsci/remoting/pull/85) JENKINS-31256(https://issues.jenkins-ci.org/browse/JENKINS-31256) - hudson.Remoting.Engine#waitForServerToBack now uses credentials for connection. (https://github.com/jenkinsci/remoting/pull/87) JENKINS-35494(https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in hudson.remoting.Launcher (main executable class). (https://github.com/jenkinsci/remoting/pull/88) Enhancements: Ensure a message is logged if remoting fails to override the default ClassFilter. (https://github.com/jenkinsci/remoting/pull/80) Add Comment
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Oleg Nenashev assigned an issue to Oleg Nenashev Jenkins / JENKINS-35190 Improper PingThread handling Change By: Oleg Nenashev Assignee: Jesse Glick Oleg Nenashev Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Oleg Nenashev commented on JENKINS-35190 Re: Improper PingThread handling Jesse Glick Yes. My plan is to have a new remoting release by the next weekly Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Jesse Glick commented on JENKINS-35190 Re: Improper PingThread handling Remoting PR merged but as yet unreleased. I guess standard practice is to mark this fixed once core picks up that release? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title SCM/JIRA link daemon commented on JENKINS-35190 Re: Improper PingThread handling Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/remoting/PingThread.java http://jenkins-ci.org/commit/remoting/1fc3c930647fd9352c857fdd247c7d9b252dbc94 Log: JENKINS-35190 Added some logging. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title SCM/JIRA link daemon commented on JENKINS-35190 Re: Improper PingThread handling Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/remoting/Launcher.java src/main/java/hudson/remoting/PingThread.java http://jenkins-ci.org/commit/remoting/59e33a4a6592bdf9c680fbeeaf4cc679a2a2 Log: Merge pull request #85 from jglick/PingThread-JENKINS-35190 JENKINS-35190 PingThread fixes Compare: https://github.com/jenkinsci/remoting/compare/c0cf33130ae5...59e33a4a6592 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title SCM/JIRA link daemon commented on JENKINS-35190 Re: Improper PingThread handling Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/remoting/Launcher.java http://jenkins-ci.org/commit/remoting/7ff0a9ae79eb897bb70d9a88296985f5b67b3c81 Log: JENKINS-35190 Turning off redundant PingThread from Launcher. Also using new onDead overload. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title SCM/JIRA link daemon commented on JENKINS-35190 Re: Improper PingThread handling Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/slaves/ChannelPinger.java http://jenkins-ci.org/commit/jenkins/0ae6c42ed2cbda0ea4a1e196656ef1d6008d80ba Log: JENKINS-35190 Do not even consult PingFailureAnalyzer if ping fails on the agent side. (#2377) Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Oleg Nenashev commented on JENKINS-35190 Re: Improper PingThread handling Jenkins core fix has been integrated into 2.7 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Jesse Glick started work on JENKINS-35190 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-35190) Improper PingThread handling
Title: Message Title Jesse Glick created an issue Jenkins / JENKINS-35190 Improper PingThread handling Issue Type: Bug Assignee: Jesse Glick Components: core Created: 2016/May/27 6:55 PM Labels: remoting Priority: Major Reporter: Jesse Glick There are several problems with the way ping threads are set up. ChannelPinger sets up a master → agent ping, and also an agent → master ping. But Launcher sets up another slave → master ping for JNLP agents (not for master-initiated ones)...and is more awkward to disable, since you must pass a system property to each agent's launch line. As noted here, the agent → master ping from ChannelPinger does not work at all, due to a mistake in usage of PingFailureAnalyzer. (Oddly, Kohsuke Kawaguchi introduced this extension point claiming it could be implemented in ssh-slaves, but apparently never did so there, or anywhere else!) The Launcher variant fails to override the nondeprecated onDead variant that gets
