[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
James Howe commented on JENKINS-17450 warning and performance not counted Maybe add a warning if the plugin detects the v1 format, but that'll be a separate ticket. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek commented on JENKINS-17450 warning and performance not counted Simple but great idea, JENKINS-24007 created, thanks This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek
commented on JENKINS-17450
warning and performance not counted
Oh, I understand now. Legacy XML v1 format uses severities that are not compatible with new XML v2. There is the following mapping in the plugin code.
if ("possible error".equals(cppcheckFile.getSeverity())) {
warningSeverityList.add(cppcheckFile);
} else if ("style".equals(cppcheckFile.getSeverity())) {
styleSeverityList.add(cppcheckFile);
} else if ("possible style".equals(cppcheckFile.getSeverity())) {
performanceSeverityList.add(cppcheckFile);
} else if ("error".equals(cppcheckFile.getSeverity())) {
errorSeverityList.add(cppcheckFile);
} else {
noCategorySeverityList.add(cppcheckFile);
}
allErrors.add(cppcheckFile);
You should always use XML v2. Cppcheck for example reports less issues with XML v1 than with XML v2 for the same analyzed code.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek resolved JENKINS-17450 as Wont Fix warning and performance not counted Rejected, the issue can't occur without manual modification of the input report. Change By: Michal Turek (11/Jul/14 6:16 PM) Status: Reopened Resolved Resolution: WontFix This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek closed JENKINS-17450 as Wont Fix warning and performance not counted Change By: Michal Turek (11/Jul/14 6:17 PM) Status: Resolved Closed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
James Howe commented on JENKINS-17450 warning and performance not counted Master: java version "1.7.0_55" OpenJDK Runtime Environment (rhel-2.4.7.1.el6_5-x86_64 u55-b13) OpenJDK 64-Bit Server VM (build 24.51-b03, mixed mode) Example slave: java version "1.6.0_41" Java(TM) SE Runtime Environment (build 1.6.0_41-b02) Java HotSpot(TM) 64-Bit Server VM (build 20.14-b01, mixed mode) Cppcheck 1.57 Other slave with same problem (on different jobs): java version "1.6.0_65" Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609) Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode) Cppcheck 1.61 Cppcheck command: cppcheck -i$PATH1 -i$PATH2 -i$PATH3 --xml --enable=style -j 2 $PATH4 2 cppcheck-int.xml xsltproc cppcheck.xslt cppcheck-int.xml cppcheck-result.xml The XSLT is changing some "style" issues to "warning" and "performance". According to comments, this is because the --xml option changed everything that wasn't an "error" into "style". I can't see a logical reason why this would affect your plugin. I'll try upgrading cppcheck and look at the options you recommend. This may prove the XSLT to be unnecessary and fix the count issue as well. If that doesn't help, I'll try the test jobs you asked for. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
James Howe commented on JENKINS-17450 warning and performance not counted Yes, switching to --xml-version=2 solves the problems. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek commented on JENKINS-17450 warning and performance not counted Hmmm, I'm absolutely unable to reproduce the issue, everything works for me. I tried the following: Debian testing, OpenJDK 7u55, Jenkins 1.447, latest git version of cppcheck plugin (~1.18), mvn hpi:run, cppcheck 1.61. New job with content of your config.xml from xml_extracts.txt. My own cppcheck-result.xml generated using "cppcheck --enable=all --inconclusive --xml --xml-version=2 graphal/graphal_gui 2 cppcheck-result.xml" that contains warning, style, performance and information severities. Content of generated files contains everything as expected and Jenkins presents the data correctly. Zipped job directory is attached as JENKINS-17450.tar.gz. New questions: What Java do you use (6/7/8, Oracle, OpenJDK, IBM, ...)? Please use "java -version" command. What version of cppcheck do you use? Please use "cppcheck --version" command. What command do you use to execute cppcheck and to generate the report passed to the plugin? Are you using XML version 2 as suggested at wiki? Are you sure all files in xml_extracts.txt belong to the same job/build? I of course expect yes, I'm asking because: Your build.xml contains zero performanceCount/warningCount but cppcheck_details.xml contains them. The files are created from the same data source in publisher so they should correspond each other. Plugin version 1.18 should be able to handle all severities (I check it with cppcheck 1.61 and 1.63 several months ago), so noCategoryCount (~other/unknown category) should be always zero at least for these versions. But it is 149 in your case. The value probably contain warning, performance etc. ones, but I have no idea why Can you find any significant difference between your job directory and the one in JENKINS-17450.tar.gz? Please Create a new job with cppcheck analysis of https://github.com/mixalturek/graphal. Perform several builds. Remove code of https://github.com/mixalturek/graphal from workwpace to have a smaller archive. Zip whole job directory as I did for JENKINS-17450.tar.gz and attach it. Thank you! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek updated JENKINS-17450 warning and performance not counted Change By: Michal Turek (09/Jul/14 7:51 PM) Attachment: JENKINS-17450.tar.gz This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
James Howe updated JENKINS-17450 warning and performance not counted Attached extracts from requested files. Jenkins is 1.569 running on CentOS 6. Change By: James Howe (07/Jul/14 2:34 PM) Attachment: xml_extracts.txt This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek commented on JENKINS-17450 warning and performance not counted Hi James, please attach or send me config.xml (job directory), build.xml (build directory), cppcheck_details.xml (build directory), source cppcheck report (workspace directory) and maybe screenshot of configuration page. If there are any sensitive data, please delete them or send me at least cppcheck related parts of the files. What version of Jenkins core and cppcheck do you use and on which platform? Thank you, Michal This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
James Howe reopened JENKINS-17450 warning and performance not counted Not fixed as far as I can see in 1.18 I have a report with 1 "error", 93 "warning", 56 "performance" and 152 "style" rows. However, the summary table lists 0 for "Warning" and "Performance", and 149 for "No category" Change By: James Howe (04/Jul/14 4:30 PM) Resolution: Fixed Status: Closed Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
James Howe edited a comment on JENKINS-17450 warning and performance not counted Not fixed as far as I can see in 1.18 I have a report with 1 "error", 93 "warning", 56 "performance" and 152 "style" rows. However, the summary table lists 0 for "Warning" and "Performance", and 149 for "No category". The Advanced configuration is unchanged from the default, with no thresholds and all boxes ticked. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
SCM/JIRA link daemon commented on JENKINS-17450 warning and performance not counted Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckBuildAction.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckPublisher.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckBuildAction.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckParserResult.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckProjectAction.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckPublisher.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckReport.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckStatistics.java src/main/java/org/jenkinsci/plugins/cppcheck/config/CppcheckConfigGraph.java src/main/java/org/jenkinsci/plugins/cppcheck/config/CppcheckConfigSeverityEvaluation.java src/main/java/org/jenkinsci/plugins/cppcheck/parser/CppcheckParser.java src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckBuildAction/statistics.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckProjectAction/floatingBox.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/Messages.properties src/main/resources/util/thresholds.jelly http://jenkins-ci.org/commit/cppcheck-plugin/2bb2ba06bd5b844a192a57b66e41acf7bbb17900 Log: JENKINS-17450 "warning" and "performance" not counted The graph doesn't consider "No Category" and whole plugin doesn't work with "portability" severity at all. "No category" and "portability" severities added at all places in the code where other severities are used. Configuration files now contain these additional values. Align of the displayed severities updated on the configuration page to use 2 rows and 4 columns. CppcheckParser is now able to parse the portability severity correctly, it used incorrect "no category". This is only for report version 2, version 1 doesn't output it. REST API extended to contain portability severity too. Legend "Severity 'SEVERITY'" in the graph updated to equivalent but much shorter "SEVERITY". There is more space for the data in the trend now. Non-parametric constructor added to CppcheckStatistics class to simplify creation of empty instance. Support for localization implemented at many places instead of hardcoded strings. Incorrect @SuppressWarnings anotations removed to fix compiler warnings. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek closed JENKINS-17450 as Fixed warning and performance not counted Change By: Michal Turek (08/Mar/14 1:37 PM) Status: Resolved Closed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek edited a comment on JENKINS-17450 warning and performance not counted Tested the latest version of the plugin, but it adds "Warning" and "Performance" issues to totals and also displays them on the graph. The described behavior may be caused by unwanted advanced configuration on configuration page. Can you confirm that? But the graph doesn't consider "No Category" and whole plugin doesn't work with "portability" severity. --errorlist Print a list of all possible error messages in XML format. ./cppcheck --xml --xml-version=2 --errorlist | grep severity | sed 's/.*severity="//' | sed 's/" msg=.*//' | sort -u error information performance portability style warning This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek commented on JENKINS-17450 warning and performance not counted Fixed in https://github.com/mixalturek/cppcheck-plugin/commit/2bb2ba06bd5b844a192a57b66e41acf7bbb17900. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek commented on JENKINS-17450 warning and performance not counted Latest version of the plugin adds "Warning" and "Performance" issues to totals and also displays them on the graph. The described behavior may be caused by unwanted advanced configuration on configuration page. Can you confirm that? But the graph doesn't consider "No Category" and whole plugin doesn't work with "portability" severity. --errorlist Print a list of all possible error messages in XML format. ./cppcheck --xml --xml-version=2 --errorlist | grep severity | sed 's/.*severity="//' | sed 's/" msg=.*//' | sort -u error information performance portability style warning This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek assigned JENKINS-17450 to Michal Turek warning and performance not counted Change By: Michal Turek (22/Feb/14 7:11 PM) Assignee: GregoryBoissinot MichalTurek This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
Michal Turek started work on JENKINS-17450 warning and performance not counted Change By: Michal Turek (22/Feb/14 7:11 PM) Status: Open InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [cppcheck] (JENKINS-17450) warning and performance not counted
James Howe created JENKINS-17450 warning and performance not counted Issue Type: Bug Assignee: Gregory Boissinot Components: cppcheck Created: 03/Apr/13 2:09 PM Description: There are entries in the report table with severity of "warning" and "performance", but they are not included in the totals or the graph. Project: Jenkins Priority: Major Reporter: James Howe This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
