[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Emil Smoleński commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification I can confirm that this problem is resolved after upgrading git plugin to 2.4.1 and git-client plugin to 1.19.1. This issue can be closed. Thank you very much for your work, guys. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Emil Smoleński resolved as Fixed Jenkins / JENKINS-30178 Regression: parameters are not set on commit notification Change By: Emil Smoleński Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Mark Waite closed an issue as Fixed Jenkins / JENKINS-30178 Regression: parameters are not set on commit notification Change By: Mark Waite Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification Code changed in jenkins User: Mark Waite Path: src/main/java/hudson/plugins/git/GitStatus.java src/test/java/hudson/plugins/git/GitStatusTest.java http://jenkins-ci.org/commit/git-plugin/2dfd86d27a7cd4089349fd012d7d70a5e827ed81 Log: Test JENKINS-30178 using GitStatus.toString Asserts that job parameter default values are available when a job is started by a notifyCommit. If the notifyCommit includes a sha1 parameter, then the changes for JENKINS-27092 fail to assign parameters their default values. Modifying the GitStatus object to be more easily tested was simpler than using a TestExtension. Should eventually replace the testing misuse of the GitStatus.toString() method with a TestExtension of GitStatus.Listener. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification Code changed in jenkins User: fbelzunc Path: src/main/java/hudson/plugins/git/GitStatus.java http://jenkins-ci.org/commit/git-plugin/0a661ceaa5da94e92df97a2220a792d1eaa34317 Log: [Fix JENKINS-30178] Add default parameters defined in the job Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title
Mark Waite edited a comment on JENKINS-30178
Re: Regression: parameters are not set on commit notification
In my tests with git plugin 2.4.0 and git client plugin 1.19.0, I can only duplicate the problem if I include "sha1=" in the notify commit argument list (just as Daniel Beck observed in an earlier comment) . When I include no argument, and when I include only the argument "branch=", then the default parameter values are visible to the XShell and Shell build steps in my test job.The notify commit I used to show the problem was:{noformat}SHA1=$(git rev-parse HEAD)curl -s http://localhost:8080/git/notifyCommit?url="" />{noformat}The notify commit I used that does not show the problem is:{noformat}curl -s http://localhost:8080/git/notifyCommit?url="" />{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-30178 Regression: parameters are not set on commit notification Change By: Jesse Glick Labels: regression Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Jesse Glick commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification Daniel Beck claims in the PR for JENKINS-27902 that it caused this. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Mark Waite commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification In my tests with git plugin 2.4.0 and git client plugin 1.19.0, I can only duplicate the problem if I include "sha1=" in the notify commit argument list. When I include no argument, and when I include only the argument "branch=", then the default parameter values are visible to the XShell and Shell build steps in my test job. The notify commit I used to show the problem was: SHA1=$(git rev-parse HEAD) curl -s http://localhost:8080/git/notifyCommit?url="" The notify commit I used that does not show the problem is: curl -s http://localhost:8080/git/notifyCommit?url="" Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Jesse Glick commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification Part of a general lack of coherent handling of default parameters in Jenkins core. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Félix Belzunce Arcos updated an issue Jenkins / JENKINS-30178 Regression: parameters are not set on commit notification Change By: Félix Belzunce Arcos URL: https://github.com/jenkinsci/git-plugin/pull/356 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Félix Belzunce Arcos assigned an issue to Félix Belzunce Arcos Jenkins / JENKINS-30178 Regression: parameters are not set on commit notification Change By: Félix Belzunce Arcos Assignee: Nicolas De Loof Félix Belzunce Arcos Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Félix Belzunce Arcos started work on JENKINS-30178 Change By: Félix Belzunce Arcos Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Daniel Beck commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification If a sha1 is provided, the build is triggered without default parameters: https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitStatus.java#L281...L292 buildParameters in the above code seems to be fed in https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitStatus.java#L72 which means it only contains explicitly passed parameters, and not those defined in the job. Haven't confirmed in a debugger, but seems to explain what's going on here. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Daniel Beck commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification Additionally, if there are no such parameters, the build will end up with an empty ParametersAction in the sidepanel anyway. This should really only be set when there actually are parameters IMO. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Emil Smoleński commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification The actual commit notification from Stash (taken from logs) looks like this: GET /git/notifyCommit?url="" In the newest versions of Stash you can also: Omit SHA1 Hash Code Omit Branch Name HTH. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title
Emil Smoleński edited a comment on JENKINS-30178
Re: Regression: parameters are not set on commit notification
TheactualcommitnotificationfromStash(takenfromlogs)lookslikethis:{code}GET/git/notifyCommit?url="" />{code}InthenewestversionsofStashyoucanalso:*OmitSHA1HashCode*OmitBranchName (theseoptionsaredisabledbydefault) HTH.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Emil Smoleński created an issue Jenkins / JENKINS-30178 Regression: parameters are not set on commit notification Issue Type: Bug Assignee: Nicolas De Loof Components: git-plugin Created: 27/Aug/15 2:39 PM Environment: Jenkins 1.626 Java 1.8 CentOS 6.6 (x86_64) Priority: Major Reporter: Emil Smoleński After upgrades (I'm not sure whether it happened after jenkins or jenkins plugin upgrade), jenkins doesn't set configured environment variables with default values in the This build is parameterized section on commit notification from SCM (Stash) using /git/notifyCommit request. However it works properly when build is manually triggered with Build with parameters button. The only difference I can see is the lack of these configured variables set – everything else works as expected. It is a regression – this setup is used for a very long time in our environment.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Emil Smoleński commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification Thanks for quick reply! I downgraded git-plugin to the 2.3.5 version and it in fact solved the problem. Please let me know if you need additional testing or more information in order to fix this. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Mark Waite commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification Could you compare the behavior of the previous release (2.3.5) and the current release (2.4.0) to see if that is where the change was introduced? There was a change included in 2.4.0 which may have caused this regression, and it would help me to have it narrowed to a specific version that introduced the bug. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-30178) Regression: parameters are not set on commit notification
Title: Message Title Mark Waite commented on JENKINS-30178 Re: Regression: parameters are not set on commit notification It would be great to confirm that the problem also occurs when using a commitNotify from something other than Stash. I don't have a Stash installation available, so it will help if I can see it from commitNotify from a simple bare git repository, rather than requiring Stash. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
