[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Spilker closed JENKINS-22708 as Fixed JobDSL Plugin can produce never ending jobs (resource leak) Change By: Daniel Spilker (04/Oct/14 1:57 PM) Status: Resolved Closed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Spilker commented on JENKINS-22708 JobDSL Plugin can produce never ending jobs (resource leak) Will be fixed in 1.26. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Spilker resolved JENKINS-22708 as Fixed JobDSL Plugin can produce never ending jobs (resource leak) Change By: Daniel Spilker (29/Sep/14 5:58 PM) Status: Open Resolved Assignee: JustinRyan DanielSpilker Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
SCM/JIRA link daemon commented on JENKINS-22708 JobDSL Plugin can produce never ending jobs (resource leak) Code changed in jenkins User: Daniel Spilker Path: docs/Home.md http://jenkins-ci.org/commit/job-dsl-plugin/bc55db2f4737cd73ff64815bbd3f455d41ce71fa Log: mention fix for JENKINS-22708 in release notes This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Spilker commented on JENKINS-22708 JobDSL Plugin can produce never ending jobs (resource leak) The problem is that properties collects all properties of the job object, so all getter methods get called. Unfortunately, also getXml() is called which generates the config XML for the job. And there starts the recursion because to generated the XML, all configure block will be evaluated. And the configure block will try to generated the XML which calls the configure block and so on. As a workaround I tried to make the "Process Job DSLs" step abortable by checking the thread's interrupted flag and throwing a InterruptedException. But that didn't work because the exception is caught somewhere and never aborts the build step. Another solution would be to rename getXml() and getNode() to createXml() and createNode(). That would change the API, but will break the recursion since properties no longer causes the XML to be generated. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Kuffner
created JENKINS-22708
JobDSL Plugin can produce never ending jobs (resource leak)
Issue Type:
Bug
Assignee:
Justin Ryan
Components:
job-dsl-plugin
Created:
22/Apr/14 8:34 AM
Description:
It is possible to create a job which will never end by configuring a job like:
job {
name "Test"
configure { root -
// Please note I forgot to start with "root"
properties / 'hudson.plugins.disk__usage.DiskUsageProperty').@plugin="disk-usage@0.23"
}
}
I did obviously a mistake in the configuration block since I start with "properties" instead of "root". Neverless it would be good if in this case the job would just fail.
JobDSL Plugin Version 1.22
Project:
Jenkins
Priority:
Blocker
Reporter:
Daniel Kuffner
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Kuffner
updated JENKINS-22708
JobDSL Plugin can produce never ending jobs (resource leak)
Change By:
Daniel Kuffner
(22/Apr/14 8:37 AM)
Description:
Itispossibletocreateajobwhichwillneverendbyconfiguringajoblike:{code}job{ nameTest configure{root- //PleasenoteIforgottostartwithroot
(
properties/
(
hudson.plugins.disk__usage.DiskUsageProperty).@plugin=disk-usage@0.23 }}{code}IdidobviouslyamistakeintheconfigurationblocksinceIstartwithpropertiesinsteadofroot.Neverlessitwouldbegoodifinthiscasethejobwouldjustfail.JobDSLPluginVersion1.22
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Kuffner
updated JENKINS-22708
JobDSL Plugin can produce never ending jobs (resource leak)
Change By:
Daniel Kuffner
(22/Apr/14 8:36 AM)
Description:
Itispossibletocreateajobwhichwillneverendbyconfiguringajoblike:{code}job{ nameTest configure{root- //PleasenoteIforgottostartwithroot properties/
(
hudson.plugins.disk__usage.DiskUsageProperty).@plugin=disk-usage@0.23 }}{code}IdidobviouslyamistakeintheconfigurationblocksinceIstartwithpropertiesinsteadofroot.Neverlessitwouldbegoodifinthiscasethejobwouldjustfail.JobDSLPluginVersion1.22
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Kuffner commented on JENKINS-22708 JobDSL Plugin can produce never ending jobs (resource leak) Just for clearifiaction, the JobDSL Plugin job hangs forever This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-22708) JobDSL Plugin can produce never ending jobs (resource leak)
Daniel Kuffner edited a comment on JENKINS-22708 JobDSL Plugin can produce never ending jobs (resource leak) Just for clarification, the JobDSL Plugin job hangs forever This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
