[JIRA] [job-dsl-plugin] (JENKINS-30111) Publisher downstreamParameterized dsl with predefined properties generates incorrect config
Title: Message Title Daniel Spilker closed an issue as Not A Defect Jenkins / JENKINS-30111 Publisher downstreamParameterized dsl with predefined properties generates incorrect config Change By: Daniel Spilker Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-30111) Publisher downstreamParameterized dsl with predefined properties generates incorrect config
Title: Message Title Daniel Spilker resolved as Not A Defect Jenkins / JENKINS-30111 Publisher downstreamParameterized dsl with predefined properties generates incorrect config Change By: Daniel Spilker Status: Open Resolved Resolution: NotADefect Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-30111) Publisher downstreamParameterized dsl with predefined properties generates incorrect config
Title: Message Title
Daniel Spilker commented on JENKINS-30111
Re: Publisher downstreamParameterized dsl with predefined properties generates incorrect config
The trigger context has no parameters context. At least not in versions = 1.37. See https://github.com/jenkinsci/job-dsl-plugin/wiki/Job-reference#parameterized-trigger.
What happens in your example is that parameters calls the method with the same name on the job context which creates the job parameters, because if a method could not be found in a context, the outer context would be used. And because the parameters context on the job level has no predefinedProp method, the predefinedProp on the trigger context is called which creates the trigger parameter. That's an oddity of the DSL.
The next release (1.38) will introduce a parameters context for the trigger context, but until then just remove the parameters context:
def jobRebase = freeStyleJob(Test)
jobRebase.with {
publishers {
downstreamParameterized {
trigger(JobB, 'SUCCESS') {
predefinedProp(BRANCH,\${GIT_BRANCH})
}
}
}
}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-30111) Publisher downstreamParameterized dsl with predefined properties generates incorrect config
Title: Message Title
Marius Balteanu created an issue
Jenkins / JENKINS-30111
Publisher downstreamParameterized dsl with predefined properties generates incorrect config
Issue Type:
Bug
Assignee:
Daniel Spilker
Attachments:
config-dsl.xml, config.xml
Components:
job-dsl-plugin
Created:
24/Aug/15 2:33 PM
Priority:
Major
Reporter:
Marius Balteanu
The following simple dsl
def jobRebase = freeStyleJob(Test)
jobRebase.with {
publishers {
downstreamParameterized {
trigger(JobB, 'SUCCESS') {
parameters { // since 1.23
predefinedProp(BRANCH,\${GIT_BRANCH})
}
}
}
}
}
generates also the definitions for This build is parameterized which is not correct.
properties
hudson.model.ParametersDefinitionProperty
parameterDefinitions/parameterDefinitions
/hudson.model.ParametersDefinitionProperty
/properties
[JIRA] [job-dsl-plugin] (JENKINS-30111) Publisher downstreamParameterized dsl with predefined properties generates incorrect config
Title: Message Title Marius Balteanu commented on JENKINS-30111 Re: Publisher downstreamParameterized dsl with predefined properties generates incorrect config Thanks for your response and for the explications, it was my mistake because I took the parameters context from the buildPipelineTrigger example which was wrong. I removed it now and it's all good. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
