[JIRA] [job-dsl-plugin] (JENKINS-32285) Consider BuildParametersContext to be extensible
Title: Message Title Daniel Spilker closed an issue as Fixed Jenkins / JENKINS-32285 Consider BuildParametersContext to be extensible Change By: Daniel Spilker Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32285) Consider BuildParametersContext to be extensible
Title: Message Title Damien Coraboeuf started work on JENKINS-32285 Change By: Damien Coraboeuf Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32285) Consider BuildParametersContext to be extensible
Title: Message Title Damien Coraboeuf commented on JENKINS-32285 Re: Consider BuildParametersContext to be extensible Hi, I have created the https://github.com/jenkinsci/job-dsl-plugin/pull/713 pull request to help making this happen. Best regards, Damien. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32285) Consider BuildParametersContext to be extensible
Title: Message Title SCM/JIRA link daemon commented on JENKINS-32285 Re: Consider BuildParametersContext to be extensible Code changed in jenkins User: Damien Coraboeuf Path: job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Job.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/wrapper/ReleaseContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/3d7203d2f9b0298d6267b00cfdba321050821df9 Log: JENKINS-32285 Making BuildParametersContext extensible Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32285) Consider BuildParametersContext to be extensible
Title: Message Title SCM/JIRA link daemon commented on JENKINS-32285 Re: Consider BuildParametersContext to be extensible Code changed in jenkins User: Daniel Spilker Path: docs/Extending-the-DSL.md docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Job.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/wrapper/ReleaseContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/f6e97ec3933e6a6b863d058b681b9309bcbe4415 Log: Merge remote-tracking branch 'dcoraboeuf/master' [FIXES JENKINS-32285] Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/b84dbb1c4149...f6e97ec3933e Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32285) Consider BuildParametersContext to be extensible
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-32285 Consider BuildParametersContext to be extensible Change By: SCM/JIRA link daemon Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32285) Consider BuildParametersContext to be extensible
Title: Message Title Damien Coraboeuf created an issue Jenkins / JENKINS-32285 Consider BuildParametersContext to be extensible Issue Type: Improvement Assignee: Daniel Spilker Components: job-dsl-plugin Created: 04/Jan/16 8:01 PM Environment: 1.41 Priority: Minor Reporter: Damien Coraboeuf Hi, It would be a plus to allow some plugins to contribute to the parameters section of the job DSL, in case they provide additional types of parameters. Looking at the code (1.41), I see that the BuildParametersContext class stores the nodes to be created as a map (in order to guarantee uniqueness of parameter names I assume). This does make this easy to make this class extend the AbstractExtensibleContext and to implement the addExtensionNode method. Can we safely assume that the node would have a name field, so we can index it? That would allow for an easy implementation. Best regards, Damien.
