[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-06-28 Thread o.v.nenas...@gmail.com (JIRA)















































Oleg Nenashev
 resolved  JENKINS-19433 as Fixed


ownership plugin does not find owners email - although its defined in his/her profile
















Will be resolved in mailer-1.9 (coming soon)





Change By:


Oleg Nenashev
(28/Jun/14 9:46 AM)




Status:


InProgress
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-03-10 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















Code changed in jenkins
User: Oleg Nenashev
Path:
 src/main/java/hudson/tasks/MailAddressResolver.java
 src/main/java/hudson/tasks/Mailer.java
 src/test/java/hudson/tasks/MailAddressResolverTest.java
http://jenkins-ci.org/commit/mailer-plugin/17c289f66b5541c0613b288c4abf89fdd7ef1a43
Log:
  Merge pull request #12 from jenkinsci/JENKINS_19433_fix

JENKINS-19433 - Added handling of user-defined e-mail addresses in FastEmailResolver.


Compare: https://github.com/jenkinsci/mailer-plugin/compare/1dfed4acc50c...17c289f66b55




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-03-04 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















Code changed in jenkins
User: Oleg Nenashev
Path:
 src/main/java/hudson/tasks/MailAddressResolver.java
http://jenkins-ci.org/commit/mailer-plugin/2b59658b5483ae465aaf9f933d12ce6bfcd4af4b
Log:
  JENKINS-19433 - MailAddressResolver::resolve(User) uses a Mailer.UserProperty as a data source with a highest priority.

Signed-off-by: Oleg Nenashev o.v.nenas...@gmail.com





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-23 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















Code changed in jenkins
User: Oleg Nenashev
Path:
 src/main/java/hudson/tasks/MailAddressResolver.java
 src/main/java/hudson/tasks/Mailer.java
 src/test/java/hudson/tasks/MailAddressResolverTest.java
http://jenkins-ci.org/commit/mailer-plugin/0a8d52ac7d06a774b0a94cf4c2d7e8826a5c3d25
Log:
  JENKINS-19433 - Added handling of user-defined e-mail addresses in FastEmailResolver.

This change adds a new routine for fast email resolution.
If a user has defined his own e-mail on the profile page, it will be resolved in the Mailer plugin with a highest priority.

Resolves https://issues.jenkins-ci.org/browse/JENKINS-19433

Signed-off-by: Oleg Nenashev o.v.nenas...@gmail.com





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-23 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















https://github.com/jenkinsci/mailer-plugin/pull/12



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-23 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 started work on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile
















Change By:


Oleg Nenashev
(23/Feb/14 8:49 PM)




Status:


Open
InProgress



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-23 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















Code changed in jenkins
User: Oleg Nenashev
Path:
 src/main/java/hudson/tasks/MailAddressResolver.java
 src/main/java/hudson/tasks/Mailer.java
http://jenkins-ci.org/commit/mailer-plugin/fe2d408c71dfe66820fc66d835b2d6082b4730ff
Log:
  JENKINS-19433 - Fixed comments from @jglick

Signed-off-by: Oleg Nenashev o.v.nenas...@gmail.com





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-22 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















The main risk: authentication plugins may configure the Mailer's property on their own (e.g. ActiveDirectory), so the field may differ from a user's expectations. If a user relies on e-mail suffix, in most cases he don't need to care about a garbage in the Mailer's user property

BTW, the approach you propose is a correct way even if it causes some regressions. Hence I propose to just put a notification in change history of the plugin.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-13 Thread slide.o....@gmail.com (JIRA)














































Alex Earl
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















Why is this an issue in the mailer plugin?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-13 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















@Alex
It's just an improvement.

FastMailResolver and MailResolver extensions from Mailer don't use "E-mail address" from user's profile if it is defined.
It seems to be a proper behavior (especially from user's position).



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-13 Thread slide.o....@gmail.com (JIRA)














































Alex Earl
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















Ok, so basically you are just looking to have the resolver look at the defined user address before trying other address resolvers?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-13 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















Yes, you are right 

The fix seems to be very easy, but it may cause regressions if user has a garbage/outdated e-mail.
So there should be a switch in global or user's configuration.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-13 Thread o.v.nenas...@gmail.com (JIRA)












































 
Oleg Nenashev
 edited a comment on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile
















Yes, you are right 

The implementation seems to be very easy, but it may cause regressions if user has a garbage/outdated e-mail.
So there should be a switch in global or user's configuration.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2014-02-13 Thread slide.o....@gmail.com (JIRA)














































Alex Earl
 commented on  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile















It could call Mailer.UserProperty.hasExplicitlyConfiguredAddress() to verify the address has been configured before using it, I think that would suffice.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [mailer] (JENKINS-19433) ownership plugin does not find owner's email - although it's defined in his/her profile

2013-11-26 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 updated  JENKINS-19433


ownership plugin does not find owners email - although its defined in his/her profile
















Reassigned the issue to mailer plugin





Change By:


Oleg Nenashev
(26/Nov/13 9:14 PM)




Issue Type:


Bug
Improvement





Component/s:


mailer



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.