[JIRA] [performance-plugin] (JENKINS-15736) Viewing performance report changes jvm locale
SCM/JIRA link daemon commented on JENKINS-15736 Viewing performance report changes jvm locale Code changed in jenkins User: Guus der Kinderen Path: src/main/java/hudson/plugins/performance/AbstractReport.java src/main/java/hudson/plugins/performance/PerformanceReport.java http://jenkins-ci.org/commit/performance-plugin/2e7c03f4415b640919104397004808726a628d62 Log: Fixes a problem with rounding numbers that was introduced by JENKINS-15736. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [performance-plugin] (JENKINS-15736) Viewing performance report changes jvm locale
SCM/JIRA link daemon commented on JENKINS-15736 Viewing performance report changes jvm locale Code changed in jenkins User: Manuel Carrasco Moñino Path: .gitignore src/main/java/hudson/plugins/performance/AbstractParser.java src/main/java/hudson/plugins/performance/AbstractReport.java src/main/java/hudson/plugins/performance/IagoParser.java src/main/java/hudson/plugins/performance/JMeterCsvParser.java src/main/java/hudson/plugins/performance/JMeterParser.java src/main/java/hudson/plugins/performance/JUnitParser.java src/main/java/hudson/plugins/performance/JmeterSummarizerParser.java src/main/java/hudson/plugins/performance/PerformanceProjectAction.java src/main/java/hudson/plugins/performance/PerformanceReport.java src/main/java/hudson/plugins/performance/WrkSummarizerParser.java src/test/java/hudson/plugins/performance/JMeterParserTest.java src/test/java/hudson/plugins/performance/JUnitParserTest.java src/test/java/hudson/plugins/performance/WrkSummarizerParserTest.java src/test/resources/JENKINS-16627_CSV_instead_of_XML.jtl src/test/resources/TEST-JUnitResults.xml.serialized src/test/resources/emptyfile.jtl src/test/resources/jUnitIssue5571.xml.serialized src/test/resources/whitespace-followed-by-xml.jtl http://jenkins-ci.org/commit/performance-plugin/d5d4c8797a0c13a051d010b380a3d6346c1db3d2 Log: Merge pull request #45 from guusdk/master FIXED JENKINS-26988 FIXED JENKINS-16627FIXED JENKINS-15736 Compare: https://github.com/jenkinsci/performance-plugin/compare/3e0f37953c07...d5d4c8797a0c This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [performance-plugin] (JENKINS-15736) Viewing performance report changes jvm locale
Guus der Kinderen commented on JENKINS-15736 Viewing performance report changes jvm locale The fix in pull request 42 triggers the following stacktrace in my logfile: feb 17, 2015 2:14:16 PM hudson.ExpressionFactory2$JexlExpression evaluate WARNING: Caught exception evaluating: it.getTotalTrafficInKb() in /view/6.%20BQ%20Trunk/job/BQ%20Trunk%20(performance)/116/performance/. Reason: java.lang.NumberFormatException: For input string: "1923,74" java.lang.NumberFormatException: For input string: "1923,74" at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1241) at java.lang.Double.valueOf(Double.java:504) at hudson.plugins.performance.PerformanceReport.roundTwoDecimals(PerformanceReport.java:325) at hudson.plugins.performance.PerformanceReport.getTotalTrafficInKb(PerformanceReport.java:211) at sun.reflect.GeneratedMethodAccessor184.invoke(Unknown Source) I have provided a fix in https://github.com/jenkinsci/performance-plugin/pull/45 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [performance-plugin] (JENKINS-15736) Viewing performance report changes jvm locale
Daryl Spartz commented on JENKINS-15736 Viewing performance report changes jvm locale Submitted pull request, https://github.com/jenkinsci/performance-plugin/pull/42 for this fix This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [performance-plugin] (JENKINS-15736) Viewing performance report changes jvm locale
evernat updated JENKINS-15736 Viewing performance report changes jvm locale Change By: evernat (30/Dec/14 12:42 PM) Priority: Major Critical This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [performance-plugin] (JENKINS-15736) Viewing performance report changes jvm locale
evernat
commented on JENKINS-15736
Viewing performance report changes jvm locale
In my opinion, this issue is critical since it affects all Jenkins core and installed plugins.
Based on the code, there is at least one line in the plugin which causes this issue and it is easy to fix:
https://github.com/jenkinsci/performance-plugin/blob/master/src/main/java/hudson/plugins/performance/AbstractReport.java#L21
In fact, the method Locale.setDefault(...) must never be called by the plugin.
I suggest to change the constructor of AbstractReport from
public AbstractReport() {
if (Stapler.getCurrentRequest() != null) {
Locale.setDefault(Stapler.getCurrentRequest().getLocale());
}
percentFormat = new DecimalFormat("0.0");
dataFormat = new DecimalFormat("#,###");
}
to
public AbstractReport() {
final Locale locale;
if (Stapler.getCurrentRequest() != null) {
locale = Stapler.getCurrentRequest().getLocale();
} else {
locale = Locale.getDefault();
}
percentFormat = new DecimalFormat("0.0", DecimalFormatSymbols.getInstance(locale));
dataFormat = new DecimalFormat("#,###", DecimalFormatSymbols.getInstance(locale));
}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
