[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort resolved as Done This was released with v1.4 - discussion of a full layout redesign to do dynamic sizing of columns is moving to separate JIRA to facilitate tracking. Jenkins / JENKINS-33498 Improve full screen view of pipeline stage view Change By: Sam Van Oort Status: In Progress Resolved Resolution: Done Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort commented on JENKINS-33498 Re: Improve full screen view of pipeline stage view John Ament and Ken Lamb I agree that it would have value to support dynamic column widths, however I think due to the complexity of the layout change that's probably out of scope for the original JIRA. I've created JENKINS-35252 for layout redesigns as a separate RFE - let's move discussion there. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Ken Lamb commented on JENKINS-33498 Re: Improve full screen view of pipeline stage view FWIW: I would like this ability as well. Currently, I have long stage names that stretch the stages to the right where they get cut off and I have to scroll. Meanwhile, if the page is being displayed in full screen mode, half of the screen is blank next to the stage view. Rather than scrolling right, it would be nice if the screen view would just use all of that real estate. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort commented on JENKINS-33498 Re: Improve full screen view of pipeline stage view John Ament The idea here is that you can see more stages onscreen without needing to scroll right (a common issue for very complex builds with many stages) – it's covering this: Can you make it take up more screen real estate, maybe based on the number of stages in the pipeline In my opinion, we don't gain much just by stretching the stages wider arbitrarily... but there might be value in allowing them to grow and shrink a bit if they have content that can use the screen real-estate. I think that should be treated as a separate RFE though because it requires more significant CSS layout changes in multiple changes, and needs testing under a variety of circumstances. As starting points: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/templates/pipeline-staged.less#L239 This sets the width of table cells (even if max-width is set, they don't grow). This sets the overall width of the table cells in view, as does the line below it: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/templates/pipeline-staged.hbs#L4 Which is unfortunately hardcoded in JS to give 10em to each stage: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/pipeline-staged.js#L60 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title John Ament commented on JENKINS-33498 Re: Improve full screen view of pipeline stage view Sam Van Oort I don't know if its 100%, but its definitely something bigger. Otherwise there's no benefit to switching to full screen mode (other than not having the sidebar). Maybe just increasing each cell to double the size (height and width) would help? Would it make sense for the header to go away as well? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort commented on JENKINS-33498 Re: Improve full screen view of pipeline stage view John Ament If I understand you correctly, you just want to stretch all the cells of the stage view to fill the available width fully, regardless of how wide that makes them? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title John Ament commented on JENKINS-33498 Re: Improve full screen view of pipeline stage view Sam, Thanks, this is definitely better but could still use some work. Right now, the graphical component is the same size on both the job and full screen view. Is it possible for the component itself to reach 100% width? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Manuel Jesús Recena Soto updated an issue Jenkins / JENKINS-33498 Improve full screen view of pipeline stage view Change By: Manuel Jesús Recena Soto Labels: user user-experience UX Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort assigned an issue to Sam Van Oort Jenkins / JENKINS-33498 Improve full screen view of pipeline stage view Change By: Sam Van Oort Assignee: Sam Van Oort Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort started work on JENKINS-33498 Change By: Sam Van Oort Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33498 Re: Improve full screen view of pipeline stage view Code changed in jenkins User: Sam Van Oort Path: ui/src/main/js/view/remove-sidepanel.js ui/src/main/less/stageview_adjunct.less http://jenkins-ci.org/commit/pipeline-stage-view-plugin/e66ebf4166549b70676ef0a7c1dd484ee08bf1d4 Log: Make fullscreen view really fullscreen JENKINS-33498 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title
Sam Van Oort edited a comment on JENKINS-33498
Re: Improve full screen view of pipeline stage view
Yes, this is what the Full Stage View should do, except that this the main Jenkins styles prevents it:{code :css }#main-panel {padding: 15px 15px 40px 15px;margin-left: 320px;}@media (max-width: 750px) { #side-panel {width: 100%;float: none;padding-bottom: 20px; } #main-panel {margin-left: 0;width: 100%; }}{code}If we override the margin-left: declaration to 0 px, it uses the full page width. This is caused by using the main-panel declaration in the index.jelly:https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/resources/com/cloudbees/workflow/ui/view/WorkflowStageViewAction/index.jelly#L29Probably adding a style (margin-left: 0 px) to the main panel to override the default style will fix this. Retagging this as a bug because I strongly suspect this layout behavior was not intended. In theory it ought to be a fast fix though.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort updated an issue Jenkins / JENKINS-33498 Improve full screen view of pipeline stage view Change By: Sam Van Oort Labels: user user-experience Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title
Sam Van Oort edited a comment on JENKINS-33498
Re: Improve full screen view of pipeline stage view
Yes, this is what the Full Stage View should do, except that this the main Jenkins styles prevents it:{code:css}#main-panel {padding: 15px 15px 40px 15px;margin-left: 320px;}@media (max-width: 750px) { #side-panel {width: 100%;float: none;padding-bottom: 20px; } #main-panel {margin-left: 0;width: 100%; }}{code}If we override the margin-left: declaration to 0 px, it uses the full page width. This is caused by using the main-panel declaration in the index.jelly:https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/resources/com/cloudbees/workflow/ui/view/WorkflowStageViewAction/index.jelly#L29Probably adding a style (margin-left: 0 px) to the main panel to override the default style will fix this. Reagging Retagging this as a bug because I strongly suspect this layout behavior was not intended. In theory it ought to be a fast fix though.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title
Sam Van Oort commented on JENKINS-33498
Re: Improve full screen view of pipeline stage view
Yes, this is what the Full Stage View should do, except that this the main Jenkins styles prevents it:
Unable to find source-code formatter for language: css. Available languages are: actionscript, html, java, _javascript_, none, sql, xhtml, xml
#main-panel {
padding: 15px 15px 40px 15px;
margin-left: 320px;
}
@media (max-width: 750px) {
#side-panel {
width: 100%;
float: none;
padding-bottom: 20px;
}
#main-panel {
margin-left: 0;
width: 100%;
}
}
If we override the margin-left: declaration to 0 px, it uses the full page width. This is caused by using the main-panel declaration in the index.jelly:
https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/resources/com/cloudbees/workflow/ui/view/WorkflowStageViewAction/index.jelly#L29
Probably adding a style (margin-left: 0 px) to the main panel to override the default style will fix this.
Reagging this as a bug because I strongly suspect this layout behavior was not intended.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Sam Van Oort updated an issue Jenkins / JENKINS-33498 Improve full screen view of pipeline stage view Change By: Sam Van Oort Issue Type: Improvement Bug Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title Antonio Muñiz assigned an issue to Unassigned Jenkins / JENKINS-33498 Improve full screen view of pipeline stage view Change By: Antonio Muñiz Assignee: Antonio Muñiz Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [pipeline-stage-view-plugin] (JENKINS-33498) Improve full screen view of pipeline stage view
Title: Message Title John Ament created an issue Jenkins / JENKINS-33498 Improve full screen view of pipeline stage view Issue Type: Improvement Assignee: Antonio Muñiz Components: pipeline-stage-view-plugin Created: 12/Mar/16 2:55 PM Priority: Minor Reporter: John Ament Even in full screen mode, the pipeline stage view is pretty small. It takes about 40% of the screen. Can you make it take up more screen real estate, maybe based on the number of stages in the pipeline? Add Comment
