[JIRA] (JENKINS-41789) GitLabTriggerPlugin Ignores Regex Match in DSL
Title: Message Title Jayme Howard created an issue Jenkins / JENKINS-41789 GitLabTriggerPlugin Ignores Regex Match in DSL Issue Type: Bug Assignee: Daniel Spilker Components: job-dsl-plugin Created: 2017/Feb/07 4:47 AM Environment: job-dsl-plugin: 1.57 gitlab-plugin: 1.44 Jenkins: 2.32.2 Labels: job-dsl-plugin gitlab Priority: Minor Reporter: Jayme Howard There is a flaw in the DSL support for the gitlab-plugin which causes the trigger to only work for standard matching, not regex. This is the default for the gitlab-plugin, so it just appears to work if you're not trying to use the regex match. I have a patch already written for this and will be submitting a pull request momentarily. Add Comment
[JIRA] (JENKINS-41789) GitLabTriggerPlugin Ignores Regex Match in DSL
Title: Message Title Jayme Howard commented on JENKINS-41789 Re: GitLabTriggerPlugin Ignores Regex Match in DSL https://github.com/jenkinsci/job-dsl-plugin/pull/992 should be all set to merge. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42887) job-dsl-plugin Still Uses Mattermost showCommitList
Title: Message Title Jayme Howard created an issue Jenkins / JENKINS-42887 job-dsl-plugin Still Uses Mattermost showCommitList Issue Type: Bug Assignee: Daniel Spilker Components: job-dsl-plugin, mattermost-plugin Created: 2017/Mar/17 4:13 PM Environment: job-dsl-plugin: 1.58 mattermost-plugin: 2.30 Jenkins: 2.40 Labels: jenkins dsl mattermost Priority: Minor Reporter: Jayme Howard The job-dsl-plugin still refers to the Mattermost plugin's old showCommitList() functionality. This was replaced in Mattermost Plugin 2.0 with commitInfoChoice(), and referred to under JENKINS-39239. Jobs built with the DSL plugin's helpers for the Mattermost plugin are unable to set commitInfoChoice(). I'm opening a pull request back to the DSL repo with a fix for this. Add Comment
[JIRA] (JENKINS-42887) job-dsl-plugin Still Uses Mattermost showCommitList
Title: Message Title Jayme Howard commented on JENKINS-42887 Re: job-dsl-plugin Still Uses Mattermost showCommitList You're correct, I agree. However, if direct support for Mattermost exists in the job-dsl-plugin, shouldn't it be correct and accurate? Further, using automatically generated DSL isn't an option for all users. In my case, we've extended HMRC's library to sit on top of the plugin, to do factory based job generation and be able to test our jobs offline. This requires calling the backing methods directly, or implementing everything within configure blocks. I don't expect the plugin to support every user's weird use case, but the hooks for support already exist and were accepted into the codebase, so keeping them accurate feels worthwhile to me, and I've written the patch with that in mind. I do see now that you've opened a merge request with intent to deprecate the Mattermost support. If that's the intended direction, I can go ahead and close my merge request and this issue, and rewrite my implementation via configure. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
