[JIRA] (JENKINS-39834) Periodic Reincarnation does not work with Accelerated Build Now
Title: Message Title Gene Smith created an issue Jenkins / JENKINS-39834 Periodic Reincarnation does not work with Accelerated Build Now Issue Type: Bug Assignee: Anthony Dahanne Components: accelerated-build-now-plugin, periodic-reincarnation-plugin Created: 2016/Nov/17 6:17 PM Environment: Jenkins ver. 2.19.2 Periodic Reincarnation version 1.9 Accelerated Build Now version 1.0.1 OpenJDK 64-Bit Server VM (Zulu 8.19.0.1-linux64) centos 2.6.32-642.6.2.el6.x86_64 Labels: queue Priority: Minor Reporter: Gene Smith This seems like a fairly simple plugin interaction problem. I had "Periodic Reincarnation version 1.9" installed and it was working.without problems for more than a year. (starting on Jenkins 1.x and carrying over to 2.x) I installed "Accelerated Build Now version 1.0.1" and... "Reincarnation" stopped working the next time it should have done something the next failed job for it to restart was a test job early in the morning, and it did not restart and it show no activity in the logs
[JIRA] (JENKINS-33975) On demand slave shows misleading offline cause message
Title: Message Title
Gene Smith commented on JENKINS-33975
Re: On demand slave shows misleading offline cause message
I can describe an imperfect test, and a way to implement it. But I am not very comfortable with this code, so I will describe it here and see what people say... (as I am not a significant contributor to this project, I am not eager to jump into its asynchronous threaded methods). This is an imperfect test because "Computer" does not have a really method to say if its "offline state" is voluntary and clean, or involuntary and a problem. {{ //'c' is an instance of hudson.model.Computer; //RetentionStrategy is hudson.slaves.RetentionStrategy if ( RetentionStrategy.Demand.class.isInstance(c.getRetentionStrategy()) && c.isIdle() && ( c.isOffline() || c.isConnecting() ) ) { //do something smart } }} To put the test in place...
AbstractAsyncNodeMonitorDescriptor's "monitor" method...
would do the test before trying to do start a call
put a different message in "data" to reflect the different state
Then ResponseTimeMonitor's "monitor"
would handle different message from "data"
As the code is now, I have had to turn off the monitoring on my Jenkins instances, because I see no way to prevent ResponseTimeMonitor from calling disconnect() when the slave comes on line during the time the asynchronous call is waiting for it.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-33975) On demand slave shows misleading offline cause message
Title: Message Title Gene Smith commented on JENKINS-33975 Re: On demand slave shows misleading offline cause message This is a reflection of another underlying problem. An On Demand Slave may lose their connection in this sequence the slave is offline a ping cycle starts and an attempt is made against the slave the slave comes online (because a job wants it) the job starts the ping cycle ends and the slave is "marked offline" the slaves state updates and the channel is closed because it has been "marked offline" If ResponseTimeMonitor.java is going to check slaves which are offline, then when a slave comes online something needs to remove it from the list or queue which is waiting for a response which will never arrive. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-33975) On demand slave shows misleading offline cause message
Title: Message Title
Gene Smith edited a comment on JENKINS-33975
Re: On demand slave shows misleading offline cause message
I can describe an imperfect test, and a way to implement it. But I am not very comfortable with this code, so I will describe it here and see what people say... (as I am not a significant contributor to this project, I am not eager to jump into its asynchronous threaded methods).This is an imperfect test because "Computer" does not have a reallymethod to say if its "offline state" is voluntary and clean, or involuntary anda problem.{{ //'c' is an instance of hudson.model.Computer;//RetentionStrategy is hudson.slaves.RetentionStrategyif ( RetentionStrategy.Demand.class.isInstance(c.getRetentionStrategy()) &&c.isIdle() && ( c.isOffline() || c.isConnecting() ) ) {//do something smart} }}To put the test in place...* AbstractAsyncNodeMonitorDescriptor's "monitor" method...** would do the test before trying to do start a call** put a different message in "data" to reflect the different state* Then ResponseTimeMonitor's "monitor"** would handle different message from "data"As the code is now, I have had to turn off the monitoring on my Jenkins instances, because I see no way to prevent ResponseTimeMonitor from calling disconnect() when the slave comes on line during the time the asynchronous call is waiting for it.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-33975) On demand slave shows misleading offline cause message
Title: Message Title
Gene Smith edited a comment on JENKINS-33975
Re: On demand slave shows misleading offline cause message
I can describe an imperfect test, and a way to implement it. But I am not very comfortable with this code, so I will describe it here and see what people say... (as I am not a significant contributor to this project, I am not eager to jump into its asynchronous threaded methods).This is an imperfect test because "Computer" does not have a reallymethod to say if its "offline state" is voluntary and clean, or involuntary anda problem. {{ //'c' is an instance of hudson.model.Computer;//RetentionStrategy is hudson.slaves.RetentionStrategyif ( RetentionStrategy.Demand.class.isInstance(c.getRetentionStrategy()) &&c.isIdle() && ( c.isOffline() || c.isConnecting() ) ) {//do something smart} }} To put the test in place...* AbstractAsyncNodeMonitorDescriptor's "monitor" method...** would do the test before trying to do start a call** put a different message in "data" to reflect the different state* Then ResponseTimeMonitor's "monitor"** would handle different message from "data"As the code is now, I have had to turn off the monitoring on my Jenkins instances, because I see no way to prevent ResponseTimeMonitor from calling disconnect() when the slave comes on line during the time the asynchronous call is waiting for it.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-56668) parameterizedtrigger and git-plugin have an unsatisfied dependency on promoted_builds
Title: Message Title
Gene Smith updated an issue
Jenkins / JENKINS-56668
parameterizedtrigger and git-plugin have an unsatisfied dependency on promoted_builds
Change By:
Gene Smith
If "Parameterized Remote Trigger Plugin 3.0.7" is installed, and "promoted builds plugin" is not installedthen Parameterized Jobs encounter this error, captured from errors.txt:{quote}{{java.lang.NoClassDefFoundError: hudson/plugins/promoted_builds/Promotion}} \ {{ at hudson.plugins.git.GitRevisionBuildParameters.getAction(GitRevisionBuildParameters.java:60)}} \ {{ at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBaseActions(BuildTriggerConfig.java:356)}} \ {{ at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBaseActions(BuildTriggerConfig.java:348)}} \ {{ at hudson.plugins.parameterizedtrigger.ParameterizedDependency.shouldTriggerBuild(ParameterizedDependency.java:62)}} \ {{ at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:271)}} \ {{ at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:651)}} \ {{ at hudson.model.Build$BuildExecution.cleanUp(Build.java:201)}} \ {{ at hudson.model.Run.execute(Run.java:1863)}} \ {{ at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)}} \ {{ at hudson.model.ResourceController.execute(ResourceController.java:97)}} \ {{ at hudson.model.Executor.run(Executor.java:429)}}{quote}With the result that some actions the job is to take may not occur.Notably, the "Discard Old Builds" action does not happen.Looking in the code, I see here:[https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitRevisionBuildParameters.java#L60]that a check in "hudson.plugins.git" requires a class declaration from "hudson.plugins.parameterizedtrigger".But the install of " hudson.plugins.parameterizedtrigger Parameterized Trigger Plugin " does not automatically install then " hudson.plugins.git promoted builds plugin "When I manually install the " hudson.plugins.git promoted builds plugin ", the problem goes away.
Add Comment
[JIRA] (JENKINS-56668) parameterizedtrigger and git-plugin have an unsatisfied dependency on promoted_builds
Title: Message Title
Gene Smith created an issue
Jenkins / JENKINS-56668
parameterizedtrigger and git-plugin have an unsatisfied dependency on promoted_builds
Issue Type:
Bug
Assignee:
Unassigned
Components:
parameterized-trigger-plugin
Created:
2019-03-21 19:06
Environment:
Jenkins ver. 2.164.1 Git client plugin 3.0.0-rc Git plugin 4.0.0-rc Parameterized Remote Trigger Plugin 3.0.7 fixed by adding: promoted builds plugin 3.2
Priority:
Minor
Reporter:
Gene Smith
If "Parameterized Remote Trigger Plugin 3.0.7" is installed, and "promoted builds plugin" is not installed then Parameterized Jobs encounter this error, captured from errors.txt:
java.lang.NoClassDefFoundError: hudson/plugins/promoted_builds/Promotion {{ at hudson.plugins.git.GitRevisionBuildParameters.getAction(GitRevisionBuildParameters.java:60)}} {{ at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBaseActions(BuildTriggerConfig.java:356)}} {{ at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBaseActions(BuildTriggerConfig.java:348)}} {{ at hudson.plugins.parameterizedtrigger.ParameterizedDependency.shouldTriggerBuild(ParameterizedDependency.java:62)}} {{ at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:271)}} {{ at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:651)}} {{ at hudson.model.Build$BuildExecution.cleanUp(Build.java:201)}} {{ at hudson.model.Run.execute(Run.java:1863)}} {{ at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)}} {{ at hudson.model.ResourceController.execute(ResourceController.java:97)}} {{ at hudson.model.Executor.run(Executor.java:429)}}
