[J2] RenderURL and ActionURL broken?

2004-04-01 Thread ate
Just checked out the latest cvs.
RenderURL and ActionURL tags don't render parameters anymore.
I noticed David been busy with the NavigationState and PortletURL implementation
so probably thats not finished yet ;-)

Any idea when this is going to work again?

A side note related to actionURL parameters:
Before these above changes I had an actionURL parameter which name was being
prefix with Pluto_17_ (17 being the id of my portlet).
Because of this prefix my portlet can't find its action parameters.
Any idea where this comes from (pluto or jetspeed) and how this can be resolved?
(maybe I should enter an issue in Jira?)

Thanks,

Ate  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



J1: serving binary files through a portlet?

2004-04-01 Thread Sami Leino
I am building a small bulletin-board system which should support
attachments as well. For that, I would need to serve binary content from a
PortletAction or Portlet class. Is this possible with J1?

The procedure I should do is:

1) Set content-disposition header to contain the correct filename
2) Set content-type header to application/octet-stream or something
more accurate if the information is present in attachment metadata
3) Dump the content using a ServletOutputStream

I tried to do this within a PortletAction class, but Jetspeed has already
obtained a Writer prior to calling the PortletAction and therefore I
cannot obtain ServletOutputStream from HttpServletResponse. As you know,
Writer shouldn't be used for binary data because it may perform some
character encoding on the content, and it might break the attachments.

Do I need to create a separate servlet for serving the attachments? I
wouldn't want to do that, because Jetspeed offers authorization and I
would really like to fully utilize it.

Regards,

Sami

-- 

Sami Leino
Software Developer
Netorek Oy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



AW: J1: serving binary files through a portlet?

2004-04-01 Thread Danny
Which version of Jetspeed do you use?

I wrote a DownloadAction myself only 1 day ago. Even though I experienced
the troubles you described some time ago, when I wanted to do the same.
After having a look at the code, I realized a comment in RunDataFactory (or
RunData class) which indicated, that this problem is fixed.

I used version 1.4b4 and it works.

Danny

 -Ursprüngliche Nachricht-
 Von: Sami Leino [mailto:[EMAIL PROTECTED]
 Gesendet: Donnerstag, 1. April 2004 16:09
 An: [EMAIL PROTECTED]
 Betreff: J1: serving binary files through a portlet?


 I am building a small bulletin-board system which should support
 attachments as well. For that, I would need to serve binary
 content from a
 PortletAction or Portlet class. Is this possible with J1?

 The procedure I should do is:

 1) Set content-disposition header to contain the correct filename
 2) Set content-type header to application/octet-stream or
 something
 more accurate if the information is present in attachment metadata
 3) Dump the content using a ServletOutputStream

 I tried to do this within a PortletAction class, but Jetspeed
 has already
 obtained a Writer prior to calling the PortletAction and therefore I
 cannot obtain ServletOutputStream from HttpServletResponse.
 As you know,
 Writer shouldn't be used for binary data because it may perform some
 character encoding on the content, and it might break the attachments.

 Do I need to create a separate servlet for serving the attachments? I
 wouldn't want to do that, because Jetspeed offers authorization and I
 would really like to fully utilize it.

 Regards,

 Sami

 --

 Sami Leino
 Software Developer
 Netorek Oy

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [J2] RenderURL and ActionURL broken?

2004-04-01 Thread ate
Quoting [EMAIL PROTECTED]:

Digged into the problem below I described earlier and think I found it.
Created new issue for it in JIRA:

  http://nagoya.apache.org/jira/browse/JS2-4

 A side note related to actionURL parameters:
 Before these above changes I had an actionURL parameter which name was being
 prefix with Pluto_17_ (17 being the id of my portlet).
 Because of this prefix my portlet can't find its action parameters.
 Any idea where this comes from (pluto or jetspeed) and how this can be
 resolved?
 (maybe I should enter an issue in Jira?)
 
 Thanks,
 
 Ate  
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-jetspeed-2/portal/src/webapp/WEB-INF/assembly jetspeed.groovy

2004-04-01 Thread taylor
taylor  2004/04/01 07:13:41

  Modified:portal/src/webapp/WEB-INF/assembly jetspeed.groovy
  Log:
  sorry, didn't mean to check this in yet

  

  PR:

  Obtained from:

  Submitted by: 

  Reviewed by:  

  CVS: --

  CVS: PR:

  CVS:   If this change addresses a PR in the problem report tracking

  CVS:   database, then enter the PR number(s) here.

  CVS: Obtained from:

  CVS:   If this change has been taken from another system, such as NCSA,

  CVS:   then name the system in this line, otherwise delete it.

  CVS: Submitted by:

  CVS:   If this code has been contributed to Apache by someone else; i.e.,

  CVS:   they sent us a patch or a new module, then include their name/email

  CVS:   address here. If this is your work then delete this line.

  CVS: Reviewed by:

  CVS:   If we are doing pre-commit code reviews and someone else has

  CVS:   reviewed your changes, include their name(s) here.

  CVS:   If you have not had it reviewed then delete this line.

  
  Revision  ChangesPath
  1.27  +4 -4  
jakarta-jetspeed-2/portal/src/webapp/WEB-INF/assembly/jetspeed.groovy
  
  Index: jetspeed.groovy
  ===
  RCS file: 
/home/cvs/jakarta-jetspeed-2/portal/src/webapp/WEB-INF/assembly/jetspeed.groovy,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- jetspeed.groovy   31 Mar 2004 06:18:04 -  1.26
  +++ jetspeed.groovy   1 Apr 2004 15:13:41 -   1.27
  @@ -124,11 +124,11 @@
   // Navigational State component
   //
   // navigationKeys: prefix, action, mode, state, renderparam, pid, prev_mode, 
prev_state, key_delim
  -// navigationKeys = _,ac,md,st,rp,pid,pm,ps,:
  -navigationKeys = _,a,m,s,r,i,pm,ps,:
  +navigationKeys = _,ac,md,st,rp,pid,pm,ps,:
  +//navigationKeys = _,a,m,s,r,i,pm,ps,:
   
  -// navStateClass = 
org.apache.jetspeed.container.session.impl.PathNavigationalState
  -navStateClass = 
org.apache.jetspeed.container.session.impl.SessionNavigationalState
  +navStateClass = org.apache.jetspeed.container.session.impl.PathNavigationalState
  +//navStateClass = 
org.apache.jetspeed.container.session.impl.SessionNavigationalState
   container.registerComponentImplementation(NavigationalStateComponent, 
JetspeedNavigationalStateComponent,
  new Parameter[] {new ConstantParameter(navStateClass), new 
ConstantParameter(navigationKeys)} )
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [J2] RenderURL and ActionURL broken?

2004-04-01 Thread David Sean Taylor
On Thursday, April 1, 2004, at 03:57  AM, [EMAIL PROTECTED] wrote:

Just checked out the latest cvs.
RenderURL and ActionURL tags don't render parameters anymore.
I noticed David been busy with the NavigationState and PortletURL 
implementation
so probably thats not finished yet ;-)

Any idea when this is going to work again?

Right now
Do a cvs update
I didn't mean to check in the session-based impl of NavigationalState 
as the active component
Still under development

A side note related to actionURL parameters:
Before these above changes I had an actionURL parameter which name was 
being
prefix with Pluto_17_ (17 being the id of my portlet).
Because of this prefix my portlet can't find its action parameters.
Any idea where this comes from (pluto or jetspeed) and how this can be 
resolved?
(maybe I should enter an issue in Jira?)

Sure, go ahead and report an issue
I'll be working closely with URLs over then next week
Your help is much appreciated.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-jetspeed-2/portal/src/java/org/apache/jetspeed/services/information PortletURLProviderImpl.java

2004-04-01 Thread taylor
taylor  2004/04/01 09:18:46

  Modified:portal/src/java/org/apache/jetspeed/container/url/impl
PortalControlParameter.java PortalURLImpl.java
   portal/src/java/org/apache/jetspeed/container/session/impl
PathNavigationalState.java
SessionNavigationalState.java
   portal/src/java/org/apache/jetspeed/container/session
NavigationalState.java
   portal/src/java/org/apache/jetspeed/services/information
PortletURLProviderImpl.java
  Added:   portal/src/java/org/apache/jetspeed/container/session/impl
AbstractNavigationalState.java
  Log:
  - abstracting inteface between navigational state components

  - fixed bug in PortletURLProvider as reported by Ate Douma

  - continuing test cases an implementation of SessionNavigationalState and 
PathNavigationalState

  

  PR:

  Obtained from:

  Submitted by: 

  Reviewed by:  

  CVS: --

  CVS: PR:

  CVS:   If this change addresses a PR in the problem report tracking

  CVS:   database, then enter the PR number(s) here.

  CVS: Obtained from:

  CVS:   If this change has been taken from another system, such as NCSA,

  CVS:   then name the system in this line, otherwise delete it.

  CVS: Submitted by:

  CVS:   If this code has been contributed to Apache by someone else; i.e.,

  CVS:   they sent us a patch or a new module, then include their name/email

  CVS:   address here. If this is your work then delete this line.

  CVS: Reviewed by:

  CVS:   If we are doing pre-commit code reviews and someone else has

  CVS:   reviewed your changes, include their name(s) here.

  CVS:   If you have not had it reviewed then delete this line.

  
  Revision  ChangesPath
  1.3   +25 -24
jakarta-jetspeed-2/portal/src/java/org/apache/jetspeed/container/url/impl/PortalControlParameter.java
  
  Index: PortalControlParameter.java
  ===
  RCS file: 
/home/cvs/jakarta-jetspeed-2/portal/src/java/org/apache/jetspeed/container/url/impl/PortalControlParameter.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- PortalControlParameter.java   31 Mar 2004 06:19:08 -  1.2
  +++ PortalControlParameter.java   1 Apr 2004 17:18:44 -   1.3
  @@ -18,6 +18,7 @@
   import java.util.ArrayList;
   import java.util.HashMap;
   import java.util.Iterator;
  +import java.util.List;
   import java.util.Map;
   import java.util.StringTokenizer;
   
  @@ -175,7 +176,7 @@
   
   public Iterator getRenderParamNames(PortletWindow window)
   {
  -ArrayList returnvalue = new ArrayList();
  +List returnvalue = new ArrayList();
   String prefix = getRenderParamKey(window);
   Iterator keyIterator = stateFullControlParameter.keySet().iterator();
   
  @@ -296,28 +297,6 @@
   return nav.getNavigationKey(NavigationalStateComponent.ID);
   }
   
  -public boolean isControlParameter(String param)
  -{
  -return 
param.startsWith(nav.getNavigationKey(NavigationalStateComponent.PREFIX));
  -}
  -
  -public boolean isStateFullParameter(String param)
  -{
  -if (isControlParameter(param))
  -{
  -String prefix = 
nav.getNavigationKey(NavigationalStateComponent.PREFIX);
  -if ((param.startsWith(prefix + 
nav.getNavigationKey(NavigationalStateComponent.MODE)))
  -|| (param.startsWith(prefix + 
nav.getNavigationKey(NavigationalStateComponent.PREV_MODE)))
  -|| (param.startsWith(prefix + 
nav.getNavigationKey(NavigationalStateComponent.STATE)))
  -|| (param.startsWith(prefix + 
nav.getNavigationKey(NavigationalStateComponent.PREV_STATE)))
  -|| (param.startsWith(prefix + 
nav.getNavigationKey(NavigationalStateComponent.RENDER_PARAM
  -{
  -return true;
  -}
  -}
  -return false;
  -}
  -
   public String decodeParameterName(String paramName)
   {
   int length = 
nav.getNavigationKey(NavigationalStateComponent.PREFIX).length();
  @@ -406,6 +385,28 @@
   value = StringUtils.replace(value, _, 0x1);
   value = StringUtils.replace(value, ., 0x2);
   return value;
  +}
  +
  +public boolean isNavigationalParameter(String token)
  +{
  +return 
token.startsWith(nav.getNavigationKey(NavigationalStateComponent.PREFIX));
  +}
  +
  +public boolean isStateFullParameter(String param)
  +{
  +if (isNavigationalParameter(param))
  +{
  +String prefix = 
nav.getNavigationKey(NavigationalStateComponent.PREFIX);
  +if ((param.startsWith(prefix + 

cvs commit: jakarta-jetspeed-2/applications/pam/src/java/org/apache/jetspeed/apps/pam PortletApplicationBrowser.java

2004-04-01 Thread taylor
taylor  2004/04/01 09:22:48

  Modified:applications/pam/src/java/org/apache/jetspeed/apps/pam
PortletApplicationBrowser.java
  Log:
  testing out PortletMode and WindowState

  

  PR:

  Obtained from:

  Submitted by: 

  Reviewed by:  

  CVS: --

  CVS: PR:

  CVS:   If this change addresses a PR in the problem report tracking

  CVS:   database, then enter the PR number(s) here.

  CVS: Obtained from:

  CVS:   If this change has been taken from another system, such as NCSA,

  CVS:   then name the system in this line, otherwise delete it.

  CVS: Submitted by:

  CVS:   If this code has been contributed to Apache by someone else; i.e.,

  CVS:   they sent us a patch or a new module, then include their name/email

  CVS:   address here. If this is your work then delete this line.

  CVS: Reviewed by:

  CVS:   If we are doing pre-commit code reviews and someone else has

  CVS:   reviewed your changes, include their name(s) here.

  CVS:   If you have not had it reviewed then delete this line.

  
  Revision  ChangesPath
  1.5   +6 -2  
jakarta-jetspeed-2/applications/pam/src/java/org/apache/jetspeed/apps/pam/PortletApplicationBrowser.java
  
  Index: PortletApplicationBrowser.java
  ===
  RCS file: 
/home/cvs/jakarta-jetspeed-2/applications/pam/src/java/org/apache/jetspeed/apps/pam/PortletApplicationBrowser.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- PortletApplicationBrowser.java8 Mar 2004 00:05:43 -   1.4
  +++ PortletApplicationBrowser.java1 Apr 2004 17:22:48 -   1.5
  @@ -25,10 +25,12 @@
   import javax.portlet.PortletConfig;
   import javax.portlet.PortletContext;
   import javax.portlet.PortletException;
  +import javax.portlet.PortletMode;
   import javax.portlet.PortletRequestDispatcher;
   import javax.portlet.PortletURL;
   import javax.portlet.RenderRequest;
   import javax.portlet.RenderResponse;
  +import javax.portlet.WindowState;
   
   //import org.apache.jetspeed.cps.util.Streams;
   
  @@ -76,7 +78,9 @@
   
   PortletURL url = response.createRenderURL();
   PortletURL actionUrl = response.createActionURL();
  -
  +url.setWindowState(WindowState.MAXIMIZED);
  +actionUrl.setPortletMode(PortletMode.EDIT);
  +
   // url.addParameter(test, value);
   
   response.getWriter().println(br/bInit Param 'Template' =  + 
this.getInitParameter(template) +  /b);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [J2] RenderURL and ActionURL broken?

2004-04-01 Thread ate
David Sean Taylor wrote:
 On Thursday, April 1, 2004, at 03:57  AM, [EMAIL PROTECTED] wrote:
 
 Just checked out the latest cvs.
 RenderURL and ActionURL tags don't render parameters anymore.
 I noticed David been busy with the NavigationState and PortletURL
 implementation
 so probably thats not finished yet ;-)
 
 Any idea when this is going to work again?
 
 Right now
 Do a cvs update

Thanks. I'll check it out.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-jetspeed/docs/site administration.html application-development.html branches.html catalog.html changes.html client-media.html code-standards.html community-portlets.html config_guide.html config_skin.html config_skin_param_summary.html content-syndication.html contributors.html customizer.html developer-notes.html diskcache.html faq.html features.html forwards.html icalendar.html index.html install.html jars.html layout.html license.html override_props.html portlet_config_AppletPortlet.html portlet_config_DBBrowser.html portlet_config_HTML.html portlet_config_JSP.html portlet_config_LogfileViewer.html portlet_config_PSMLBrowser.html portlet_config_RSS.html portlet_config_Velocity.html portlet_config_WebClippingPortlet.html portlet_config_WebPagePortlet.html portlet_config_XSL.html portlet_config_common.html psml.html psml_db.html registry.html registry_syntax.html registry_xml.html resources.html security.html supporting-projects.html todo.html uml.html usejetspeed.html wap.html

2004-04-01 Thread morciuch
morciuch2004/04/01 10:51:11

  Modified:docs/site administration.html application-development.html
branches.html catalog.html changes.html
client-media.html code-standards.html
community-portlets.html config_guide.html
config_skin.html config_skin_param_summary.html
content-syndication.html contributors.html
customizer.html developer-notes.html diskcache.html
faq.html features.html forwards.html icalendar.html
index.html install.html jars.html layout.html
license.html override_props.html
portlet_config_AppletPortlet.html
portlet_config_DBBrowser.html
portlet_config_HTML.html portlet_config_JSP.html
portlet_config_LogfileViewer.html
portlet_config_PSMLBrowser.html
portlet_config_RSS.html
portlet_config_Velocity.html
portlet_config_WebClippingPortlet.html
portlet_config_WebPagePortlet.html
portlet_config_XSL.html portlet_config_common.html
psml.html psml_db.html registry.html
registry_syntax.html registry_xml.html
resources.html security.html
supporting-projects.html todo.html uml.html
usejetspeed.html wap.html
  Log:
  Point bug database to JIRA
  
  Revision  ChangesPath
  1.33  +4 -18 jakarta-jetspeed/docs/site/administration.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/administration.html.diff?r1=1.32r2=1.33
  
  
  1.33  +4 -18 jakarta-jetspeed/docs/site/application-development.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/application-development.html.diff?r1=1.32r2=1.33
  
  
  1.33  +4 -18 jakarta-jetspeed/docs/site/branches.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/branches.html.diff?r1=1.32r2=1.33
  
  
  1.27  +4 -18 jakarta-jetspeed/docs/site/catalog.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/catalog.html.diff?r1=1.26r2=1.27
  
  
  1.162 +13 -18jakarta-jetspeed/docs/site/changes.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/changes.html.diff?r1=1.161r2=1.162
  
  
  1.11  +4 -18 jakarta-jetspeed/docs/site/client-media.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/client-media.html.diff?r1=1.10r2=1.11
  
  
  1.41  +4 -18 jakarta-jetspeed/docs/site/code-standards.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/code-standards.html.diff?r1=1.40r2=1.41
  
  
  1.4   +4 -18 jakarta-jetspeed/docs/site/community-portlets.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/community-portlets.html.diff?r1=1.3r2=1.4
  
  
  1.36  +4 -18 jakarta-jetspeed/docs/site/config_guide.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/config_guide.html.diff?r1=1.35r2=1.36
  
  
  1.22  +4 -18 jakarta-jetspeed/docs/site/config_skin.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/config_skin.html.diff?r1=1.21r2=1.22
  
  
  1.23  +4 -18 jakarta-jetspeed/docs/site/config_skin_param_summary.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/config_skin_param_summary.html.diff?r1=1.22r2=1.23
  
  
  1.33  +4 -18 jakarta-jetspeed/docs/site/content-syndication.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/content-syndication.html.diff?r1=1.32r2=1.33
  
  
  1.39  +4 -18 jakarta-jetspeed/docs/site/contributors.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/contributors.html.diff?r1=1.38r2=1.39
  
  
  1.34  +4 -18 jakarta-jetspeed/docs/site/customizer.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/customizer.html.diff?r1=1.33r2=1.34
  
  
  1.32  +4 -18 jakarta-jetspeed/docs/site/developer-notes.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/developer-notes.html.diff?r1=1.31r2=1.32
  
  
  1.34  +4 -18 jakarta-jetspeed/docs/site/diskcache.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/diskcache.html.diff?r1=1.33r2=1.34
  
  
  1.43  +4 -18 jakarta-jetspeed/docs/site/faq.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/faq.html.diff?r1=1.42r2=1.43
  
  
  1.34  +4 -18 jakarta-jetspeed/docs/site/features.html
  
  
http://cvs.apache.org/viewcvs/jakarta-jetspeed/docs/site/features.html.diff?r1=1.33r2=1.34
  
  
  1.8   +4 -18 jakarta-jetspeed/docs/site/forwards.html
  
  

cvs commit: jakarta-jetspeed/xdocs/stylesheets project.xml

2004-04-01 Thread morciuch
morciuch2004/04/01 10:52:53

  Modified:xdocs/stylesheets project.xml
  Log:
  Point bug database to JIRA
  
  Revision  ChangesPath
  1.23  +1 -1  jakarta-jetspeed/xdocs/stylesheets/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-jetspeed/xdocs/stylesheets/project.xml,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- project.xml   17 Mar 2004 21:27:24 -  1.22
  +++ project.xml   1 Apr 2004 18:52:53 -   1.23
  @@ -64,7 +64,7 @@
   item name=View CVS  
href=http://cvs.apache.org/viewcvs/jakarta-jetspeed//
   item name=CVS Branches  href=/branches.html/
   item name=Coding Spec   href=/code-standards.html/
  -item name=Bug Database  
href=http://issues.apache.org/bugzilla/buglist.cgi?product=jetspeed/ 
  +item name=Bug Database  
href=http://nagoya.apache.org/jira/secure/BrowseProject.jspa?id=10493/ 
   /menu
   /body
   /project
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[J2] Bug: render called twice after an actionRequest

2004-04-01 Thread ate
I just noticed that a portlet render method is called twice as result of an
ActionRequest.
Furthermore, the RenderRequest contains all the ActionRequest parameters as
well (which is a violation of the specs).
Debugging isn't so easy as the render events happen in seperate
o.a.j.aggregator.impl.Worker threads.
I know Pluto will send a redirect after a processAction so I'm a bit puzzled
where this is coming from.

This is partically troublesome as I'm currently trying to implement Struts
as a Jetspeed portlet in which I perform Struts action  processing from
processAction and Struts view rendering from doView. Because I need to
transport render information over from the processAction to the doView
handling I put these temporarily in the session. The doView handling removes
it from the session on first usage (just like Struts can temporarily store
its messages in the session).
Now with the doView being called twice this setup clearly is falling apart.

Hopefully someone has an idea?

I've already created an issue for this:
  http://nagoya.apache.org/jira/browse/JS2-5

Thanks, Ate



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [J2] Bug: render called twice after an actionRequest

2004-04-01 Thread David Sean Taylor
On Thursday, April 1, 2004, at 12:34  PM, [EMAIL PROTECTED] wrote:

I just noticed that a portlet render method is called twice as result 
of an
ActionRequest.
That shouldn't happen.
Im in the middle of refactoring and componentizing the navigation and 
URL code, so its very likely things will break.
Im putting in unit tests around all the components
Very much appreciate your help here, but please bear with me for a few 
days while I transition the code to a more manageable state
and decouple the navigational state from Pluto's implementation.

Furthermore, the RenderRequest contains all the ActionRequest 
parameters as
well (which is a violation of the specs).
Yes I know about that.
Log it as a bug if you'd like.
I just opened it up so that post parameters made it back and so portlet 
developers could write portlets that use form processing now

Debugging isn't so easy as the render events happen in seperate
o.a.j.aggregator.impl.Worker threads.
Have you tried debugging with Eclipse 3.0? It handles multithreading 
nicely.
Or try changing the aggregator component's algorithm to single threaded 
to make debugging easier

I know Pluto will send a redirect after a processAction so I'm a bit 
puzzled
where this is coming from.

This is partically troublesome as I'm currently trying to implement 
Struts
as a Jetspeed portlet in which I perform Struts action  processing from
processAction and Struts view rendering from doView. Because I need to
transport render information over from the processAction to the doView
handling I put these temporarily in the session. The doView handling 
removes
it from the session on first usage (just like Struts can temporarily 
store
its messages in the session).
Now with the doView being called twice this setup clearly is falling 
apart.

This sounds very interesting.
Will this be a general solution that you plan on contributing to J2?
I think a Jetspeed/Struts portlet application framework is a valuable 
contribution.

Hopefully someone has an idea?

Yes, Im pretty much dedicated to working on cleaning up this part of 
the code over the next week.
No big deal, it will get fixed soon. Im with a client today and 
tomorrow though

I've already created an issue for this:
  http://nagoya.apache.org/jira/browse/JS2-5
Thanks

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


JIRA

2004-04-01 Thread David Sean Taylor
It appears that none of us (Jetspeed committers)  can assign issues, or 
change the status of  issues in JIRA.
Guess I missed something when working with infrastructure on setting it 
up.

I just created an issue in JIRA under Infrastructure/JIRA

http://nagoya.apache.org/jira/browse/INFRA-55

Hope to get this issue resolved soon
Sorry about that
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-jetspeed-2/applications/demo/src/java/org/apache/jetspeed/demo/customerInfo CustomerPortlet.java

2004-04-01 Thread taylor
taylor  2004/04/01 17:03:37

  Modified:applications/demo/src/java/org/apache/jetspeed/demo/customerInfo
CustomerPortlet.java
  Log:
  trying out application scope for session variables
bug is JS2-1 is still there, narrowing it down

  CVS: --
  CVS: PR:
  CVS:   If this change addresses a PR in the problem report tracking
  CVS:   database, then enter the PR number(s) here.
  CVS: Obtained from:
  CVS:   If this change has been taken from another system, such as NCSA,
  CVS:   then name the system in this line, otherwise delete it.
  CVS: Submitted by:
  CVS:   If this code has been contributed to Apache by someone else; i.e.,
  CVS:   they sent us a patch or a new module, then include their name/email
  CVS:   address here. If this is your work then delete this line.
  CVS: Reviewed by:
  CVS:   If we are doing pre-commit code reviews and someone else has
  CVS:   reviewed your changes, include their name(s) here.
  CVS:   If you have not had it reviewed then delete this line.
  
  Revision  ChangesPath
  1.3   +8 -2  
jakarta-jetspeed-2/applications/demo/src/java/org/apache/jetspeed/demo/customerInfo/CustomerPortlet.java
  
  Index: CustomerPortlet.java
  ===
  RCS file: 
/home/cvs/jakarta-jetspeed-2/applications/demo/src/java/org/apache/jetspeed/demo/customerInfo/CustomerPortlet.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- CustomerPortlet.java  8 Mar 2004 00:03:59 -   1.2
  +++ CustomerPortlet.java  2 Apr 2004 01:03:37 -   1.3
  @@ -140,8 +140,14 @@
   PortletSession portletSession = request.getPortletSession();
   if (portletSession != null)
   {
  -customerList = (List) portletSession.getAttribute(CustomerList);
  +customerList = (List) portletSession.getAttribute(CustomerList, 
PortletSession.APPLICATION_SCOPE);
  +if (customerList == null)
  +{
  +customerList = this.defaultCustomers;
  +portletSession.setAttribute(CustomerList, this.defaultCustomers, 
PortletSession.APPLICATION_SCOPE);
  +}
   }
  +
   else
   {
   // TODO:  the portletSession == null?
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-jetspeed-2/portal/src/webapp/pages/pam - New directory

2004-04-01 Thread taylor
taylor  2004/04/01 17:27:14

  jakarta-jetspeed-2/portal/src/webapp/pages/pam - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [J2] Bug: render called twice after an actionRequest

2004-04-01 Thread ate
David Sean Taylor wrote:
 On Thursday, April 1, 2004, at 12:34  PM, [EMAIL PROTECTED] wrote:

 I just noticed that a portlet render method is called twice as result
 of an
 ActionRequest.

 That shouldn't happen.
 Im in the middle of refactoring and componentizing the navigation and
 URL code, so its very likely things will break.
 Im putting in unit tests around all the components
 Very much appreciate your help here, but please bear with me for a few
 days while I transition the code to a more manageable state
 and decouple the navigational state from Pluto's implementation.


I know. I haven't much time left though for my Struts portlet framework so I
will delve into it
myself also. I will report back anything important I encounter if you don't
mind :-)

 Have you tried debugging with Eclipse 3.0? It handles multithreading
 nicely.

Well, yeah, I'm using Eclipse 3 now but I'm still getting used to it as I
come from IntelliJ
(painfully missing a few fine features now and then).

 Or try changing the aggregator component's algorithm to single
 threaded to make debugging easier

That's a good hint, didn't think of that. Is it configurable or do I have to
modify the code for it?
I'll check it out.

 This is partically troublesome as I'm currently trying to implement
 Struts
 as a Jetspeed portlet in which I perform Struts action  processing
 from processAction and Struts view rendering from doView.

 This sounds very interesting.
 Will this be a general solution that you plan on contributing to J2?
 I think a Jetspeed/Struts portlet application framework is a valuable
 contribution.

Sure, I'll contribute it to Jetspeed (I already promised so before).

How much of a general solution it will be I don't know yet. There will be
some restrictions for Struts usage mainly because of portlet restrictions in
general.
Furthermore, I'm not trying to port existing standalone Struts applications
but to
provide a framework for new Struts porlet development based on the current
head
version of Struts (well, I'm currently using the non-released Struts 1.2
version).
As test case though I'm using the Struts MessageReader example.

I'm not sure yet though if I should submit it to Jetspeed as a whole
or partly also to Struts (if they are interested).
This will be part Jetspeed adaption and part Struts modifications/extensions
to allow Struts work within a Portlet (mainly a specialized
RequestProcessor, handling of URL's and delayed view rendering).


 Hopefully someone has an idea?

 Yes, Im pretty much dedicated to working on cleaning up this part of
 the code over the next week.

Great. With a bit of luck I will be able to get a basic, first version of
the Struts Portlet framework for J2 up and running by then.

Ate



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: AW: J1: serving binary files through a portlet?

2004-04-01 Thread Sami Leino
 Which version of Jetspeed do you use?

1.4 release, with few post-1.4 patches (pluggable ProfileLocator support).

-- 

Sami Leino
Software Developer
Netorek Oy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]