Re: -XaddExports: not recognized in JavaVMInitArgs on Windows
On 03/03/2016 23:55, Mandy Chung wrote: : It’s a known open issue (I couldn’t find from JBS yet and will file one). The issue is tracked as JDK-8136930 [1], the main issue is whether there is a documented way for custom launchers to do the equivalent of the launcher -X options. For now then just set the property as Mandy pointed out. -Alan [1] https://bugs.openjdk.java.net/browse/JDK-8136930
hg: jigsaw/jake/nashorn: removed -Xpatch and -Xbootclasspath options in nasgen tool invocation.
Changeset: 64016e0013ca Author:sundar Date: 2016-03-04 10:36 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/64016e0013ca removed -Xpatch and -Xbootclasspath options in nasgen tool invocation. ! make/BuildNashorn.gmk
Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module
> On Mar 3, 2016, at 7:36 PM, David DeHaven wrote: > > > Updated webrev: > http://cr.openjdk.java.net/~ddehaven/8132743/webrev.1/ > Looks fine to me. Thanks for the update. thanks Mandy
Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module
Updated webrev:
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.1/
Added jdk.jsobject to MAIN_MODULES
Made suggested Javadoc changes
Gave JSException a real serialVersionUID
-DrD-
> On Mar 3, 2016, at 5:06 PM, David DeHaven wrote:
>
>
> Adding it to MAIN_MODULES, I now see it in bootmodules.jimage:
> /jdk.jsobject/jdk/internal/netscape/javascript/spi/JSObjectProvider.class
> /jdk.jsobject/netscape/javascript/JSException.class
> /jdk.jsobject/netscape/javascript/JSObject$ProviderLoader$1.class
> /jdk.jsobject/netscape/javascript/JSObject$ProviderLoader.class
> /jdk.jsobject/netscape/javascript/JSObject.class
>
> -DrD-
>
>> jdk9-dev is not the right mailing list. I bcc’ed it and add jigsaw-dev
>> instead.
>>
>>
>>> On Mar 3, 2016, at 3:57 PM, Kevin Rushforth
>>> wrote:
>>>
>>> Looks OK to me. I did a quick test build and I can see the new package in
>>> the exploded JDK, but not in the images. Maybe I did something wrong?
>>>
>>
>> Good catch.
>>
>> jdk.jsobject needs to be added in MAIN_MODULES list in make/Images.gmk
>>
>> Mandy
>>
>>> -- Kevin
>>>
>>>
>>> David DeHaven wrote:
>> JBS Issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8132743
>>
>>
>> Code review:
>>
>> http://cr.openjdk.java.net/~ddehaven/8132743/webrev.0/
>>
>>
>>
> Looks okay. There is no @since - I guess it’s okay because
> netscape.javascript has been shipped with plugin for long time.
>
>
I can't track down when it was first included. It pre-dates anything I've
looked at so far.
> package-info.java
> "when running in an {@link java.applet.Applet Applet}” - is this true
> when running with JavaFX webkit?
>
>
Yes, I believe so, assuming you have a JSObject representing the root
window object. Maybe that should be reworded, I think just remove the
"when running in an Applet" part.
> JSObject.java
> @throws JSException is missing in the methods
>
> Does it throw NPE if the parameter is null? Or JSException - that needs
> to be specified.
>
> Nit: it’d be good to wrap null with {@code null} in the javadoc.
>
>
Ok. I can fix that.
-DrD-
>>
>
hg: jigsaw/jake/nashorn: removed compile time, runtime dependency from nasgen tool to nashorn code. Nashorn .class files are treated as just data files by nasgen tool.
Changeset: a67ceefb5a7b Author:sundar Date: 2016-03-04 07:41 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a67ceefb5a7b removed compile time, runtime dependency from nasgen tool to nashorn code. Nashorn .class files are treated as just data files by nasgen tool. ! buildtools/nasgen/build.xml ! buildtools/nasgen/project.properties ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MemberInfo.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfo.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfoCollector.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java + buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/Where.java ! make/build-nasgen.xml ! make/build.xml ! make/project.properties
hg: jigsaw/jake/langtools: Test cleanup to add @modules
Changeset: c1a5259e9c75 Author:mchung Date: 2016-03-03 17:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c1a5259e9c75 Test cleanup to add @modules ! test/jdk/jshell/InferTypeTest.java
Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module
Adding it to MAIN_MODULES, I now see it in bootmodules.jimage:
/jdk.jsobject/jdk/internal/netscape/javascript/spi/JSObjectProvider.class
/jdk.jsobject/netscape/javascript/JSException.class
/jdk.jsobject/netscape/javascript/JSObject$ProviderLoader$1.class
/jdk.jsobject/netscape/javascript/JSObject$ProviderLoader.class
/jdk.jsobject/netscape/javascript/JSObject.class
-DrD-
> jdk9-dev is not the right mailing list. I bcc’ed it and add jigsaw-dev
> instead.
>
>
>> On Mar 3, 2016, at 3:57 PM, Kevin Rushforth
>> wrote:
>>
>> Looks OK to me. I did a quick test build and I can see the new package in
>> the exploded JDK, but not in the images. Maybe I did something wrong?
>>
>
> Good catch.
>
> jdk.jsobject needs to be added in MAIN_MODULES list in make/Images.gmk
>
> Mandy
>
>> -- Kevin
>>
>>
>> David DeHaven wrote:
> JBS Issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8132743
>
>
> Code review:
>
> http://cr.openjdk.java.net/~ddehaven/8132743/webrev.0/
>
>
>
Looks okay. There is no @since - I guess it’s okay because
netscape.javascript has been shipped with plugin for long time.
>>>
>>> I can't track down when it was first included. It pre-dates anything I've
>>> looked at so far.
>>>
>>>
>>>
>>>
package-info.java
"when running in an {@link java.applet.Applet Applet}” - is this true
when running with JavaFX webkit?
>>>
>>> Yes, I believe so, assuming you have a JSObject representing the root
>>> window object. Maybe that should be reworded, I think just remove the "when
>>> running in an Applet" part.
>>>
>>>
>>>
>>>
JSObject.java
@throws JSException is missing in the methods
Does it throw NPE if the parameter is null? Or JSException - that needs
to be specified.
Nit: it’d be good to wrap null with {@code null} in the javadoc.
>>>
>>> Ok. I can fix that.
>>>
>>> -DrD-
>>>
>>>
>>>
>
Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module
> jdk9-dev is not the right mailing list. I bcc’ed it and add jigsaw-dev > instead. > > >> On Mar 3, 2016, at 3:57 PM, Kevin Rushforth >> wrote: >> >> Looks OK to me. I did a quick test build and I can see the new package in >> the exploded JDK, but not in the images. Maybe I did something wrong? >> > > Good catch. > > jdk.jsobject needs to be added in MAIN_MODULES list in make/Images.gmk Ok, I'll fix that too. -DrD-
Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module
jdk9-dev is not the right mailing list. I bcc’ed it and add jigsaw-dev instead.
> On Mar 3, 2016, at 3:57 PM, Kevin Rushforth
> wrote:
>
> Looks OK to me. I did a quick test build and I can see the new package in the
> exploded JDK, but not in the images. Maybe I did something wrong?
>
Good catch.
jdk.jsobject needs to be added in MAIN_MODULES list in make/Images.gmk
Mandy
> -- Kevin
>
>
> David DeHaven wrote:
JBS Issue:
https://bugs.openjdk.java.net/browse/JDK-8132743
Code review:
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.0/
>>> Looks okay. There is no @since - I guess it’s okay because
>>> netscape.javascript has been shipped with plugin for long time.
>>>
>>>
>>
>> I can't track down when it was first included. It pre-dates anything I've
>> looked at so far.
>>
>>
>>
>>
>>> package-info.java
>>>"when running in an {@link java.applet.Applet Applet}” - is this true
>>> when running with JavaFX webkit?
>>>
>>>
>>
>> Yes, I believe so, assuming you have a JSObject representing the root window
>> object. Maybe that should be reworded, I think just remove the "when running
>> in an Applet" part.
>>
>>
>>
>>
>>> JSObject.java
>>> @throws JSException is missing in the methods
>>>
>>> Does it throw NPE if the parameter is null? Or JSException - that needs
>>> to be specified.
>>>
>>> Nit: it’d be good to wrap null with {@code null} in the javadoc.
>>>
>>>
>>
>> Ok. I can fix that.
>>
>> -DrD-
>>
>>
>>
Re: RFR: JDK-8150998: Fix module dependences in java/lang tests
Shura, > On Mar 3, 2016, at 12:11 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > Could you please have another look on the webrev. > > http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.03/ > http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.03/ I have pushed the patch in webrev.jdk9.03. > I have addressed all the comments except moving the fix of > test/java/lang/management/MemoryMXBean/PendingAllGC.sh to JDK9, as this test > is already different in JDK9 and Jake, so a fix in JDK9 will be overridden. 30 # @modules java.base/jdk.internal.misc This change should also be in JDK 9 as well. Anyway, I pushed the patch from webrev.jake.03 to jake except FieldSetAccessibleTest.java. Another alternative is to get the modules in the boot layer Layer.boot().stream().map(Module::getName) Mandy
hg: jigsaw/jake/jdk: Minor clean up on test module dependences
Changeset: be591147fb87 Author:shurailine Date: 2016-03-03 16:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/be591147fb87 Minor clean up on test module dependences ! test/java/lang/Class/GetModuleTest.java ! test/java/lang/management/MemoryMXBean/PendingAllGC.sh
Re: -XaddExports: not recognized in JavaVMInitArgs on Windows
> On Mar 3, 2016, at 2:49 PM, Keimpe Bronkhorst > wrote: > > I'm using build 9-ea+107-jigsaw-nightly-h4560-20160301 on Windows. > > I'm executing my program through jvm.dll using JavaVMInitArgs and JNI. I set > JavaVMInitArgs.ignoreUnrecognized = JNI_FALSE and add > -XaddExports:java.desktop/sun.awt=ALL-UNNAMED as one of the > JavaVMInitArgs.options. > > This results in Unrecognized option: > -XaddExports:java.desktop/sun.awt=ALL-UNNAMED > In the current implementation, -XaddExports is a launcher option, not a VM option. For custom launchers, it’s yet to decide whether the equivalent of -XaddExports. For now, you can pass -Djdk.launcher.addexports.=/= $N is a unique number starting from 0, one system property per /. For example -Djdk.launcher.addexports.0=java.desktop/sun.awt=ALL-UNNAMED > If use JavaVMInitArgs.ignoreUnrecognized = JNI_TRUE, I run into the exception: > Exception breakpoint: Reflection.java:467, java.lang.IllegalAccessException, > class org.openide.util.RequestProcessor$TopLevelThreadGroup cannot access > class sun.awt.AppContext (in module java.desktop) because module java.desktop > does not export sun.awt to unnamed module @204f30ec > > Is this a known limitation at this time or should I file a bug? It’s a known open issue (I couldn’t find from JBS yet and will file one). Mandy
hg: jigsaw/jake/hotspot: Continued clean up for JVM's jigsaw support as part of feedback from internal review.
Changeset: d66480af11d0 Author:lfoltan Date: 2016-03-03 18:11 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d66480af11d0 Continued clean up for JVM's jigsaw support as part of feedback from internal review. ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/klassFactory.cpp ! src/share/vm/classfile/moduleEntry.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp
-XaddExports: not recognized in JavaVMInitArgs on Windows
I'm using build 9-ea+107-jigsaw-nightly-h4560-20160301 on Windows. I'm executing my program through jvm.dll using JavaVMInitArgs and JNI. I set JavaVMInitArgs.ignoreUnrecognized = JNI_FALSE and add -XaddExports:java.desktop/sun.awt=ALL-UNNAMED as one of the JavaVMInitArgs.options. This results in Unrecognized option: -XaddExports:java.desktop/sun.awt=ALL-UNNAMED If use JavaVMInitArgs.ignoreUnrecognized = JNI_TRUE, I run into the exception: Exception breakpoint: Reflection.java:467, java.lang.IllegalAccessException, class org.openide.util.RequestProcessor$TopLevelThreadGroup cannot access class sun.awt.AppContext (in module java.desktop) because module java.desktop does not export sun.awt to unnamed module @204f30ec Is this a known limitation at this time or should I file a bug? Keimpe Bronkhorst
hg: jigsaw/jake/nashorn: 6 new changesets
Changeset: 93854b0b5e5e Author:sundar Date: 2016-02-25 13:56 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/93854b0b5e5e 8148379: jdk.nashorn.api.scripting spec. adjustments, clarifications Reviewed-by: hannesw, mhaupt ! make/build.xml ! make/project.properties ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/AbstractJSObject.java ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/JSObject.java ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/NashornException.java ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/ScriptUtils.java ! test/script/basic/JDK-8026367.js Changeset: a797fcfb7780 Author:lana Date: 2016-02-25 11:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a797fcfb7780 Merge Changeset: 58409eff7e3e Author:mhaupt Date: 2016-02-29 09:49 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/58409eff7e3e 8150814: correct package declaration in Nashorn test Reviewed-by: sundar ! test/src/jdk/nashorn/api/scripting/test/JDK_8148140_Test.java Changeset: e63f20c52128 Author:henryjen Date: 2016-03-02 21:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/e63f20c52128 Merge ! make/build.xml ! make/project.properties Changeset: 10d21e3ecd4f Author:lana Date: 2016-03-03 12:26 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/10d21e3ecd4f Added tag jdk-9+108 for changeset 58409eff7e3e ! .hgtags Changeset: e9c8b229c463 Author:mchung Date: 2016-03-03 12:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/e9c8b229c463 Merge ! .hgtags - src/jdk.scripting.nashorn/share/classes/META-INF/MANIFEST.MF - src/jdk.scripting.nashorn/share/classes/META-INF/services/javax.script.ScriptEngineFactory
hg: jigsaw/jake/jdk: 31 new changesets
Changeset: b9b28d7137cd Author:ihse Date: 2016-02-22 11:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b9b28d7137cd 8150203: Incremental update from build-infra project Reviewed-by: erikj ! make/gensrc/GensrcMisc.gmk ! make/lib/Awt2dLibraries.gmk ! make/lib/CoreLibraries.gmk ! make/lib/Lib-java.instrument.gmk ! make/lib/Lib-jdk.jdi.gmk ! make/lib/Lib-jdk.jdwp.agent.gmk ! make/src/classes/build/tools/dtdbuilder/DTDParser.java Changeset: 0b0518bff70c Author:amlu Date: 2016-02-23 09:52 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0b0518bff70c 8149154: tools/pack200/Pack200Test.java failed with NullPointerException Reviewed-by: ksrini ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/Utils.java Changeset: 4d1292a702b8 Author:mhaupt Date: 2016-02-23 07:17 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4d1292a702b8 8150360: augment/correct MethodHandle API documentation Reviewed-by: psandoz ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java Changeset: 8096d018a9a5 Author:peytoia Date: 2016-02-23 17:09 +0900 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8096d018a9a5 8074411: Describe "minor unit" and/or "default fraction digits" in Currency class' javadoc clearly Reviewed-by: naoto, okutsu, peytoia Contributed-by: Nishit Jain ! src/java.base/share/classes/java/util/Currency.java Changeset: 9d536355b828 Author:mhaupt Date: 2016-02-23 09:49 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9d536355b828 8143410: augment pseudo-code descriptions in MethodHandles API Reviewed-by: psandoz ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java Changeset: f92af283ab18 Author:alanb Date: 2016-02-23 17:41 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f92af283ab18 6432031: Add support for SO_REUSEPORT Reviewed-by: alanb, simonis, chegar Contributed-by: yingqi...@intel.com ! make/mapfiles/libnet/mapfile-vers ! make/mapfiles/libnio/mapfile-linux ! make/mapfiles/libnio/mapfile-macosx ! make/mapfiles/libnio/mapfile-solaris ! make/src/native/genconstants/ch/genSocketOptionRegistry.c ! src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java ! src/java.base/share/classes/java/net/DatagramSocketImpl.java ! src/java.base/share/classes/java/net/MulticastSocket.java ! src/java.base/share/classes/java/net/SocketImpl.java ! src/java.base/share/classes/java/net/SocketOptions.java ! src/java.base/share/classes/java/net/StandardSocketOptions.java ! src/java.base/share/classes/jdk/net/Sockets.java ! src/java.base/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/java.base/share/native/libnet/net_util.c ! src/java.base/share/native/libnet/net_util.h ! src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java ! src/java.base/unix/classes/java/net/PlainSocketImpl.java ! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c ! src/java.base/unix/native/libnet/SdpSupport.c + src/java.base/unix/native/libnet/SocketImpl.c ! src/java.base/unix/native/libnet/net_util_md.c ! src/java.base/unix/native/libnet/net_util_md.h ! src/java.base/unix/native/libnio/ch/Net.c ! src/java.base/unix/native/libnio/ch/nio_util.h ! src/java.base/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java ! src/java.base/windows/classes/java/net/DualStackPlainSocketImpl.java ! src/java.base/windows/classes/java/net/PlainSocketImpl.java ! src/java.base/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java ! src/java.base/windows/classes/java/net/TwoStacksPlainSocketImpl.java + src/java.base/windows/native/libnet/SocketImpl.c ! src/java.base/windows/native/libnet/net_util_md.c ! src/java.base/windows/native/libnet/net_util_md.h ! src/java.base/windows/native/libnio/ch/Net.c ! test/java/net/SocketOption/OptionsTest.java ! test/java/nio/channels/AsynchronousServerSocketChannel/Basic.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java ! test/java/nio/channels/DatagramChannel/SocketOptionTests.java ! test/java/nio/channels/ServerSocketChannel/SocketOptionTests.java Changeset: c92ae3d0e6a3 Author:naoto Date: 2016-02-23 10:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c92ae3d0e6a3 8150434: Remove redundant "jdk_localedata" from the CLDR locale data meta info class name Reviewed-by: mchung ! make/src/classes/build/tools/cldrconverter/ResourceBundleGenerator.java ! src/jdk.localedata/share/classes/META-INF/servic
hg: jigsaw/jake/langtools: 16 new changesets
Changeset: 3cdfbbdb6f61 Author:vromero Date: 2016-02-22 16:17 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3cdfbbdb6f61 8149600: javac, remove unused options, step 2 Reviewed-by: jjg, mcimadamore ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties ! src/jdk.compiler/share/classes/com/sun/tools/javah/JavahTask.java ! test/tools/javac/6257443/T6257443.java - test/tools/javac/6521805/T6521805a.java - test/tools/javac/6521805/T6521805a_1.out - test/tools/javac/6521805/T6521805a_2.out ! test/tools/javac/api/taskListeners/EventsBalancedTest.java ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt - test/tools/javac/diags/examples/WarnSyntheticNameConflict.java Changeset: dd43a467134b Author:darcy Date: 2016-02-23 11:17 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dd43a467134b 8150427: Demote ToolReloadTest.java and mark as intermittently failing Reviewed-by: jjg ! test/TEST.groups ! test/jdk/jshell/ToolReloadTest.java Changeset: 700565092eb6 Author:jjg Date: 2016-02-23 16:13 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/700565092eb6 8149772: cleanup handling of -encoding in JavacFileManager Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/BaseFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java Changeset: f04e97a97930 Author:vromero Date: 2016-02-23 16:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f04e97a97930 8149328: remove the dependency on java.logging from java.compiler Reviewed-by: jjg ! src/java.compiler/share/classes/javax/tools/ToolProvider.java Changeset: 527e819dbc95 Author:jjg Date: 2016-02-23 16:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/527e819dbc95 8145472: replace remaining java.io.File with java.nio.file.Path Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Infer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/CommandLine.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/OptionHelper.java Changeset: 21d9e172e9f6 Author:jjg Date: 2016-02-23 19:17 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/21d9e172e9f6 8150475: -sourcepath / crashes javac Reviewed-by: darcy, vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java + test/tools/javac/file/T8150475.java Changeset: 7892ba7c7015 Author:lana Date: 2016-02-25 11:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7892ba7c7015 Merge - test/tools/javac/6521805/T6521805a.java - test/tools/javac/6521805/T6521805a_1.out - test/tools/javac/6521805/T6521805a_2.out - test/tools/javac/diags/examples/WarnSyntheticNameConflict.java Changeset: ddfdf0304052 Author:jlahoda Date: 2016-02-29 11:54 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ddfdf0304052 8131027: JShell API/tool: suggest imports for a class Summary: Adding two new actions to JShell: add imports and create variable. Reviewed-by: rfield ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/ConsoleIOContext.java ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java ! src/jdk.jshell/share/classes/jdk/jshell/Eval.java ! src/jdk.jshell/share/classes/jdk/jshell/JShell.java ! src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysis.java ! src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysisImpl.java ! src/jdk.jshell/share/classes/jdk/jshell/TreeDissector.java + test/jdk/jshell/ComputeFQNsTest.java + test/jdk/jshell/InferTypeTest.java ! test/jdk/jshell/KullaTesting.java Changeset: b7583d50f67d Author:alundblad Date: 2016-02-29 13:24 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b7583d50f67d 8147569: Error messages from sjavac server does not always get relayed back to client Summary: Refactored how logging works in sjavac. Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/CleanProperties.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java ! src/jdk.compiler/share/clas
hg: jigsaw/jake/corba: 2 new changesets
Changeset: b75afa17aefe Author:lana Date: 2016-03-03 12:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/b75afa17aefe Added tag jdk-9+108 for changeset 84f2862a25eb ! .hgtags Changeset: 9ba71f9ac61d Author:mchung Date: 2016-03-03 12:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/9ba71f9ac61d Merge
hg: jigsaw/jake/jaxws: 2 new changesets
Changeset: a4c1ffe5fdec Author:lana Date: 2016-03-03 12:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/a4c1ffe5fdec Added tag jdk-9+108 for changeset 513eb2e432f6 ! .hgtags Changeset: 364f3dc30f72 Author:mchung Date: 2016-03-03 12:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/364f3dc30f72 Merge
hg: jigsaw/jake/hotspot: 56 new changesets
Changeset: 45c738cde513 Author:ihse Date: 2016-02-23 21:44 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/45c738cde513 8150257: Remove softfloat lib support Reviewed-by: dholmes, erikj ! make/bsd/makefiles/arm.make Changeset: ddd51ea1a9b0 Author:thartmann Date: 2016-02-10 15:24 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ddd51ea1a9b0 8149123: [TESTBUG] compiler/loopopts/superword/SumRed* tests running on non-x86 platforms Summary: Restricted test execution to supported archs. Reviewed-by: kvn Contributed-by: Jamsheed Mohammed ! test/compiler/loopopts/superword/ProdRed_Double.java ! test/compiler/loopopts/superword/ProdRed_Float.java ! test/compiler/loopopts/superword/ProdRed_Int.java ! test/compiler/loopopts/superword/ReductionPerf.java ! test/compiler/loopopts/superword/SumRedSqrt_Double.java ! test/compiler/loopopts/superword/SumRed_Double.java ! test/compiler/loopopts/superword/SumRed_Float.java ! test/compiler/loopopts/superword/SumRed_Int.java ! test/compiler/loopopts/superword/SumRed_Long.java Changeset: 69fc70ea2f4e Author:shade Date: 2016-02-10 15:58 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/69fc70ea2f4e 8149356: Leftover from JDK-8141044: UseNewCode usage Reviewed-by: vlivanov ! src/share/vm/c1/c1_Canonicalizer.cpp Changeset: 306affd7e6c9 Author:shade Date: 2016-02-10 16:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/306affd7e6c9 Merge Changeset: b038c3bea5a4 Author:twisti Date: 2016-02-10 11:23 -1000 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b038c3bea5a4 8149415: [AArch64] implement JVMCI CodeInstaller Reviewed-by: aph, kvn ! src/cpu/aarch64/vm/jvmciCodeInstaller_aarch64.cpp ! src/cpu/aarch64/vm/nativeInst_aarch64.cpp ! src/cpu/aarch64/vm/nativeInst_aarch64.hpp ! src/jdk.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64.java ! src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotRegisterConfig.java ! src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotRegisterConfig.java ! src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/jdk/vm/ci/hotspot/sparc/SPARCHotSpotRegisterConfig.java Changeset: 1f62d2e8308f Author:thartmann Date: 2016-02-11 11:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/1f62d2e8308f 8145700: Uninitialised variable in macroAssembler_x86.cpp:7038 Summary: Added missing local variable initializations. Reviewed-by: kvn, vlivanov, thartmann, mcberg Contributed-by: Rahul Raghavan ! src/cpu/x86/vm/macroAssembler_x86.cpp Changeset: a43579055b3c Author:twisti Date: 2016-02-11 11:32 -1000 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a43579055b3c 8149695: [JVMCI] add missing Checkstyle configuration file Reviewed-by: kvn + src/jdk.vm.ci/share/classes/jdk.vm.ci.services/.checkstyle_checks.xml Changeset: e8d72190f6ba Author:twisti Date: 2016-02-11 12:29 -1000 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e8d72190f6ba 8149689: [JVMCI] CodeInstaller::pd_patch_DataSectionReference should be able to throw exceptions Reviewed-by: kvn ! src/cpu/aarch64/vm/jvmciCodeInstaller_aarch64.cpp ! src/cpu/ppc/vm/jvmciCodeInstaller_ppc.cpp ! src/cpu/sparc/vm/jvmciCodeInstaller_sparc.cpp ! src/cpu/x86/vm/jvmciCodeInstaller_x86.cpp ! src/share/vm/jvmci/jvmciCodeInstaller.cpp ! src/share/vm/jvmci/jvmciCodeInstaller.hpp Changeset: 3769c85083ca Author:thartmann Date: 2016-02-12 12:18 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3769c85083ca 8148564: compiler/intrinsics/string/TestStringIntrinsics2.java times out Summary: Test should not run with -Xcomp because MaxInlineSize is large. Reviewed-by: kvn, simonis ! test/compiler/intrinsics/string/TestStringIntrinsics2.java Changeset: 894c8b63e200 Author:roland Date: 2016-02-03 12:36 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/894c8b63e200 8143542: C2 doesn't eliminate identical checks Summary: Two identical Ifs back to back can be merged Reviewed-by: kvn ! src/share/vm/opto/castnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp Changeset: 5fefcbeda616 Author:mcberg Date: 2016-02-12 16:12 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5fefcbeda616 8149421: Vectorized Post Loops Summary: add vectorised post loop for counted loops with vectors. Reviewed-by: kvn ! src/cpu/aarch64/vm/c2_globals_aarch64.hpp ! src/cpu/ppc/vm/c2_globals_ppc.hpp ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/superword.cpp Changeset: a63cf6a69972 Author:roland Date:
hg: jigsaw/jake/jaxp: 6 new changesets
Changeset: 95c223e6eaf0 Author:joehw Date: 2016-02-22 11:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/95c223e6eaf0 8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE Reviewed-by: joehw Contributed-by: christoph.lan...@sap.com ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XML11DTDScannerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/HTTPInputSource.java + test/javax/xml/jaxp/unittest/validation/Bug8149915.xsd + test/javax/xml/jaxp/unittest/validation/SchemaTest.java Changeset: 264df5d957cd Author:clanger Date: 2016-02-24 19:25 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/264df5d957cd 8150470: JCK: api/xsl/conf/copy/copy19 test failure Reviewed-by: joehw, aefimov ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java Changeset: 3b9fa8b14914 Author:lana Date: 2016-02-25 11:27 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/3b9fa8b14914 Merge Changeset: 94b08a4d8fcc Author:henryjen Date: 2016-03-02 21:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/94b08a4d8fcc Merge Changeset: 24e247ee1fff Author:lana Date: 2016-03-03 12:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/24e247ee1fff Added tag jdk-9+108 for changeset 3b9fa8b14914 ! .hgtags Changeset: b78ff3e8c408 Author:mchung Date: 2016-03-03 12:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/b78ff3e8c408 Merge
hg: jigsaw/jake: 8 new changesets
Changeset: 623e45a43ff3 Author:ihse Date: 2016-02-22 11:22 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/623e45a43ff3 8150203: Incremental update from build-infra project Reviewed-by: erikj ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 ! common/autoconf/spec.gmk.in ! make/Init.gmk ! make/common/NativeCompilation.gmk Changeset: 900e2e405414 Author:simonis Date: 2016-02-22 11:27 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/900e2e405414 8150197: Integrate AIX fixes from build-infra Reviewed-by: erikj ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! make/common/NativeCompilation.gmk Changeset: 4040949857df Author:ihse Date: 2016-02-23 21:43 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/4040949857df 8150257: Remove softfloat lib support Reviewed-by: dholmes, erikj ! make/common/NativeCompilation.gmk Changeset: 958ccf794051 Author:lana Date: 2016-02-25 11:27 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/958ccf794051 Merge Changeset: c7be2a78c31b Author:michaelm Date: 2016-02-25 23:00 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/c7be2a78c31b 8087112: HTTP API and HTTP/1.1 implementation Reviewed-by: alanb, chegar, coffeys, psandoz, rriggs ! make/common/CORE_PKGS.gmk ! modules.xml Changeset: 906d3d2cbd3a Author:henryjen Date: 2016-03-02 21:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/906d3d2cbd3a Merge ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! make/common/CORE_PKGS.gmk ! make/common/NativeCompilation.gmk Changeset: 83fe2455dcc1 Author:lana Date: 2016-03-03 12:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/83fe2455dcc1 Added tag jdk-9+108 for changeset c7be2a78c31b ! .hgtags Changeset: 019e092d159d Author:mchung Date: 2016-03-03 12:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/019e092d159d Merge
Re: RFR: JDK-8150998: Fix module dependences in java/lang tests
Hi. Could you please have another look on the webrev. http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.03/ http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.03/ I have reverted changes to java/lang/management tests for now, until resolution of https://bugs.openjdk.java.net/browse/JDK-8151099. I have addressed all the comments except moving the fix of test/java/lang/management/MemoryMXBean/PendingAllGC.sh to JDK9, as this test is already different in JDK9 and Jake, so a fix in JDK9 will be overridden. Shura > On Mar 2, 2016, at 9:48 AM, Alexandre (Shura) Iline > wrote: > > Hi. > > Could you please take a look on a fix to add missing module dependencies for > tests in java/lang. > > JDK9 changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.01 > Jake changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.01 > > Shura.
hg: jigsaw/jake/hotspot: Change test because class BootLoader was moved to package jdk.internal.loader
Changeset: 870fb65a6dd1 Author:hseigel Date: 2016-03-03 11:43 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/870fb65a6dd1 Change test because class BootLoader was moved to package jdk.internal.loader ! test/runtime/getSysPackage/GetSysPkgTest.java
hg: jigsaw/jake/hotspot: Trivial change to fix cosmetic difference in 2 files between jigsaw and JDK 9.
Changeset: 89f7ea11f0cd Author:lfoltan Date: 2016-03-03 11:37 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/89f7ea11f0cd Trivial change to fix cosmetic difference in 2 files between jigsaw and JDK 9. ! make/bsd/makefiles/mapfile-vers-darwin-debug ! make/solaris/makefiles/mapfile-vers
Re: jlink and automatic modules
> On 03 Mar 2016, at 16:50, Alan Bateman wrote: > > There isn't currently any support for automatic modules at link-time. We have > an issue tracking it [1] but I think requires thinking through whether it's > the right thing to do. Thanks, that explains it. The difference in behavior between the two modulepaths threw me off for a bit. Whether it's the right thing to do almost sounds more like a philosophical rather than a technical discussion? -- Sander
Re: jlink and automatic modules
On 03/03/2016 15:38, Sander Mak wrote: I'm experimenting with an application that consists of proper modules (with module-info), where one module A requires an automatic module Lib. After creating modular jars for my application modules and running the application with both the application modules and the non-modular Lib-jar on the modulepath, everything works as expected. Now, I try to create a runtime image for my application using jlink. I add module A using --addmods, and again put both my application modules and the Lib-jar on the --modulepath of jlink. This results in the following error: Error: jdk.tools.jlink.plugin.PluginException: module-info.class not found for Lib module Is this expected behavior? There isn't currently any support for automatic modules at link-time. We have an issue tracking it [1] but I think requires thinking through whether it's the right thing to do. -Alan [1] https://bugs.openjdk.java.net/browse/JDK-8130047
jlink and automatic modules
I'm experimenting with an application that consists of proper modules (with module-info), where one module A requires an automatic module Lib. After creating modular jars for my application modules and running the application with both the application modules and the non-modular Lib-jar on the modulepath, everything works as expected. Now, I try to create a runtime image for my application using jlink. I add module A using --addmods, and again put both my application modules and the Lib-jar on the --modulepath of jlink. This results in the following error: > Error: jdk.tools.jlink.plugin.PluginException: module-info.class not found > for Lib module Is this expected behavior? -- Sander
Initial webrev with changes for JDK 9
I've pushed webrevs with the initial changes for JDK 9 here: http://cr.openjdk.java.net/~alanb/8142968/0/ This is a snapshot of what is currently in the jigsaw/jake forest. Our mission over the next few weeks is to iterate on this and get it to the point where we + Reviewers are happy that it is a reasonable/acceptable state to bring into JDK 9. We will need to set a deadline so that we can plan the integration, more on this soon. As per our previous milestones (JEP 201 and JEP 220) then we'll ask that the integration from jdk9/dev to master skip a beat so that the module system is the only change in master that week. It's important to remember that the initial push to JDK 9 is exactly that, it's not the final bits. There are many areas that still need work, there are many open issues, there is an ongoing JSR, and of course there will be ongoing feedback that will help us get it right. Another important thing to say is this isn't a module system design or API review. Questions/comments on the module system design can be brought up here of course but we might have to punt to jpms-spec-comments on topics that involve JSR discussions. For the API then I expect it will go through many iterations, as every good API does. The following is a summary of what is in each repository, this might help to get a feel for where the implementation is currently at. ** top-level repository ** Most of the build changes have already been pushed to JDK 9 as part of JEP 201 and subsequent iteration. There are some additional jake-specific build changes, most of it is in the top-level repository with some changes in other repositories too. Of significance is that the temporary modules.xml document in the root directory is gone, this has been replaced by a module declaration in the source code of each module. The other significant thing is that the build creates a packaged module for each standard and JDK module. It also uses the jlink tool to create the JDK and JRE run-time images. Erik Joelsson will take point for all the build changes, with help from Reviewers from the build group. ** hotspot repository ** At a high-level, the changes in hotspot repository adds support for modules to the virtual machine with access control extended to modules. Startup has been significantly reworked into a sequence of phases, akin to runlevels, so that the module system is initialized before any code outside of the base module is loaded. What we used to know as the boot class path is mostly gone except for agent and -Xbootclasspath/a cases. Classes are instead loaded from modules defined to boot loader. There is also support for patching modules for testing and ad hoc needs. JNI has new functions, as has JVM TI with initial support for debuggers and agents that instrument code in modules. There is additional work on JVM TI in progress so expect to see more in later webrevs. There are a number of diagnosability improvements, include improved exception messages and support for module details in stack traces. There are many new tests. There are also updates to many existing tests. Christian Tornqvist is planning to bring at least some of test changes into jdk9/dev so we should see the patch reduce a bit once we sync up. Lois Foltan will take point on the hotspot repository, she has lined up several Reviewers in the hotspot group to help. ** langtools repository ** As expected, the javac compiler is significantly updated to support compilation containing module declarations. The javadoc tool and doclet code has also involve significant changes. When compiling then there are several new command-line options, support for module paths, and new compilation modes. JEP 261 has useful descriptions. The jdeps tool has been upgraded with many new options. The javap tool has also been updated. This repository also has the initial updates to the javax.tools and javax.lang.model APIs. There are a lot of updates to existing tests in the webrev and many new tests too. Jonathan Gibbons will take point for the langtools repository and I expect will use Reviewers from the compiler group to help get through this. ** jdk repository ** There are a lot of changes in this repository. One of the most obvious is that there is a module-info.java source file in each module's directory. There is a new java.lang.module API to support module descriptors and to create configurations of modules. There are new APIs in java.lang.reflect to represent modules and layers of modules. There are is a lot of support code for the module system itself, for example ModuleBootstrap is the class that creates the configuration and creates the boot layer. The application and extension class loaders have been replaced with a new implementation based on BuiltinClassLoader that supports loading classes/resources from modules (in addition to the class path). Note that there are no chang
Re: Missing issue? - indexing
On 03/03/2016 08:48, Rory O'Donnell wrote: Alex, Sure, I will try to reach out to them. If you or anyone on the list has contacts they can share with me that would be great. Rgds,Rory I don't know have contacts but just to add to Alex's mail where he said: "The concern is whether these tools make assumptions about the JDK's class loader hierarchy (Gradle was hit by this) and the JDK classes loaded by each loader (Eclipse was hit by this). " It is important to flush out these issues. In the Gradle case then it assumed the system class loader is a URLClassLoader [1]. In the Eclipse case then it seems to be delegating directly to the boot loader and so was tripped up by changes to move non-core classes out of the boot loader [2]. I don't like pointing out specific issue in other tools/libraries of course but they are useful examples that other projects might relate to. I have no doubt that there will be more of these cases like this, particularly the latter as we have moved many non-core modules, including all of the "morally EE" modules, to the extension class loader. -Alan [1] https://issues.gradle.org/browse/GRADLE-3287 [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=466683
Re: Missing issue? - indexing
Alex, Sure, I will try to reach out to them. If you or anyone on the list has contacts they can share with me that would be great. Rgds,Rory On 02/03/2016 21:54, jigsaw-dev-requ...@openjdk.java.net wrote: Message: 1 Date: Wed, 02 Mar 2016 11:05:33 -0800 From: Alex Buckley To: rory.odonn...@oracle.com, jigsaw-dev Subject: Re: Missing issue? - indexing Message-ID: <56d7397d.3000...@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Rory, Could you please add Reflections and Scannotation to the Quality Outreach effort? The concern is not whether these tools understand the new JDK image or the modulepath. The concern is whether these tools make assumptions about the JDK's class loader hierarchy (Gradle was hit by this) and the JDK classes loaded by each loader (Eclipse was hit by this). Alex On 3/2/2016 4:40 AM, Stephen Colebourne wrote: Tools like Reflections [1], Scannotaions [2] and many more [3] provide the ability to find instances of annotations on the classpath. They also provide the ability to find subclasses of an interface. This kind of tooling is commonly needed by Java EE. Different tools use different approaches to gather the information, but it is definitely something that could be captured when building a module. At the very least, it is important to ensure that these tools continue to work. Stephen [1] https://github.com/ronmamo/reflections [2] http://scannotation.sourceforge.net/ [3] http://stackoverflow.com/questions/259140/scanning-java-annotations-at-runtime -- Rgds,Rory O'Donnell Quality Engineering Manager Oracle EMEA , Dublin, Ireland
