Re: Initial webrev with changes for JDK 9

[Bhavesh Patel]

Hi,
I have review the javadoc (including doclet and tests) changes. It 
mostly looks good. Following are my comments on the changes


1) jdk/javadoc/internal/doclets/formats/html/ConfigurationImpl.java

- (Line 522) PackageSymbol "pd" is cast to ModuleSymbol which is incorrect.

2) jdk/javadoc/internal/doclets/toolkit/AbstractDoclet.java

- (Lines 109 and 111) e.printStackTrace() needs to be deleted.

3) jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java

- (Lines 130 - 135) The Module label and name gets enclosed in . We 
need to update this to enclose them in a  and  similar to 
what we do in 
jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java (Lines 
200 - 205).


Other minor changes that are needed are as follows

4) com/sun/tools/doclets/formats/html/PackageWriterImpl.java

- The class lists no changes other than the copyright year change. If no 
changes have happened, the copyright year change needs to be reverted.


5) com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java

- (Line 275) Missing @param.
- (Line 292) Missing documentation.

6) com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java

- Copyright year shows 2012 instead of 2016.

7) com/sun/tools/javadoc/DocletInvoker.java

- (Line 367) Missing @param.
- (Line 384) Missing documentation.

8) jdk/javadoc/internal/doclets/formats/html/WriterFactoryImpl.java

- (Lines 94 - 102) needs to be deleted.

9) jdk/javadoc/internal/doclets/toolkit/AbstractDoclet.java

- Line 121 needs to be deleted

10) jdk/javadoc/internal/doclets/toolkit/Configuration.java

- Extra line 398 needs to be deleted.
- (Line 654) Not updated as a part of this fix but @return needs to be 
updated.


11) jdk/javadoc/internal/doclets/toolkit/WriterFactory.java

- (Line 74) The param name should be "mdle" instead of "module"

12) jdk/javadoc/internal/doclets/toolkit/builders/BuilderFactory.java

- (Line 108) The param name should be "mdle" instead of "module"

13) jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java

- (Line 266) Missing @param.
- (Line 285) Missing documentation.

14) jdk/javadoc/internal/doclets/toolkit/util/DocPaths.java

- (Line 158) should be "The name of the file for the module overview frame."

15) jdk/javadoc/internal/tool/Start.java

- (Line 313) Missing @param.

16) jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java

- (Line 80) "module" should be "mdle".
- (Line 95) "module" should be "mdle".

Regards,
Bhavesh.

hg: jigsaw/jake/jdk: Fix javadoc warnings

[mandy . chung]

Changeset: 43aa40114786
Author:mchung
Date:  2016-03-15 20:58 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/43aa40114786

Fix javadoc warnings

! src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/Pool.java

Re: Initial webrev with changes for JDK 9

[Mandy Chung]

Daniel,

Thanks for the review.

> On Mar 15, 2016, at 10:48 AM, Daniel Fuchs  wrote:
> 
> 
> 120 @Override
> 121 public int hashCode() {
> 122 int hash = 7;
> 123 hash = 67*hash + Objects.hashCode(this.filename) +
> 124 Objects.hashCode(this.path);
> 125 return hash;
> 126 }
> 
> I wonder if that could be simplified in:
> 
> return Objects.hash(this.filename, this.path);
> 

Good idea.  I made the change.

> 
> typo:
> 443 // otherwise analyze the depednencies


Fixed.

Mandy

hg: jigsaw/jake/langtools: 2 new changesets

[mandy . chung]

Changeset: 9d07ca03b896
Author:mchung
Date:  2016-03-15 20:37 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9d07ca03b896

print output in sorted order

! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleAnalyzer.java

Changeset: 85a52d56ec3c
Author:mchung
Date:  2016-03-15 20:37 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/85a52d56ec3c

review comment from dfuchs

! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Analyzer.java
! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Archive.java
! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java

hg: jigsaw/jake/langtools: Cleanup after ProblemList.jake.txt removal

[mandy . chung]

Changeset: d8475d27a07c
Author:mchung
Date:  2016-03-15 20:32 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d8475d27a07c

Cleanup after ProblemList.jake.txt removal

! make/build.xml
! test/Makefile

hg: jigsaw/jake/langtools: cleanup diags examples

[jonathan . gibbons]

Changeset: e743f91c2e24
Author:jjg
Date:  2016-03-15 18:42 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e743f91c2e24

cleanup diags examples

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java
! test/ProblemList.txt
! test/tools/javac/diags/Example.java
! test/tools/javac/diags/examples/DirPathElementNotFound.java
! 
test/tools/javac/diags/examples/InvalidDefaultInterface/InvalidDefaultInterface.java
! 
test/tools/javac/diags/examples/InvalidStaticInterface/InvalidStaticInterface.java
! test/tools/javac/diags/examples/NoJavaLang.java
! test/tools/javac/diags/examples/NoSuperclass.java

hg: jigsaw/jake/hotspot: 8151908: Fix remaining extension class loader references in AppCDS code

[lois . foltan]

Changeset: 5420f2f73383
Author:jiangli
Date:  2016-03-15 13:40 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5420f2f73383

8151908: Fix remaining extension class loader references in AppCDS code
Summary: Fix extension classloader references in AppCDS code and comments.
Reviewed-by: mchung

! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/classLoader.hpp
! src/share/vm/oops/instanceKlass.hpp

hg: jigsaw/jake/langtools: move problem tests to main ProblemList.txt

[jonathan . gibbons]

Changeset: 34fbc157727e
Author:jjg
Date:  2016-03-15 16:17 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/34fbc157727e

move problem tests to main ProblemList.txt

- test/ProblemList.jake.txt
! test/ProblemList.txt
! test/tools/javac/diags/examples.not-yet.txt

hg: jigsaw/jake/jdk: 2 new changesets

[mandy . chung]

Changeset: edb95a70985f
Author:lana
Date:  2016-03-15 13:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/edb95a70985f

Added tag jdk-9+110 for changeset 9417e1bcded6

! .hgtags

Changeset: 988c192cecc5
Author:mchung
Date:  2016-03-15 14:43 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/988c192cecc5

Merge

! .hgtags
- make/gendata/Gendata-jdk.jdeps.gmk
- make/gensrc/Gensrc-jdk.dev.gmk
- make/gensrc/Gensrc-jdk.jvmstat.gmk
- make/launcher/Launcher-jdk.dev.gmk
- make/scripts/localelist.sh
- make/src/classes/build/tools/module/GenJdepsModulesXml.java
- make/src/classes/build/tools/module/GenModulesList.java
- make/src/classes/build/tools/module/ImageBuilder.java
- make/src/classes/build/tools/module/ModuleArchive.java
- make/src/classes/build/tools/module/boot.modules
- make/src/classes/build/tools/module/ext.modules
- src/java.base/share/classes/jdk/internal/jimage/Archive.java
- src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java
- src/java.base/share/classes/jdk/internal/jimage/ExternalFilesWriter.java
- src/java.base/share/classes/jdk/internal/jimage/ImageFileCreator.java
- src/java.base/share/classes/jdk/internal/jimage/ImageJavaSubstrate.java
- src/java.base/share/classes/jdk/internal/jimage/ImageLocationBase.java
- src/java.base/share/classes/jdk/internal/jimage/ImageLocationWriter.java
- src/java.base/share/classes/jdk/internal/jimage/ImageModuleData.java
- src/java.base/share/classes/jdk/internal/jimage/ImageModuleDataWriter.java
- src/java.base/share/classes/jdk/internal/jimage/ImageNativeSubstrate.java
- src/java.base/share/classes/jdk/internal/jimage/ImageResourcesTree.java
- src/java.base/share/classes/jdk/internal/jimage/ImageStringsWriter.java
- src/java.base/share/classes/jdk/internal/jimage/ImageSubstrate.java
- src/java.base/share/classes/jdk/internal/jimage/PerfectHashBuilder.java
- src/java.base/share/classes/jdk/internal/jimage/ResourcePool.java
- src/java.base/share/classes/jdk/internal/jimage/ResourcePoolImpl.java
- src/java.base/share/classes/jdk/internal/jimage/StringTable.java
- src/java.base/share/classes/jdk/internal/jimage/UTF8String.java
- src/java.base/share/classes/sun/misc/Launcher.java
- 
src/java.base/share/classes/sun/util/CoreResourceBundleControl-XLocales.java.template
- src/java.base/share/native/libjava/Package.c
- src/java.base/share/native/libjava/Proxy.c
- src/java.base/share/native/libjimage/ImageNativeSubstrate.cpp
- 
src/java.desktop/share/classes/META-INF/services/java.net.ContentHandlerFactory
- 
src/java.desktop/share/classes/META-INF/services/javax.print.PrintServiceLookup
- 
src/java.desktop/share/classes/META-INF/services/javax.print.StreamPrintServiceFactory
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.midi.spi.MidiDeviceProvider
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.midi.spi.MidiFileReader
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.midi.spi.MidiFileWriter
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.midi.spi.SoundbankReader
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.sampled.spi.AudioFileReader
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.sampled.spi.AudioFileWriter
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.sampled.spi.FormatConversionProvider
- 
src/java.desktop/share/classes/META-INF/services/javax.sound.sampled.spi.MixerProvider
- 
src/java.desktop/share/classes/META-INF/services/sun.datatransfer.DesktopDatatransferService
- 
src/java.logging/share/classes/META-INF/services/jdk.internal.logger.DefaultLoggerFinder
- 
src/java.security.jgss/share/classes/META-INF/services/sun.security.ssl.ClientKeyExchangeService
- 
src/jdk.accessibility/windows/classes/META-INF/services/javax.accessibility.AccessibilityProvider
- 
src/jdk.attach/share/classes/META-INF/services/com.sun.tools.attach.spi.AttachProvider
- 
src/jdk.charsets/share/classes/META-INF/services/java.nio.charset.spi.CharsetProvider
- src/jdk.dev/share/classes/jdk/tools/jimage/ExtractedImage.java
- src/jdk.dev/share/classes/jdk/tools/jimage/JImageTask.java
- src/jdk.dev/share/classes/jdk/tools/jimage/Main.java
- src/jdk.dev/share/classes/jdk/tools/jimage/TaskHelper.java
- src/jdk.dev/share/classes/jdk/tools/jimage/resources/jimage.properties
- src/jdk.jdi/share/classes/META-INF/services/com.sun.jdi.connect.Connector
- 
src/jdk.jdi/share/classes/META-INF/services/com.sun.jdi.connect.spi.TransportService
- 
src/jdk.jvmstat.rmi/share/classes/META-INF/services/sun.jvmstat.monitor.MonitoredHostService
- 
src/jdk.jvmstat/share/classes/META-INF/services/sun.jvmstat.monitor.MonitoredHostService
- 
src/jdk.localedata/share/classes/META-INF/services/sun.util.locale.provider.LocaleDataMetaInfo
- 
src/jdk.management/share/classes/META-INF/services/sun.management.spi.PlatformMBeanProvider
- 
src/jdk.naming.dns/share/classes/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor
- 

hg: jigsaw/jake/nashorn: 2 new changesets

[mandy . chung]

Changeset: f64433f6ff69
Author:lana
Date:  2016-03-15 13:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/f64433f6ff69

Added tag jdk-9+110 for changeset 9937077e48f1

! .hgtags

Changeset: ea5605f73921
Author:mchung
Date:  2016-03-15 14:44 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/ea5605f73921

Merge

! .hgtags
- src/jdk.scripting.nashorn/share/classes/META-INF/MANIFEST.MF
- 
src/jdk.scripting.nashorn/share/classes/META-INF/services/javax.script.ScriptEngineFactory

hg: jigsaw/jake/langtools: 2 new changesets

[mandy . chung]

Changeset: dbd1f626bd00
Author:lana
Date:  2016-03-15 13:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dbd1f626bd00

Added tag jdk-9+110 for changeset 9b4c916633f8

! .hgtags

Changeset: 8f70f503ce72
Author:mchung
Date:  2016-03-15 14:43 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8f70f503ce72

Merge

! .hgtags
- src/jdk.compiler/share/classes/com/sun/tools/javac/sym/CreateSymbols.java
- src/jdk.compiler/share/classes/com/sun/tools/javac/sym/Profiles.java
- src/jdk.compiler/share/classes/com/sun/tools/javac/util/ServiceLoader.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AbstractProfileIndexWriter.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ProfileWriterImpl.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/ProfilePackageSummaryWriter.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/ProfileSummaryWriter.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfilePackageSummaryBuilder.java
- 
src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfileSummaryBuilder.java
- src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModulesXmlReader.java
- src/jdk.jdeps/share/classes/com/sun/tools/jdeps/PlatformClassPath.java
- test/com/sun/javadoc/testLinkOption/java/lang/StringBuilderChild.java
- test/com/sun/javadoc/testLinkOption/package-list
- test/com/sun/javadoc/testProfiles/TestProfiles.java
- test/com/sun/javadoc/testProfiles/TestProfilesConfiguration.java
- test/com/sun/javadoc/testProfiles/pkg1/Class1Pkg1.java
- test/com/sun/javadoc/testProfiles/pkg1/Class2Pkg1.java
- test/com/sun/javadoc/testProfiles/pkg1/Class3Pkg1.java
- test/com/sun/javadoc/testProfiles/pkg1/Interface1Pkg1.java
- test/com/sun/javadoc/testProfiles/pkg2/Anno1Pkg2.java
- test/com/sun/javadoc/testProfiles/pkg2/Anno2Pkg2.java
- test/com/sun/javadoc/testProfiles/pkg2/Class1Pkg2.java
- test/com/sun/javadoc/testProfiles/pkg2/ClassError.java
- test/com/sun/javadoc/testProfiles/pkg2/ClassException.java
- test/com/sun/javadoc/testProfiles/pkg3/Class1Pkg3.java
- test/com/sun/javadoc/testProfiles/pkg3/Class2Pkg3.java
- test/com/sun/javadoc/testProfiles/pkg3/Interface1Pkg3.java
- test/com/sun/javadoc/testProfiles/pkg4/Anno1Pkg4.java
- test/com/sun/javadoc/testProfiles/pkg4/Class1Pkg4.java
- test/com/sun/javadoc/testProfiles/pkg5/Class1Pkg5.java
- test/com/sun/javadoc/testProfiles/pkg5/Interface1Pkg5.java
- test/com/sun/javadoc/testProfiles/pkgDeprecated/Class1PkgDeprecated.java
- test/com/sun/javadoc/testProfiles/pkgDeprecated/package-info.java
- test/com/sun/javadoc/testProfiles/profile-rtjar-includes-nopkgs.txt
- test/com/sun/javadoc/testProfiles/profile-rtjar-includes.txt
- test/jdk/javadoc/doclet/testLinkOption/java/lang/StringBuilderChild.java
- test/jdk/javadoc/doclet/testLinkOption/package-list
- test/tools/javac/Object1.java
- test/tools/javac/Object1.out
- test/tools/javac/Object2.java
- test/tools/javac/Object2.out
- test/tools/javac/profiles/ProfileTest.java
- test/tools/javac/proprietary/WarnClass.java
- test/tools/javac/proprietary/WarnClass.out
- test/tools/javac/proprietary/WarnImport.java
- test/tools/javac/proprietary/WarnImport.out
- test/tools/javac/proprietary/WarnMethod.java
- test/tools/javac/proprietary/WarnMethod.out
- test/tools/javac/proprietary/WarnStaticImport.java
- test/tools/javac/proprietary/WarnStaticImport.out
- test/tools/javac/proprietary/WarnVariable.java
- test/tools/javac/proprietary/WarnVariable.out
- test/tools/javac/proprietary/WarnWildcard.java
- test/tools/javac/proprietary/WarnWildcard.out
- test/tools/javac/synthesize/Boolean.java
- test/tools/javac/synthesize/Byte.java
- test/tools/javac/synthesize/Character.java
- test/tools/javac/synthesize/Cloneable.java
- test/tools/javac/synthesize/Double.java
- test/tools/javac/synthesize/Float.java
- test/tools/javac/synthesize/Integer.java
- test/tools/javac/synthesize/Long.java
- test/tools/javac/synthesize/Number.java
- test/tools/javac/synthesize/Object.java
- test/tools/javac/synthesize/Serializable.java
- test/tools/javac/synthesize/Short.java
- test/tools/javac/synthesize/Test.java
- test/tools/javac/synthesize/Void.java
- test/tools/jdeps/VerboseFormat/use/indirect/DontUseUnsafe2.java
- test/tools/jdeps/VerboseFormat/use/indirect/UseUnsafeIndirectly.java
- test/tools/jdeps/VerboseFormat/use/indirect2/DontUseUnsafe3.java
- test/tools/jdeps/VerboseFormat/use/indirect2/UseUnsafeIndirectly2.java
- 

hg: jigsaw/jake/corba: 2 new changesets

[mandy . chung]

Changeset: c842d4efaf48
Author:lana
Date:  2016-03-15 13:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/c842d4efaf48

Added tag jdk-9+110 for changeset 9666775734fb

! .hgtags

Changeset: c7801b2f56a6
Author:mchung
Date:  2016-03-15 14:43 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/c7801b2f56a6

Merge

hg: jigsaw/jake/jaxp: 2 new changesets

[mandy . chung]

Changeset: 5a94c67f40c8
Author:lana
Date:  2016-03-15 13:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/5a94c67f40c8

Added tag jdk-9+110 for changeset 1c1bb661d35b

! .hgtags

Changeset: 310469c55c5c
Author:mchung
Date:  2016-03-15 14:43 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/310469c55c5c

Merge

hg: jigsaw/jake/hotspot: 2 new changesets

[mandy . chung]

Changeset: 0de4d895a5c8
Author:lana
Date:  2016-03-15 13:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0de4d895a5c8

Added tag jdk-9+110 for changeset 2f5d1578b240

! .hgtags

Changeset: 77095b95631f
Author:mchung
Date:  2016-03-15 14:43 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/77095b95631f

Merge

! .hgtags
- 
src/jdk.vm.ci/share/classes/META-INF/services/jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory
- test/compiler/jsr292/NonInlinedCall/NonInlinedReinvoker.java
- test/compiler/jvmci/common/CompilerToVMHelper.java
- test/compiler/jvmci/common/PublicMetaspaceWrapperObject.java
- test/compiler/jvmci/events/MetaAccessWrapper.java
- test/runtime/BadObjectClass/Object.java
- test/testlibrary/jdk/test/lib/PerfCounter.java
- test/testlibrary/jdk/test/lib/PerfCounters.java

hg: jigsaw/jake: 2 new changesets

[mandy . chung]

Changeset: ea2ee1d57d22
Author:lana
Date:  2016-03-15 13:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/ea2ee1d57d22

Added tag jdk-9+110 for changeset 925be13b3740

! .hgtags

Changeset: f1d1ac446fb2
Author:mchung
Date:  2016-03-15 14:43 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/f1d1ac446fb2

Merge

- make/CheckModules.gmk
- make/GenerateModuleDeps.gmk
- modules.xml

Re: Initial webrev with changes for JDK 9

[Chris Hegarty]

Mandy,

On 14 Mar 2016, at 20:37, Mandy Chung  wrote:

> 
>> On Mar 11, 2016, at 1:39 AM, Alan Bateman  wrote:
>> 
>> 
>> I've refreshed the webrevs here:
>>  http://cr.openjdk.java.net/~alanb/8142968/2
> 
> 
> I have reviewed the jmod tool and some comments:
> 
> 299 private boolean printModuleDescriptor(InputStream in)
> 
> jmod -p option prints the output in different sections.
> java -listmods: prints the module descriptor closer to 
> module-info.java declaration.  Also jmod -p does not do any 
> sorting and names are unordered.
> 
> It would be better for both options to use similar format.  I think
> closer to how it is declared in module-info.java would be preferred.
> The optional attributes will follow it - the existing format is fine.

Good idea. I updated the output as close as possible, where applicable,
to -listmods:.

> It’d help if the package names and uses are printed in alphabetical order.
> 
> 584 } catch (ZipException x) {
> 585 // Skip. Do nothing. No packages will be added
> 
> When ZipException is thrown?  Should it be handled in the same way as 
> IOException?

I do remember adding this explicit catch. I’m reluctant to remove it
until I can find my notes, as to why it was added. I’ll have to get back
to you on this.

> 603 .filter(pkg -> pkg.length() > 0)   // module-info
> 
> I think jmod should detect if there is any unnamed package and output an 
> error since unnamed package is not allowed in named module.  Currently any 
> classes in unnamed package are include in the jmod file.

Classes in the unnamed package are now disallowed.

> findPackages should filter module-info.class explicitly.
> 
> 396 Path tempTarget = target.resolveSibling(target.getFileName() + 
> ".tmp”);
> 
> When any error occurs, foo.mod.tmp is left behind.

Fixed.

> jmods.properties - some unused messages.
> 
> err.cp.must.be.specified:--class-path must be specified
> err.dir.not.empty=not empty: {0}
> err.invalid.arg.for.option=invalid argument for option: {0}
> err.option.after.class=option must be specified before classes: {0}

Removed.

Changeset with the above updates:
  http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7e5d2398a250

-Chris.

Re: "Provides" and "with" type relationships

[Alex Buckley]

// Ignore last mail (mail client did a surprising thing)

A 'provides' clause specifies two things: a service interface and a 
service implementation. Using those terms helps to avoid confusion.


A service interface does not have to be an interface; it can be an 
abstract class or even (not recommended) a concrete class.


A service implementation must not be an interface, or an abstract class; 
it must be a concrete class.


Therefore, it's legal (but not recommended) for a concrete class to be 
specified as both service interface and service implementation. It's 
illegal for an interface (or abstract class) to be specified as both 
service interface and service implementation. JCK will be writing tests 
for edge cases like this.


Alex

On 3/15/2016 12:39 PM, Paul Benedict wrote:

Thanks for your response Alex. If I am understanding you correctly,
"provides" is "not constrained to be an interface" because it can be "a
single interface or abstract class". So shouldn't my concrete class for
"provides" be rejected by the compiler? And is it okay that both types
were identical?

Cheers,
Paul

On Tue, Mar 15, 2016 at 2:26 PM, Alex Buckley > wrote:

The first operand to 'provides' (the "service interface") is not
constrained to be an interface by "Modules in the Java Language and
JVM". This is because the spec of j.u.ServiceLoader ("a service is
represented by a single type, that is, a single interface or
abstract class").

The second operand to 'provides' (the "service implementation") is
constrained not to be an interface or an abstract class by "Modules
in the Java Language and JVM". This is also because of the spec of
j.u.ServiceLoader ("provider classes must have a zero-argument
constructor so that they can be instantiated during loading").

Bear in mind that the JCK team can easily set up abstract test cases
like this. What they can't do is check whether YOUR application runs
on JDK-9-with-Jigsaw, or whether arbitrary JARs on YOUR classpath
work as automatic modules.

Alex


On 3/15/2016 12:07 PM, Paul Benedict wrote:

module z {
  exports z;
  provides z.Main with z.Main;
}

The SOTM says "Service-provider declarations can be further
interpreted to
ensure that providers (e.g., com.mysql.jdbc.Driver) actually do
implement
their declared service interfaces" (section 4, para. 8).

I see javac checking that they are related types, but javac is
not checking
that "provides" is an interface type. That is what I was
expecting based on
the reading material.

The other unexpected outcome was that provides/with allows the
identical
type. I don't know if that's intended, but please advise.

PS: I did go through the open tickets this time (thanks Alan)
and do not
see any similar reports. If I missed it, I apologize; just
trying not to
waste your time by reporting a duplicate.

Cheers,
Paul

Re: "Provides" and "with" type relationships

[Alex Buckley]

A 'provides' clause specifies two things: a service interface and a 
service implementation. Using those terms helps to avoid confusion. A 
service interface does not have to be an interface; it can be an 
abstract class or even (not recommended) a concrete class. A service 
implementation must not be an interface, or an abstract class; it must 
be a concrete class. Therefore, it's not OK if the same type is 
specified as both service interface and service implementation, and JCK 
will be writing tests for that, I promise.


Alex

On 3/15/2016 12:39 PM, Paul Benedict wrote:

Thanks for your response Alex. If I am understanding you correctly,
"provides" is "not constrained to be an interface" because it can be "a
single interface or abstract class". So shouldn't my concrete class for
"provides" be rejected by the compiler? And is it okay that both types
were identical?

Cheers,
Paul

On Tue, Mar 15, 2016 at 2:26 PM, Alex Buckley > wrote:

The first operand to 'provides' (the "service interface") is not
constrained to be an interface by "Modules in the Java Language and
JVM". This is because the spec of j.u.ServiceLoader ("a service is
represented by a single type, that is, a single interface or
abstract class").

The second operand to 'provides' (the "service implementation") is
constrained not to be an interface or an abstract class by "Modules
in the Java Language and JVM". This is also because of the spec of
j.u.ServiceLoader ("provider classes must have a zero-argument
constructor so that they can be instantiated during loading").

Bear in mind that the JCK team can easily set up abstract test cases
like this. What they can't do is check whether YOUR application runs
on JDK-9-with-Jigsaw, or whether arbitrary JARs on YOUR classpath
work as automatic modules.

Alex


On 3/15/2016 12:07 PM, Paul Benedict wrote:

module z {
  exports z;
  provides z.Main with z.Main;
}

The SOTM says "Service-provider declarations can be further
interpreted to
ensure that providers (e.g., com.mysql.jdbc.Driver) actually do
implement
their declared service interfaces" (section 4, para. 8).

I see javac checking that they are related types, but javac is
not checking
that "provides" is an interface type. That is what I was
expecting based on
the reading material.

The other unexpected outcome was that provides/with allows the
identical
type. I don't know if that's intended, but please advise.

PS: I did go through the open tickets this time (thanks Alan)
and do not
see any similar reports. If I missed it, I apologize; just
trying not to
waste your time by reporting a duplicate.

Cheers,
Paul

hg: jigsaw/jake/hotspot: Fix failing jvmci/compilerToVM tests.

[harold . seigel]

Changeset: 474012546f4d
Author:hseigel
Date:  2016-03-15 15:15 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/474012546f4d

Fix failing jvmci/compilerToVM tests.

! test/compiler/jvmci/compilerToVM/LookupKlassInPoolTest.java
! test/compiler/jvmci/compilerToVM/LookupKlassRefIndexInPoolTest.java
! test/compiler/jvmci/compilerToVM/LookupMethodInPoolTest.java
! test/compiler/jvmci/compilerToVM/LookupNameAndTypeRefIndexInPoolTest.java
! test/compiler/jvmci/compilerToVM/LookupNameInPoolTest.java
! test/compiler/jvmci/compilerToVM/LookupSignatureInPoolTest.java
! test/compiler/jvmci/compilerToVM/ResolveConstantInPoolTest.java
! test/compiler/jvmci/compilerToVM/ResolveFieldInPoolTest.java
! test/compiler/jvmci/compilerToVM/ResolvePossiblyCachedConstantInPoolTest.java
! test/compiler/jvmci/compilerToVM/ResolveTypeInPoolTest.java

Re: "Provides" and "with" type relationships

[Paul Benedict]

Thanks for your response Alex. If I am understanding you correctly,
"provides" is "not constrained to be an interface" because it can be "a
single interface or abstract class". So shouldn't my concrete class for
"provides" be rejected by the compiler? And is it okay that both types were
identical?

Cheers,
Paul

On Tue, Mar 15, 2016 at 2:26 PM, Alex Buckley 
wrote:

> The first operand to 'provides' (the "service interface") is not
> constrained to be an interface by "Modules in the Java Language and JVM".
> This is because the spec of j.u.ServiceLoader ("a service is represented by
> a single type, that is, a single interface or abstract class").
>
> The second operand to 'provides' (the "service implementation") is
> constrained not to be an interface or an abstract class by "Modules in the
> Java Language and JVM". This is also because of the spec of
> j.u.ServiceLoader ("provider classes must have a zero-argument constructor
> so that they can be instantiated during loading").
>
> Bear in mind that the JCK team can easily set up abstract test cases like
> this. What they can't do is check whether YOUR application runs on
> JDK-9-with-Jigsaw, or whether arbitrary JARs on YOUR classpath work as
> automatic modules.
>
> Alex
>
>
> On 3/15/2016 12:07 PM, Paul Benedict wrote:
>
>> module z {
>>  exports z;
>>  provides z.Main with z.Main;
>> }
>>
>> The SOTM says "Service-provider declarations can be further interpreted to
>> ensure that providers (e.g., com.mysql.jdbc.Driver) actually do implement
>> their declared service interfaces" (section 4, para. 8).
>>
>> I see javac checking that they are related types, but javac is not
>> checking
>> that "provides" is an interface type. That is what I was expecting based
>> on
>> the reading material.
>>
>> The other unexpected outcome was that provides/with allows the identical
>> type. I don't know if that's intended, but please advise.
>>
>> PS: I did go through the open tickets this time (thanks Alan) and do not
>> see any similar reports. If I missed it, I apologize; just trying not to
>> waste your time by reporting a duplicate.
>>
>> Cheers,
>> Paul
>>
>>

Re: "Provides" and "with" type relationships

[Alex Buckley]

The first operand to 'provides' (the "service interface") is not 
constrained to be an interface by "Modules in the Java Language and 
JVM". This is because the spec of j.u.ServiceLoader ("a service is 
represented by a single type, that is, a single interface or abstract 
class").


The second operand to 'provides' (the "service implementation") is 
constrained not to be an interface or an abstract class by "Modules in 
the Java Language and JVM". This is also because of the spec of 
j.u.ServiceLoader ("provider classes must have a zero-argument 
constructor so that they can be instantiated during loading").


Bear in mind that the JCK team can easily set up abstract test cases 
like this. What they can't do is check whether YOUR application runs on 
JDK-9-with-Jigsaw, or whether arbitrary JARs on YOUR classpath work as 
automatic modules.


Alex

On 3/15/2016 12:07 PM, Paul Benedict wrote:

module z {
 exports z;
 provides z.Main with z.Main;
}

The SOTM says "Service-provider declarations can be further interpreted to
ensure that providers (e.g., com.mysql.jdbc.Driver) actually do implement
their declared service interfaces" (section 4, para. 8).

I see javac checking that they are related types, but javac is not checking
that "provides" is an interface type. That is what I was expecting based on
the reading material.

The other unexpected outcome was that provides/with allows the identical
type. I don't know if that's intended, but please advise.

PS: I did go through the open tickets this time (thanks Alan) and do not
see any similar reports. If I missed it, I apologize; just trying not to
waste your time by reporting a duplicate.

Cheers,
Paul

hg: jigsaw/jake/jdk: 2 new changesets

[alan . bateman]

Changeset: 25f2e8deaa8c
Author:alanb
Date:  2016-03-15 19:12 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/25f2e8deaa8c

Module::toString needs more tests

! test/java/lang/reflect/Module/BasicModuleTest.java

Changeset: 2ebb5997fb5c
Author:alanb
Date:  2016-03-15 19:12 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2ebb5997fb5c

Merge

- test/jdk/modules/etc/JdkModules.java

"Provides" and "with" type relationships

[Paul Benedict]

module z {
exports z;
provides z.Main with z.Main;
}

The SOTM says "Service-provider declarations can be further interpreted to
ensure that providers (e.g., com.mysql.jdbc.Driver) actually do implement
their declared service interfaces" (section 4, para. 8).

I see javac checking that they are related types, but javac is not checking
that "provides" is an interface type. That is what I was expecting based on
the reading material.

The other unexpected outcome was that provides/with allows the identical
type. I don't know if that's intended, but please advise.

PS: I did go through the open tickets this time (thanks Alan) and do not
see any similar reports. If I missed it, I apologize; just trying not to
waste your time by reporting a duplicate.

Cheers,
Paul

hg: jigsaw/jake/nashorn: Bump jtreg requiredVersion to 4.2

[mandy . chung]

Changeset: 0dfe12b7a113
Author:mchung
Date:  2016-03-15 12:01 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/0dfe12b7a113

Bump jtreg requiredVersion to 4.2

! test/TEST.ROOT

hg: jigsaw/jake/hotspot: Bump jtreg requiredVersion to 4.2

[mandy . chung]

Changeset: 425a05d96c09
Author:mchung
Date:  2016-03-15 12:00 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/425a05d96c09

Bump jtreg requiredVersion to 4.2

! test/TEST.ROOT

hg: jigsaw/jake/langtools: Bump jtreg requiredVersion to 4.2

[mandy . chung]

Changeset: 9dd59ecda4eb
Author:mchung
Date:  2016-03-15 12:01 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9dd59ecda4eb

Bump jtreg requiredVersion to 4.2

! test/TEST.ROOT

hg: jigsaw/jake/jdk: Rename and clean up JdkModules test

[mandy . chung]

Changeset: 98fa6b5b262f
Author:mchung
Date:  2016-03-15 12:05 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/98fa6b5b262f

Rename and clean up JdkModules test

- test/jdk/modules/etc/JdkModules.java
+ test/jdk/modules/etc/VerifyModuleDelegation.java

Re: Unexpected package bug in jdk-9-ea+109

[Alan Bateman]

https://bugs.openjdk.java.net/browse/JDK-8150733


On 15/03/2016 18:29, Paul Benedict wrote:

File src/z/module-info.java:
package z;

Command line:
javac -d out src/z/module-info.java

Output:
An exception has occurred in the compiler (9-ea). Please file a bug against
the Java compiler via the Java bug reporting page (http://bugreport.java.com)
after checking the Bug Database (http://bugs.j
ava.com) for duplicates. Include your program and the following diagnostic
in your report. Thank you.
java.lang.NullPointerException
 at
com.sun.tools.javac.comp.TypeEnter$ImportsPhase.checkClassPackageClash(jdk.compiler@9-ea
/TypeEnter.java:362)
 at
com.sun.tools.javac.comp.TypeEnter$ImportsPhase.resolveImports(jdk.compiler@9-ea
/TypeEnter.java:342)
 at
com.sun.tools.javac.comp.TypeEnter$ImportsPhase.access$1600(jdk.compiler@9-ea
/TypeEnter.java:284)
 at
com.sun.tools.javac.comp.TypeEnter.lambda$ensureImportsChecked$0(jdk.compiler@9-ea
/TypeEnter.java:169)
 at
com.sun.tools.javac.comp.TypeEnter.finishImports(jdk.compiler@9-ea
/TypeEnter.java:220)
 at
com.sun.tools.javac.comp.TypeEnter.ensureImportsChecked(jdk.compiler@9-ea
/TypeEnter.java:169)
 at com.sun.tools.javac.comp.Enter.complete(jdk.compiler@9-ea
/Enter.java:553)
 at com.sun.tools.javac.comp.Enter.main(jdk.compiler@9-ea
/Enter.java:524)
 at
com.sun.tools.javac.main.JavaCompiler.enterTrees(jdk.compiler@9-ea
/JavaCompiler.java:1038)
 at com.sun.tools.javac.main.JavaCompiler.compile(jdk.compiler@9-ea
/JavaCompiler.java:904)
 at com.sun.tools.javac.main.Main.compile(jdk.compiler@9-ea
/Main.java:261)
 at com.sun.tools.javac.main.Main.compile(jdk.compiler@9-ea
/Main.java:143)
 at com.sun.tools.javac.Main.compile(jdk.compiler@9-ea/Main.java:55)
 at com.sun.tools.javac.Main.main(jdk.compiler@9-ea/Main.java:41)

Cheers,
Paul

Re: Package, import and type declarations are allowed now in module-info.java by spec

[Paul Benedict]

I am happy to say the latest EA only allows "module" or types. It is
either-or but not both.

Cheers,
Paul

On Tue, Mar 15, 2016 at 12:43 PM, Paul Benedict 
wrote:

> On Mon, Mar 14, 2016 at 5:21 PM, Alex Buckley 
> wrote:
>
>> The JLS doesn't know what the string "module-info.class" means or what a
>> "JAR root" is.
>
>
> Of course. Though that wasn't my ultimate point; I was merely illustrating
> (philosophically) why having "package" in module-info.java is nonsensical
> syntax. A "package" statement doesn't mean anything useful in the context
> of specifying module configuration. As far as I am aware, the module syntax
> is meant to standalone in the file, but please correct me if you have other
> intentions for the syntax. If you can also declare types, then a "package"
> statement begins to make more sense -- but it would seem like a clumsy way
> of doing things, which I wouldn't advocate (or allow syntactically).
>
> Cheers,
> Paul
>
>
>> In 3/14/2016 9:08 AM, Paul Benedict wrote:
>>
>>> Alex, you wrote: "The JLS doesn't prevent javac from rejecting a package
>>> declaration or an import declaration in a file called module-info.java."
>>>
>>> It seems that a package declaration, in this context, should be
>>> prohibited syntax because module-info.class is always in the JAR root
>>> which has no package.
>>>
>>> Cheers,
>>> Paul
>>>
>>> On Wed, Mar 9, 2016 at 4:02 PM, Alex Buckley >> > wrote:
>>>
>>> The JLS doesn't prevent javac from rejecting a package declaration
>>> or an import declaration in a file called module-info.java.
>>>
>>> In fact, since a package declaration or import declaration must be
>>> followed by a type declaration, and since a type declaration cannot
>>> use a hyphen, javac is free to take the optional rule from JLS 7.6
>>> -- filename must align with type declaration -- and develop it
>>> further: rejecting a package declaration or import declaration in
>>> module-info.java because the filename cannot possibly align with any
>>> type declaration.
>>>
>>> I can't speak to what a particular EA build of javac is doing with a
>>> particular option. javac options are irrelevant to the JLS. If a
>>> compiler accepts the Java language circa SE 9, then a module
>>> declaration is a valid compilation unit. What's the name of the file
>>> containing such a compilation unit? Anything the compiler likes.
>>>
>>> Alex
>>>
>>> On 3/9/2016 5:14 AM, Georgiy Rakov wrote:
>>>
>>> Hi Alex,
>>>
>>> if I understand correctly you mean about following assertions
>>> from JLS 7.6:
>>>
>>>  If and only if packages are stored in a file system (§7.2
>>>
>>> <
>>> http://docs.oracle.com/javase/specs/jls/se8/html/jls-7.html#jls-7.2>),
>>>  the host system may choose to enforce the restriction that
>>> it is a
>>>  compile-time error if a type is not found in a file under a
>>> name
>>>  composed of the type name plus an extension (such as
>>> |.java|or
>>>  |.jav|) if either of the following is true:
>>>
>>>*
>>>
>>>  The type is referred to by code in other compilation
>>> units of
>>>  the package in which the type is declared.
>>>
>>>*
>>>
>>>  The type is declared |public|(and therefore is
>>> potentially
>>>  accessible from code in other packages).
>>>
>>> Literally these assertion doesn't make presented behavior
>>> corresponding
>>> to spec because the declared type is neither public nor being
>>> referred
>>> to from other sources being compiled.
>>>
>>> Nevertheless following sources doesn't compile either despite
>>> the fact
>>> that no types are declared there at all.
>>> Namely when only package is specified:
>>>
>>>  mod\module-info.java:
>>>  module mod {
>>>   exports pkg;
>>>  }
>>>
>>>  mod\pkg\module-info.java:
>>>  package pkg;
>>>
>>> then compiling it by following command line with javac from [2]:
>>>
>>>  javac -modulesourcepath . mod\module-info.java
>>> mod\pkg\module-info.java
>>>
>>> causes following output:
>>>
>>>  mod\pkg\module-info.java:1: error: expected 'module
>>>  package pkg;
>>>  ^
>>>  1 error
>>>
>>> When only import statment is specified:
>>>
>>>  mod\module-info.java:
>>>  module mod {
>>>   exports pkg;
>>>  }
>>>
>>>  mod\pkg\module-info.java:
>>>  import java.util.List;
>>>
>>> then compiling it by following command line with javac from [2]:
>>>
>>>  javac 

hg: jigsaw/jake/jdk: 2 new changesets

[mandy . chung]

Changeset: 37c2fa5d57ce
Author:mchung
Date:  2016-03-15 11:19 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/37c2fa5d57ce

Move ProblemList.jake.txt to ProblemList.txt

! test/Makefile
- test/ProblemList.jake.txt
! test/ProblemList.txt

Changeset: ec17ca2d2932
Author:mchung
Date:  2016-03-15 11:20 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ec17ca2d2932

Update test/Makefile to use jtreg 4.2

! test/Makefile

hg: jigsaw/jake/jdk: Move tests out of jdk/jigsaw tree

[alan . bateman]

Changeset: 8711f9420791
Author:alanb
Date:  2016-03-15 18:04 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8711f9420791

Move tests out of jdk/jigsaw tree

! test/ProblemList.jake.txt
! test/TEST.groups
! test/java/lang/Class/forName/modules/TestDriver.java
! test/java/lang/Class/getResource/ResourcesTest.java
! test/java/lang/ClassLoader/getResource/modules/ResourcesTest.java
+ test/java/lang/invoke/modules/ModuleAccessControlTest.java
+ test/java/lang/invoke/modules/src/m1/module-info.java
+ test/java/lang/invoke/modules/src/m1/p1/Main.java
+ test/java/lang/invoke/modules/src/m1/p1/Type1.java
+ test/java/lang/invoke/modules/src/m1/p2/Type2.java
+ test/java/lang/invoke/modules/src/m2/module-info.java
+ test/java/lang/invoke/modules/src/m2/q1/Type1.java
+ test/java/lang/invoke/modules/src/m2/q2/Type2.java
+ test/java/lang/module/AutomaticModulesTest.java
+ test/java/lang/module/ConfigurationTest.java
+ test/java/lang/module/ModuleDescriptorTest.java
+ test/java/lang/module/ModuleFinderTest.java
+ test/java/lang/module/ModuleReader/ModuleReaderTest.java
+ test/java/lang/module/ModuleReader/src/m/module-info.java
+ test/java/lang/module/ModuleReader/src/m/p/Main.java
+ test/java/lang/module/ModuleReferenceTest.java
+ test/java/lang/module/VersionTest.java
+ test/java/lang/reflect/AccessibleObject/ModuleSetAccessibleTest.java
+ test/java/lang/reflect/Layer/BasicLayerTest.java
+ test/java/lang/reflect/Layer/LayerAndLoadersTest.java
+ test/java/lang/reflect/Layer/layertest/Test.java
+ test/java/lang/reflect/Layer/src/m1/module-info.java
+ test/java/lang/reflect/Layer/src/m1/p/Main.java
+ test/java/lang/reflect/Layer/src/m1/p/Service.java
+ test/java/lang/reflect/Layer/src/m2/module-info.java
+ test/java/lang/reflect/Layer/src/m2/q/Hello.java
+ test/java/lang/reflect/Layer/src/m3/module-info.java
+ test/java/lang/reflect/Layer/src/m3/w/Hello.java
+ test/java/lang/reflect/Layer/src/m4/impl/ServiceImpl.java
+ test/java/lang/reflect/Layer/src/m4/module-info.java
+ test/java/lang/reflect/Module/AddExportsTest.java
+ test/java/lang/reflect/Module/BasicModuleTest.java
+ test/java/lang/reflect/Module/access/AccessTest.java
+ test/java/lang/reflect/Module/access/src/target/module-info.java
+ test/java/lang/reflect/Module/access/src/target/p/Exported.java
+ test/java/lang/reflect/Module/access/src/target/p/Helper.java
+ test/java/lang/reflect/Module/access/src/target/q/Internal.java
+ test/java/lang/reflect/Module/access/src/test/module-info.java
+ test/java/lang/reflect/Module/access/src/test/test/Main.java
+ test/java/lang/reflect/Proxy/ProxyClassAccessTest.java
+ test/java/lang/reflect/Proxy/ProxyForMethodHandle.java
+ test/java/lang/reflect/Proxy/ProxyLayerTest.java
+ test/java/lang/reflect/Proxy/ProxyModuleMapping.java
+ test/java/lang/reflect/Proxy/ProxyTest.java
+ test/java/lang/reflect/Proxy/q/NP.java
+ test/java/lang/reflect/Proxy/q/U.java
+ test/java/lang/reflect/Proxy/src/m1/module-info.java
+ test/java/lang/reflect/Proxy/src/m1/p/one/I.java
+ test/java/lang/reflect/Proxy/src/m1/p/one/internal/J.java
+ test/java/lang/reflect/Proxy/src/m2/module-info.java
+ test/java/lang/reflect/Proxy/src/m2/p/two/A.java
+ test/java/lang/reflect/Proxy/src/m2/p/two/B.java
+ test/java/lang/reflect/Proxy/src/m2/p/two/Bar.java
+ test/java/lang/reflect/Proxy/src/m2/p/two/internal/C.java
+ test/java/lang/reflect/Proxy/src/m3/module-info.java
+ test/java/lang/reflect/Proxy/src/m3/p/three/P.java
+ test/java/lang/reflect/Proxy/src/m3/p/three/internal/Q.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/Main.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/NP.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/ProxyClassAccess.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/ProxyTest.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/internal/R.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/internal/RImpl.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/internal/foo/Foo.java
+ test/java/lang/reflect/Proxy/src/test/jdk/test/internal/foo/FooException.java
+ test/java/lang/reflect/Proxy/src/test/module-info.java
! test/java/security/Provider/SecurityProviderModularTest.java
+ test/java/util/ServiceLoader/modules/BasicTest.java
+ test/java/util/ServiceLoader/modules/ServicesTest.java
+ test/java/util/ServiceLoader/modules/src/bananascript/module-info.java
+ 
test/java/util/ServiceLoader/modules/src/bananascript/org/banana/BananaScript.java
+ 
test/java/util/ServiceLoader/modules/src/bananascript/org/banana/BananaScriptEngineFactory.java
+ 
test/java/util/ServiceLoader/modules/src/pearscript/META-INF/services/javax.script.ScriptEngineFactory
+ test/java/util/ServiceLoader/modules/src/pearscript/org/pear/PearScript.java
+ 
test/java/util/ServiceLoader/modules/src/pearscript/org/pear/PearScriptEngineFactory.java
+ test/java/util/ServiceLoader/modules/src/test/module-info.java
+ test/java/util/ServiceLoader/modules/src/test/test/Main.java
! 

Re: Package, import and type declarations are allowed now in module-info.java by spec

[Paul Benedict]

On Mon, Mar 14, 2016 at 5:21 PM, Alex Buckley 
wrote:

> The JLS doesn't know what the string "module-info.class" means or what a
> "JAR root" is.


Of course. Though that wasn't my ultimate point; I was merely illustrating
(philosophically) why having "package" in module-info.java is nonsensical
syntax. A "package" statement doesn't mean anything useful in the context
of specifying module configuration. As far as I am aware, the module syntax
is meant to standalone in the file, but please correct me if you have other
intentions for the syntax. If you can also declare types, then a "package"
statement begins to make more sense -- but it would seem like a clumsy way
of doing things, which I wouldn't advocate (or allow syntactically).

Cheers,
Paul


> In 3/14/2016 9:08 AM, Paul Benedict wrote:
>
>> Alex, you wrote: "The JLS doesn't prevent javac from rejecting a package
>> declaration or an import declaration in a file called module-info.java."
>>
>> It seems that a package declaration, in this context, should be
>> prohibited syntax because module-info.class is always in the JAR root
>> which has no package.
>>
>> Cheers,
>> Paul
>>
>> On Wed, Mar 9, 2016 at 4:02 PM, Alex Buckley > > wrote:
>>
>> The JLS doesn't prevent javac from rejecting a package declaration
>> or an import declaration in a file called module-info.java.
>>
>> In fact, since a package declaration or import declaration must be
>> followed by a type declaration, and since a type declaration cannot
>> use a hyphen, javac is free to take the optional rule from JLS 7.6
>> -- filename must align with type declaration -- and develop it
>> further: rejecting a package declaration or import declaration in
>> module-info.java because the filename cannot possibly align with any
>> type declaration.
>>
>> I can't speak to what a particular EA build of javac is doing with a
>> particular option. javac options are irrelevant to the JLS. If a
>> compiler accepts the Java language circa SE 9, then a module
>> declaration is a valid compilation unit. What's the name of the file
>> containing such a compilation unit? Anything the compiler likes.
>>
>> Alex
>>
>> On 3/9/2016 5:14 AM, Georgiy Rakov wrote:
>>
>> Hi Alex,
>>
>> if I understand correctly you mean about following assertions
>> from JLS 7.6:
>>
>>  If and only if packages are stored in a file system (§7.2
>>
>> <
>> http://docs.oracle.com/javase/specs/jls/se8/html/jls-7.html#jls-7.2>),
>>  the host system may choose to enforce the restriction that
>> it is a
>>  compile-time error if a type is not found in a file under a
>> name
>>  composed of the type name plus an extension (such as
>> |.java|or
>>  |.jav|) if either of the following is true:
>>
>>*
>>
>>  The type is referred to by code in other compilation
>> units of
>>  the package in which the type is declared.
>>
>>*
>>
>>  The type is declared |public|(and therefore is
>> potentially
>>  accessible from code in other packages).
>>
>> Literally these assertion doesn't make presented behavior
>> corresponding
>> to spec because the declared type is neither public nor being
>> referred
>> to from other sources being compiled.
>>
>> Nevertheless following sources doesn't compile either despite
>> the fact
>> that no types are declared there at all.
>> Namely when only package is specified:
>>
>>  mod\module-info.java:
>>  module mod {
>>   exports pkg;
>>  }
>>
>>  mod\pkg\module-info.java:
>>  package pkg;
>>
>> then compiling it by following command line with javac from [2]:
>>
>>  javac -modulesourcepath . mod\module-info.java
>> mod\pkg\module-info.java
>>
>> causes following output:
>>
>>  mod\pkg\module-info.java:1: error: expected 'module
>>  package pkg;
>>  ^
>>  1 error
>>
>> When only import statment is specified:
>>
>>  mod\module-info.java:
>>  module mod {
>>   exports pkg;
>>  }
>>
>>  mod\pkg\module-info.java:
>>  import java.util.List;
>>
>> then compiling it by following command line with javac from [2]:
>>
>>  javac -modulesourcepath . mod\module-info.java
>> mod\pkg\module-info.java
>>
>> causes following output:
>>
>>  mod\pkg\module-info.java:1: error: expected 'module'
>>  import java.util.List;
>>  ^
>>  1 error
>>
>> Please see minimized test cases attached in 

hg: jigsaw/jake/jdk: VerifyStackTrace.java test fails with 9-ea version

[mandy . chung]

Changeset: 6b54aaa39cd1
Author:mchung
Date:  2016-03-15 09:58 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6b54aaa39cd1

VerifyStackTrace.java test fails with 9-ea version

! test/java/lang/StackWalker/VerifyStackTrace.java

hg: jigsaw/jake/jdk: Update example in javadoc to make it clearer

[alan . bateman]

Changeset: 9c4e80fb153e
Author:alanb
Date:  2016-03-15 16:19 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9c4e80fb153e

Update example in javadoc to make it clearer

! src/java.base/share/classes/java/lang/module/Configuration.java

hg: jigsaw/jake/hotspot: Fix open build problem.

[harold . seigel]

Changeset: 23944543f258
Author:hseigel
Date:  2016-03-15 11:37 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/23944543f258

Fix open build problem.

! src/share/vm/trace/traceBackend.cpp

hg: jigsaw/jake/langtools: jdk/jshell/ToolFormatTest.java still failing

[alan . bateman]

Changeset: 7b926e339f9d
Author:alanb
Date:  2016-03-15 16:00 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7b926e339f9d

jdk/jshell/ToolFormatTest.java still failing

! test/jdk/jshell/ToolFormatTest.java

hg: jigsaw/jake: Changing Jib dependency for jtreg to 4.2 b01

[erik . joelsson]

Changeset: 65b3f0d0bc2c
Author:erikj
Date:  2016-03-15 16:45 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/65b3f0d0bc2c

Changing Jib dependency for jtreg to 4.2 b01

! common/conf/jib-profiles.js

Re: jlink tool review (Re: Initial webrev with changes for JDK 9)

[Sundararajan Athijegannathan]

Hi,

Thanks for the review. I've filed a bug to track your suggestions:
https://bugs.openjdk.java.net/browse/JDK-8151896

Thanks,
-Sundar

On 3/14/2016 6:26 PM, Michael Haupt wrote:
> Hi again,
>
> some certain list server doesn't like attachments. ;-)
> Find it at http://cr.openjdk.java.net/~mhaupt/jigsaw/
>
> Best,
>
> Michael
>
>> Am 14.03.2016 um 13:49 schrieb Michael Haupt :
>>
>> Alan, all,
>>
>> please find a patch with suggested changes to jlink in the attachment. The 
>> patch also contains a file named review-comments.txt, which addresses 
>> several topics throughout jlink. I've covered most code; only the 
>> jlink.internal package is still missing. I've been able to compile jake with 
>> these refactorings applied; I have not yet run all the jlink tests.
>>
>> Unfortunately, I have to lay down the review work at this time; Sundar is 
>> taking over (thanks!!). I'm available for clarification matters.
>>
>> Best,
>>
>> Michael
>

hg: jigsaw/jake/hotspot: Clean up of InstanceKlass casts within verify_check_access_msg based on code review comment.

[lois . foltan]

Changeset: bc1f549323f8
Author:lfoltan
Date:  2016-03-15 10:22 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bc1f549323f8

Clean up of InstanceKlass casts within verify_check_access_msg based on code 
review comment.

! src/share/vm/runtime/reflection.cpp

hg: jigsaw/jake/jdk: 2 new changesets

[alan . bateman]

Changeset: f8ff31f1b257
Author:alanb
Date:  2016-03-15 14:35 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f8ff31f1b257

Missing javadoc for toString/equals/hashCode

! src/java.base/share/classes/java/lang/module/Configuration.java
! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java
! src/java.base/share/classes/java/lang/module/ModuleReference.java
! src/java.base/share/classes/java/lang/module/ResolvedModule.java
! src/java.base/share/classes/java/lang/reflect/Module.java

Changeset: ae2511546022
Author:alanb
Date:  2016-03-15 14:38 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ae2511546022

Constructor specific javadoc showing up in Method and Field

! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java
! src/java.base/share/classes/java/lang/reflect/Constructor.java

hg: jigsaw/jake/hotspot: Partial fix for open build issue.

[harold . seigel]

Changeset: 13a7333a92ab
Author:hseigel
Date:  2016-03-15 10:03 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/13a7333a92ab

Partial fix for open build issue.

! src/share/vm/trace/traceTypes.xsl

Re: Initial webrev with changes for JDK 9

[Peter Levart]

Sorry,

On 03/15/2016 02:56 PM, Peter Levart wrote:
If you also care for constant lambda, this could be optimized even 
further, but for the price of more complex code:



NamedPackage p = packages.get(name);

if (p instanceof Package) {
return (Package) p;
} else if (p == null) {
Package pkg = NamedPackage.toPackage(name, m);
p = packages.putIfAbsent(name, pkg);
if (p == null) {
return pkg;
}
}

return (Package)packages.compute((n, p) -> {


return (Package)packages.compute(name, (n, p) -> {


assert p != null;
// replace NamedPackage with Package
return (p instanceof Package) ? p : 
NamedPackage.toPackage(p.name(), p.module());
}); 

hg: jigsaw/jake/jdk: Add @implNote warning that jdk.internal.jimage/jrtfs must maintain backwards-compatibility with JDK 8

[sundararajan . athijegannathan]

Changeset: 905d45f82376
Author:sundar
Date:  2016-03-15 19:45 +0530
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/905d45f82376

Add @implNote warning that jdk.internal.jimage/jrtfs must maintain 
backwards-compatibility with JDK 8
Reviewed-by: sundar
Contributed-by: claes.redes...@oracle.com

! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageBufferCache.java
! src/java.base/share/classes/jdk/internal/jimage/ImageHeader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageLocation.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStream.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStrings.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStringsReader.java
! src/java.base/share/classes/jdk/internal/jimage/NativeImageBuffer.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressIndexes.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressedResourceHeader.java
! src/java.base/share/classes/jdk/internal/jimage/decompressor/Decompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressorFactory.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressorRepository.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/SignatureParser.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/StringSharingDecompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/StringSharingDecompressorFactory.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ZipDecompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ZipDecompressorFactory.java
! src/java.base/share/classes/jdk/internal/jrtfs/AbstractJrtFileAttributes.java
! src/java.base/share/classes/jdk/internal/jrtfs/AbstractJrtFileSystem.java
! src/java.base/share/classes/jdk/internal/jrtfs/AbstractJrtPath.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtDirectoryStream.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtExplodedFileAttributes.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtExplodedFileSystem.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtExplodedPath.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileAttributeView.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileAttributes.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileStore.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtPath.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtUtils.java
! src/java.base/share/classes/jdk/internal/jrtfs/SystemImages.java
! src/java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js
! src/java.base/share/classes/jdk/internal/jrtfs/jrtls.js

Re: Initial webrev with changes for JDK 9

[Peter Levart]

Hi Alan, Paul,

Just a comment on comment: wouldn't the variant with a single compute 
replace a Package with itself on each repeated call? Semantically it is 
the same, but there is a volatile memory store on the cache-hit involved 
where in the original variant, it isn't...


On 03/11/2016 05:50 PM, Paul Sandoz wrote:

j.l.ClassLoader
—

1777 // define Package object if the named package is not yet defined
1778 NamedPackage p = packages.computeIfAbsent(name,
1779   k -> 
NamedPackage.toPackage(name, m));
1780 if (p instanceof Package)
1781 return (Package)p;
1782
1783 // otherwise, replace the NamedPackage object with Package object
1784 return (Package)packages.compute(name, this::toPackage);

You could merge the computeIfAbsent and compute into a single compute call if 
you so wish.

return (Package)packages.compute((n, p) -> {
   // define Package object if the named package is not yet defined
   if (p == null) return NamedPackage.toPackage(name, m);
   // otherwise, replace the NamedPackage object with Package object
   return (p instanceof Package) ? p : toPackage(n, p);
});


You could pre-screen the .compute with a .get and this would be the more 
optimal (no locking on cache-hits):


NamedPackage p = packages.get(name);
if (p instanceof Package) {
return (Package) p;
}

return (Package)packages.compute((n, p) -> {
  // define Package object if it is not yet defined or replace it if it 
is a NamedPackage

  return (p instanceof Package) ? p : NamedPackage.toPackage(n, m);
});

See, no private ClassLoader.toPackage(String name, NamedPackage p) needed.


If you also care for constant lambda, this could be optimized even 
further, but for the price of more complex code:



NamedPackage p = packages.get(name);

if (p instanceof Package) {
return (Package) p;
} else if (p == null) {
Package pkg = NamedPackage.toPackage(name, m);
p = packages.putIfAbsent(name, pkg);
if (p == null) {
return pkg;
}
}

return (Package)packages.compute((n, p) -> {
assert p != null;
// replace NamedPackage with Package
return (p instanceof Package) ? p : 
NamedPackage.toPackage(p.name(), p.module());

});


Regards, Peter

hg: jigsaw/jake/jdk: Rename args to match names in JVM. Part of fix for JDK-8151816.

[harold . seigel]

Changeset: 1e6e0c32f51e
Author:hseigel
Date:  2016-03-15 08:45 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1e6e0c32f51e

Rename args to match names in JVM.  Part of fix for JDK-8151816.

! src/java.base/share/native/include/jni.h

hg: jigsaw/jake/hotspot: Update JNI AddModuleReads() and CanReadModule() to disallow NULL (JDK-8151816) and fix test failures (JDK-8151817)

[harold . seigel]

Changeset: 07df4997bf44
Author:hseigel
Date:  2016-03-15 08:41 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/07df4997bf44

Update JNI AddModuleReads() and CanReadModule() to disallow NULL (JDK-8151816) 
and fix test failures (JDK-8151817)

! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jni.h
! test/runtime/modules/AccessCheck/DiffCL_UmodUpkg.java
! test/runtime/modules/AccessCheck/UmodUPkg.java
! test/runtime/modules/AccessCheck/myloaders/MyDiffClassLoader.java
! test/runtime/modules/AccessCheck/myloaders/MySameClassLoader.java
- test/runtime/modules/AccessCheck/p3/c3Loose.jcod
! test/runtime/modules/getModuleJNI/GetModule.java

Re: Initial webrev with changes for JDK 9

[Yuri Nesterenko]

On 03/15/2016 02:22 PM, Alan Bateman wrote:
[...]


Yuri needs to look at test/java/awt/xembed/server/TesterClient.java as
that addExports usage is not right. I hope Yuri can also help on your

^ this one is historic: it is from immemorial July while the Helper
class is dated by December. I could piggyback a change to
the new version of my test fix currently on review.


comment about why skipTestingEmbeddedFrame=true is commented out in
test/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java.

Originally, the tests run twice (second time with EmbeddedFrame)
and reported "do not skipTestingEmbeddedFrame" in between.
Then the Mac port work started, and that second run was skipped for Mac.
Then unskipped.



test/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh
could do with a clean-up too, I assume the @compile was dropped because
the test is invoking javac directly now.

Exactly; it requires now a different set of compile-time flags
for every platform which is hard to pass in @compile. I decided not
to remove it as a sign "avoid this" for a future reader.
But then, what should I clean there? A commented out part?
I could also append a change to the outstanding fix.

-yan

hg: jigsaw/jake/jdk: jartool: code review comments

[chris . hegarty]

Changeset: 507b98946557
Author:chegar
Date:  2016-03-15 12:14 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/507b98946557

jartool: code review comments

! src/jdk.jartool/share/classes/sun/tools/jar/Main.java
! test/tools/jar/modularJar/Basic.java

hg: jigsaw/jake/jdk: Update com.sun.jdi.ModuleReference to use consistent param name

[alan . bateman]

Changeset: 03a2b5f7c9e5
Author:alanb
Date:  2016-03-15 11:47 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/03a2b5f7c9e5

Update com.sun.jdi.ModuleReference to use consistent param name

! src/jdk.jdi/share/classes/com/sun/jdi/ModuleReference.java

hg: jigsaw/jake/langtools: jdk/jshell/ToolFormatTest.java failing

[alan . bateman]

Changeset: b50953acc2b9
Author:alanb
Date:  2016-03-15 11:30 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b50953acc2b9

jdk/jshell/ToolFormatTest.java failing

! test/jdk/jshell/ToolFormatTest.java

Re: Initial webrev with changes for JDK 9

[Alan Bateman]

Thanks again for going through all the changes in this area.

I've reverted the changes to java/awt/color/ICC_Profile.java and 
sun/print/ServiceDialog.java as they changes were clearly left over from 
early exploration into resource encapsulation.


I've decided not to touch com/apple/laf/AquaUtils.java as that is 
something that should be cleaned up in jdk9/client. The only reason we 
had to touch this code was because it directly used sun.misc.Launcher, 
which is now gone.


Yuri needs to look at test/java/awt/xembed/server/TesterClient.java as 
that addExports usage is not right. I hope Yuri can also help on your 
comment about why skipTestingEmbeddedFrame=true is commented out in 
test/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java.


test/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh 
could do with a clean-up too, I assume the @compile was dropped because 
the test is invoking javac directly now.


-Alan

hg: jigsaw/jake/jdk: Revert ICC_Profile and ServiceDialog, patches from early phases not needed

[alan . bateman]

Changeset: a3e1d44fc6ac
Author:alanb
Date:  2016-03-15 11:14 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a3e1d44fc6ac

Revert ICC_Profile and ServiceDialog, patches from early phases not needed

! src/java.desktop/share/classes/java/awt/color/ICC_Profile.java
! src/java.desktop/share/classes/sun/print/ServiceDialog.java
! test/java/awt/patchlib/java.desktop/java/awt/Helper.java

hg: jigsaw/jake/jdk: java/net/http/SelectorTest.java failing

[alan . bateman]

Changeset: 421bd705bf16
Author:alanb
Date:  2016-03-15 10:26 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/421bd705bf16

java/net/http/SelectorTest.java failing

+ test/java/net/httpclient/whitebox/Driver.java
- test/java/net/httpclient/whitebox/TEST.properties
+ 
test/java/net/httpclient/whitebox/java.httpclient/java/net/http/SelectorTest.java
- test/java/net/httpclient/whitebox/java/net/http/SelectorTest.java

hg: jigsaw/jake/hotspot: Add implementation file for tracebackend

[alan . bateman]

Changeset: 398601df5686
Author:mgronlun
Date:  2016-03-15 09:38 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/398601df5686

Add implementation file for tracebackend

+ src/share/vm/trace/traceBackend.cpp

hg: jigsaw/jake/jaxp: jaxp unittest tests need @modules new internal API

[mandy . chung]

Changeset: 8748c27f511b
Author:mchung
Date:  2016-03-15 00:52 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/8748c27f511b

jaxp unittest tests need @modules new internal API

! test/javax/xml/jaxp/unittest/TEST.properties

hg: jigsaw/jake/langtools: 12 new changesets

[mandy . chung]

Changeset: 01fdf839bbe6
Author:vromero
Date:  2016-03-07 13:45 -0500
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/01fdf839bbe6

8139474: -release 7 -verbose causes Javac exception
Reviewed-by: jjg

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/RelativePath.java
! 
src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
+ test/tools/javac/T8139474/DashRelease7DashVerboseTest.java

Changeset: a61a3c4a3cb3
Author:bchristi
Date:  2016-03-08 11:37 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a61a3c4a3cb3

8148187: Remove OS X-specific com.apple.concurrent package
Summary: Removed jdk.deploy.osx module (including com.apple.concurrent)
Reviewed-by: alanb, erikj, mchung

! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/ct.properties
! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Profile.java

Changeset: 08b48678df34
Author:rfield
Date:  2016-03-08 11:53 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/08b48678df34

8148316: jshell tool: Configurable output format
8148317: jshell tool: unify commands into /set
8149524: JShell: CompletenessAnalysis fails on class Case, 
E2 extends Enum, E3 extends Enum> {}
Reviewed-by: jlahoda

+ src/jdk.jshell/share/classes/jdk/internal/jshell/tool/ArgTokenizer.java
+ src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Feedback.java
! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
! src/jdk.jshell/share/classes/jdk/jshell/CompletenessAnalyzer.java
! test/jdk/jshell/CommandCompletionTest.java
! test/jdk/jshell/CompletenessTest.java
! test/jdk/jshell/ExternalEditorTest.java
! test/jdk/jshell/ReplToolTesting.java
! test/jdk/jshell/ToolBasicTest.java
+ test/jdk/jshell/ToolFormatTest.java

Changeset: 7a9d55dbfb84
Author:shade
Date:  2016-03-09 12:52 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7a9d55dbfb84

8151223: String concatenation fails with implicit toString() on package-private 
class
Reviewed-by: mcimadamore, forax

! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/StringConcat.java
+ test/tools/javac/StringConcat/access/Holder.java
+ test/tools/javac/StringConcat/access/PublicClass.java
+ test/tools/javac/StringConcat/access/PublicInterface.java
+ test/tools/javac/StringConcat/access/Public_PrivateInterface1.java
+ test/tools/javac/StringConcat/access/Public_PrivateInterface2.java
+ test/tools/javac/StringConcat/access/Public_PublicClass.java
+ test/tools/javac/StringConcat/access/Public_PublicInterface.java
+ test/tools/javac/StringConcat/access/Test.java

Changeset: d04881ed4d86
Author:shade
Date:  2016-03-09 18:31 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d04881ed4d86

8151516: test/tools/javac/TestIndyStringConcat depends on runtime JDK details
Reviewed-by: mcimadamore

+ test/tools/javac/StringConcat/TestIndyStringConcat.java
! test/tools/javac/StringConcat/access/Test.java
- test/tools/javac/TestIndyStringConcat.java

Changeset: 985695afdd3a
Author:simonis
Date:  2016-03-10 08:54 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/985695afdd3a

8150632: jdk.jshell.TaskFactory should use jdk.Version to check for 
java.specification.version
Reviewed-by: rfield

! src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java

Changeset: b2a8c7611686
Author:lana
Date:  2016-03-10 09:51 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b2a8c7611686

Merge

- test/tools/javac/TestIndyStringConcat.java

Changeset: 0356613310dd
Author:rfield
Date:  2016-03-10 14:47 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0356613310dd

8080069: JShell: Support for corralled classes
Reviewed-by: jlahoda

! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
+ src/jdk.jshell/share/classes/jdk/jshell/Corraller.java
! src/jdk.jshell/share/classes/jdk/jshell/Eval.java
! src/jdk.jshell/share/classes/jdk/jshell/ExecutionControl.java
! src/jdk.jshell/share/classes/jdk/jshell/UnresolvedReferenceException.java
! src/jdk.jshell/share/classes/jdk/jshell/Wrap.java
! test/jdk/jshell/ClassesTest.java
! test/jdk/jshell/DropTest.java
! test/jdk/jshell/KullaTesting.java
! test/jdk/jshell/ReplaceTest.java

Changeset: 9c3966e9a7a7
Author:ksrini
Date:  2016-02-24 15:31 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9c3966e9a7a7

8149139: [javadoc] Modify Content to accept CharSequence
Reviewed-by: jjg

! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java
! 

hg: jigsaw/jake/jaxp: 3 new changesets

[mandy . chung]

Changeset: 0fe7231b64a6
Author:joehw
Date:  2016-03-09 16:09 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/0fe7231b64a6

8150704: XALAN: ERROR: 'No more DTM IDs are available' when transforming with 
lots of temporary result trees
Reviewed-by: joehw
Contributed-by: christoph.lan...@sap.com

! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/DOM.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyTemplates.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CallTemplate.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Sort.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SyntaxTreeNode.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Template.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableBase.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/WithParam.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AdaptiveResultTreeImpl.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DOMAdapter.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultiDOM.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SAXImpl.java
! 
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SimpleResultTreeImpl.java
- test/javax/xml/jaxp/unittest/transform/Bug4693341.out
! test/javax/xml/jaxp/unittest/transform/Bug4693341Test.java
- test/javax/xml/jaxp/unittest/transform/Bug4693341_golden.dtd
- test/javax/xml/jaxp/unittest/transform/Bug4693341_golden.xml
- test/javax/xml/jaxp/unittest/transform/Bug6505031.java
+ test/javax/xml/jaxp/unittest/transform/Bug8150704-1.ref
+ test/javax/xml/jaxp/unittest/transform/Bug8150704-1.xml
+ test/javax/xml/jaxp/unittest/transform/Bug8150704-1.xsl
+ test/javax/xml/jaxp/unittest/transform/Bug8150704-2.ref
+ test/javax/xml/jaxp/unittest/transform/Bug8150704-2.xml
+ test/javax/xml/jaxp/unittest/transform/Bug8150704-2.xsl
! test/javax/xml/jaxp/unittest/transform/TransformerTest.java

Changeset: 1c1bb661d35b
Author:lana
Date:  2016-03-10 09:51 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/1c1bb661d35b

Merge

- test/javax/xml/jaxp/unittest/transform/Bug4693341.out
- test/javax/xml/jaxp/unittest/transform/Bug4693341_golden.dtd
- test/javax/xml/jaxp/unittest/transform/Bug4693341_golden.xml
- test/javax/xml/jaxp/unittest/transform/Bug6505031.java

Changeset: bc96fc213c03
Author:henryjen
Date:  2016-03-14 20:44 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/bc96fc213c03

Merge

- test/javax/xml/jaxp/unittest/transform/Bug4693341.out
- test/javax/xml/jaxp/unittest/transform/Bug4693341_golden.dtd
- test/javax/xml/jaxp/unittest/transform/Bug4693341_golden.xml
- test/javax/xml/jaxp/unittest/transform/Bug6505031.java

hg: jigsaw/jake/hotspot: 111 new changesets

[mandy . chung]

Changeset: 9900740dd51f
Author:ppunegov
Date:  2016-02-17 17:48 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9900740dd51f

8144621: CompilerControl: inline tests timeout with Xcomp
Summary: Restrict patterns that lead to timeout
Reviewed-by: kvn, neliasso

! test/compiler/compilercontrol/share/AbstractTestBase.java

Changeset: 2c3c43037e14
Author:thartmann
Date:  2016-02-19 10:06 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2c3c43037e14

8145707: 4 Null pointer dereference defect groups in compileBroker.cpp.
Summary: Added explicit null checks to fix possible null pointer dereference 
errors for internal tests.
Reviewed-by: kvn
Contributed-by: Rahul Raghavan 

! src/share/vm/compiler/compileBroker.cpp

Changeset: a97431603d3f
Author:vlivanov
Date:  2016-02-19 20:40 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a97431603d3f

7177745: JSR292: Many Callsite relinkages cause target method to always run in 
interpreter mode
Reviewed-by: jrose, kvn

! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/code/dependencies.hpp
! src/share/vm/code/dependencyContext.cpp
! src/share/vm/code/nmethod.cpp
! src/share/vm/code/nmethod.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/runtime/vmStructs.cpp
+ test/compiler/jsr292/ContinuousCallSiteTargetChange.java

Changeset: b3434fcd4e11
Author:vlivanov
Date:  2016-02-19 20:41 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b3434fcd4e11

8149741: Don't refer to stub entry points by index in external_word relocations
Reviewed-by: kvn

! src/cpu/x86/vm/templateInterpreterGenerator_x86.cpp
! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp
! src/share/vm/code/relocInfo.cpp
! src/share/vm/code/relocInfo.hpp
! src/share/vm/prims/jvmtiCodeBlobEvents.cpp
! src/share/vm/runtime/stubCodeGenerator.cpp
! src/share/vm/runtime/stubCodeGenerator.hpp

Changeset: d743113e99e2
Author:vlivanov
Date:  2016-02-19 20:45 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d743113e99e2

8067014: LinearScan::is_sorted significantly slows down fastdebug builds' 
performance
Reviewed-by: vlivanov, shade

! src/share/vm/c1/c1_CFGPrinter.hpp
! src/share/vm/c1/c1_LinearScan.cpp
! src/share/vm/c1/c1_LinearScan.hpp

Changeset: f1c5937e76a2
Author:mdoerr
Date:  2016-02-19 11:09 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f1c5937e76a2

8149655: PPC64: Implement CompactString intrinsics
Reviewed-by: goetz, kvn

! src/cpu/ppc/vm/globals_ppc.hpp
! src/cpu/ppc/vm/macroAssembler_ppc.cpp
! src/cpu/ppc/vm/macroAssembler_ppc.hpp
! src/cpu/ppc/vm/ppc.ad
! src/cpu/ppc/vm/stubGenerator_ppc.cpp
! src/cpu/ppc/vm/vm_version_ppc.cpp
! src/cpu/ppc/vm/vm_version_ppc.hpp
! test/compiler/intrinsics/string/TestStringIntrinsics2.java

Changeset: bc4aca25ef2a
Author:kshefov
Date:  2016-02-20 11:44 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bc4aca25ef2a

8141616: Add new methods to the java Whitebox API
Reviewed-by: kvn, dpochepk

! src/share/vm/prims/whitebox.cpp

Changeset: ed4f837cee25
Author:kshefov
Date:  2016-02-20 11:49 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ed4f837cee25

8141618: Change JVMCI compilerToVM constant pool tests to support CP cache
Reviewed-by: twisti, dpochepk

! test/compiler/jvmci/common/testcases/MultipleAbstractImplementer.java
! test/compiler/jvmci/common/testcases/MultipleImplementer2.java
! test/compiler/jvmci/common/testcases/MultipleImplementersInterface.java
! test/compiler/jvmci/compilerToVM/ConstantPoolTestCase.java
! test/compiler/jvmci/compilerToVM/ConstantPoolTestsHelper.java
! test/compiler/jvmci/compilerToVM/LookupKlassInPoolTest.java
! test/compiler/jvmci/compilerToVM/ResolveConstantInPoolTest.java
! test/compiler/jvmci/compilerToVM/ResolveTypeInPoolTest.java

Changeset: a8377a286e90
Author:kshefov
Date:  2016-02-20 11:49 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a8377a286e90

8141619: Develop new tests for JVMCI compilerToVM class' CP related methods
Reviewed-by: twisti, dpochepk

+ test/compiler/jvmci/compilerToVM/LookupKlassRefIndexInPoolTest.java
+ test/compiler/jvmci/compilerToVM/LookupMethodInPoolTest.java
+ test/compiler/jvmci/compilerToVM/LookupNameAndTypeRefIndexInPoolTest.java
+ test/compiler/jvmci/compilerToVM/LookupNameInPoolTest.java
+ test/compiler/jvmci/compilerToVM/LookupSignatureInPoolTest.java
+ test/compiler/jvmci/compilerToVM/ResolveFieldInPoolTest.java
+ test/compiler/jvmci/compilerToVM/ResolvePossiblyCachedConstantInPoolTest.java

Changeset: e06b9173b181
Author:thartmann
Date:  2016-02-22 08:04 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e06b9173b181

Merge

! src/cpu/ppc/vm/globals_ppc.hpp

Changeset: 55778b6121e3
Author:roland
Date:  2016-02-15