hg: jigsaw/jake/jdk: 3 new changesets

[mandy . chung]

Changeset: e1d07d9c9e64
Author:mchung
Date:  2016-11-24 22:30 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e1d07d9c9e64

Remove temporary copying of copyright/license to jmod

! make/copy/Copy-java.base.gmk
! make/copy/CopyCommon.gmk

Changeset: 673f6b89cd09
Author:mchung
Date:  2016-11-24 22:31 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/673f6b89cd09

Clean up jlink system module plugin code

! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModuleDescriptorPlugin.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/ResourcePoolEntry.java

Changeset: b20b41370415
Author:mchung
Date:  2016-11-24 22:32 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b20b41370415

--list-modules to print automatic module

! src/java.base/share/classes/sun/launcher/LauncherHelper.java

hg: jigsaw/jake/jdk: jar tool to handle entries with META-INF/versions path

[mandy . chung]

Changeset: c0170badab7d
Author:mchung
Date:  2016-11-24 13:51 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c0170badab7d

jar tool to handle entries with META-INF/versions path

! src/java.base/share/classes/module-info.java
! src/jdk.jartool/share/classes/sun/tools/jar/Main.java
! src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties
+ test/tools/jar/multiRelease/Basic1.java

Re: Replacement for JDK8 APIs

[Alan Bateman]

On 24/11/2016 14:22, Stéphane Nicoll wrote:


:

We use "sun.misc.VMSupport" to retrieve the port being used by the Java
remote debugging. You can find the actual code in RemoteDebugPortProvider[3]

This class was never intended to be used directly of course. It doesn't 
exist (or rather it has moved) in JDK 9. Are you grabbing the port so 
that it can be published for debuggers to attach? Have you considered 
publishing the pid instead - that would allow debuggers to use the 
ProcessAttachingConnector to attach.


-Alan

Re: modules and tests

[Jochen Theodorou]

On 24.11.2016 16:41, Alan Bateman wrote:
[...]

to Alan and Sander:
setting command line arguments or using a build tool to fiddle them
for you is exactly what we do not want here! We want fidelity between
the compile time configuration and the runtime configuration. Having
to play with -Xpatch at runtime is conceptually exactly like setting
the classpath. I don't want to explain to the Java devs that we have
fidelity between compile-time and runtime on source code but not on
test code.


I hope in time that there will be support from the tools, plugins, test
runners ... so that regular developers don't need to be concerned with
this.


I don't understand why it is better if a tool does -Xpatch, than when I 
do it myself. Anything else will require several classes be loaded that 
will change how the modules work and influence the tests with their 
present and their dependencies


bye Jochen

hg: jigsaw/jake/jdk: Fixed typos in javadoc

[alan . bateman]

Changeset: 09b3083d7de2
Author:alanb
Date:  2016-11-24 16:19 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/09b3083d7de2

Fixed typos in javadoc

! src/java.base/share/classes/java/util/ServiceLoader.java

Re: modules and tests

[Alan Bateman]

On 24/11/2016 14:39, Remi Forax wrote:

:
to Alan:
currently you can not get your test framework as a service and you can not 
declare your test as a provider for a test infrastructure like jenkins (i.e. 
there is no --uses and --provides).
Fair point, uses/provides can't currently be augmented via the 
command-line but this is only because it hasn't been needed.




to Alan and Sander:
setting command line arguments or using a build tool to fiddle them for you is 
exactly what we do not want here! We want fidelity between the compile time 
configuration and the runtime configuration. Having to play with -Xpatch at 
runtime is conceptually exactly like setting the classpath. I don't want to 
explain to the Java devs that we have fidelity between compile-time and runtime 
on source code but not on test code.

I hope in time that there will be support from the tools, plugins, test 
runners ... so that regular developers don't need to be concerned with this.


-Alan

Code review for jigsaw/jake -> jdk9/dev sync up

[Alan Bateman]

Folks on jigsaw-dev will know that we are on a mission to bring the 
changes accumulated in the jake forest to jdk9/dev. We can think of this 
as a refresh of the module system in JDK 9, the last big refresh was in 
May with many small updates since then.


The focus this time is to bring the changes that are tied to JSR issues 
into jdk9/dev, specifically the issues that are tracked on the JSR 
issues list [1] as:


#CompileTimeDependences
#AddExportsInManifest
#ClassFileModuleName
#ClassFileAccPublic
#ServiceLoaderEnhancements
#ResourceEncapsulation/#ClassFilesAsResources
#ReflectiveAccessToNonExportedTypes
#AwkwardStrongEncapsulation
#ReadabilityAddedByLayerCreator
#IndirectQualifiedReflectiveAccess (partial)
#VersionsInModuleNames
#NonHierarchicalLayers
#ModuleAnnotations/#ModuleDeprecation
#ReflectiveAccessByInstrumentationAgents

Some of these issues are not "Resolved" yet, meaning there is still 
ongoing discussion on the EG mailing list. That is okay, there is 
nothing final here. If there are changes to these proposals then the 
implementation changes will follow. Also, as I said in a mail to 
jigsaw-dev yesterday [2], is that we will keep the jake forest open for 
ongoing prototyping and iteration, also ongoing implementation 
improvements where iteration or bake time is important.


For the code review then the focus is therefore on sanity checking the 
changes that we would like to bring into jdk9/dev. We will not use this 
review thread to debate alternative designs or other big implementation 
changes that are more appropriate to bake in jake.


To get going, I've put the webrevs with a snapshot of the changes in 
jake here:

http://cr.openjdk.java.net/~alanb/8169069/0/

The changes are currently sync'ed against jdk-9+146 and will be rebased 
(and re-tested) against jdk9/dev prior to integration. There are a 
number of small changes that need to be added to this in the coming 
days, I will refresh the webrev every few days to take account of these 
updates.



A few important points to mention, even if you aren't reviewing the changes:

1. This refresh requires a new version of jtreg to run the tests. The 
changes for this new version are in the code-tools/jtreg repository and 
the plan is to tag a new build (jtreg4.2-b04) next week. Once the tag 
has been added then we'll update the requiredVersion property in each 
TEST.ROOT to force everyone to update.


2. For developers trying out modules with the main line JDK 9 builds 
then be aware that `requires public` changes to `requires transitive` 
and the `provides` clause changes to require all providers for a 
specific service type to be in the same clause. Also be aware that the 
binary form of the module declaration (module-info.class) changes so you 
will need to recompile any modules.


3. Those running existing code on JDK 9 and ignoring modules will need 
to be aware of a disruptive change in this refresh. The disruptive 
change is #AwkwardStrongEncapsulation where setAccessible(true) is 
changed so that it can't be used to break into non-public fields/methods 
of JDK classes. This change is going to expose a lot of hacks in 
existing code. We plan to send mail to jdk9-dev in advance of this 
integration to create awareness of this change. As per the original 
introduction of strong encapsulation then command line options (and now 
the manifest of application JAR files) can be used to keep existing code 
working. The new option is `--add-opens` to open a package in a module 
for deep reflection by other modules. As an example, if you find 
yourself with code that hacks into the private `comparator` field in 
java.util.TreeMap then running with `--add-opens 
java.base/java.util=ALL-UNNAMED` will keep that code working.



A few miscellaneous notes for those that are reviewing:

1. We have some temporary/transition code in the top-level repo to deal 
with the importing of the JavaFX modules. This will be removed once the 
changes are in JDK 9 for the OpenJFX project to use.


2. In the jdk repo then it's important to understand that the module 
system is initialized at startup and there are many places where we need 
to keep startup performance in mind. This sometimes means less elegant 
code than might be used if startup wasn't such a big concern.


3. The changes in the jaxws repo make use of new APIs that means the 
code doesn't compile with JDK 7 or JDK 8. Our intention is to work with 
the JAXB and JAX-WS maintainers to address the issues in the upstream 
project and then bring those changes into jdk9/dev to replace the 
patches that we are forced to push for the short term.


4. You will see several tests where the value of the @modules tag has 
`:open` or `:+open`. This is new jtreg speak. The former means the test 
is run with --add-opens to open the package, the latter means the test 
is exported at compile-time and exported + open at run-time (the latter 
usage will be rare, it's where tests have static references to JDK 

Re: modules and tests

[Remi Forax]

- Mail original -
> De: "Sander Mak" 
> À: "jigsaw-dev" 
> Envoyé: Jeudi 24 Novembre 2016 14:44:08
> Objet: Re: modules and tests

>> On 24 Nov 2016, at 14:31, Alan Bateman
>> > wrote:
>> 
>> On 24/11/2016 08:46, Remi Forax wrote:
>> 
>> :
>> 
>> It's not obvious at it seems, it requires javac to be able to merge several
>> module-info.java into one, and because the module descriptor allows to 
>> restrict
>> exports or opens, the merging rules* as to be specified.
>> 
>> Have you run into anything that isn't solved by compiling with 
>> -Xmodule:
>> and/or specify --add-reads and --add-exports to augment the module 
>> declaration?
>> I realize it's awkward to specify these options but in time then I would 
>> expect
>> the build tools and test runners to make this a lot easier.
> 
> For a concrete example of this:
> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-March/006594.html
> (modulo the old-style flags). Later I ported the same example to the a Maven
> build, which takes care of all this setup under the hood. Worked fine, without
> having to fiddle with -Xmodule/-Xpatch and readability to test-scope
> dependencies happens automatically in that case.
> 
> 
> Sander

to Alan:
currently you can not get your test framework as a service and you can not 
declare your test as a provider for a test infrastructure like jenkins (i.e. 
there is no --uses and --provides).

to Alan and Sander:
setting command line arguments or using a build tool to fiddle them for you is 
exactly what we do not want here! We want fidelity between the compile time 
configuration and the runtime configuration. Having to play with -Xpatch at 
runtime is conceptually exactly like setting the classpath. I don't want to 
explain to the Java devs that we have fidelity between compile-time and runtime 
on source code but not on test code.

regards,
Rémi

Replacement for JDK8 APIs

[Stéphane Nicoll]

Hi,

I am working on the Spring Boot project[1] and I am trying to make sure our
codebase compiles with the current JDK9 build[2]. So far I've hit two major
issues:

We use "sun.misc.VMSupport" to retrieve the port being used by the Java
remote debugging. You can find the actual code in RemoteDebugPortProvider[3]

We have an annotation processor that inspects all classes annotated with
@ConfigurationProperties and generates some meta-data about them. One
important piece of this is to extract the default value assigned to fields.
Consider the following example

@ConfigurationProperties
public class Foo {

  private static final String DEFAULT_NAME = "name";

  private String name = DEFAULT_NAME;

  private Integer counter = 42;

  private List hosts = Collections.singletonList("localhost");


}

What we've build is a visitor that navigates to those elements and extracts
the default values assigned to each field, including navigating to parent
element (the "name" constant there) or inferring value from method
parameters ("localhost"). The  current code relies on a feature of the JDK
that is no longer exported[4]:


java.lang.IllegalAccessException: class
org.springframework.boot.configurationprocessor.fieldvalues.javac.Trees
cannot access class com.sun.tools.javac.api.JavacTrees (in module
jdk.compiler) because module jdk.compiler does not export
com.sun.tools.javac.api to unnamed module @5a7fe64


Does anybody has some insight as how we could migrate those two use cases?
In particular, the second use case could be implemented with a contract of
javax.lang.model but we haven't found how to do it.

Thank you,
S.



[1] https://github.com/spring-projects/spring-boot
[2] https://github.com/spring-projects/spring-boot/issues/7226
[3]
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/tunnel/server/RemoteDebugPortProvider.java
[4]
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/fieldvalues/javac/Trees.java

hg: jigsaw/jake/hotspot: 81 new changesets

[alan . bateman]

Changeset: d5c67c13e5f9
Author:mcberg
Date:  2016-10-18 19:08 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d5c67c13e5f9

8167987: change merge context to clear for mask register usage model
Reviewed-by: kvn

! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/assembler_x86.hpp

Changeset: f5c44b9b4ff9
Author:hshi
Date:  2016-10-17 05:44 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f5c44b9b4ff9

8167421: AArch64: in one core system, fatal error: Illegal threadstate 
encountered
Summary: adding missing thread state store when os::is_MP() is false
Reviewed-by: aph

! src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp

Changeset: efcbf5de754e
Author:ehelin
Date:  2016-10-06 16:32 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/efcbf5de754e

8166790: Add stress test GCBasher
Reviewed-by: dfazunen, dholmes, erikj, tschatzl, lmesnik

! test/TEST.groups
+ test/gc/stress/gcbasher/ByteCursor.java
+ test/gc/stress/gcbasher/Bytecode.java
+ test/gc/stress/gcbasher/ClassInfo.java
+ test/gc/stress/gcbasher/ConstantPoolEntry.java
+ test/gc/stress/gcbasher/Decompiler.java
+ test/gc/stress/gcbasher/Dependency.java
+ test/gc/stress/gcbasher/MethodInfo.java
+ test/gc/stress/gcbasher/TestGCBasher.java
+ test/gc/stress/gcbasher/TestGCBasherWithCMS.java
+ test/gc/stress/gcbasher/TestGCBasherWithG1.java
+ test/gc/stress/gcbasher/TestGCBasherWithParallel.java
+ test/gc/stress/gcbasher/TestGCBasherWithSerial.java

Changeset: 844f8dd1e097
Author:kzhaldyb
Date:  2016-09-28 17:26 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/844f8dd1e097

8166804: Convert TestMetachunk_test to GTest
Reviewed-by: iignatyev

! src/share/vm/memory/metachunk.cpp
! src/share/vm/memory/metachunk.hpp
! src/share/vm/utilities/internalVMTests.cpp
+ test/native/memory/test_metachunk.cpp

Changeset: b426373a34a3
Author:kzhaldyb
Date:  2016-09-28 17:18 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b426373a34a3

8166563: Convert GuardedMemory_test to Gtest
Reviewed-by: iignatyev

! src/share/vm/memory/guardedMemory.cpp
! src/share/vm/memory/guardedMemory.hpp
! src/share/vm/utilities/internalVMTests.cpp
+ test/native/memory/test_guardedMemory.cpp

Changeset: 817bb013257f
Author:kzhaldyb
Date:  2016-10-19 12:10 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/817bb013257f

Merge


Changeset: 5fd2019b77bd
Author:akulyakh
Date:  2016-10-18 14:27 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5fd2019b77bd

8166289: RuntimeException: canRead() reports false for reading from the same 
module: expected true, was false
Summary: A fix in the JDWP test along with some extra logging added
Reviewed-by: sspitsyn

! test/serviceability/jdwp/AllModulesCommandTest.java
! test/serviceability/jdwp/JdwpCanReadReply.java
! test/serviceability/jdwp/JdwpCmd.java
+ test/serviceability/jdwp/JdwpModuleCmd.java
+ test/serviceability/jdwp/JdwpModuleReply.java
+ test/serviceability/jdwp/JdwpVisibleClassesCmd.java
+ test/serviceability/jdwp/JdwpVisibleClassesReply.java

Changeset: 7e0181d2ca46
Author:lmesnik
Date:  2016-10-19 10:10 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7e0181d2ca46

8155570: serviceability/tmtools/jstat/GcTest02.java fails with parallel GC
Reviewed-by: jwilhelm

! test/serviceability/tmtools/jstat/GcTest02.java
! test/serviceability/tmtools/jstat/utils/GcProvokerImpl.java

Changeset: 99096bf79f31
Author:lmesnik
Date:  2016-10-19 10:06 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/99096bf79f31

8166724: gc/g1/TestHumongousShrinkHeap.java fails with OOME
Reviewed-by: dfazunen, jwilhelm

! test/gc/g1/TestHumongousShrinkHeap.java

Changeset: 4c2ce2515ad0
Author:dfazunen
Date:  2016-10-19 16:56 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/4c2ce2515ad0

Merge


Changeset: bc41ec244c94
Author:mwalsh
Date:  2016-10-19 10:48 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bc41ec244c94

8164002: Add a new CPU family (S_family) for SPARC S7 and above processors
Reviewed-by: dholmes, ecaspole, kvn

! src/cpu/sparc/vm/vm_version_sparc.cpp
! src/cpu/sparc/vm/vm_version_sparc.hpp

Changeset: 51277d8704af
Author:kvn
Date:  2016-10-19 17:53 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/51277d8704af

Merge


Changeset: d7f89a030d77
Author:dnsimon
Date:  2016-10-19 20:15 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d7f89a030d77

8168295: [JVMCI] -XX:+JVMCIPrintProperties should exit after printing
Reviewed-by: kvn, twisti

! .mx.jvmci/.pydevproject
! 
src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java
! src/share/vm/jvmci/jvmci_globals.hpp
! test/compiler/jvmci/TestJVMCIPrintProperties.java

Changeset: 77f3076526fc
Author:dnsimon
Date:  2016-10-19 18:57 +
URL:  

hg: jigsaw/jake/jdk: 20 new changesets

[alan . bateman]

Changeset: 892fde66a95e
Author:darcy
Date:  2016-11-15 13:31 -0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/892fde66a95e

8169736: Mark RmiIiopReturnValueTest.java as intermittently failing
Reviewed-by: lancea

! test/javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java

Changeset: ff9c1d07969e
Author:vtewari
Date:  2016-10-20 15:07 +0530
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ff9c1d07969e

8167294: MXBean javadoc should be updated to take modules into account
Summary: Updated MXBean class javadoc to take modules into account
Reviewed-by: alanb
Contributed-by: amit.sa...@oracle.com

! src/java.management/share/classes/javax/management/MXBean.java

Changeset: 4a837dd80453
Author:amurillo
Date:  2016-10-20 17:05 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4a837dd80453

Merge

- src/java.base/share/classes/jdk/internal/misc/JavaNetAccess.java
- src/jdk.jlink/share/classes/jdk/tools/jlink/Jlink.java
- src/jdk.jlink/share/classes/jdk/tools/jlink/JlinkPermission.java
- test/sun/net/www/protocol/https/HttpsClient/OriginServer.java
- test/sun/security/tools/jarsigner/ts.sh

Changeset: 50851d9db89f
Author:sla
Date:  2016-10-24 09:07 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/50851d9db89f

8168483: Remove jtreg timeout handler timeout
Reviewed-by: dholmes, tbell

! test/Makefile

Changeset: 11932b04e6a0
Author:rehn
Date:  2016-10-24 09:07 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/11932b04e6a0

8164501: Uninitialised memory in byteArrayToPacket of SharedMemoryConnection.c
Reviewed-by: sla, dsamersoff

! src/jdk.jdi/share/native/libdt_shmem/SharedMemoryConnection.c

Changeset: 0b19d27ee4dc
Author:rehn
Date:  2016-10-24 11:47 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0b19d27ee4dc

Merge


Changeset: 7a5fa747419d
Author:dsamersoff
Date:  2016-10-24 14:52 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7a5fa747419d

8160376: DebuggerException: Can't attach symbolicator to the process
Summary: Make SA link to JavaRuntimeSupport in MacOS X
Reviewed-by: dsamersoff, dcubed
Contributed-by: Sharath Ballal 

! test/ProblemList.txt

Changeset: b60ef7010504
Author:dsamersoff
Date:  2016-10-25 14:49 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b60ef7010504

8165500: TestJpsJar shouldn't jar all test.classpath directories
Summary: Refactor test to better handle errors
Reviewed-by: sspitsyn

! test/ProblemList.txt
- test/sun/tools/jps/JpsBase.java
! test/sun/tools/jps/JpsHelper.java
+ test/sun/tools/jps/LingeredApp.java
+ test/sun/tools/jps/LingeredAppForJps.java
+ test/sun/tools/jps/TestJps.java
- test/sun/tools/jps/TestJpsClass.java
- test/sun/tools/jps/TestJpsJar.java
- test/sun/tools/jps/TestJpsJarRelative.java
! test/sun/tools/jps/TestJpsSanity.java

Changeset: 016c12cbe397
Author:vtewari
Date:  2016-10-26 15:08 +0530
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/016c12cbe397

8151099: java.lang.management.ManagementFactory.getPlatformMXBeans() should 
work even if jdk.management is not present.
Summary: Removed dependency of java.management over jdk.management.
Reviewed-by: mchung, dfuchs, dholmes
Contributed-by: amit.sa...@oracle.com

! src/java.management/share/classes/sun/management/VMManagementImpl.java
! src/java.management/share/native/libmanagement/VMManagementImpl.c
! 
test/com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationContentTest.java
! 
test/com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationTest.java
+ test/java/lang/management/ManagementFactory/DefaultManagementProviderTest.java

Changeset: 0f7b50cc702f
Author:psandoz
Date:  2016-10-14 14:47 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0f7b50cc702f

8166974: invokedynamic implementation should not wrap Errors
Reviewed-by: smarks, jrose

! src/java.base/share/classes/java/lang/invoke/CallSite.java
! src/java.base/share/classes/java/lang/invoke/package-info.java
! test/java/lang/invoke/8022701/InvokeSeveralWays.java

Changeset: 71457eaca096
Author:dsamersoff
Date:  2016-10-28 11:18 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/71457eaca096

8168397: sun/tools/jhsdb/HeapDumpTest.java timesout on MacOS X on non images 
build
Summary: Remove BasicLauncherTest.java and HeapDumpTest.java from quarantine 
list.
Reviewed-by: sla, dsamersoff
Contributed-by: sharath.bal...@oracle.com

! test/ProblemList.txt

Changeset: 8c9df9fa7104
Author:psandoz
Date:  2016-11-01 17:20 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8c9df9fa7104

8163553: java.lang.LinkageError from test java/lang/ThreadGroup/Stop.java
Reviewed-by: redestad

! src/java.base/share/classes/java/lang/invoke/BoundMethodHandle.java
! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
! 

hg: jigsaw/jake/jaxp: 5 new changesets

[alan . bateman]

Changeset: 53a255be3abc
Author:dfuchs
Date:  2016-11-15 17:45 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/53a255be3abc

8169723: remove jaxp/src/java.xml/share/classes/org/w3c/dom/xpath/COPYRIGHT.html
Reviewed-by: rriggs

- src/java.xml/share/classes/org/w3c/dom/xpath/COPYRIGHT.html

Changeset: 16a430f8bed7
Author:aefimov
Date:  2016-11-15 23:28 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/16a430f8bed7

8164479: Update JAX-WS RI integration to latest version (2.3.0-SNAPSHOT)
Reviewed-by: alanb, joehw, lancea, mchung
Contributed-by: roman.grigori...@oracle.com

! src/java.xml/share/classes/module-info.java

Changeset: 09eda28b98e4
Author:lana
Date:  2016-11-21 18:48 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/09eda28b98e4

Merge


Changeset: f1042f0aa643
Author:lana
Date:  2016-11-23 16:16 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/f1042f0aa643

Added tag jdk-9+146 for changeset 09eda28b98e4

! .hgtags

Changeset: f5bb326c9dd4
Author:alanb
Date:  2016-11-24 13:00 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/f5bb326c9dd4

Merge

! src/java.xml/share/classes/module-info.java
- src/java.xml/share/classes/org/w3c/dom/xpath/COPYRIGHT.html

hg: jigsaw/jake/jaxws: 5 new changesets

[alan . bateman]

Changeset: 26c9b9c51052
Author:aefimov
Date:  2016-11-15 23:43 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/26c9b9c51052

8164479: Update JAX-WS RI integration to latest version (2.3.0-SNAPSHOT)
Reviewed-by: alanb, joehw, lancea, mchung
Contributed-by: roman.grigori...@oracle.com

! src/java.activation/share/classes/javax/activation/CommandInfo.java
! src/java.activation/share/classes/module-info.java
! src/java.xml.bind/share/classes/com/sun/xml/internal/bind/util/Which.java
! src/java.xml.bind/share/classes/javax/xml/bind/JAXBContext.java
! src/java.xml.bind/share/classes/javax/xml/bind/attachment/package.html
! 
src/java.xml.bind/share/classes/javax/xml/bind/helpers/AbstractUnmarshallerImpl.java
! src/java.xml.bind/share/classes/javax/xml/bind/helpers/package.html
! src/java.xml.bind/share/classes/javax/xml/bind/package.html
! src/java.xml.bind/share/classes/javax/xml/bind/util/package.html
! 
src/java.xml.ws/share/classes/com/sun/xml/internal/ws/encoding/XmlDataContentHandler.java
! 
src/java.xml.ws/share/classes/com/sun/xml/internal/ws/model/RuntimeModeler.java
! src/java.xml.ws/share/classes/com/sun/xml/internal/ws/util/version.properties
! src/java.xml.ws/share/classes/com/sun/xml/internal/ws/util/xml/XmlUtil.java
! src/java.xml.ws/share/classes/module-info.java
! src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/JCodeModel.java
+ 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/JExportsDirective.java
+ src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/JModule.java
+ 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/JModuleDirective.java
! src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/JPackage.java
+ 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/JRequiresDirective.java
! 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/writer/FileCodeWriter.java
! 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/writer/FilterCodeWriter.java
! 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/writer/ProgressCodeWriter.java
! 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/writer/PrologCodeWriter.java
! 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/writer/SingleStreamCodeWriter.java
! 
src/jdk.xml.bind/share/classes/com/sun/codemodel/internal/writer/ZipCodeWriter.java
! 
src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/MessageBundle.properties
! src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/Messages.java
! src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/Options.java
! 
src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/ProgressCodeWriter.java
! 
src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/generator/bean/BeanGenerator.java
! 
src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/generator/bean/ObjectFactoryGeneratorImpl.java
! 
src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/model/CBuiltinLeafInfo.java
! 
src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/model/Constructor.java
! 
src/jdk.xml.bind/share/classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/BIInterface.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/NGCCRuntimeEx.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/attributeDeclBody.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/attributeGroupDecl.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/complexType.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/elementDeclBody.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/group.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/identityConstraint.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/notation.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/qname.java
! 
src/jdk.xml.bind/share/classes/com/sun/xml/internal/xsom/impl/parser/state/simpleType.java
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/processor/modeler/annotation/TypeModeler.java
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceAp.java
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceWrapperGenerator.java
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/resources/wscompile.properties
! src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/version.properties
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/wscompile/FilerCodeWriter.java
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/wscompile/WsgenTool.java
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/wscompile/WsimportOptions.java
! 
src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/wscompile/WsimportTool.java

Changeset: b8671d61613c
Author:aefimov
Date:  2016-11-16 00:55 

hg: jigsaw/jake/langtools: 2 new changesets

[alan . bateman]

Changeset: d715163cd7c5
Author:lana
Date:  2016-11-23 16:16 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d715163cd7c5

Added tag jdk-9+146 for changeset 26f972dc2d17

! .hgtags

Changeset: 7178621e9e1f
Author:alanb
Date:  2016-11-24 09:14 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7178621e9e1f

Merge

! .hgtags

hg: jigsaw/jake/corba: 2 new changesets

[alan . bateman]

Changeset: dc49e0922a8e
Author:lana
Date:  2016-11-23 16:16 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/dc49e0922a8e

Added tag jdk-9+146 for changeset ecd74b41ab65

! .hgtags

Changeset: f02fa6dd4e0b
Author:alanb
Date:  2016-11-24 09:15 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/f02fa6dd4e0b

Merge

hg: jigsaw/jake: 11 new changesets

[alan . bateman]

Changeset: 0ec12d231af9
Author:ehelin
Date:  2016-09-28 16:41 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/0ec12d231af9

8166790: Add stress test GCBasher
Reviewed-by: dfazunen, dholmes, erikj, tschatzl, lmesnik

! make/jprt.properties

Changeset: a26dbefcc658
Author:dpochepk
Date:  2016-10-20 16:53 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/a26dbefcc658

8155219: [TESTBUG] Rewrite compiler/ciReplay/TestVM.sh in java
Reviewed-by: kvn

! test/jtreg-ext/requires/VMProps.java

Changeset: f04a8e69ec8f
Author:amurillo
Date:  2016-10-20 17:05 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/f04a8e69ec8f

Merge


Changeset: 49aa366f9afc
Author:sla
Date:  2016-10-21 15:40 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/49aa366f9afc

8168412: Reduce buffering in jtreg timeouthandler
Reviewed-by: mlarsson

! 
test/failure_handler/src/share/classes/jdk/test/failurehandler/HtmlSection.java
! 
test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnosticInfoObserver.java
! 
test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherProcessInfoTimeoutHandler.java

Changeset: 281a14e87a3b
Author:sla
Date:  2016-10-24 09:12 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/281a14e87a3b

8168414: Various timeouthandler fixes
Reviewed-by: mlarsson

! test/failure_handler/Makefile
! 
test/failure_handler/src/share/classes/jdk/test/failurehandler/action/ActionHelper.java

Changeset: eeb794d72bbf
Author:dsamersoff
Date:  2016-10-25 14:49 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/eeb794d72bbf

8165500: TestJpsJar shouldn't jar all test.classpath directories
Summary: Refactor test to better handle errors
Reviewed-by: sspitsyn

! test/lib/jdk/test/lib/apps/LingeredApp.java

Changeset: ca7f2d2fa460
Author:jwilhelm
Date:  2016-11-09 15:32 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/ca7f2d2fa460

Merge


Changeset: a22e2671d88f
Author:lana
Date:  2016-11-21 18:47 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/a22e2671d88f

Merge


Changeset: 3e3e158ef45f
Author:lana
Date:  2016-11-23 16:16 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/3e3e158ef45f

Added tag jdk-9+146 for changeset a22e2671d88f

! .hgtags

Changeset: dfa387b4ba02
Author:alanb
Date:  2016-11-24 13:00 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/dfa387b4ba02

Merge

! common/autoconf/generated-configure.sh
! make/jprt.properties
! 
test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnosticInfoObserver.java
! 
test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherProcessInfoTimeoutHandler.java

Changeset: 3d8def3e9ed0
Author:alanb
Date:  2016-11-24 13:15 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/3d8def3e9ed0

Merge

! common/autoconf/generated-configure.sh

hg: jigsaw/jake/nashorn: 5 new changesets

[alan . bateman]

Changeset: 1e7049278c4c
Author:sla
Date:  2016-10-24 09:07 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/1e7049278c4c

8168483: Remove jtreg timeout handler timeout
Reviewed-by: dholmes, tbell

! test/Makefile

Changeset: ce057a78b44c
Author:jwilhelm
Date:  2016-11-09 13:37 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/ce057a78b44c

Merge


Changeset: 55f5a96988de
Author:lana
Date:  2016-11-21 18:48 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/55f5a96988de

Merge


Changeset: 82281fffea7c
Author:lana
Date:  2016-11-23 16:16 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/82281fffea7c

Added tag jdk-9+146 for changeset 55f5a96988de

! .hgtags

Changeset: 75b099ddc58a
Author:alanb
Date:  2016-11-24 09:15 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/75b099ddc58a

Merge

! .hgtags

Re: modules and tests

[Sander Mak]

On 24 Nov 2016, at 14:31, Alan Bateman 
> wrote:

On 24/11/2016 08:46, Remi Forax wrote:

:

It's not obvious at it seems, it requires javac to be able to merge several 
module-info.java into one, and because the module descriptor allows to restrict 
exports or opens, the merging rules* as to be specified.

Have you run into anything that isn't solved by compiling with 
-Xmodule: and/or specify --add-reads and --add-exports to augment the 
module declaration? I realize it's awkward to specify these options but in time 
then I would expect the build tools and test runners to make this a lot easier.

For a concrete example of this: 
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-March/006594.html 
(modulo the old-style flags). Later I ported the same example to the a Maven 
build, which takes care of all this setup under the hood. Worked fine, without 
having to fiddle with -Xmodule/-Xpatch and readability to test-scope 
dependencies happens automatically in that case.


Sander

Re: modules and tests

[Alan Bateman]

On 24/11/2016 08:46, Remi Forax wrote:


:

It's not obvious at it seems, it requires javac to be able to merge several 
module-info.java into one, and because the module descriptor allows to restrict 
exports or opens, the merging rules* as to be specified.

Have you run into anything that isn't solved by compiling with 
-Xmodule: and/or specify --add-reads and --add-exports to 
augment the module declaration? I realize it's awkward to specify these 
options but in time then I would expect the build tools and test runners 
to make this a lot easier.


-Alan

hg: jigsaw/jake/jdk: 2 new changesets

[alan . bateman]

Changeset: 633cacfb9b2f
Author:alanb
Date:  2016-11-24 12:50 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/633cacfb9b2f

Drop implAddExportsPrivate, no longer needed

! src/java.base/share/classes/java/lang/reflect/Module.java

Changeset: a27f80d73f0d
Author:alanb
Date:  2016-11-24 12:52 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a27f80d73f0d

Restore SL behavior when META-INF/services lists class that cannot be loaded

! src/java.base/share/classes/java/util/ServiceLoader.java

hg: jigsaw/jake: Regenerated configure after merge

[erik . joelsson]

Changeset: 13e19d185301
Author:erikj
Date:  2016-11-24 11:37 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/13e19d185301

Regenerated configure after merge

! common/autoconf/generated-configure.sh

Re: uses is useless ?

[Alan Bateman]

On 24/11/2016 08:08, fo...@univ-mlv.fr wrote:


I've resolved my problem of delegation of uses myself,
trying to re-explain my problem, i wanted to provide a method on top of 
ServiceLoader and force modules that use that API to declare a directive uses.
This should work fine, assuming that the service types are accessible to 
the middleman and it makes use of addUses.


-Alan



In fact, you don't need any additional support from the jdk because you can 
already use the new StackWalker API to get the caller module and do the check 
using methods of java.lang.reflect.Module.

cheers,
Rémi

modules and tests

[Remi Forax]

We already have discussed how to do testing in the new modular environment, but 
i'm not satisfied by the current state (but maybe i'm wrong).

Here, i will focus on unit testing, which is the most intrusive kind of testing.

Historically, unit testing was easy because you can have several source 
directories (src and test) containing the same package, note that this doesn't 
create split packages, because during the compilation, the classes inside src 
and test are compiled together and later executed together. Having a separation 
between a folder containing the sources and the on containing the tests allow 
to produce two jars, one based only on sources and one based on the merging 
between the sources and the tests. Because the tests can have dependencies not 
needed by the sources (think junit.jar by example), the classpath when 
compiling and running the sources and the tests was slightly differents, the 
classpath of the test having more dependencies.

Now, we have introduced modules and modules define their own dependencies. At 
compile-time/runtime, source and test have to be in the same module otherwise, 
there will be a gap between the sources environment and the test environment. 
So like before, the idea is to generate two jars, representing the same module. 
Also, because sources and tests do not have exactly the same dependencies, the 
source folder and the test folder should have their own module-info.java.
But when compiling the test, javac raises an error, because it doesn't allow to 
have two module-info files. I believe this is a bug that should be fixed.

It's not obvious at it seems, it requires javac to be able to merge several 
module-info.java into one, and because the module descriptor allows to restrict 
exports or opens, the merging rules* as to be specified.

But i think we should support modules AND tests by default as we have done 
since more than 20 years.

regards,
Rémi

* here is an executable specification of the merging rules: 
https://github.com/forax/pro/blob/master/src/main/java/com.github.forax.pro.helper/com/github/forax/pro/helper/ModuleHelper.java#L258

hg: jigsaw/jake/jdk: java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java needs :open

[alan . bateman]

Changeset: c853c037270d
Author:alanb
Date:  2016-11-24 08:37 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c853c037270d

java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java needs :open

! test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java

Re: uses is useless ?

[forax]

I've resolved my problem of delegation of uses myself,
trying to re-explain my problem, i wanted to provide a method on top of 
ServiceLoader and force modules that use that API to declare a directive uses.
In fact, you don't need any additional support from the jdk because you can 
already use the new StackWalker API to get the caller module and do the check 
using methods of java.lang.reflect.Module.

cheers,
Rémi 

- Mail original -
> De: "Alan Bateman" 
> À: fo...@univ-mlv.fr
> Cc: "jigsaw-dev" 
> Envoyé: Jeudi 17 Novembre 2016 09:43:41
> Objet: Re: uses is useless ?

> On 16/11/2016 19:41, fo...@univ-mlv.fr wrote:
> 
>> :
>> My point is that in teory, that's cool but in reality the module-info of
>> java.base (or java.sql) declares a lot of 'uses' making the whole idea moot.
>> To avoid java.base to use 'uses', we need a way to be able to have a way to
>> delegate the power of the ServiceLoader to another code, so the other code 
>> will
>> have to use 'uses'.
> If a consumer is making use of an API in java.base and the
> implementation of that API makes use of services under the covers then
> it is transparent to the consumer of the API. The consumer of the API
> shouldn't need to know anything about the "SPI" types and would be very
> surprising if the user of an API needed to declare `uses` on such types.
> 
> In the JDK then I'm only aware of two cases where the consumer passes a
> service type to an API that doesn't know anything about the service type
> (the two cases are JVMCI and a utility method in javac). Both of these
> cases use addUses to get through the hygiene check.
> 
> jlink is a bit special in that the user of the tool needs at least some
> global knowledge when choosing the service provider modules to include
> in the run time image. As I said, the tool could help more but having it
> do eager service binding is problematic as it tends to maximize rather
> than minimize the number of the modules.
> 
> -Alan.