[jira] [Commented] (KAFKA-15146) Flaky test ConsumerBounceTest.testConsumptionWithBrokerFailures
[
https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856634#comment-17856634
]
Chia Chuan Yu commented on KAFKA-15146:
---
Hi [~divijvaidya]
I'm interested in this one, can I have it? thanks!
> Flaky test ConsumerBounceTest.testConsumptionWithBrokerFailures
> ---
>
> Key: KAFKA-15146
> URL: https://issues.apache.org/jira/browse/KAFKA-15146
> Project: Kafka
> Issue Type: Test
> Components: unit tests
>Reporter: Divij Vaidya
>Priority: Major
> Labels: flaky-test
>
> Flaky test that fails with the following error. Example build -
> [https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13953/2]
> {noformat}
> Gradle Test Run :core:integrationTest > Gradle Test Executor 177 >
> ConsumerBounceTest > testConsumptionWithBrokerFailures() FAILED
> org.apache.kafka.clients.consumer.CommitFailedException: Offset commit
> cannot be completed since the consumer is not part of an active group for
> auto partition assignment; it is likely that the consumer was kicked out of
> the group.
> at
> app//org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.sendOffsetCommitRequest(ConsumerCoordinator.java:1351)
> at
> app//org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.commitOffsetsSync(ConsumerCoordinator.java:1188)
> at
> app//org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1518)
> at
> app//org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1417)
> at
> app//org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1374)
> at
> app//kafka.api.ConsumerBounceTest.consumeWithBrokerFailures(ConsumerBounceTest.scala:109)
> at
> app//kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures(ConsumerBounceTest.scala:81){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-17010) Remove DescribeLogDirsResponse#ReplicaInfo
[ https://issues.apache.org/jira/browse/KAFKA-17010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856629#comment-17856629 ] Chia Chuan Yu commented on KAFKA-17010: --- Hi, [~chia7712] Can I have this one please? thanks! > Remove DescribeLogDirsResponse#ReplicaInfo > -- > > Key: KAFKA-17010 > URL: https://issues.apache.org/jira/browse/KAFKA-17010 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 4.0.0 > > > It was deprecated by KAFKA-10120 in 2.7 > https://github.com/apache/kafka/blob/64702bcf6f883d266ccffcec458b4c3c0706ad75/clients/src/main/java/org/apache/kafka/common/requests/DescribeLogDirsResponse.java#L113 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16976) Improve the dynamic config handling for RemoteLogManagerConfig when a broker is restarted.
[ https://issues.apache.org/jira/browse/KAFKA-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855873#comment-17855873 ] Chia Chuan Yu commented on KAFKA-16976: --- Hi,[~satish.duggana] Can I have this one please? Thanks! > Improve the dynamic config handling for RemoteLogManagerConfig when a broker > is restarted. > -- > > Key: KAFKA-16976 > URL: https://issues.apache.org/jira/browse/KAFKA-16976 > Project: Kafka > Issue Type: Task >Reporter: Satish Duggana >Priority: Major > Fix For: 3.9.0 > > > This is a followup on the discussion: > https://github.com/apache/kafka/pull/16353#pullrequestreview-2121953295 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16957) Enable KafkaConsumerTest#configurableObjectsShouldSeeGeneratedClientId to work with CLASSIC and CONSUMER
[ https://issues.apache.org/jira/browse/KAFKA-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855001#comment-17855001 ] Chia Chuan Yu commented on KAFKA-16957: --- Hi, [~chia7712] Can I have this? thanks! > Enable KafkaConsumerTest#configurableObjectsShouldSeeGeneratedClientId to > work with CLASSIC and CONSUMER > - > > Key: KAFKA-16957 > URL: https://issues.apache.org/jira/browse/KAFKA-16957 > Project: Kafka > Issue Type: Test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > The `CLIENT_IDS` is a static variable, so the latter one will see previous > test results. We should clear it before testing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16885) Consider renaming RemoteLogManagerConfig#enableRemoteStorageSystem to RemoteLogManagerConfig#isRemoteStorageSystemEnabled
[ https://issues.apache.org/jira/browse/KAFKA-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853493#comment-17853493 ] Chia Chuan Yu commented on KAFKA-16885: --- Hi, [~ckamal] Yes, I'm working on this one. > Consider renaming RemoteLogManagerConfig#enableRemoteStorageSystem to > RemoteLogManagerConfig#isRemoteStorageSystemEnabled > - > > Key: KAFKA-16885 > URL: https://issues.apache.org/jira/browse/KAFKA-16885 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia Chuan Yu >Priority: Major > > see the discussion: > https://github.com/apache/kafka/pull/16153#issuecomment-2144269279 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16918) TestUtils#assertFutureThrows should use future.get with timeout
[ https://issues.apache.org/jira/browse/KAFKA-16918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853340#comment-17853340 ] Chia Chuan Yu commented on KAFKA-16918: --- Hi, [~showuon] Can I have this one please? thanks! > TestUtils#assertFutureThrows should use future.get with timeout > --- > > Key: KAFKA-16918 > URL: https://issues.apache.org/jira/browse/KAFKA-16918 > Project: Kafka > Issue Type: Test >Reporter: Luke Chen >Priority: Major > > In KAFKA-16916, we had a test running forever. To avoid this issue happened > again, we can use future.get with timeout in TestUtils#assertFutureThrows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16661) add a lower `log.initial.task.delay.ms` value to integration test framework
[ https://issues.apache.org/jira/browse/KAFKA-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852412#comment-17852412 ] Chia Chuan Yu commented on KAFKA-16661: --- Hi, [~showuon] I'm currently working on other tasks, I think it would be better to let [~vinay272001] have this one. Thanks! > add a lower `log.initial.task.delay.ms` value to integration test framework > --- > > Key: KAFKA-16661 > URL: https://issues.apache.org/jira/browse/KAFKA-16661 > Project: Kafka > Issue Type: Test >Reporter: Luke Chen >Assignee: Chia Chuan Yu >Priority: Major > Labels: newbie, newbie++ > > After KAFKA-16552, we created an internal config `log.initial.task.delay.ms` > to control the initial task delay in log manager. This ticket follows it up, > to set a default low value (100ms, 500ms maybe?) for it, to speed up the > tests. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16885) Consider renaming RemoteLogManagerConfig#enableRemoteStorageSystem to RemoteLogManagerConfig#isRemoteStorageSystemEnabled
[ https://issues.apache.org/jira/browse/KAFKA-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852252#comment-17852252 ] Chia Chuan Yu commented on KAFKA-16885: --- Hi, [~chia7712] Can I have this one, thanks! > Consider renaming RemoteLogManagerConfig#enableRemoteStorageSystem to > RemoteLogManagerConfig#isRemoteStorageSystemEnabled > - > > Key: KAFKA-16885 > URL: https://issues.apache.org/jira/browse/KAFKA-16885 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > > see the discussion: > https://github.com/apache/kafka/pull/16153#issuecomment-2144269279 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KAFKA-16669) Remove extra collection copy when generating DescribeAclsResource
[ https://issues.apache.org/jira/browse/KAFKA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia Chuan Yu updated KAFKA-16669: -- Summary: Remove extra collection copy when generating DescribeAclsResource (was: Remove extra collection copy when genrating DescribeAclsResource) > Remove extra collection copy when generating DescribeAclsResource > - > > Key: KAFKA-16669 > URL: https://issues.apache.org/jira/browse/KAFKA-16669 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia Chuan Yu >Priority: Trivial > > There are three collection copy happening in generating DescribeAclsResource > 1. Iterable -> HashSet > (https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/core/src/main/scala/kafka/server/AclApis.scala#L72) > 2. HashSet -> Map > (https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java#L141) > 3. Map -> List > (https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java#L146) > We can do two small optimization: > 1. remove the first collection copy. This optimization needs two steps: a) > change `aclsResources` input type from `Collection` to `Iterable`. b) > de-duplicate in second collection copy: HashSet -> Map. We use `Set` > to replace the `List` > 2. set the array size. > https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java#L148 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16669) Remove extra collection copy when genrating DescribeAclsResource
[ https://issues.apache.org/jira/browse/KAFKA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843570#comment-17843570 ] Chia Chuan Yu commented on KAFKA-16669: --- Hi, [~chia7712] Can I have this one? Thanks! > Remove extra collection copy when genrating DescribeAclsResource > > > Key: KAFKA-16669 > URL: https://issues.apache.org/jira/browse/KAFKA-16669 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Trivial > > There are three collection copy happening in generating DescribeAclsResource > 1. Iterable -> HashSet > (https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/core/src/main/scala/kafka/server/AclApis.scala#L72) > 2. HashSet -> Map > (https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java#L141) > 3. Map -> List > (https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java#L146) > We can do two small optimization: > 1. remove the first collection copy. This optimization needs two steps: a) > change `aclsResources` input type from `Collection` to `Iterable`. b) > de-duplicate in second collection copy: HashSet -> Map. We use `Set` > to replace the `List` > 2. set the array size. > https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java#L148 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KAFKA-16661) add a lower `log.initial.task.delay.ms` value to integration test framework
[ https://issues.apache.org/jira/browse/KAFKA-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia Chuan Yu reassigned KAFKA-16661: - Assignee: Chia Chuan Yu > add a lower `log.initial.task.delay.ms` value to integration test framework > --- > > Key: KAFKA-16661 > URL: https://issues.apache.org/jira/browse/KAFKA-16661 > Project: Kafka > Issue Type: Test >Reporter: Luke Chen >Assignee: Chia Chuan Yu >Priority: Major > Labels: newbie, newbie++ > > After KAFKA-16552, we created an internal config `log.initial.task.delay.ms` > to control the initial task delay in log manager. This ticket follows it up, > to set a default low value (100ms, 500ms maybe?) for it, to speed up the > tests. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16574) The metrics of LogCleaner disappear after reconfiguration
[
https://issues.apache.org/jira/browse/KAFKA-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838420#comment-17838420
]
Chia Chuan Yu commented on KAFKA-16574:
---
Hi, [~chia7712]
Can I have this one ? thanks!
> The metrics of LogCleaner disappear after reconfiguration
> -
>
> Key: KAFKA-16574
> URL: https://issues.apache.org/jira/browse/KAFKA-16574
> Project: Kafka
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
>
> see
> [https://github.com/apache/kafka/blob/a3dcbd4e28a35f79f75ec1bf316ef0b39c0df164/core/src/main/scala/kafka/log/LogCleaner.scala#L227]
> We don't rebuild the metrics after calling shutdown. The following test can
> prove that.
> {code:java}
> @Test
> def testMetricsAfterReconfiguration(): Unit = {
> val logCleaner = new LogCleaner(new CleanerConfig(true),
> logDirs = Array(TestUtils.tempDir()),
> logs = new Pool[TopicPartition, UnifiedLog](),
> logDirFailureChannel = new LogDirFailureChannel(1),
> time = time)
> def check(): Unit =
> LogCleaner.MetricNames.foreach(name =>
> assertNotNull(KafkaYammerMetrics.defaultRegistry.allMetrics().get(logCleaner.metricsGroup
> .metricName(name, java.util.Collections.emptyMap())), s"$name is
> gone?"))
> try {
> check()
> logCleaner.reconfigure(new KafkaConfig(TestUtils.createBrokerConfig(1,
> "localhost:2181")),
> new KafkaConfig(TestUtils.createBrokerConfig(1, "localhost:2181")))
> check()
> } finally logCleaner.shutdown()
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-16546) add docs to explain how to update cluster-wide default by Admin#incrementalAlterConfigs
[ https://issues.apache.org/jira/browse/KAFKA-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837123#comment-17837123 ] Chia Chuan Yu commented on KAFKA-16546: --- Hi, [~chia7712] Can I have this one? Please assign me the task. Much appreciated! > add docs to explain how to update cluster-wide default by > Admin#incrementalAlterConfigs > --- > > Key: KAFKA-16546 > URL: https://issues.apache.org/jira/browse/KAFKA-16546 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > We have good docs about updating cluster-wide configs by commend tool > (https://kafka.apache.org/documentation/#dynamicbrokerconfigs), and it would > be great Admin#incrementalAlterConfigs has such good docs also. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16466) QuorumController is swallowing some exception messages
[
https://issues.apache.org/jira/browse/KAFKA-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836120#comment-17836120
]
Chia Chuan Yu commented on KAFKA-16466:
---
[~ilyazr] ,
Hi, I just assigned the task to you. Please go ahead. Thanks!
> QuorumController is swallowing some exception messages
> --
>
> Key: KAFKA-16466
> URL: https://issues.apache.org/jira/browse/KAFKA-16466
> Project: Kafka
> Issue Type: Bug
> Components: controller
>Affects Versions: 3.7.0
>Reporter: David Arthur
>Assignee: Ilya Zakharov
>Priority: Major
> Labels: good-first-issue
> Fix For: 3.8.0, 3.7.1
>
>
> In some cases in QuorumController, we throw exceptions from the control
> manager methods. Unless these are explicitly caught and handled, they will
> eventually bubble up to the ControllerReadEvent/ControllerWriteEvent an hit
> the generic error handler.
> In the generic error handler of QuorumController, we examine the exception to
> determine if it is a fault or not. In the case where it is not a fault, we
> log the error like:
> {code:java}
> log.info("{}: {}", name, failureMessage);
> {code}
> which results in messages like
> {code:java}
> [2024-04-02 16:08:38,078] INFO [QuorumController id=3000] registerBroker:
> event failed with UnsupportedVersionException in 167 microseconds.
> (org.apache.kafka.controller.QuorumController:544)
> {code}
> In this case, the exception actually has more details in its own message
> {code:java}
> Unable to register because the broker does not support version 8 of
> metadata.version. It wants a version between 20 and 20, inclusive.
> {code}
> We should include the exception's message in the log output for non-fault
> errors as it includes very useful debugging info.
> This was found while writing an integration test for KRaft migration where
> the brokers and controllers have a mismatched MetadataVersion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (KAFKA-16466) QuorumController is swallowing some exception messages
[
https://issues.apache.org/jira/browse/KAFKA-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia Chuan Yu reassigned KAFKA-16466:
-
Assignee: Ilya Zakharov (was: Chia Chuan Yu)
> QuorumController is swallowing some exception messages
> --
>
> Key: KAFKA-16466
> URL: https://issues.apache.org/jira/browse/KAFKA-16466
> Project: Kafka
> Issue Type: Bug
> Components: controller
>Affects Versions: 3.7.0
>Reporter: David Arthur
>Assignee: Ilya Zakharov
>Priority: Major
> Labels: good-first-issue
> Fix For: 3.8.0, 3.7.1
>
>
> In some cases in QuorumController, we throw exceptions from the control
> manager methods. Unless these are explicitly caught and handled, they will
> eventually bubble up to the ControllerReadEvent/ControllerWriteEvent an hit
> the generic error handler.
> In the generic error handler of QuorumController, we examine the exception to
> determine if it is a fault or not. In the case where it is not a fault, we
> log the error like:
> {code:java}
> log.info("{}: {}", name, failureMessage);
> {code}
> which results in messages like
> {code:java}
> [2024-04-02 16:08:38,078] INFO [QuorumController id=3000] registerBroker:
> event failed with UnsupportedVersionException in 167 microseconds.
> (org.apache.kafka.controller.QuorumController:544)
> {code}
> In this case, the exception actually has more details in its own message
> {code:java}
> Unable to register because the broker does not support version 8 of
> metadata.version. It wants a version between 20 and 20, inclusive.
> {code}
> We should include the exception's message in the log output for non-fault
> errors as it includes very useful debugging info.
> This was found while writing an integration test for KRaft migration where
> the brokers and controllers have a mismatched MetadataVersion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-16490) Upgrade gradle from 8.6 to 8.7
[ https://issues.apache.org/jira/browse/KAFKA-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835357#comment-17835357 ] Chia Chuan Yu commented on KAFKA-16490: --- Hi,I want to take this one, please assigned me with the task. Thanks! > Upgrade gradle from 8.6 to 8.7 > -- > > Key: KAFKA-16490 > URL: https://issues.apache.org/jira/browse/KAFKA-16490 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > > gradle 8.7: > https://docs.gradle.org/8.7/release-notes.html?_gl=1*meg7rg*_ga*MTA4Mzk2MzA3MC4xNzEwOTI1MjQx*_ga_7W7NC6YNPT*MTcxMjY2MjM3My4yMC4wLjE3MTI2NjIzNzMuNjAuMC4w > As there is a unresolved issue about 8.6 [0], it would be nice to test all > instructions in readme when running this update. > [0] https://github.com/apache/kafka/pull/15553 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KAFKA-16466) QuorumController is swallowing some exception messages
[
https://issues.apache.org/jira/browse/KAFKA-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia Chuan Yu reassigned KAFKA-16466:
-
Assignee: Chia Chuan Yu
> QuorumController is swallowing some exception messages
> --
>
> Key: KAFKA-16466
> URL: https://issues.apache.org/jira/browse/KAFKA-16466
> Project: Kafka
> Issue Type: Bug
> Components: controller
>Affects Versions: 3.7.0
>Reporter: David Arthur
>Assignee: Chia Chuan Yu
>Priority: Major
> Labels: good-first-issue
> Fix For: 3.8.0, 3.7.1
>
>
> In some cases in QuorumController, we throw exceptions from the control
> manager methods. Unless these are explicitly caught and handled, they will
> eventually bubble up to the ControllerReadEvent/ControllerWriteEvent an hit
> the generic error handler.
> In the generic error handler of QuorumController, we examine the exception to
> determine if it is a fault or not. In the case where it is not a fault, we
> log the error like:
> {code:java}
> log.info("{}: {}", name, failureMessage);
> {code}
> which results in messages like
> {code:java}
> [2024-04-02 16:08:38,078] INFO [QuorumController id=3000] registerBroker:
> event failed with UnsupportedVersionException in 167 microseconds.
> (org.apache.kafka.controller.QuorumController:544)
> {code}
> In this case, the exception actually has more details in its own message
> {code:java}
> Unable to register because the broker does not support version 8 of
> metadata.version. It wants a version between 20 and 20, inclusive.
> {code}
> We should include the exception's message in the log output for non-fault
> errors as it includes very useful debugging info.
> This was found while writing an integration test for KRaft migration where
> the brokers and controllers have a mismatched MetadataVersion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-16397) Use ByteBufferOutputStream to avoid array copy
[ https://issues.apache.org/jira/browse/KAFKA-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829420#comment-17829420 ] Chia Chuan Yu commented on KAFKA-16397: --- Hi, [~apoorvmittal10] I'm interested in this enhancement, could I take this one? Thanks! > Use ByteBufferOutputStream to avoid array copy > -- > > Key: KAFKA-16397 > URL: https://issues.apache.org/jira/browse/KAFKA-16397 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Priority: Minor > > from https://github.com/apache/kafka/pull/15148#discussion_r1531889679 > source code: > https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java#L216 > we can use ByteBufferOutputStream to collect the uncompressed data, and then > return the inner buffer directly instead of copying full array. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16298) Ensure user callbacks exceptions are propagated to the user on consumer poll
[ https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822804#comment-17822804 ] Chia Chuan Yu commented on KAFKA-16298: --- Hi, [~lianetm] I'm a new contributor and I would like to take this one. Is this still available? Thanks! > Ensure user callbacks exceptions are propagated to the user on consumer poll > > > Key: KAFKA-16298 > URL: https://issues.apache.org/jira/browse/KAFKA-16298 > Project: Kafka > Issue Type: Sub-task > Components: clients, consumer >Affects Versions: 3.7.0 >Reporter: Lianet Magrans >Priority: Blocker > Labels: callback, kip-848-client-support > Fix For: 3.8.0 > > > When user-defined callbacks fail with an exception, the expectation is that > the error should be propagated to the user as a KafkaExpception and break the > poll loop (behaviour in the legacy coordinator). The new consumer executes > callbacks in the application thread, and sends an event to the background > with the callback result and error if any, [passing the error along with the > event > here|https://github.com/apache/kafka/blob/98a658f871fc2c533b16fb5fd567a5ceb1c340b7/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java#L1882] > to the background thread, but does not seem to propagate the exception to > the user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
