OmniaGM opened a new pull request, #13201: URL: https://github.com/apache/kafka/pull/13201
This pr include - The changes include switching Scala code to java - Move TopicCommand and all test cases to tools - The PR depends on #13171 to replace the usage of `CoreUtils.duplicate` by `ToolsUtils.findDuplicates` Some implementation notes: <Notes to share with upstream> - I added `ToolsTestUtils.createBrokerProperties` as a wrapper for `TestUtils.createBrokerConfig` to hide the conversion between Scala and Java types. - Replicated `TestUtils.setReplicationThrottleForPartitions` and `TestUtils.removeReplicationThrottleForPartitions` to `ToolsTestUtils` as the methods are used only `TopicCommandIntegrationTest` and `ReassignPartitionsIntegrationTest`. We need to remove it from `TestUtils` once we migrate `ReassignPartitions` - Replicated `TestInfoUtils.TestWithParameterizedQuorumName` to `ToolsTestUtils` as java convert this into a getter function which cannot be used with `ParameterizedTest` *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
