[GitHub] [kafka] bdbyrne commented on pull request #8658: KAFKA-9980: Fix client quotas default entity name handling in broker.

2020-05-21 Thread GitBox 


bdbyrne commented on pull request #8658:
URL: https://github.com/apache/kafka/pull/8658#issuecomment-632348072


   Both errors in 
`org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]`
 appear unrelated:
   
   ```
   Failing for the past 1 build (Since Failed#6410 )
   Took 2 min 32 sec.
   Error Message
   java.lang.AssertionError: Did not receive all 20 records from topic 
multiPartitionOutputTopic within 6 ms
   Expected: is a value equal to or greater than <20>
but: <0> was less than <20>
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] bdbyrne commented on pull request #8658: KAFKA-9980: Fix client quotas default entity name handling in broker.

2020-05-16 Thread GitBox 


bdbyrne commented on pull request #8658:
URL: https://github.com/apache/kafka/pull/8658#issuecomment-629714866


   @cmccabe this is ready for review. Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] bdbyrne commented on pull request #8658: KAFKA-9980: Fix client quotas default entity name handling in broker.

2020-05-16 Thread GitBox 


bdbyrne commented on pull request #8658:
URL: https://github.com/apache/kafka/pull/8658#issuecomment-629713796


   I've applied @d8tltanc's updates to `quota_test.py` and verified their 
success:
   
   ```
   docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file 
/opt/kafka-dev/tests/docker/build/cluster.json  
./tests/kafkatest/tests/client/quota_test.py"
   [INFO:2020-05-16 14:54:39,531]: starting test run with session id 
2020-05-16--002...
   [INFO:2020-05-16 14:54:39,531]: running 9 tests...
   [INFO:2020-05-16 14:54:39,531]: Triggering test 1 of 9...
   [INFO:2020-05-16 14:54:39,536]: RunnerClient: Loading test {'directory': 
'/opt/kafka-dev/tests/kafkatest/tests/client', 'file_name': 'quota_test.py', 
'method_name': 'test_quota', 'cls_name': 'QuotaTest', 'injected_args': 
{'consumer_num': 2, 'quota_type': 'client-id'}}
   [INFO:2020-05-16 14:54:39,539]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.consumer_num=2.quota_type=client-id:
 Setting up...
   /usr/local/lib/python2.7/dist-packages/paramiko/kex_ecdh_nist.py:39: 
CryptographyDeprecationWarning: encode_point has been deprecated on 
EllipticCurvePublicNumbers and will be removed in a future version. Please use 
EllipticCurvePublicKey.public_bytes to obtain both compressed and uncompressed 
point encoding.
 m.add_string(self.Q_C.public_numbers().encode_point())
   /usr/local/lib/python2.7/dist-packages/paramiko/kex_ecdh_nist.py:94: 
CryptographyDeprecationWarning: Support for unsafe construction of public 
numbers from encoded data will be removed in a future version. Please use 
EllipticCurvePublicKey.from_encoded_point
 self.curve, Q_S_bytes
   /usr/local/lib/python2.7/dist-packages/paramiko/kex_ecdh_nist.py:109: 
CryptographyDeprecationWarning: encode_point has been deprecated on 
EllipticCurvePublicNumbers and will be removed in a future version. Please use 
EllipticCurvePublicKey.public_bytes to obtain both compressed and uncompressed 
point encoding.
 hm.add_string(self.Q_C.public_numbers().encode_point())
   [INFO:2020-05-16 14:54:41,606]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.consumer_num=2.quota_type=client-id:
 Running...
   [INFO:2020-05-16 14:57:18,680]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.consumer_num=2.quota_type=client-id:
 PASS
   [INFO:2020-05-16 14:57:18,681]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.consumer_num=2.quota_type=client-id:
 Tearing down...
   [WARNING - 2020-05-16 14:57:18,981 - service_registry - stop_all - 
lineno:55]: Error stopping service 
: 1
   [INFO:2020-05-16 14:57:25,809]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.consumer_num=2.quota_type=client-id:
 Summary: 
   [INFO:2020-05-16 14:57:25,810]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.consumer_num=2.quota_type=client-id:
 Data: None
   [INFO:2020-05-16 14:57:25,866]: 
~
   [INFO:2020-05-16 14:57:25,867]: Triggering test 2 of 9...
   [INFO:2020-05-16 14:57:25,871]: RunnerClient: Loading test {'directory': 
'/opt/kafka-dev/tests/kafkatest/tests/client', 'file_name': 'quota_test.py', 
'method_name': 'test_quota', 'cls_name': 'QuotaTest', 'injected_args': 
{'old_broker_throttling_behavior': True, 'quota_type': 'client-id'}}
   [INFO:2020-05-16 14:57:25,873]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.old_broker_throttling_behavior=True.quota_type=client-id:
 Setting up...
   /usr/local/lib/python2.7/dist-packages/paramiko/kex_ecdh_nist.py:39: 
CryptographyDeprecationWarning: encode_point has been deprecated on 
EllipticCurvePublicNumbers and will be removed in a future version. Please use 
EllipticCurvePublicKey.public_bytes to obtain both compressed and uncompressed 
point encoding.
 m.add_string(self.Q_C.public_numbers().encode_point())
   /usr/local/lib/python2.7/dist-packages/paramiko/kex_ecdh_nist.py:94: 
CryptographyDeprecationWarning: Support for unsafe construction of public 
numbers from encoded data will be removed in a future version. Please use 
EllipticCurvePublicKey.from_encoded_point
 self.curve, Q_S_bytes
   /usr/local/lib/python2.7/dist-packages/paramiko/kex_ecdh_nist.py:109: 
CryptographyDeprecationWarning: encode_point has been deprecated on 
EllipticCurvePublicNumbers and will be removed in a future version. Please use 
EllipticCurvePublicKey.public_bytes to obtain both compressed and uncompressed 
point encoding.
 hm.add_string(self.Q_C.public_numbers().encode_point())
   [INFO:2020-05-16 14:57:27,557]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.old_broker_throttling_behavior=True.quota_type=client-id:
 Running...
   [INFO:2020-05-16 14:59:58,427]: RunnerClient: 
kafkatest.tests.client.quota_test.QuotaTest.test_quota.old_broker_throttling_behavior=True.quota_type=client-id:
 PASS
   [INFO:2020-05-16