[GitHub] [kafka] chia7712 commented on pull request #8703: MINOR: add a getOrCreate function to KRPC collections

2021-02-08 Thread GitBox 


chia7712 commented on pull request #8703:
URL: https://github.com/apache/kafka/pull/8703#issuecomment-775127545


   > int brokerId = 2;
   Broker broker = brokerCollection.getOrCreate(brokerId);
   
   +1 to this pattern and I hope this PR can get merged :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8703: MINOR: add a getOrCreate function to KRPC collections

2020-05-21 Thread GitBox 


chia7712 commented on pull request #8703:
URL: https://github.com/apache/kafka/pull/8703#issuecomment-632170085


   What is the purpose of this new method? Should we add ```getOrCreate``` to 
```ImplicitLinkedHashMultiCollection``` as well?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org