[GitHub] [kafka] chia7712 commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions

2020-12-03 Thread GitBox 


chia7712 commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-738140790


   @lqjack good question!
   
   >  I find the only differences is that controllerContext.allPartitions can 
be invoked once or the number of partition times .
   
   ```controllerContext.allPartitions``` does not return a constant value. It 
create a new collection and the overhead could be high if there are a lot of 
partitions. This PR makes ```controllerContext.allPartitions``` be called only 
once to reduce the cost of getting "all partitions".
   
   > does the patch can resolve the issue ?
   
   @Montyleo It seems to me the optimization of this PR is good enough. 
However, it would be better to show the improvement on your env by this patch.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions

2020-12-02 Thread GitBox 


chia7712 commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737624669


   @Montyleo Thanks for your contribution!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions

2020-12-02 Thread GitBox 


chia7712 commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737244340


   > I'll find the reason.
   
   Is there a existent ticket? If not, could you file a jira to log it? Also, 
you can assign the ticket to yourself ( I have given the permission to you) if 
you have free cycle to trace it.
   
   I will merge this PR tomorrow if no objection.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions

2020-12-02 Thread GitBox 


chia7712 commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737189029


   @Montyleo Is the failed test related to this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org