[GitHub] [kafka] dajac commented on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol
dajac commented on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-738174240 Test failure is unrelated: * Build / JDK 8 / kafka.api.TransactionsTest.testBumpTransactionalEpoch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol
dajac commented on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-737897424 I just rebased the PR and it had conflicts with 7ecc3a579a4b13e0cef4bd3129982ea3bc1a9341. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol
dajac commented on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-737093030 @hachikuji Thanks for your feedback. I have addressed your points. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol
dajac commented on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-734383954 > Also, there are a lot of data structure like `Map[TopicPartition, OffsetForLeaderPartitionResult]`. It contains duplicate (int) partition info. Not sure whether > it is worth replacing it by `Map[String,List[OffsetForLeaderPartitionResult]]` to eliminate duplicate partition info. It will bring a bunch of changes :( Yeah, I considered this actually. Finally, I went with keeping TopicPartition as a key mainly because TopicPartition is required by most of the callers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol
dajac commented on pull request #9630: URL: https://github.com/apache/kafka/pull/9630#issuecomment-732013207 cc @hachikuji @chia7712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
