[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns
dielhennr commented on a change in pull request #11082:
URL: https://github.com/apache/kafka/pull/11082#discussion_r672662886
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
Forwarding write requests to the controller is a requirement for KRaft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns
dielhennr commented on a change in pull request #11082:
URL: https://github.com/apache/kafka/pull/11082#discussion_r672657134
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
@jsancio For 272 to execute, startProcessingTime must not be present.
The only place I see an exception get thrown before startProcessingTime is
defined is in the ControllerWriteEvent and it is a NotControllerException. This
would mean that we would not have to resign/renounce since it is already not
the controller.
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
Forwarding write requests to the controller is a requirement for KRaft
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
@jsancio For 272 to execute, startProcessingTime must not be present.
The only place I see an exception get thrown before startProcessingTime is
defined is in the ControllerWriteEvent and it is a NotControllerException. This
would mean that resign/renounce should not be on line 272 since it is already
not the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns
dielhennr commented on a change in pull request #11082:
URL: https://github.com/apache/kafka/pull/11082#discussion_r672657134
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
@jsancio For 272 to execute, startProcessingTime must not be present.
The only place I see an exception get thrown before startProcessingTime is
defined is in the ControllerWriteEvent and it is a NotControllerException. This
would mean that we would not have to resign/renounce since it is already not
the controller.
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
Forwarding write requests to the controller is a requirement for KRaft
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
@jsancio For 272 to execute, startProcessingTime must not be present.
The only place I see an exception get thrown before startProcessingTime is
defined is in the ControllerWriteEvent and it is a NotControllerException. This
would mean that resign/renounce should not be on line 272 since it is already
not the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns
dielhennr commented on a change in pull request #11082:
URL: https://github.com/apache/kafka/pull/11082#discussion_r672657134
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
@jsancio For 272 to execute, startProcessingTime must not be present.
The only place I see an exception get thrown before startProcessingTime is
defined is in the ControllerWriteEvent and it is a NotControllerException. This
would mean that resign/renounce should not be on line 272 since it is already
not the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns
dielhennr commented on a change in pull request #11082:
URL: https://github.com/apache/kafka/pull/11082#discussion_r672662886
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
Forwarding write requests to the controller is a requirement for KRaft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns
dielhennr commented on a change in pull request #11082:
URL: https://github.com/apache/kafka/pull/11082#discussion_r672657134
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -284,6 +284,7 @@ private Throwable handleEventException(String name,
"Reverting to last committed offset {}.",
this, exception.getClass().getSimpleName(), curClaimEpoch, deltaUs,
lastCommittedOffset, exception);
+raftClient.resign(curClaimEpoch);
Review comment:
@jsancio For 272 to execute, startProcessingTime must not be present.
The only place I see an exception get thrown before startProcessingTime is
defined is in the ControllerWriteEvent and it is a NotControllerException. This
would mean that we would not have to resign/renounce since it is already not
the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
